On 5/16/24 17:41, jm...@redhat.com wrote:
> From: Jakob Meng
>
> The 'dpif/show' command now supports machine-readable JSON output in
> addition to the plain-text output for humans. An example would be:
>
> ovs-appctl --format json dpif/show
>
> Reported-at:
t; +
> +AT_CHECK([ovs-appctl list-commands], [0], [ignore])
> +AT_CHECK([ovs-appctl --format json list-commands], [0], [stdout])
> +# Check that ovs-appctl prints a single line without a trailing newline.
There should be a new line. :)
> +AT_CHECK([wc -l stdout], [0], [0 stdout
&g
re if this patch is necessary, but it's OK to have it just for
the parity with ovs-appctl, I suppose.
Bets regards, Ilya Maximets.
>
> diff --git a/tests/appctl.py b/tests/appctl.py
> index cf3ea3642..b08bf9033 100644
> --- a/tests/appctl.py
> +++ b/tests/appctl.py
> @@ -3
On 5/16/24 17:41, jm...@redhat.com wrote:
> From: Jakob Meng
>
> With the '--pretty' option, ovs-appctl will now print JSON output in a
> more readable fashion, i.e. with additional line breaks, spaces and
> sorted dictionary keys.
>
> Signed-off-by: Jakob Meng
> ---
>
On 5/16/24 17:41, jm...@redhat.com wrote:
> From: Jakob Meng
>
> This patch introduces support for different output formats to Python
> Unixctl* classes and appctl.py, similar to what the previous commit did
> for ovs-appctl.
> In particular, tests/appctl.py gains a global option '-f,--format'
>
}
> switch (option) {
> case 't':
> -if (target) {
> +if (args->target) {
> ovs_fatal(0, "-t or --target may be specified only once");
> }
> -target = optarg;
&g
incorrect checksum in the schema is not a fatal failure,
most of the schemas we're testing with have incorrect checksums and
that's OK as long as the database record itself is correct.
So, I don't think this validation method is a good solution.
Also, we need to at least back up any non-empty files.
14.1 was released on June 4 and 14.0 will reach EoL in September.
Update now.
Signed-off-by: Ilya Maximets
---
.cirrus.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.cirrus.yml b/.cirrus.yml
index 8db385f00..d73154a97 100644
--- a/.cirrus.yml
+++ b/.cirrus.yml
@@ -3,7
On 7/2/24 20:24, Jakub Kicinski wrote:
> On Tue, 2 Jul 2024 20:16:51 +0200 Ilya Maximets wrote:
>> On 7/2/24 20:06, Jakub Kicinski wrote:
>>> On Tue, 2 Jul 2024 11:53:01 +0200 Ilya Maximets wrote:
>>>> Or create a simple static function and mark all the argume
On 7/2/24 20:06, Jakub Kicinski wrote:
> On Tue, 2 Jul 2024 11:53:01 +0200 Ilya Maximets wrote:
>> Or create a simple static function and mark all the arguments as unused,
>> which kind of compliant to the coding style, but the least pretty.
>
> To be clear - kernel explici
n(-)
Thanks, Terry! Applied.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 7/2/24 19:38, Mark Michelson wrote:
> The documentation stated that for soft freeze, the development team
> would only consider merging new feature patches that had been "discussed
> and reviewed" during the soft freeze period. In reality, the OVN team
> has been willing to merge any new
sequent checks to determine if all
> the
> fields issued are supported. This mask will not be passed to the DPDK side,
> so it
> will not affect the offloading operation.
It will, because we should have failed offloading, since we can't
offload setting of ECN bits.
>
> On 6/28/
On 7/2/24 08:04, Chris Mi wrote:
> On 6/27/2024 1:24 PM, Chris Mi wrote:
>> On 6/18/2024 2:27 PM, Chris Mi wrote:
>>> On 5/16/2024 5:09 AM, Ilya Maximets wrote:
>>>> On 3/26/24 03:30, Chris Mi wrote:
>>>>> This patch set adds offload support for sFlo
On 6/27/24 15:03, Eelco Chaudron wrote:
>
>
> On 4 Jun 2024, at 13:52, Ilya Maximets wrote:
>
>> On 6/4/24 13:42, Eelco Chaudron wrote:
>>>
>>>
>>> On 1 Jun 2024, at 0:08, Ilya Maximets wrote:
>>>
>>>> On 5/7/24 15:52, Eelco Chau
ine' here is not performance, but silencing
compiler's potential 'maybe unused' warnings:
Function-like macros with unused parameters should be replaced by static
inline functions to avoid the issue of unused variables
I think, the rule for static inline functions in .c files is at odds with
the 'C
iew.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
elftests/net/openvswitch/openvswitch.sh | 115 +-
> .../selftests/net/openvswitch/ovs-dpctl.py| 73 ++-
> 2 files changed, 182 insertions(+), 6 deletions(-)
This version seems to work correctly with and without argume
he comments! The new name also
seems reasonable to me.
Reviewed-by: Ilya Maximets
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 6/28/24 16:51, Eelco Chaudron wrote:
>
>
> On 14 Jun 2024, at 14:22, Ilya Maximets wrote:
>
>> The main purpose of locking the memory is to ensure that OVS can keep
>> doing what it did before in case of increased memory pressure, e.g.,
>> during VM i
On 6/28/24 23:08, Ilya Maximets wrote:
> On 6/20/24 09:35, Sunyang Wu via dev wrote:
>> Add the "set dscp action" parsing function,
>> so that the "set dscp action" can be offloaded.
>>
>> Signed-off-by: Sunyang Wu
>> ---
>> lib/netdev
be add a Fixes: and I think we should backport this.
>
>> Signed-off-by: Kevin Traynor
>> ---
>> lib/netdev-dpdk.c | 20
>> 1 file changed, 12 insertions(+), 8 deletions(-)
>
> The patch looks good to me.
> Reviewed-by: David Marchand
Thanks, Kevin and David! I fixed the nits and applied the change.
Also backported to branch-3.3.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ertions(+), 1 deletion(-)
>
Hi, Sunyang Wu. Thanks for the patch!
See some comments inline.
Best regards, Ilya Maximets.
> diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
> index 623005b1c..524942457 100644
> --- a/lib/netdev-offload-dpdk.c
> +++ b/lib/netde
On 6/28/24 17:38, Dumitru Ceara wrote:
> On 6/28/24 15:05, Ilya Maximets wrote:
>> On 6/28/24 11:03, Ales Musil wrote:
>>> Hi Frode,
>>>
>>> looking forward to the RFC. AFAIU it means that the routes would be exposed
>>> on
>>> LR, mor
yet, but can we, please, stop adding routing
features
to switches? :) If someone wants routing, they should use a router, IMO.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 6/28/24 09:20, Dumitru Ceara wrote:
> On 6/27/24 00:02, Ilya Maximets wrote:
>> Every transaction has RAFT log prerequisites. Even if transactions
>> are not related (because RAFT doesn't actually know what data it is
>> handling). When leader writes a new rec
gt; +if OBJ_STR.format(i) not in word:
> +results.append(word)
> +break
> +replacement = json.pop(0)
> + results.append(word.replace(OBJ_STR.format(i), replacement))
> +i += 1
> +return
ever, actions:2,3])
> +
> +ufids=$(ovs-appctl dpctl/dump-flows -m | match_ufid)
> +AT_CHECK([for ufid in $ufids; do ovs-appctl upcall/dump-ufid-rules $ufid
> pmd=0; done | ofctl_strip | sort], [0], [dnl
> +cookie=0x12345678, n_packets=1, n_bytes=118, n_offload_packets=0,
>
On 6/27/24 12:15, Adrián Moreno wrote:
> On Thu, Jun 27, 2024 at 11:31:41AM GMT, Eelco Chaudron wrote:
>>
>>
>> On 27 Jun 2024, at 11:23, Ilya Maximets wrote:
>>
>>> On 6/27/24 11:14, Eelco Chaudron wrote:
>>>>
>>>>
>>>> On
On 6/27/24 11:14, Eelco Chaudron wrote:
>
>
> On 27 Jun 2024, at 10:36, Ilya Maximets wrote:
>
>> On 6/27/24 09:52, Adrián Moreno wrote:
>>> On Thu, Jun 27, 2024 at 09:06:46AM GMT, Eelco Chaudron wrote:
>>>>
>>>>
>>>> On 26 Jun
t;>> The uAPI header documentation will be used for other datapaths? How so?
>>> At some point we should document what the action does from the kernel
>>> pov, right? Where should we do that if not here?
>>
>> Well you know how OVS works, all the data paths use the same netlink
>> messages. Not sure how to solve this, but we could change the text a bit to
>> be more general?
>>
>> * For the Linux kernel it sends the packet to the psample multicast group
>> * with the specified group and cookie. It is possible to combine this
>> * action with the %OVS_ACTION_ATTR_TRUNC action to limit the size of the
>> * packet being emitted.
>>
>
> I know we reuse the kernel attributes I don't think the uAPI
> documentation should be less expressive just because some userspace
> application decides to reuse parts of it.
>
> There are many kernel-specific terms all over the uAPI ("netdev",
> "netlink pid", "skb", even the action "userspace") that do not make
> sense in a non-kernel datapath.
+1
This is a kernel uAPI header it describes the behavior of the kernel.
Having parts like "For the Linux kernel" in here is awkward.
>
> Maybe we can add such a comment in the copy of the header we store in
> the ovs tree?
Makes sense to me.
If we'll want to implement a similar action in userspace datapath,
we'll have to have a separate documentation for it anyway, since
the packets will end up in a different place for users to collect.
>
>
>>>>> + */
>>>>> +enum ovs_emit_sample_attr {
>>>>> + OVS_EMIT_SAMPLE_ATTR_GROUP = 1, /* u32 number. */
>>>>> + OVS_EMIT_SAMPLE_ATTR_COOKIE,/* Optional, user specified cookie. */
>>>>
>>>> As we start a new set of attributes maybe it would be good starting it off
>>>> in
>>>> alphabetical order?
>>>>
>>>
>>> Having an optional attribute before a mandatory one seems strange to me,
>>> wouldn't you agree?
>>
>> I don't mind, but I don't have a strong opinion on it. If others don't mind,
>> I would leave it as is.
>>
>
> I think I prefer to put mandatory attributes first.
That's my thought as well. Though that might be broken if we ever need
more attributes. But we do not extend individual actions that often.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 6/26/24 22:07, Adrián Moreno wrote:
> On Wed, Jun 26, 2024 at 12:51:19PM GMT, Ilya Maximets wrote:
>> On 6/25/24 22:51, Adrian Moreno wrote:
>>> Add support for a new action: emit_sample.
>>>
>>> This action accepts a u32 group id and a variable-length cooki
of simultaneous transactions from different followers. It's
a normal thing for a distributed database due to its nature.
Signed-off-by: Ilya Maximets
---
ovsdb/raft.c| 45 -
ovsdb/raft.h| 2 +-
ovsdb/storage.c | 9 +
ovsdb/storage.h
it_sample word.
This makes './openvswitch.sh emit_sample' to not run the test,
because 'emit_sample' != 'emit_sample '.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
insertions(+), 4 deletions(-)
Reviewed-by: Ilya Maximets
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
const struct sw_flow_key *key,
The 'key' is not used in the function.
> + const struct nlattr *attr)
> +{
> +#if IS_ENABLED(CONFIG_PSAMPLE)
IIUC, the general coding style guideline is to compile out the whole
function, instead of only the parts. i.e. something like:
#if IS_ENABLED(CONFIG_PSAMPLE)
static void execute_emit_sample(...) {
}
#else
#define execute_emit_sample(dp, skb, attr)
#endif
Otherwise, we'll also need to mark the arguments with __maybe_unused.
The rest of the patch looks good to me.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 6/26/24 07:14, Adrián Moreno wrote:
> On Tue, Jun 25, 2024 at 11:04:42PM GMT, Ilya Maximets wrote:
>> On 6/25/24 22:53, Adrián Moreno wrote:
>>> On Mon, Jun 24, 2024 at 07:43:32PM GMT, Adrián Moreno wrote:
>>>> On Mon, Jun 24, 2024 at 04:05:36PM GMT, Ilya Maximets
On 6/25/24 22:53, Adrián Moreno wrote:
> On Mon, Jun 24, 2024 at 07:43:32PM GMT, Adrián Moreno wrote:
>> On Mon, Jun 24, 2024 at 04:05:36PM GMT, Ilya Maximets wrote:
>>> On 6/24/24 15:19, Adrián Moreno wrote:
>>>> On Mon, Jun 24, 2024 at 01:37:44PM GMT, Ilya Maximet
.
And as far as my understanding goes, NETIF_F_GSO_UDP is
deprecated for all use, except for tuntap. So, we probably
shouldn't add it. UFO generally creates more issues than
it solves.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
#define TCA_SAMPLE_MAX (__TCA_SAMPLE_MAX - 1)
>
> I believe Ilya's comment on v3 is correct, this chunk looks unrelated
> and unneeded. I guess you can drop it? Or am I missing something?
Oops, somehow I missed that there is a v4 and replied
AMPLE_PROBABILITY,
> __TCA_SAMPLE_MAX
> };
> #define TCA_SAMPLE_MAX (__TCA_SAMPLE_MAX - 1)
Not a full review yet, but this hunk seems unrelated to the set
as you're not adding rate_as_probability to act_sample.
I suppose, it was part of the plan at some point, but then
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 6/24/24 20:00, Adrián Moreno wrote:
> On Mon, Jun 24, 2024 at 02:03:00PM GMT, Ilya Maximets wrote:
> [...]
>>
>> Why are we adding IPFIX? This should work without IPFIX.
>>
>> Having both together can be a separate test.
>>
>>> +
>>
On 6/24/24 19:38, Adrián Moreno wrote:
> On Mon, Jun 24, 2024 at 04:15:50PM GMT, Ilya Maximets wrote:
>> On 6/24/24 15:14, Adrián Moreno wrote:
>>> On Mon, Jun 24, 2024 at 02:03:00PM GMT, Ilya Maximets wrote:
>>>> On 6/5/24 22:23, Adrian Moreno wrote:
>>&
On 6/24/24 15:14, Adrián Moreno wrote:
> On Mon, Jun 24, 2024 at 02:03:00PM GMT, Ilya Maximets wrote:
>> On 6/5/24 22:23, Adrian Moreno wrote:
>>> Test simultaneous IPFIX and local sampling including slow-path.
>>>
>>> Signed-off-by: Adrian Moreno
>>>
On 6/24/24 15:19, Adrián Moreno wrote:
> On Mon, Jun 24, 2024 at 01:37:44PM GMT, Ilya Maximets wrote:
>> On 6/5/24 22:23, Adrian Moreno wrote:
>>> Use the newly added emit_sample to implement OpenFlow sample() actions
>>> with local sampling configuration.
>>&
On 6/5/24 22:23, Adrian Moreno wrote:
> Test simultaneous IPFIX and local sampling including slow-path.
>
> Signed-off-by: Adrian Moreno
> ---
> tests/system-common-macros.at | 4 ++
> tests/system-traffic.at | 105 ++
> 2 files changed, 109 insertions(+)
-dpif.at
that would check that we generate correct datapath flows.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
t uninstall pip 24.0, RECORD file not found.
>> Hint: The package was installed by debian.
>>
>> Suggested-by: Ilya Maximets
>> Signed-off-by: Ales Musil
>> ---
>
> Thanks, Ales, for fixing the CI!
>
>> utilities/containers/ubuntu/Dockerfile | 2 +-
=false"
> +
> + # Disable DPDK developer mode, this results in less build checks and
> less
> + # meson verbose outputs.
> + DPDK_OPTS="$DPDK_OPTS -Ddeveloper_mode=disabled"
> +
> + # OVS compilation and the "ovn-system-dpdk" unit tests (run in the CI)
> + # only depend on virtio/tap drivers.
> + # We can disable all remaining drivers to save compilation time.
> + DPDK_OPTS="$DPDK_OPTS -Denable_drivers=net/null,net/tap,net/virtio"
> + # OVS depends on the vhost library (and its dependencies).
> + # net/tap depends on the gso library.
> + DPDK_OPTS="$DPDK_OPTS -Denable_libs=cryptodev,dmadev,gso,vhost"
> +
> + # Install DPDK using prefix.
> + DPDK_OPTS="$DPDK_OPTS --prefix=$DPDK_INSTALL_DIR"
> +
> + meson $DPDK_OPTS build
> + ninja -C build
> + ninja -C build install
> + popd
> +
> + # Remove examples sources.
> + rm -rf $DPDK_INSTALL_DIR/share/dpdk/examples
> +
> + echo "${DPDK_VER}" > ${VERSION_FILE}
> +}
> +
> compile_sparse
> compile_openbfdd
> install_python_dep
> +build_dpdk
> diff --git a/utilities/containers/py-requirements.txt
> b/utilities/containers/py-requirements.txt
> index a8e8f17da..7b12b4ab5 100644
> --- a/utilities/containers/py-requirements.txt
> +++ b/utilities/containers/py-requirements.txt
> @@ -1,4 +1,5 @@
> flake8>=6.1.0
> +meson==0.53.2
Not a full review, but you're chanign the base image and the python
version as a result for the DPDK build. This version of meson is
not compatible with Python 3.12.
Here is an exmaple of what I did for OVS:
https://github.com/openvswitch/ovs/commit/16b7475414fa1eaf0ab1d723fdb6978060511c44
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
me and there is a workaround
for those who hit the issue, it should be enough.
I'd suggest considering the change inside the DPDK itself, i.e. enabling
LSC by default for all or problematic (mlx) drivers.
For the patch itself, I'm not sure why WARN and DBG messages are worded
differently
ttrick
>> ---
>> v2: removed memcpy
>> v3: fixed checkpatch
>> ---
>> lib/ofp-prop.c | 17 ++---
>> 1 file changed, 10 insertions(+), 7 deletions(-)
>>
> Looks good to me, thanks.
>
> Acked-by: Ales Musil
>
Thanks, Mike and Ales!
On 3/27/24 16:55, Mike Pattrick wrote:
> This patch adopts the proposed RFC 6935 by allowing null UDP checksums
> even if the tunnel protocol is IPv6. This is already supported by Linux
> through the udp6zerocsumtx tunnel option. It is disabled by default and
> IPv6 tunnels are flagged as
witch: set IPS_CONFIRMED in tmpl status only when
> commit is set in conntrack")
> Reported-by: Ilya Maximets
> Signed-off-by: Xin Long
> ---
> net/openvswitch/conntrack.c | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/net/openvswitch/
On 6/19/24 22:40, Adrián Moreno wrote:
> On Wed, Jun 19, 2024 at 08:21:02PM GMT, Ilya Maximets wrote:
>> On 6/19/24 08:35, Adrián Moreno wrote:
>>> On Tue, Jun 18, 2024 at 05:44:05PM GMT, Ilya Maximets wrote:
>>>> On 6/18/24 12:50, Adrián Moreno wrote:
>>>&g
On 6/19/24 08:35, Adrián Moreno wrote:
> On Tue, Jun 18, 2024 at 05:44:05PM GMT, Ilya Maximets wrote:
>> On 6/18/24 12:50, Adrián Moreno wrote:
>>> On Tue, Jun 18, 2024 at 12:22:23PM GMT, Ilya Maximets wrote:
>>>> On 6/18/24 09:00, Adrián Moreno wrote:
>>>&g
On 6/19/24 16:07, Xin Long wrote:
> On Wed, Jun 19, 2024 at 8:58 AM Ilya Maximets wrote:
>>
>> On 6/18/24 17:50, Ilya Maximets wrote:
>>> On 6/18/24 16:58, Xin Long wrote:
>>>> On Tue, Jun 18, 2024 at 7:34 AM Ilya Maximets wrote:
>>>>>
>>
On 6/18/24 17:50, Ilya Maximets wrote:
> On 6/18/24 16:58, Xin Long wrote:
>> On Tue, Jun 18, 2024 at 7:34 AM Ilya Maximets wrote:
>>>
>>> On 6/17/24 22:10, Ilya Maximets wrote:
>>>> On 7/16/23 23:09, Xin Long wrote:
>>>>> By not setting IPS_C
On 6/11/24 16:02, Aaron Conole wrote:
> Ilya Maximets writes:
>
>> On 6/5/24 16:54, Aaron Conole wrote:
>>> Mike Pattrick writes:
>>>
>>>> When conntrack is reassembling packet fragments, the same reassembly
>>>> context can be sha
On 6/18/24 16:58, Xin Long wrote:
> On Tue, Jun 18, 2024 at 7:34 AM Ilya Maximets wrote:
>>
>> On 6/17/24 22:10, Ilya Maximets wrote:
>>> On 7/16/23 23:09, Xin Long wrote:
>>>> By not setting IPS_CONFIRMED in tmpl that allows the exp not to be removed
>>
On 6/18/24 12:50, Adrián Moreno wrote:
> On Tue, Jun 18, 2024 at 12:22:23PM GMT, Ilya Maximets wrote:
>> On 6/18/24 09:00, Adrián Moreno wrote:
>>> On Mon, Jun 17, 2024 at 02:10:37PM GMT, Ilya Maximets wrote:
>>>> On 6/17/24 13:55, Ilya Maximets wrote:
>>>
On 6/17/24 22:10, Ilya Maximets wrote:
> On 7/16/23 23:09, Xin Long wrote:
>> By not setting IPS_CONFIRMED in tmpl that allows the exp not to be removed
>> from the hashtable when lookup, we can simplify the exp processing code a
>> lot in openvswitch conntrack.
>>
On 6/18/24 09:00, Adrián Moreno wrote:
> On Mon, Jun 17, 2024 at 02:10:37PM GMT, Ilya Maximets wrote:
>> On 6/17/24 13:55, Ilya Maximets wrote:
>>> On 6/3/24 20:56, Adrian Moreno wrote:
>>>> The OVS_ACTION_ATTR_SAMPLE action is, in essence,
>>>> observa
On 6/18/24 11:47, Ilya Maximets wrote:
> On 6/18/24 09:33, Adrián Moreno wrote:
>> On Mon, Jun 17, 2024 at 12:44:45PM GMT, Ilya Maximets wrote:
>>> On 6/3/24 20:56, Adrian Moreno wrote:
>>>> Add support for a new action: emit_sample.
>>>>
>>>
On 6/18/24 09:33, Adrián Moreno wrote:
> On Mon, Jun 17, 2024 at 12:44:45PM GMT, Ilya Maximets wrote:
>> On 6/3/24 20:56, Adrian Moreno wrote:
>>> Add support for a new action: emit_sample.
>>>
>>> This action accepts a u32 group id and a variable-length cooki
On 6/18/24 09:38, Adrián Moreno wrote:
> On Mon, Jun 17, 2024 at 12:00:04PM GMT, Ilya Maximets wrote:
>> On 6/3/24 20:56, Adrian Moreno wrote:
>>> If the action has a user_cookie, pass it along to the sample so it can
>>> be easily identified.
>>>
>>> S
getting +rel+trk and not
new. This is a problem because we need to commit this connection with the label
and we do that for +new packets. If we can't get +new packet we'll have to
commit
every single +rel+trk packet, which doesn't make a lot of sense. And it's a
significant behavior change
On 6/17/24 13:55, Ilya Maximets wrote:
> On 6/3/24 20:56, Adrian Moreno wrote:
>> The OVS_ACTION_ATTR_SAMPLE action is, in essence,
>> observability-oriented.
>>
>> Apart from some corner case in which it's used a replacement of clone()
>> for old kernels, it's
ot; and now "emit_sample". "output" and "recirc" are
consuming the skb "naturally" by stealing it when it is the last action.
"userspace" has an explicit check to consume the skb if it is the last
action. "emit_sample" should have the similar check. It should likely
be added at the point of action introduction instead of having a separate
patch.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 6/17/24 09:08, Adrián Moreno wrote:
> On Fri, Jun 14, 2024 at 12:55:59PM GMT, Aaron Conole wrote:
>> Adrian Moreno writes:
>>
>>> The behavior of actions might not be the exact same if they are being
>>> executed inside a nested sample action. Store the probability of the
>>> parent sample
On 6/3/24 20:56, Adrian Moreno wrote:
> Add support for a new action: emit_sample.
>
> This action accepts a u32 group id and a variable-length cookie and uses
> the psample multicast group to make the packet available for
> observability.
>
> The maximum length of the user-defined cookie is set
const struct tc_action *a,
>struct tcf_result *res)
> {
> + u8 cookie_data[TC_COOKIE_MAX_SIZE] = {};
Is it necessary to initialize these 16 bytes on every call?
Might be expensive. We're passing the data length around,
so the uninitialized parts s
On 6/17/24 09:46, David Marchand wrote:
> On Fri, Jun 14, 2024 at 6:22 PM Ilya Maximets wrote:
>>> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
>>> index 0fa37d5145..a260bc8485 100644
>>> --- a/lib/netdev-dpdk.c
>>> +++ b/lib/netdev-dpdk.c
>>&g
On 6/11/24 00:09, Alin Serdean wrote:
> Acked-by: Alin-Gabriel Serdean
Thanks! Applied.
Best regards, Ilya Maximets.
>
> On Mon, Jun 10, 2024 at 11:18 PM Ilya Maximets <mailto:i.maxim...@ovn.org>> wrote:
>
> Apparently, if the cache dependency is spe
On 6/14/24 17:08, David Marchand wrote:
> Querying link status may get delayed for an undeterministic (long) time
> with mlx5 ports. This is a consequence of the mlx5 driver calling ethtool
> kernel API and getting stuck on the kernel RTNL lock while some other
> operation is in progress under
On 6/13/24 12:15, Eli Britstein wrote:
>
>
>> -Original Message-----
>> From: Ilya Maximets
>> Sent: Monday, 10 June 2024 15:53
>> To: Roi Dayan ; d...@openvswitch.org
>> Cc: Eli Britstein ; Maor Dickman ;
>> i.maxim...@ovn.org
>> Subject
/lib/ofp-prop.c
>>> +++ b/lib/ofp-prop.c
>>> @@ -271,10 +271,12 @@ enum ofperr
>>> ofpprop_parse_u128(const struct ofpbuf *property, ovs_u128 *value)
>>> {
>>> ovs_be128 *p = property->msg;
>>&g
correct thing to do. By design, only one flow API
should be able to accept a particular port type. If two API implementations
can accept the same port, that would be a bug. Also, initializing more than
one API will cause resource leaks and potentially incorrect datapath behavior.
Since you'r
memory. Post-copy relies on userfaultfd
to work on shared huge pages, which is only available in 4.11+ kernels.
So, technically, it should not be possible for MCL_ONFAULT to fail and
the call without it to succeed. But keeping the check just in case
for now.
Signed-off-by: Ilya Maximets
the updated cache back.
Fixes: 9d8208484a35 ("appveyor: Build with OpenSSL 3.0.")
Reported-at:
https://help.appveyor.com/discussions/problems/36144-cache-reports-up-to-date-while-it-is-not
Signed-off-by: Ilya Maximets
---
appveyor.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
ge people to use a full word instead by not adding to the
dictionary.
Some added words like 'lexograpically' seem like just legit typos. This
is not how this word supposed to be spelled.
>>
>> To make it easier to review the words added, maybe split the patch in
>> two patch
ses.
We should technically remove all the 'qid % n_txq' stuff from all the
netdev implementations and replace them with ovs_assert() on the API
level. We had a few patches for that in the past, but they didn't get
proper attention and went stale.
Best regards, Ilya Maximets.
>
> Fixes: 3
On 6/7/24 16:42, Kevin Traynor wrote:
> On 07/06/2024 15:01, Ilya Maximets wrote:
>> We didn't make a stable release for a while. It's definitely time
>> to make one.
>>
>> Ilya Maximets (2):
>> Set release date for 3.3.1.
>> Prepare
Signed-off-by: Ilya Maximets
---
NEWS | 3 ++-
debian/changelog | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 31d235a40..aaf8d4b4a 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,6 @@
-v3.3.1 - xx xxx
+v3.3.1 - 07 Jun 2024
Signed-off-by: Ilya Maximets
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index aaf8d4b4a..f62d06ffb 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+v3.3.2 - xx xxx
We didn't make a stable release for a while. It's definitely time
to make one.
Ilya Maximets (2):
Set release date for 3.3.1.
Prepare for 3.3.2.
NEWS | 6 +-
configure.ac | 2 +-
debian/changelog | 8 +++-
3 files changed, 13 insertions(+), 3 deletions
Signed-off-by: Ilya Maximets
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index 43ab6d806..492b096db 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+v3.2.4 - xx xxx
Signed-off-by: Ilya Maximets
---
NEWS | 3 ++-
debian/changelog | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 8baf3d2aa..43ab6d806 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,6 @@
-v3.2.3 - xx xxx
+v3.2.3 - 07 Jun 2024
We didn't make a stable release for a while. It's definitely time
to make one.
Ilya Maximets (2):
Set release date for 3.2.3.
Prepare for 3.2.4.
NEWS | 6 +-
configure.ac | 2 +-
debian/changelog | 8 +++-
3 files changed, 13 insertions(+), 3 deletions
Signed-off-by: Ilya Maximets
---
NEWS | 3 ++-
debian/changelog | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 44a3e6247..9604939b3 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,6 @@
-v3.1.5 - xx xxx
+v3.1.5 - 07 Jun 2024
Signed-off-by: Ilya Maximets
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index 9604939b3..cf0700ab3 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+v3.1.6 - xx xxx
We didn't make a stable release for a while. It's definitely time
to make one.
Ilya Maximets (2):
Set release date for 3.1.5.
Prepare for 3.1.6.
NEWS | 6 +-
configure.ac | 2 +-
debian/changelog | 8 +++-
3 files changed, 13 insertions(+), 3 deletions
We didn't make a stable release for a while. It's definitely time
to make one.
Ilya Maximets (2):
Set release date for 3.0.7.
Prepare for 3.0.8.
NEWS | 6 +-
configure.ac | 2 +-
debian/changelog | 8 +++-
3 files changed, 13 insertions(+), 3 deletions
Signed-off-by: Ilya Maximets
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index 088bf0dd2..504c70b6b 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+v3.0.8 - xx xxx
Signed-off-by: Ilya Maximets
---
NEWS | 3 ++-
debian/changelog | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 8550e8e89..088bf0dd2 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,6 @@
-v3.0.7 - xx xxx
+v3.0.7 - 07 Jun 2024
We didn't make a stable release for a while. It's definitely time
to make one.
Ilya Maximets (2):
Set release date for 2.17.10.
Prepare for 2.17.11.
NEWS | 6 +-
configure.ac | 2 +-
debian/changelog | 8 +++-
3 files changed, 13 insertions(+), 3 deletions
Signed-off-by: Ilya Maximets
---
NEWS | 3 ++-
debian/changelog | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index e91072dd6..a809e8e3d 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,6 @@
-v2.17.10 - xx xxx
+v2.17.10 - 07 Jun 2024
Signed-off-by: Ilya Maximets
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index a809e8e3d..8ba8a8d62 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+v2.17.11 - xx xxx
On 6/6/24 19:53, Adrián Moreno wrote:
> On Thu, Jun 06, 2024 at 06:00:26PM GMT, Ilya Maximets wrote:
>> On 6/6/24 17:15, Adrian Moreno wrote:
>>> Add check_pkt_len action to the decoder list that it, itself, uses.
>>>
>>> This makes nested check_pkt_len
On 6/6/24 20:55, Terry Wilson wrote:
> On Thu, Jun 6, 2024 at 10:41 AM Dumitru Ceara wrote:
>>
>> On 5/27/24 23:39, Ilya Maximets wrote:
>>> When a row is modified, python IDL doesn't perform any operations on
>>> existing client-side indexes. This means that
plied remaining 2 patches and backported them down to 3.1.
Best regards, Ilya Maximets.
>
> Terry
>
> On Wed, Apr 10, 2024 at 4:39 PM Terry Wilson wrote:
>>
>> The Python IDL code very closely mirrors the C IDL code, which uses
>> an hmap to store table rows. hmap
101 - 200 of 7046 matches
Mail list logo
