[ovs-dev] Please help add me to AUTHORS

2022-06-02 Thread jinjun gao
Hi guys, I'm a contributor in datapath-windows part with jinj...@vmware.com. Can you please help add me to the AUTHORS? Thanks! Name: Jinjun Gao Mail: gjin...@gmail.com -- Best Regards, Jinjun Gao ___ dev mailing list d...@openvswitch.org https

Re: [ovs-dev] [PATCH v3 8/8] appveyor: Bump outdated links and add artifacts

2020-09-25 Thread Jinjun Gao
o-authored-by: Yonggang Luo Signed-off-by: Yonggang Luo Co-authored-by: Jinjun Gao Signed-off-by: Jinjun Gao Signed-off-by: Alin Gabriel Serdean --- appveyor.yml | 40 1 file changed, 28 insertions(+), 12 deletions(-)

Re: [ovs-dev] Bond support on Windows OVS

2020-08-24 Thread Jinjun Gao
tch -Name external -NetAdapterName external \ -AllowManagementOS $false Regards, -Jinjun From: Alin Serdean Sent: Monday, August 24, 2020 8:37 PM To: Jinjun Gao ; Anand Kumar Cc: ovs-dev@openvswitch.org Subject: RE: Bond support on Windows OVS Hi Jin

Re: [ovs-dev] [PATCH] datapath-windows: Update flow key in SET action

2020-07-28 Thread Jinjun Gao
: Tuesday, July 28, 2020 at 11:42 PM To: Jinjun Gao , "d...@openvswitch.org" , Anand Kumar Cc: Rui Cao , Jinjun Gao Subject: RE: [PATCH] datapath-windows: Update flow key in SET action Thanks a lot for testing and fixing this as discussed offline. Can you please split the assignment vi

[ovs-dev] [PATCH v2] datapath-windows: Update flow key in SET action

2020-07-28 Thread Jinjun Gao
The flow key is not updated when process OVS_ACTION_ATTR_SET action. It will impact follow-up actions, such as, conntrack module cannot find created conntrack entry if passing old flow key to it. Reported-by: Rui Cao Signed-off-by: Jinjun Gao --- v2: Separated assignment to happy MSFT SDV tool

[ovs-dev] [PATCH] datapath-windows: Update flow key in SET action

2020-07-27 Thread Jinjun Gao
The flow key is not updated when process OVS_ACTION_ATTR_SET action. It will impact follow-up actions, such as, conntrack module cannot find created conntrack entry if passing older flow key to it. Reported-by: Rui Cao Signed-off-by: Jinjun Gao --- datapath-windows/ovsext/Actions.c | 41

[ovs-dev] [PATCH v3] datapath-windows: Reset ct_mark/ct_label to support ALG

2020-07-22 Thread Jinjun Gao
The ct_mark/ct_label setting on related connection keep the same behavior with Linux datapath. If one CT entry has parent/master entry, its ct_mark and ct_label should inherit from the corresponding part of parent/master entry at initialization. Signed-off-by: Jinjun Gao --- v3: Resolve Alin's

Re: [ovs-dev] [ovs-dev v2] datapath-windows: Reset ct_mark/ct_label to support ALG

2020-07-22 Thread Jinjun Gao
Alin, thanks for review. I have updated the patch to resolve your comment and use RtlCopyMemory to replace memcpy. The PR also is updated: https://github.com/openvswitch/ovs/pull/324 . - Jinjun From: Alin Serdean Date: Thursday, July 23, 2020 at 3:47 AM To: Jinjun Gao , "d...@openvswitc

[ovs-dev] [ovs-dev v2] datapath-windows: Reset ct_mark/ct_label to support ALG

2020-07-20 Thread Jinjun Gao
The ct_mark/ct_label setting on related connection keep the same behavior with Linux datapath. If one CT entry has parent/master entry, its ct_mark and ct_label should inherit from the corresponding part of parent/master entry at initialization. Signed-off-by: Jinjun Gao --- v2: Resolve Anand's

Re: [ovs-dev] [ovs-dev 1/1] datapath-windows: Reset ct_mark/ct_label to support ALG

2020-07-20 Thread Jinjun Gao
Thanks for review, Anand. I have sent v2 patch. Please review it again. PS: I also create pull request for it https://github.com/openvswitch/ovs/pull/324 -Jinjun From: Anand Kumar Sent: Monday, July 20, 2020 10:12 PM To: Jinjun Gao ; d...@openvswitch.org

[ovs-dev] [ovs-dev 1/1] datapath-windows: Reset ct_mark/ct_label to support ALG

2020-07-15 Thread Jinjun Gao
The ct_mark/ct_label setting on related connection keep the same behavior with Linux datapath. If one CT entry has parent/master entry, its ct_mark and ct_label should inherit from the corresponding part of parent/master entry at initialization. Signed-off-by: Jinjun Gao --- datapath-windows

[ovs-dev] Reset ct_mark and ct_lables in conntrack entry

2020-07-13 Thread Jinjun Gao
Hi Alin/Anand, We have a project that needs to support ALG FTP on Windows OVS. I have added CT_HELP and CT_TUPLE_MASTER in previous merged patch. Now, we also need to support ct_mark and ct_labels. We have tested that FTP data traffic cannot inherit ct_mark and ct_labels from its master FTP

Re: [ovs-dev] datapath-windows: Add CTA_HELP and CTA_TUPLE_MASTER

2020-06-30 Thread Jinjun Gao
Thanks for review, Alin. Please see the comments in inline [Jinjun]. -- Jinjun From: Alin Serdean Date: Tuesday, June 30, 2020 at 5:34 PM To: Jinjun Gao , "d...@openvswitch.org" Cc: Anand Kumar Subject: RE: [ovs-dev] datapath-windows: Add CTA_HELP and CTA_TUPLE_MASTER Thanks f

[ovs-dev] [ovs-dev v2] datapath-windows: Add CTA_HELP and CTA_TUPLE_MASTER

2020-06-30 Thread Jinjun Gao
Add helper and master if existing to a conntrack entry: 1, For CTA_HELP, only support FTP/TFTP; 2, For CTA_TUPLE_MASTER, only support FTP. Signed-off-by: Jinjun Gao --- v2: 1, Add CTA_TUPLE_MASTER support in CT event subscribe/report system. 2, Release CT entry lock in fail path. 3, Add

[ovs-dev] datapath-windows: Add CTA_HELP and CTA_TUPLE_MASTER

2020-06-23 Thread Jinjun Gao
Add helper and master if existing to a conntrack entry: 1, For CTA_HELP, only support FTP/TFTP; 2, For CTA_TUPLE_MASTER, only support FTP. Signed-off-by: Jinjun Gao --- datapath-windows/ovsext/Conntrack-related.c | 1 - datapath-windows/ovsext/Conntrack.c | 40

[ovs-dev] Windows OVS datapath conntrack support CTA_HELP and CTA_TUPLE_MASTER

2020-05-27 Thread Jinjun Gao
and implement? What details do I need to pay attention to if I want to implement them? -Jinjun Gao ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [ovs-dev, v2] datapath-windows: Don't delete internal port

2019-12-08 Thread Jinjun Gao via dev
l port in HvDisconnectNic(), HvCreateNic() will fail when received OID_SWITCH_NIC_CREATE late because there is no corresponding port. Signed-off-by: Jinjun Gao --- datapath-windows/ovsext/Vport.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/datapath-windows/ovsext/Vpo

[ovs-dev] datapath-windows: Don't delete internal port

2019-12-02 Thread Jinjun Gao via dev
l port in HvDisconnectNic(), HvCreateNic() will fail when received OID_SWITCH_NIC_CREATE late because there is no corresponding port. Signed-off-by: Jinjun Gao --- datapath-windows/ovsext/Vport.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/datapath-windows/ovsext/Vpo