, and I'll see you around wherever our paths cross again :-)
Signed-off-by: Joe Stringer
---
MAINTAINERS.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst
index f4f6188c85cb..414df68758c1 100644
--- a/MAINTAINERS.rst
+++ b/MAINT
Hey Aaron, long time no chat :)
On Fri, Mar 19, 2021 at 1:43 PM Aaron Conole wrote:
>
> When a user instructs a flow pipeline to perform connection tracking,
> there is an implicit L3 operation that occurs - namely the IP fragments
> are reassembled and then processed as a single unit. After thi
pecifying which
> > conntrack events (IPCT_*) should be delivered via the Netfilter
> > netlink multicast groups. Default behavior depends on the system
> > configuration, but typically a lot of events are delivered. This can be
> > very chatty for the NF
e.") replaced that with nf_ct_tmpl_free which
> is a more appropriate. Now the original problem is removed.
>
> Then 44d6e2f27328 ("net: Replace NF_CT_ASSERT() with WARN_ON().")
> replaced a debug assert with a WARN_ON() which is trigged now.
>
> Signed-off-by: Flavi
27;re
>> > seeing problems in another branch, let me know and I will backport.
>>
>> Thanks!
>>
>> I think the issue was introduced into OVS by the following commit a long
>> time ago.
>>
>> commit 23597df052262dec961fd86eb7c54d10984a1ec0
>
On 26 March 2018 at 14:32, Aaron Conole wrote:
> Thanks for the review, Ansis!
>
> Ansis Atteka writes:
>
>> On 20 March 2018 at 14:05, Aaron Conole wrote:
>>> +.
>>> +.PP
>>> +Each of \fBovs\-ctl\fR's commands is described separately below.
>>> +.
>>> +.SH "The ``insert'' command"
>>> +.
>>> +.
On 20 March 2018 at 06:12, Eelco Chaudron wrote:
> Hi Joe,
>
> I'm investigating an issue where I've seen "handler_duplicate_upcall"
> incrementing once, and where "upcall_ukey_replace" is happening quite often.
Without other evidence of undesirable behaviour, I wouldn't be overly
concerned about
Ok, thanks for the clarification.
On Mon, 5 Mar 2018, 03:23 Yang, Yi, wrote:
> On Mon, Mar 05, 2018 at 04:19:58AM +0800, Joe Stringer wrote:
> > ?On 2 March 2018 at 04:32, Yi Yang wrote:
> > > From: Feng Yang
> > >
> > > +
> > > +
On 4 March 2018 at 19:58, Yang, Yi wrote:
> On Sun, Mar 04, 2018 at 07:40:49PM -0800, Joe Stringer wrote:
>> On 4 March 2018 at 18:48, Yang, Yi wrote:
>> > On Mon, Mar 05, 2018 at 04:19:58AM +0800, Joe Stringer wrote:
>> >> ?On 2 March 2018 at 04:32, Yi Yang wrote:
On 4 March 2018 at 18:48, Yang, Yi wrote:
> On Mon, Mar 05, 2018 at 04:19:58AM +0800, Joe Stringer wrote:
>> ?On 2 March 2018 at 04:32, Yi Yang wrote:
>> >
>> > Signed-off-by: Feng Yang
>> > Signed-off-by: Yi Yang
>> > ---
>>
>> Hi Yi,
On 4 March 2018 at 12:19, Joe Stringer wrote:
> ?On 2 March 2018 at 04:32, Yi Yang wrote:
>> From: Feng Yang
>>
>> GPRS Tunneling Protocol (GTP) is a group of IP-based communications
>> protocols used to carry general packet radio service (GPRS) within
>> GSM,
On 4 March 2018 at 00:31, Damo Brisbane wrote:
> Hello;
>
> I am trying to do basic ovs but confused by vswitchd messages, could be
> platform issue, but having hard time trying to decipher. Am running 4.15.x
> kernel on gentoo, so going with latest github (openvswitch/ovs).
>
> Can fetch sources,
?On 2 March 2018 at 04:32, Yi Yang wrote:
> From: Feng Yang
>
> GPRS Tunneling Protocol (GTP) is a group of IP-based communications
> protocols used to carry general packet radio service (GPRS) within
> GSM, UMTS and LTE networks.
>
> GTP can be decomposed into separate protocols, GTP-C, GTP-U an
On 6 February 2018 at 06:44, Matteo Croce wrote:
> Documentation for both n-handler-threads and n-revalidator-threads was
> wrong, the spawned threads are per port instead of per datapath.
>
> Update the docs according to vswitchd/ovs-vswitchd.8.in and code behaviour.
>
> Signed-off-by: Matteo Cro
rted-by: Bhargava Shastry
> Signed-off-by: Ben Pfaff
> ---
Acked-by: Joe Stringer
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, 2 Nov 2017, 15:02 Ben Pfaff, wrote:
> On Mon, Sep 18, 2017 at 02:56:35PM -0700, Greg Rose wrote:
> > On 09/06/2017 03:12 PM, Joe Stringer wrote:
> > >In most situations, we don't expect that a flow we've successfully
> > >dumped, which we intend to d
On 10 October 2017 at 12:13, Eric Garver wrote:
> On Tue, Oct 10, 2017 at 10:24:20AM -0700, Joe Stringer wrote:
>> On 10 October 2017 at 08:09, Eric Garver wrote:
>> > On Tue, Oct 10, 2017 at 05:33:48AM -0700, Joe Stringer wrote:
>> >> On 9 October 2017 at 21:41, Pr
On 10 October 2017 at 08:09, Eric Garver wrote:
> On Tue, Oct 10, 2017 at 05:33:48AM -0700, Joe Stringer wrote:
>> On 9 October 2017 at 21:41, Pravin Shelar wrote:
>> > On Fri, Oct 6, 2017 at 9:44 AM, Eric Garver wrote:
>> >> This adds a ct_clear action for clearin
On 9 October 2017 at 21:41, Pravin Shelar wrote:
> On Fri, Oct 6, 2017 at 9:44 AM, Eric Garver wrote:
>> This adds a ct_clear action for clearing conntrack state. ct_clear is
>> currently implemented in OVS userspace, but is not backed by an action
>> in the kernel datapath. This is useful for fl
er)
> CC: Ali Volkan ATLI
> Signed-off-by: Andy Zhou
LGTM.
Acked-by: Joe Stringer
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
s.
>
> Fixes: 85c55772a453 ("bridge: Fix controller status update")
> Reported-by: Josh Bailey
> Signed-off-by: Andy Zhou
Acked-by: Joe Stringer
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 6 September 2017 at 15:24, Andy Zhou wrote:
> The bug can cause ovs-vswitchd to crash (due to assert) when it is
> set up with a passive controller connection. Since only active
> connections are kept, the passive connection status update should be
> ignored and not trigger asserts.
>
Fixes: 8
atapath flow when that happens.
Signed-off-by: Joe Stringer
---
ofproto/ofproto-dpif-upcall.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
index 4a71bbe258df..bd324fbb6323 100644
--- a/ofproto/ofproto-dpif-upcall.c
+++ b
On 31 August 2017 at 02:02, Stephen Finucane wrote:
> On Thu, 2017-08-31 at 09:59 +0100, Stephen Finucane wrote:
>> On Wed, 2017-08-30 at 10:38 -0700, Joe Stringer wrote:
>> > On 29 August 2017 at 02:54, Stephen Finucane wrote:
>
> [snip]
>
>> > However, it
On 29 August 2017 at 02:54, Stephen Finucane wrote:
> Now that Patchwork 2.0 is out, folks can start to take advantage of some
> of the new features that it offers. Chief among these is series support,
> which is only exposed via the web UI and new REST API and which, in
> turn, necessitates using
On 24 August 2017 at 00:03, Paul Blakey wrote:
>
>
> On 23/08/2017 03:20, Joe Stringer wrote:
>>
>> On 22 August 2017 at 13:31, Paul Blakey wrote:
>>>
>>>
>>>
>>> On 22/08/2017 23:07, Paul Blakey wrote:
>>>>
>>>>
On 22 August 2017 at 17:52, Yi-Hung Wei wrote:
> When a system traffic is skipped due to 'HAVE_FTP = no' or
> 'HAVE_TFTP = no', it takes some effort to figure out it is due to
> missing the required python library. Add some comments around the
> find_l7_lib(), so that user can figure that out by
>
On 22 August 2017 at 18:00, Joe Stringer wrote:
> On 22 August 2017 at 17:52, Yi-Hung Wei wrote:
>> RHEL 7.4 introduces netdev_master_upper_dev_link_rh() that breaks the
>> backport of OVS kernel module on RHEL 7.4. This patch fixes that issue.
>>
>> Signed-off-by: Yi-
On 23 August 2017 at 11:21, Greg Rose wrote:
> Upstream commit:
> commit c57c054eb5b1ccf230c49f736f7a018fcbc3e952
> Author: Tonghao Zhang
> Date: Mon Jul 17 23:28:05 2017 -0700
>
> openvswitch: Optimize updating for OvS flow_stats.
>
> In the ovs_flow_stats_update(), we only
On 23 August 2017 at 11:21, Greg Rose wrote:
> Upstream commit:
> commit 880388aa3c07fdea4f9b85e35641753017b1852f
> Author: David S. Miller
> Date: Mon Jul 3 07:29:12 2017 -0700
>
> net: Remove all references to SKB_GSO_UDP.
>
> Such packets are no longer possible.
>
> S
On 23 August 2017 at 10:32, Joe Stringer wrote:
> On 23 August 2017 at 01:04, Sam wrote:
>> Hi all,
>>
>> I'm testing, I add a new at file, and in that file, I run another shell
>> script like this:
>>
>> AT_SETUP([vhost - run prepare-env.sh])
>>
On 23 August 2017 at 01:04, Sam wrote:
> Hi all,
>
> I'm testing, I add a new at file, and in that file, I run another shell
> script like this:
>
> AT_SETUP([vhost - run prepare-env.sh])
>> #OVS_VSWITCHD_START
>> # No need to create, as bond1 has been created.
>> echo "@"
>> /root
On 22 August 2017 at 17:52, Yi-Hung Wei wrote:
> RHEL 7.4 introduces netdev_master_upper_dev_link_rh() that breaks the
> backport of OVS kernel module on RHEL 7.4. This patch fixes that issue.
>
> Signed-off-by: Yi-Hung Wei
> ---
Thanks YiHung, LGTM.
Unless others have objections, it seems like
On 22 August 2017 at 13:31, Paul Blakey wrote:
>
>
> On 22/08/2017 23:07, Paul Blakey wrote:
>>
>>
>>
>> On 21/08/2017 20:45, Joe Stringer wrote:
>>>
>>> On 20 August 2017 at 01:50, Paul Blakey wrote:
>>>>
>>>>
>&g
On 22 August 2017 at 08:26, Greg Rose wrote:
> On 08/18/2017 02:41 PM, Joe Stringer wrote:
>>
>> On 16 August 2017 at 15:48, Greg Rose wrote:
>> > Upstream commit:
>> > commit 494bea39f3201776cdfddc232705f54a0bd210c4
>> > Author: Liping Zhang
g the ct() action execution, controller writers who
wish to preserve access to this content across a CT action execution
can do so using registers. In practice I'm not aware of any controller
that is currently operating this way though.
Do we need a NEWS item for this?
Acked-by: Joe Str
On 21 August 2017 at 06:31, Aaron Conole wrote:
> Joe Stringer writes:
>
>> The coding style states that BSD-style brace placement should be used,
>> and even single statements should be enclosed. Add checks to checkpatch
>> for this, particularly for 'else' st
On 20 August 2017 at 01:50, Paul Blakey wrote:
>
>
> On 18/08/2017 00:52, Joe Stringer wrote:
>>
>> On 17 August 2017 at 02:18, Paul Blakey wrote:
>>>
>>>
>>>
>>> On 15/08/2017 20:04, Joe Stringer wrote:
>
On 16 August 2017 at 15:48, Greg Rose wrote:
> Upstream commit:
> commit 494bea39f3201776cdfddc232705f54a0bd210c4
> Author: Liping Zhang
> Date: Wed Aug 16 13:30:07 2017 +0800
>
> For sw_flow_actions, the actions_len only represents the kernel part's
> size, and when we dump
On 17 August 2017 at 11:07, Joe Stringer wrote:
> On 17 August 2017 at 00:17, Roi Dayan wrote:
>>
>>
>> On 17/08/2017 08:32, Roi Dayan wrote:
>>>
>>>
>>>
>>> On 17/08/2017 01:17, Joe Stringer wrote:
>>>>
>>>>
On 16 August 2017 at 22:59, Roi Dayan wrote:
> Executing dpctl commands from userspace also calls to
> dpif_open()/dpif_close() but not really creating another dpif
> but using a clone.
> As for netdev_ports map is global we avoid adding duplicate entries
> but also need to make sure we are not re
On 17 August 2017 at 00:52, Paul Blakey wrote:
>
>
> On 15/08/2017 20:24, Joe Stringer wrote:
>>
>> On 15 August 2017 at 01:19, Paul Blakey wrote:
>>>
>>>
>>>
>>> On 15/08/2017 10:28, Paul Blakey wrote:
>>>>
>>>&g
On 17 August 2017 at 02:18, Paul Blakey wrote:
>
>
> On 15/08/2017 20:04, Joe Stringer wrote:
>>
>> On 15 August 2017 at 01:19, Paul Blakey wrote:
>>>
>>>
>>>
>>> On 15/08/2017 00:56, Joe Stringer wrote:
>>>>
>>>&g
On 17 August 2017 at 05:07, Kavanagh, Mark B wrote:
>
>>From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Sam
>>Sent: Thursday, August 17, 2017 7:31 AM
>>To: ovs-disc...@openvswitch.org; ovs-dev@openvswitch.org; d...@dpdk.org
>
> Hi Sam,
>
> Just a heads-up that d...@dpdk.org is strictly for DP
The coding style states that BSD-style brace placement should be used,
and even single statements should be enclosed. Add checks to checkpatch
for this, particularly for 'else' statements.
Signed-off-by: Joe Stringer
---
v2: Combine in same check as if_and_for_end_with_bra
On 17 August 2017 at 07:35, Aaron Conole wrote:
> Hi Joe,
>
> Joe Stringer writes:
>
>> The coding style states that BSD-style brace placement should be used,
>> and even single statements should be enclosed. Add checks to checkpatch
>> for this.
>
On 17 August 2017 at 00:17, Roi Dayan wrote:
>
>
> On 17/08/2017 08:32, Roi Dayan wrote:
>>
>>
>>
>> On 17/08/2017 01:17, Joe Stringer wrote:
>>>
>>> On 16 August 2017 at 05:14, Roi Dayan wrote:
>>>>
>>>> Doing dump-flow
The coding style states that BSD-style brace placement should be used,
and even single statements should be enclosed. Add checks to checkpatch
for this.
Signed-off-by: Joe Stringer
---
utilities/checkpatch.py | 13 +
1 file changed, 13 insertions(+)
diff --git a/utilities
On 16 August 2017 at 05:27, Roi Dayan wrote:
> There is an identical log msg from multiple api calls.
> Add a prefix to identify the source function of the log msg.
>
> Signed-off-by: Roi Dayan
> Reviewed-by: Paul Blakey
> ---
Applied, thanks!
___
dev
On 16 August 2017 at 05:14, Roi Dayan wrote:
> Doing dump-flows also altering the netdev ports list.
> So doing it pre the actual test is adding a check to
> make sure we don't break the that list.
>
> Signed-off-by: Roi Dayan
> Reviewed-by: Paul Blakey
I'm actually not sure what the requiremen
On 16 August 2017 at 05:12, Roi Dayan wrote:
> Executing dpctl commands from userspace also calls to
> dpif_open()/dpif_close() but not really creating another dpif
> but using a clone.
> As for netdev_ports map is global we avoid adding duplicate entries
> but also need to make sure we are not re
On 15 August 2017 at 16:45, Flavio Leitner wrote:
> On Tue, 15 Aug 2017 16:15:55 -0700
> Joe Stringer wrote:
>
>> Signed-off-by: Joe Stringer
>> ---
>> tests/atlocal.in | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/tests/atloca
On 15 August 2017 at 16:45, Flavio Leitner wrote:
> On Tue, 15 Aug 2017 16:15:54 -0700
> Joe Stringer wrote:
>
>> This was causing test script execution to hang forever on Ubuntu Zesty.
>> Make sure it times out within 5 seconds, so at least it will fail out
>> properl
Signed-off-by: Joe Stringer
---
tests/atlocal.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/atlocal.in b/tests/atlocal.in
index ba143d30f1d7..7c5e9e3357e5 100644
--- a/tests/atlocal.in
+++ b/tests/atlocal.in
@@ -152,8 +152,10 @@ find_command nc
# Determine correct netcat
This was causing test script execution to hang forever on Ubuntu Zesty.
Make sure it times out within 5 seconds, so at least it will fail out
properly.
Signed-off-by: Joe Stringer
---
tests/atlocal.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/atlocal.in b
On 15 August 2017 at 15:23, Flavio Leitner wrote:
> On Tue, 15 Aug 2017 15:03:25 -0700
> Joe Stringer wrote:
>
>> This was causing test script execution to hang forever on Ubuntu Zesty.
>> Make sure it times out within 5 seconds, so at least it will fail out
>> properl
This was causing test script execution to hang forever on Ubuntu Zesty.
Make sure it times out within 5 seconds, so at least it will fail out
properly.
Signed-off-by: Joe Stringer
---
tests/atlocal.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/atlocal.in b/tests
On 11 August 2017 at 11:06, Joe Stringer wrote:
> In the OVSDB IDL, we use C++ keywords such as "new", "mutable", "class"
> for variable and field names. This series updates these names so that
> they don't conflict with the C++ keywords, which should
On 8 August 2017 at 07:21, Roi Dayan wrote:
> From: Paul Blakey
>
> Implement support for offloading ovs action set using
> tc header rewrite action.
>
> Signed-off-by: Paul Blakey
> Reviewed-by: Roi Dayan
> ---
Another couple of bits I noticed while responding..
> @@ -454,10 +572,56 @@ net
On 15 August 2017 at 01:19, Paul Blakey wrote:
>
>
> On 15/08/2017 10:28, Paul Blakey wrote:
>>
>>
>>
>> On 15/08/2017 04:04, Joe Stringer wrote:
>>>
>>> On 8 August 2017 at 07:21, Roi Dayan wrote:
>>>>
>>>> From: P
On 15 August 2017 at 01:19, Paul Blakey wrote:
>
>
> On 15/08/2017 00:56, Joe Stringer wrote:
>>
>> On 8 August 2017 at 07:21, Roi Dayan wrote:
>>>
>>> From: Paul Blakey
>>>
>>> @@ -346,6 +425,96 @@ nl_parse_flow
On 8 August 2017 at 07:21, Roi Dayan wrote:
> From: Paul Blakey
>
> Implement support for offloading ovs action set using
> tc header rewrite action.
>
> Signed-off-by: Paul Blakey
> Reviewed-by: Roi Dayan
> ---
> @@ -274,6 +346,48 @@ netdev_tc_flow_dump_destroy(struct netdev_flow_dump
> *d
On 8 August 2017 at 07:21, Roi Dayan wrote:
> From: Paul Blakey
>
> To be later used to implement ovs action set offloading.
>
> Signed-off-by: Paul Blakey
> Reviewed-by: Roi Dayan
> ---
Hi Paul and folks, some questions inline.
utilities/checkpatch.py says:
$ utilities/checkpatch.py -4
== C
On 8 August 2017 at 01:03, Simon Horman wrote:
> On Mon, Aug 07, 2017 at 06:19:04PM +0300, Roi Dayan wrote:
>> Hi,
>>
>> This series adds support for offloading ip ttl and tcp flags
>> using tc interface.
>
> This looks nice, thanks.
>
> Acked-by: Simon Horman
>
> I'm also happy to apply this if
Now that the 'new' datum is named 'new_datum', be more consistent by
renaming 'old' to 'old_datum' to match.
Signed-off-by: Joe Stringer
Acked-by: Ben Pfaff
---
v3: Add ack.
v2: New patch.
---
lib/ovsdb-data.h | 4 +--
lib/ovsdb-idl-provide
In C++, 'new' is a keyword. If this is used as the name for a field,
then C++ compilers can get confused about the context and fail to
compile references to such fields. Rename the field to 'new_datum' to
avoid this issue.
Signed-off-by: Joe Stringer
Acked-by: Ben Pfaff
In C++, 'mutable' is a keyword. If this is used as the name for a field,
then C++ compilers can get confused about the context and fail to
compile references to such fields. Rename the field to 'is_mutable' to
avoid this issue.
Signed-off-by: Joe Stringer
---
v3: Rename
In C++, 'class' is a keyword. If this is used as the name for a field,
then C++ compilers can get confused about the context and fail to
compile references to such fields. Rename the field to 'class_' to
avoid this issue.
Signed-off-by: Joe Stringer
---
v3: Also update ovs
7; % {'prefix': prefix.upper()})
+#include "uuid.h"
+
+#ifdef __cplusplus
+extern "C" {
+#endif''' % {'prefix': prefix.upper()})
for tableName, table in sorted(schema.tables.items()):
structName = "%s%s" % (prefix, ta
On 10 August 2017 at 13:30, Ben Pfaff wrote:
> On Wed, Aug 09, 2017 at 03:27:41PM -0700, Joe Stringer wrote:
>> In C++, 'new' is a keyword. If this is used as the name for a field,
>> then C++ compilers can get confused about the context and fail to
>> compile re
On 9 August 2017 at 20:54, Gao Zhenyu wrote:
> How about mutable --> is_mutable ?
Thanks, I'll apply this change and respin.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 9 August 2017 at 17:18, Joe Stringer wrote:
> Previously, netdev_ports_insert() would allocate and insert an
> ifindex->odp_port mapping, but netdev_ports_remove() would never remove
> the mapping or free the mapping structure. This patch fixes these up.
>
> Fixes: 32b77c31
On 11 August 2017 at 04:26, Joe Perches wrote:
> OVS_NLERR already adds a newline so these just add blank
> lines to the logging.
>
> Signed-off-by: Joe Perches
Acked-by: Joe Stringer
___
dev mailing list
d...@openvswit
On 10 August 2017 at 11:41, Ben Pfaff wrote:
> On Thu, Aug 10, 2017 at 01:01:32PM +0800, Gao Zhenyu wrote:
>> How about:
>> struct ovsdb_idl_table {
>> ...
>> const struct ovsdb_idl_table_class *table_class
>>
>> }
>>
>> struct ovsdb_idl {
>>
>> const struct ovsdb_idl_class *idl
by: Andy Zhou
Signed-off-by: Joe Stringer
Acked-by: Andy Zhou
---
v2: Added more safety checks for ifindex, NULL pointers.
Added warning message if the ifindex can't be obtained.
---
lib/netdev.c | 20
1 file changed, 20 insertions(+)
diff --git a/lib/netdev.c b/
On 9 August 2017 at 13:59, Ben Pfaff wrote:
> On Wed, Aug 09, 2017 at 01:37:52PM -0700, Joe Stringer wrote:
>> The style guide states that lines should not end with '?' or ':'. Check
>> for this and report an error.
>>
>> Signed-off-by: Joe String
On 9 August 2017 at 13:58, Ben Pfaff wrote:
> On Wed, Aug 09, 2017 at 01:37:51PM -0700, Joe Stringer wrote:
>> Most of the prerequisite checks so far matched on filenames that ended
>> in some character followed by 'c' or 'h', rather than a filename tha
On 9 August 2017 at 13:58, Ben Pfaff wrote:
> On Wed, Aug 09, 2017 at 01:37:50PM -0700, Joe Stringer wrote:
>> The 'Expressions' section of the coding style specifies that one space
>> should be on either side of infix binary and ternary operators. This
>> adds a
On 9 August 2017 at 13:46, Ben Pfaff wrote:
> On Wed, Aug 09, 2017 at 01:38:05PM -0700, Joe Stringer wrote:
>> Signed-off-by: Joe Stringer
>
> For all three patches:
> Acked-by: Ben Pfaff
Thanks, applied to master.
___
On 8 August 2017 at 18:16, Andy Zhou wrote:
> On Tue, Aug 8, 2017 at 5:10 PM, Joe Stringer wrote:
>> Previously, netdev_ports_insert() would allocate and insert an
>> ifindex->odp_port mapping, but netdev_ports_remove() would never remove
>> the mapping or free the mappi
On 8 August 2017 at 18:33, Andy Zhou wrote:
> On Tue, Aug 8, 2017 at 5:10 PM, Joe Stringer wrote:
>> Commit 32b77c316d9982("dpif: Save added ports in a port map.")
>> introduced tracking of all dpif ports by taking a reference on each
>> available netdev when the d
Now that the 'new' datum is named 'new_datum', be more consistent by
renaming 'old' to 'old_datum' to match.
Signed-off-by: Joe Stringer
---
v2: New patch.
---
lib/ovsdb-data.h | 4 +--
lib/ovsdb-idl-provider.h | 22 +
In C++, 'new' is a keyword. If this is used as the name for a field,
then C++ compilers can get confused about the context and fail to
compile references to such fields. Rename the field to 'new_datum' to
avoid this issue.
Signed-off-by: Joe Stringer
---
v2: Rebase.
In C++, 'mutable' is a keyword. If this is used as the name for a field,
then C++ compilers can get confused about the context and fail to
compile references to such fields. Rename the field to 'mutable_' to
avoid this issue.
Signed-off-by: Joe Stringer
---
v2: Rebase
In C++, 'class' is a keyword. If this is used as the name for a field,
then C++ compilers can get confused about the context and fail to
compile references to such fields. Rename the field to 'class_' to
avoid this issue.
Signed-off-by: Joe Stringer
---
v2: Rebase.
--
.upper()})
+#include "uuid.h"
+
+#ifdef __cplusplus
+extern "C" {
+#endif''' % {'prefix': prefix.upper()})
for tableName, table in sorted(schema.tables.items()):
structName = "%s%s" % (prefix, tableName.lower())
@@ -1050,6 +1054,10
Signed-off-by: Joe Stringer
---
ovn/northd/ovn-northd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
index 99d15a7a56c4..49e4ac3383d3 100644
--- a/ovn/northd/ovn-northd.c
+++ b/ovn/northd/ovn-northd.c
@@ -1886,7 +1886,7
Signed-off-by: Joe Stringer
---
ofproto/ofproto-dpif-ipfix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ofproto/ofproto-dpif-ipfix.c b/ofproto/ofproto-dpif-ipfix.c
index fcba02e45b75..472c27281d5f 100644
--- a/ofproto/ofproto-dpif-ipfix.c
+++ b/ofproto/ofproto-dpif
Signed-off-by: Joe Stringer
---
lib/netdev-dummy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c
index 62ddd0c67834..f731af1dfd0e 100644
--- a/lib/netdev-dummy.c
+++ b/lib/netdev-dummy.c
@@ -1574,7 +1574,7 @@ netdev_dummy_receive
The style guide states that lines should not end with '?' or ':'. Check
for this and report an error.
Signed-off-by: Joe Stringer
---
v2: Restrict to '?' and ':'.
Make sure that goto tags aren't flagged.
---
utilities/checkpatch.py | 14 ++
Most of the prerequisite checks so far matched on filenames that ended
in some character followed by 'c' or 'h', rather than a filename that
ends in '.c' or '.h'. Fix this.
Signed-off-by: Joe Stringer
---
utilities/checkpatch.py | 8
1 fi
ot apply to the contents of strings.
This check is left at warning level because there isn't a good way to
determine whether a line is within a multiline comment or string, so it
will occasionally flag such lines which contain hyphenated words.
Signed-off-by: Joe Stringer
---
utilitie
On 9 August 2017 at 12:51, Aaron Conole wrote:
> Darrell Ball writes:
>
>> Thanks Joe
>> I forgot to add your Tested-by to V5; I have been testing this myself;
>> but let me know if you would like it added – I can send a V6.
>
> It will automatically be added by patchwork. It is sufficient to
>
On 8 August 2017 at 19:10, Darrell Ball wrote:
> Thanks Joe
> I forgot to add your Tested-by to V5; I have been testing this myself; but
> let me know if you would like it added – I can send a V6.
No worries, it looks like you'll resubmit with a slightly different
approach so feel free to drop t
cular problem by not adding such devices to the netdev_ports
map, but the referencing/unreferencing upon dpif_open()/dpif_close() is
still not balanced.
Balance the referencing of netdevs by clearing these during dpif_close().
Fixes: 32b77c316d9982("dpif: Save added ports in a port map."
by: Andy Zhou
Signed-off-by: Joe Stringer
---
v3: First post.
---
lib/netdev.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/lib/netdev.c b/lib/netdev.c
index 7e9896b82928..a8f5348264c8 100644
--- a/lib/netdev.c
+++ b/lib/netdev.c
@@ -2266,9 +2266,20 @@ netdev_ports_remove(odp_p
On 8 August 2017 at 00:46, Gao Zhenyu wrote:
> Thanks for working on it!
>
> I think new_ is not a good name. Could you please try to revise it?
> like: old --> old_datum
>new -->new_datum
Sure thing, that's a better name.
> BTW, you also need to update 'new' in the description of struc
d.
>
> Fixes: 7451af618e0d ("dp-packet : Update DPDK rx checksum validation
> functions.")
> CC: Sugesh Chandran
> Signed-off-by: Darrell Ball
> ---
Tested-by: Joe Stringer
Tested-at: https://travis-ci.org/joestringer/openvswitch/jobs/262464859
I'll let those mo
On 8 August 2017 at 16:11, Ben Pfaff wrote:
> The OVS coding style document says that a .c file should include the
> corresponding .h file first, to ensure that the .h file includes all of
> its dependencies, but this file didn't do that.
>
> Signed-off-by: Ben Pfaff
On 8 August 2017 at 16:10, Ben Pfaff wrote:
> On Tue, Aug 08, 2017 at 02:30:28PM -0700, Joe Stringer wrote:
>> If a libopenvswitch user includes ofp-print.h before ofp-util.h (which
>> is standard alphabetical order), and turns on -Werror, then they would
>> hit this com
1 - 100 of 811 matches
Mail list logo
