Re: [ovs-dev] [PATCH v2] MAINTAINERS.rst: Move several people to emeritus status

Show off. > On May 21, 2023, at 5:41 PM, Jesse Gross wrote: > > On Fri, May 19, 2023 at 7:53 AM Russell Bryant wrote: > The following document discusses emeritus committer status: > > https://docs.openvswitch.org/en/latest/internals/committer-emeritus-status/ > > There are several people who

Re: [ovs-dev] [PATCH v2] MAINTAINERS.rst: Move several people to emeritus status

Acked-by: Justin Pettit Thanks for pulling this together, Russell. (It's been so long since I've done anything code-related, that I'm back to top-posting. :-/ ) --Justin > On May 19, 2023, at 7:52 AM, Russell Bryant wrote: > > The following document discusses e

Re: [ovs-dev] [PATCH v3 3/3] dpif-netlink: Remove redundant null assignment

I assume someone else will pull this in as part of the patch set, so: Acked-by: Justin Pettit Ilya, let me know if you'd like me to merge it, though. --Justin > On Nov 4, 2022, at 6:06 AM, Roi Dayan wrote: > > The assignment of the features pointer is not doing > an

Re: [ovs-dev] [PATCH v2 3/3] dpif-netlink: Move meter features reset from wrapper

> On Nov 3, 2022, at 3:38 PM, Ilya Maximets wrote: > > On 11/3/22 09:47, Roi Dayan wrote: >> >> diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c >> index a620a6ec52dd..2bdd2137af36 100644 >> --- a/lib/dpif-netlink.c >> +++ b/lib/dpif-netlink.c >> @@ -4105,7 +4105,7 @@ dpif_netlink_meter_ge

Re: [ovs-dev] [PATCH 3/3] dpif-netlink: Fix reset meter features

> On Nov 2, 2022, at 5:54 AM, Roi Dayan wrote: > > Fix reset features if probe for meter support fails. > > Fixes: 92d0d515d67b ("dpif-netlink: Probe for broken Linux meter > implementations.") > CC: Justin Pettit > Signed-off-by: Roi Dayan > ---

Re: [ovs-dev] [PATCH] security.rst: Add more information about the Downstream mailing list.

> On Dec 24, 2020, at 12:45 PM, Flavio Leitner wrote: > > On Thu, Dec 24, 2020 at 10:58:08AM -0800, Justin Pettit wrote: >> Signed-off-by: Justin Pettit >> --- > > LGTM > Acked-by: Flavio Leitner Thanks! I pu

[ovs-dev] [PATCH] security.rst: Add more information about the Downstream mailing list.

Signed-off-by: Justin Pettit --- Documentation/internals/security.rst | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/Documentation/internals/security.rst b/Documentation/internals/security.rst index f6a31ad01116..8b4e5c3f4d5d 100644 --- a/Documentation/internals

Re: [ovs-dev] [PATCH] release-process: Describe how to branch and how to make a release.

Small point, but do you think it's worth pointing to the website repo in the instructions? (I suppose anyone who's doing branching probably knows it.) Acked-by: Justin Pettit --Justin > On Feb 14, 2020, at 4:18 PM, Ben Pfaff wrote: > > CC: Justin Pettit > Si

Re: [ovs-dev] ovs release checklist

> On Feb 14, 2020, at 11:31 AM, Flavio Leitner wrote: > > On Fri, Feb 14, 2020 at 09:45:40AM -0800, Ben Pfaff wrote: >> Hi Justin, I released 2.13.0, or at least I pushed it to the repo. Do >> you have a checklist of other things to do for a release? I know I need >> to tag it, but I think yo

Re: [ovs-dev] [ovn] stableids

I think this is in the ddlog-dev-v2 branch, not master, correct? That branch was a working directory for me, and I probably just pulled those patches in the wrong order. Does that make sense? --Justin > On Feb 7, 2020, at 2:58 PM, Ben Pfaff wrote: > > Hi Justin. > > In the OVN repo, commi

Re: [ovs-dev] [PATCH] datapath: Fix conntrack cache with timeout

Thanks for the patch, Yi-Hung, and the review, Darrell. I pushed this to master. --Justin > On Sep 29, 2019, at 10:09 AM, Darrell Ball wrote: > > Thanks for the patch > > Looks good and matches the upstream version, including the rcu deference > fixup. > Thanks for remembering to add the re

Re: [ovs-dev] [PATCH v5 9/9] ofproto-dpif-xlate: Translate timeout policy in ct action

> On Sep 25, 2019, at 4:34 PM, Yi-Hung Wei wrote: > > Thanks Justin for the review. The proposed diff looks good to me. Thanks. I pushed the series to master. --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailma

Re: [ovs-dev] [PATCH v5 9/9] ofproto-dpif-xlate: Translate timeout policy in ct action

> On Aug 28, 2019, at 3:14 PM, Yi-Hung Wei wrote: > > diff --git a/lib/dpif-provider.h b/lib/dpif-provider.h > index e988626ea05b..4a599c8eb866 100644 > --- a/lib/dpif-provider.h > +++ b/lib/dpif-provider.h > @@ -542,6 +542,16 @@ struct dpif_class { >stru

Re: [ovs-dev] [PATCH] MAINTAINERS: Add Leonid Ryzhyk.

> On Sep 23, 2019, at 10:18 AM, Ben Pfaff wrote: > > Leonid was elected by the OVN committers on Sept. 23. Welcome to the > team, Leonid! > > CC: Leonid Ryzhyk > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___

Re: [ovs-dev] [PATCH] configure: Properly handle case where sphinx-build is not available.

> On Sep 20, 2019, at 12:00 PM, Ben Pfaff wrote: > > Reported-by: Justin Pettit > Fixes: ab4514890587 ("Recommend Sphinx from Python 3 in documentation and > packaging.") > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___

Re: [ovs-dev] [PATCH] tests: Fix ovs-vsctl unit test failure regression.

> On Sep 17, 2019, at 2:30 PM, Ben Pfaff wrote: > > This worked fine as long as there was only one table whose name started > with "C", but now we have three of them. > > CC: Justin Pettit > Fixes: 61a5264d60d0 ("ovs-vswitchd: Add Datapath, CT_Zone, and

Re: [ovs-dev] [PATCH v5 6/9] ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables

> On Aug 28, 2019, at 3:14 PM, Yi-Hung Wei wrote: > > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c > index 751535249e21..4b4c4d722645 100644 > --- a/ofproto/ofproto-dpif.c > +++ b/ofproto/ofproto-dpif.c > > +static void > +ct_timeout_policy_destroy(struct ct_timeout_policy *ct_

Re: [ovs-dev] [PATCH v5 2/9] ovs-vsctl: Add conntrack zone commands.

> On Sep 13, 2019, at 11:06 AM, William Tu wrote: > > On Fri, Sep 13, 2019 at 10:48 AM Justin Pettit wrote: >> >> >>> On Sep 13, 2019, at 10:41 AM, William Tu wrote: >>> >>>> Is there a reason you limited this to 18 arguments and not use

Re: [ovs-dev] [PATCH v5 2/9] ovs-vsctl: Add conntrack zone commands.

> On Sep 13, 2019, at 10:41 AM, William Tu wrote: > >> Is there a reason you limited this to 18 arguments and not use INT_MAX? > > I use 18 because at most we have 11 tcp, 3 udp, 2 icmp, total of 16 and plus > (dp_name, zone_id), so total is 18. > I think using INT_MAX is fine, because at db s

Re: [ovs-dev] [PATCH v5 1/9] ovs-vswitchd: Add Datapath, CT_Zone, and CT_Zone_Policy tables.

> On Aug 28, 2019, at 3:14 PM, Yi-Hung Wei wrote: > > From: Justin Pettit > > Signed-off-by: Justin Pettit > Signed-off-by: Yi-Hung Wei > Co-authored-by: Yi-Hung Wei Thanks. I merged this into master. --Justin _

Re: [ovs-dev] Querying OVS for OpenFlow capabilities

> On Sep 12, 2019, at 2:15 PM, William Tu wrote: > > On Thu, Sep 12, 2019 at 03:47:58PM -0400, Mark Michelson wrote: >> On 9/12/19 2:46 PM, Justin Pettit wrote: >>> >>> >>>> On Sep 12, 2019, at 11:08 AM, Mark Michelson wrote: >>>> &g

Re: [ovs-dev] [PATCH v5 2/9] ovs-vsctl: Add conntrack zone commands.

> On Aug 28, 2019, at 3:14 PM, Yi-Hung Wei wrote: > > diff --git a/utilities/ovs-vsctl.8.in b/utilities/ovs-vsctl.8.in > index 7c09df79bd29..5b9883ae1c3d 100644 > --- a/utilities/ovs-vsctl.8.in > +++ b/utilities/ovs-vsctl.8.in > @@ -353,6 +353,32 @@ list. > Prints the name of the bridge that co

Re: [ovs-dev] Querying OVS for OpenFlow capabilities

> On Sep 12, 2019, at 11:08 AM, Mark Michelson wrote: > > Hi guys, > > I recently sent a new version of a document describing proposed OVN/OVS > compatibility [1]. In it, I suggested that when we add new OpenFlow > capabilities to OVS, then OVN needs to probe OVS for the OpenFlow > capabil

Re: [ovs-dev] [PATCH] faq: Update list of kernels supported by 2.12.

> On Sep 6, 2019, at 4:52 PM, Yifeng Sun wrote: > > Looks good to me, thanks. > > Reviewed-by: Yifeng Sun Thanks for the quick review. I pushed this to master and branch-2.12. --Justin ___ dev mailing list d...@openvswitch.org https://mail.open

[ovs-dev] [PATCH] faq: Update list of kernels supported by 2.12.

Signed-off-by: Justin Pettit --- Documentation/faq/releases.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst index 8daa23bb2d0c..8c29e32efa71 100644 --- a/Documentation/faq/releases.rst +++ b/Documentation/faq/releases.rst

Re: [ovs-dev] [branch-2.5 1/2] Set release date for 2.5.9.

> On Sep 5, 2019, at 12:38 PM, Ben Pfaff wrote: > > All of these 2.5 to 2.8 release series look good to me. > > Acked-by: Ben Pfaff Thanks. I pushed these to all the appropriate branches. --Justin ___ dev mailing list d...@openvswitch.org https

[ovs-dev] [branch-10 2/2] Prepare for 2.10.5.

Signed-off-by: Justin Pettit --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 8015901d63d9..1756f605a657 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.10.5 - xx xxx

[ovs-dev] [branch-10 1/2] Set release date for 2.10.4.

Signed-off-by: Justin Pettit --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 46c751571482..8015901d63d9 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.10.4 - xx xxx +v2.10.4 - 06 Sep 2019

[ovs-dev] [branch-11 1/2] Set release date for 2.11.3.

Signed-off-by: Justin Pettit --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 8f84f68a4dfe..f177d7efc181 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.11.3 - xx xxx +v2.11.3 - 06 Sep 2019

[ovs-dev] [branch-11 2/2] Prepare for 2.11.4.

Signed-off-by: Justin Pettit --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index f177d7efc181..7c45f561cb0d 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.11.4 - xx xxx

Re: [ovs-dev] [branch-2.11 1/2] Set release date for 2.11.2.

> On Sep 5, 2019, at 4:40 PM, aginwala wrote: > > Hi Justin: > > Please back-port the above patches to branch-2.10 too as it fails there too. Done. Thanks. --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/

Re: [ovs-dev] [branch-2.11 1/2] Set release date for 2.11.2.

> On Sep 5, 2019, at 4:08 PM, Han Zhou wrote: > > Shall older branches support latest kernels? If so, some kernel patches need > to be backported to avoid compile failure. For example, on 2.11, below patch > is required for kernel module compile to pass on Ubuntu with kernel version > 4.15.0

Re: [ovs-dev] [PATCH V2 branch-2.8 1/2] datapath: Properly set L4 keys on "later" IP fragments

key_update_l3l4() and export it so that it is accessible by > handle_fragments() for conntrack packet reassembly. > >Co-authored-by: Justin Pettit >Signed-off-by: Greg Rose >Acked-by: Pravin B Shelar >Signed-off-by: David S. Miller > > Signed-off-by: Greg

[ovs-dev] [branch-2.5 2/2] Prepare for 2.5.10.

Signed-off-by: Justin Pettit --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 681642b6403d..0f8a43d81575 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.5.10 - xx xxx

[ovs-dev] [branch-2.5 1/2] Set release date for 2.5.9.

Signed-off-by: Justin Pettit --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 6de6bdf726a8..681642b6403d 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.5.9 - xx xxx +v2.5.9 - 04 Sep 2019

[ovs-dev] [branch-2.6 2/2] Prepare for 2.6.8.

Signed-off-by: Justin Pettit --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 43ea0c865b92..1ed44dd06b60 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.6.8 - xx xxx

[ovs-dev] [branch-2.6 1/2] Set release date for 2.6.7.

Signed-off-by: Justin Pettit --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 75d1e5a05bfb..43ea0c865b92 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.6.7 - xx xxx +v2.6.7 - 04 Sep 2019

[ovs-dev] [branch-2.7 2/2] Prepare for 2.7.11.

Signed-off-by: Justin Pettit --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index f98b3b301f11..8786e58bdbd9 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.7.11 - xx xxx

[ovs-dev] [branch-2.7 1/2] Set release date for 2.7.10.

Signed-off-by: Justin Pettit --- NEWS | 5 +++-- debian/changelog | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index b7723f147c02..f98b3b301f11 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.7.10 - xx xxx - +v2.7.10

[ovs-dev] [branch-2.8 2/2] Prepare for 2.8.9.

Signed-off-by: Justin Pettit --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index e0d45e9cb621..5aa1dddc14f9 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.8.9 - xx xxx

[ovs-dev] [branch-2.8 1/2] Set release date for 2.8.8.

Signed-off-by: Justin Pettit --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 62ace2f71434..e0d45e9cb621 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.8.8 - xx xxx +v2.8.8 - 04 Sep 2019

[ovs-dev] [branch-2.8 2/2] Prepare for 2.8.9.

Signed-off-by: Justin Pettit --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index e0d45e9cb621..5aa1dddc14f9 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.8.9 - xx xxx

[ovs-dev] [branch-2.8 1/2] Set release date for 2.8.8.

Signed-off-by: Justin Pettit --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 62ace2f71434..e0d45e9cb621 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.8.8 - xx xxx +v2.8.8 - 04 Sep 2019

Re: [ovs-dev] [branch-2.12 1/2] Set release date for 2.12.0.

> On Sep 4, 2019, at 5:30 AM, Flavio Leitner wrote: > > On Tue, Sep 03, 2019 at 03:02:59PM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit >> --- > > To the set > Acked-by: Flavio Leitner Thanks. I pushed these to all the appropriate branches (

Re: [ovs-dev] [branch-2.12 1/2] Set release date for 2.12.0.

> On Sep 4, 2019, at 7:37 AM, Ilya Maximets wrote: > >> Signed-off-by: Justin Pettit >> --- >> NEWS | 4 ++-- >> debian/changelog | 4 ++-- >> 2 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/NEWS b/NEWS >>

[ovs-dev] [branch-2.9 2/2] Prepare for 2.9.7.

Signed-off-by: Justin Pettit --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 8f6469fd4dbc..0e708efd64c4 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.9.7 - xx xxx

[ovs-dev] [branch-2.9 1/2] Set release date for 2.9.6.

Signed-off-by: Justin Pettit --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index c1bb90fe03af..8f6469fd4dbc 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.9.6 - xx xxx +v2.9.6 - 03 Sep 2019

[ovs-dev] [branch-2.10 2/2] Prepare for 2.10.4.

Signed-off-by: Justin Pettit --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 6233984fa1e0..109d809d6a61 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.10.4 - xx xxx

[ovs-dev] [branch-2.10 1/2] Set release date for 2.10.3.

Signed-off-by: Justin Pettit --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 064550b038f9..6233984fa1e0 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.10.3 - xx xxx +v2.10.3 - 03 Sep 2019

[ovs-dev] [branch-2.11 2/2] Prepare for 2.11.3.

Signed-off-by: Justin Pettit --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index f2d44e4630bb..a21d475628d0 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.11.3 - xx xxx

[ovs-dev] [branch-2.11 1/2] Set release date for 2.11.2.

Signed-off-by: Justin Pettit --- NEWS | 3 ++- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index ff2647739375..f2d44e4630bb 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.11.2 - xx xxx +v2.11.2 - 03 Sep 2019

[ovs-dev] [branch-2.12 2/2] Prepare for 2.12.1.

Signed-off-by: Justin Pettit --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 9f4845d8788e..877d965e8691 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.12.1 - xx xxx

[ovs-dev] [branch-2.12 1/2] Set release date for 2.12.0.

Signed-off-by: Justin Pettit --- NEWS | 4 ++-- debian/changelog | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/NEWS b/NEWS index be3ea42b4c91..9f4845d8788e 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,5 @@ -v2.12.0 - xx xxx -- +v2.12.0

Re: [ovs-dev] [PATCH branch-2.8 2/2] datapath: Clear the L4 portion of the key for "later" fragments

> On Aug 29, 2019, at 6:46 PM, Gregory Rose wrote: > > > On 8/29/2019 3:25 PM, Justin Pettit wrote: >>> On Aug 29, 2019, at 10:55 AM, Greg Rose wrote: >>> >>> diff --git a/datapath/flow.c b/datapath/flow.c >>> index 083288f..92fc6ac 100644 >

Re: [ovs-dev] [PATCH branch-2.8 2/2] datapath: Clear the L4 portion of the key for "later" fragments

> On Aug 29, 2019, at 10:55 AM, Greg Rose wrote: > > diff --git a/datapath/flow.c b/datapath/flow.c > index 083288f..92fc6ac 100644 > --- a/datapath/flow.c > +++ b/datapath/flow.c > @@ -529,6 +529,7 @@ static int key_extract_l3l4(struct sk_buff *skb, struct > sw_flow_key *key) >

Re: [ovs-dev] [PATCH branch-2.9 1/2] datapath: Properly set L4 keys on "later" IP fragments

ction >ovs_flow_key_update_l3l4() and export it so that it is accessible by > handle_fragments() for conntrack packet reassembly. > >Co-authored-by: Justin Pettit >Signed-off-by: Greg Rose >Acked-by: Pravin B Shelar >Signed-off-by: David S. Miller

Re: [ovs-dev] [PATCH branch-2.10 1/2] datapath: Properly set L4 keys on "later" IP fragments

ction >ovs_flow_key_update_l3l4() and export it so that it is accessible by > handle_fragments() for conntrack packet reassembly. > >Co-authored-by: Justin Pettit >Signed-off-by: Greg Rose >Acked-by: Pravin B Shelar >Signed-off-by: David S. Miller >

Re: [ovs-dev] [PATCH branch-2.11 1/2] datapath: Properly set L4 keys on "later" IP fragments

ction >ovs_flow_key_update_l3l4() and export it so that it is accessible by > handle_fragments() for conntrack packet reassembly. > >Co-authored-by: Justin Pettit >Signed-off-by: Greg Rose >Acked-by: Pravin B Shelar >Signed-off-by: David S. Miller >

Re: [ovs-dev] [PATCH 1/2] datapath: Properly set L4 keys on "later" IP fragments

ction >ovs_flow_key_update_l3l4() and export it so that it is accessible by > handle_fragments() for conntrack packet reassembly. > >Co-authored-by: Justin Pettit >Signed-off-by: Greg Rose >Acked-by: Pravin B Shelar >Signed-off-by: David S. Miller >

Re: [ovs-dev] [PATCH 1/2] datapath: Properly set L4 keys on "later" IP fragments

> On Aug 28, 2019, at 5:05 PM, Yi-Hung Wei wrote: > > Thanks for the backport. > > Acked-by: Yi-Hung Wei Thanks, Yi-Hung. I already pushed the backports. --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/li

Re: [ovs-dev] [PATCH] sat-math: Do not use __builtin_s*_overflow() with sparse.

> On Aug 21, 2019, at 10:17 AM, Ben Pfaff wrote: > > Some versions of sparse do not understand __builtin_saddll_overflow() and > related GCC builtins for calculations with overflow detection. This patch > avoids using them when sparse is in use. > > Reported-by: Justi

Re: [ovs-dev] [PATCH v2 5/9] ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables

> On Aug 7, 2019, at 11:40 AM, Darrell Ball wrote: > > There are 3 behaviors with the patchset that are datapath specific > > 1/ Unwildcarding of commit flows with timeout policies > As we discussed, the userspace conntrack does not need to do this and > would not since it is suboptimal >

Re: [ovs-dev] [PATCH v2 8/9] ofproto-dpif-xlate: Translate timeout policy in ct action

> On Aug 1, 2019, at 3:07 PM, Yi-Hung Wei wrote: > > diff --git a/lib/dpif-provider.h b/lib/dpif-provider.h > index 79a2314500cf..57b32ccb610f 100644 > --- a/lib/dpif-provider.h > +++ b/lib/dpif-provider.h > @@ -536,6 +536,11 @@ struct dpif_class { >struc

Re: [ovs-dev] [PATCH ovn] ovn-northd: Clarify lsp's 'enabled' and 'up' column handling.

> On Aug 9, 2019, at 11:16 AM, Numan Siddique wrote: > >> On Fri, Aug 9, 2019 at 11:33 PM Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Thanks. This looks good to me. > > Acked-by: Numan Siddique Thanks. I pushed this to OVN master

Re: [ovs-dev] [PATCH] ovn-northd: Fix ARP respond flows flapping.

> On Aug 1, 2019, at 11:08 AM, Han Zhou wrote: > > > diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c > > index eb6c47c..212aa88 100644 > > --- a/ovn/northd/ovn-northd.c > > +++ b/ovn/northd/ovn-northd.c > > @@ -3495,7 +3495,7 @@ lsp_is_enabled(const struct nbrec_logical_switch_po

[ovs-dev] [PATCH ovn] ovn-northd: Clarify lsp's 'enabled' and 'up' column handling.

Signed-off-by: Justin Pettit --- northd/ovn-northd.c | 8 ++-- ovn-nb.xml | 1 + 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index e6953a405..e86134414 100644 --- a/northd/ovn-northd.c +++ b/northd/ovn-northd.c @@ -3488,16

Re: [ovs-dev] [PATCH 1/1] Fixed memory leak in ovn-controller while handling port binding changes.

> On Aug 6, 2019, at 3:20 AM, Numan Siddique wrote: > > On Tue, Jul 23, 2019 at 4:47 PM Dumitru Ceara wrote: > >> On Tue, Jul 23, 2019 at 12:33 PM Damijan Skvarc >> wrote: >>> >>> Signed-off-by: Damijan Skvarc >> >> Looks good to me. Thanks! >> Acked-by: Dumitru Ceara >> > > Thank for

Re: [ovs-dev] [branch 2.12] ovn-northd: fixed memory leak in ovn_port_update_sbrec()

Thanks. I merged this into branch-2.12. --Justin > On Aug 6, 2019, at 4:04 AM, nusid...@redhat.com wrote: > > From: Damijan Skvarc > > Memory leak happens because of redundand memory allocation for array > of single pointer. Issue was solved by removing this redundand allocation > and using

Re: [ovs-dev] [branch 2.12] ovn-controller: Encode the virtual port key in vport_bind action in network byte order

Thanks. I merged this into branch-2.12. --Justin > On Aug 5, 2019, at 11:54 PM, nusid...@redhat.com wrote: > > From: Numan Siddique > > The commit [1] encoded the vport key using uint32_t and the test case > "action parsing" is failing for s380 arch. > > This patch fixes this issue by encodi

Re: [ovs-dev] [PATCH branch 2.12] OVN: fix default L4 default proto reported by ovn-nbctl

Thanks. I added a reference to the OVN repo commit and merged this into branch-2.12. --Justin > On Aug 6, 2019, at 7:35 AM, Lorenzo Bianconi > wrote: > > If no protcol is specified defining a load balancing rule TCP is > selected as default but ovn-nbctl lb-list reports 'tcp/udp' in this >

Re: [ovs-dev] [branch 2.12] ovn-northd: fix memory leak in add_distributed_nat_routes() function

Thanks. I added a reference to the OVN repo commit and merged this into branch-2.12. --Justin > On Aug 8, 2019, at 1:25 AM, Damijan Skvarc wrote: > > Within this function actions & match dynamic strings are used as helper > variables for adding entries into logical flow table. Variables are

Re: [ovs-dev] [PATCH branch 2.12] ovn-controller: Fix inject-pkt command error response.

Thanks. I added a reference to the OVN repo commit and merged this into branch-2.12. --Justin > On Aug 5, 2019, at 9:10 AM, Han Zhou wrote: > > From: Han Zhou > > From: Han Zhou > > When using unixctl command inject-packet, it always respond with > failure "server not ready", although th

Re: [ovs-dev] [PATCH branch 2.12 2/2] ovn-controller: Fix IP engine run with in-flight messages

Thanks. I added a reference to the OVN repo commit and merged this into branch-2.12. --Justin > On Aug 5, 2019, at 8:50 AM, Han Zhou wrote: > > From: Dumitru Ceara > > When trying to incrementally process changes even if there are in-flight > messages we were incorrectly setting the engine

Re: [ovs-dev] [PATCH branch 2.12 1/2] ovn-controller: Fix flow installation latency caused by recompute.

Thanks. I added a reference to the OVN repo commit and merged this into branch-2.12. --Justin > On Aug 5, 2019, at 8:50 AM, Han Zhou wrote: > > From: Han Zhou > > When there are in-flight flow-installations pending to ovs-vswitchd, > current incremental processing logic prioritizes new cha

Re: [ovs-dev] [PATCH branch-2.12] [ovn-northd] Don't emit ICMP need to frag on LRP with no IPv4 address

Thanks. I added a reference to the OVN repo commit and merged this into branch-2.12. --Justin > On Aug 5, 2019, at 8:52 AM, Daniel Alvarez wrote: > > Prior to this patch, when a LRP has only IPv6 addresses, ovn-northd > will crash (SIGSEV) because the current code injects a flow to > emit th

Re: [ovs-dev] [branch2.12] ovn-northd: Add the option to pause and resume

Thanks. I merged this into branch-2.12. --Justin > On Jul 31, 2019, at 11:31 PM, nusid...@redhat.com wrote: > > From: Numan Siddique > > This patch adds 3 unixctl socket comments - pause, resume and is-paused. > > Usage: ovs-appctl -t ovn-northd pause/resume/is-paused > > This feature will

Re: [ovs-dev] [branch 2.12] ovn-controller: Fix the chassis row recreation issue

Thanks. I merged this into branch-2.12. --Justin > On Jul 29, 2019, at 10:08 PM, nusid...@redhat.com wrote: > > From: Numan Siddique > > Before the commit [1], ovn-controller would always recreate its > chassis row if deleted externally. After this commit, it no longer > recreates it. This i

Re: [ovs-dev] [PATCH v2 7/9] datapath: Add support for conntrack timeout policy

> On Aug 1, 2019, at 3:07 PM, Yi-Hung Wei wrote: > > This patch adds support for specifying a timeout policy for a > connection in connection tracking system in kernel datapath. > The timeout policy will be attached to a connection when the > connection is committed to conntrack. > > This patc

Re: [ovs-dev] [PATCH v2 6/9] datapath: compat: Backport nf_conntrack_timeout support

> On Aug 1, 2019, at 3:07 PM, Yi-Hung Wei wrote: > > This patch brings in nf_ct_timeout_put() and nf_ct_set_timeout() > when it is not available in the kernel. > > Three symbols are created in acinclude.m4. > > * HAVE_NF_CT_SET_TIMEOUT is used to determine if upstream net-next commit > 717700

Re: [ovs-dev] [PATCH v2 5/9] ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables

> On Aug 5, 2019, at 8:07 PM, Darrell Ball wrote: > > On Thu, Aug 1, 2019 at 3:10 PM Yi-Hung Wei wrote: > >> +struct ct_timeout_policy { >> +struct uuid uuid; >> +unsigned int last_used_seqno; >> +struct ct_dpif_timeout_policy cdtp; >> +struct cmap_node node; /* Eleme

Re: [ovs-dev] [PATCH v2 5/9] ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables

> On Aug 1, 2019, at 3:07 PM, Yi-Hung Wei wrote: > > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c > index 751535249e21..6336494e0bc8 100644 > --- a/ofproto/ofproto-dpif.c > +++ b/ofproto/ofproto-dpif.c > > +static struct ct_timeout_policy * > +ct_timeout_policy_alloc(struct ovs

Re: [ovs-dev] [PATCH v2 4/9] ct-dpif, dpif-netlink: Add conntrack timeout policy support

> On Aug 1, 2019, at 3:07 PM, Yi-Hung Wei wrote: > > This patch also adds missing symbols in the windows datapath so > that the build on windows can pass. Alin, can you do a quick sanity-check on the Windows part? Thanks. Yi-Hung, it looks good to me. Just mostly some minor stuff below. >

Re: [ovs-dev] [PATCH v2 3/9] ct-dpif: Export ct_dpif_format_ipproto()

> On Aug 1, 2019, at 3:07 PM, Yi-Hung Wei wrote: > > This function will be useful for following patchs. s/patchs/patches/ Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman

Re: [ovs-dev] [PATCH v2 2/9] ovs-vsctl: Add conntrack zone commands.

cord not found.", dp_name); There's some inconsistency about whether the errors have a period. I'd suggest removing them, since I think that's more common in the ovs-vsctl error messages. > +return; > +} > + > +zone = find_ct_zone(dp, zone_id); > +

Re: [ovs-dev] [PATCH 02/12] vswitchd: Add datapath, CT_Zone, and CT_Timeout_Policy tables.

> On Jul 26, 2019, at 8:11 AM, William Tu wrote: > > On Thu, Jul 25, 2019 at 04:24:04PM -0700, Yi-Hung Wei wrote: >> >> + "type": {"key": "string", "value": "string", >> + "min": 0, "max": "unlimited"}}}, >> + "indexes": [["timeouts"]]}, > > Just to let you know

Re: [ovs-dev] [PATCH v2 1/9] ovs-vswitchd: Add Datapath, CT_Zone, and CT_Zone_Policy tables.

> On Aug 1, 2019, at 3:07 PM, Yi-Hung Wei wrote: > > From: Justin Pettit > > From: Justin Pettit Can you drop one of these "From:" statements? Otherwise it appears in the commit message. As we discussed off-line, can you apply the following diff, which we worke

Re: [ovs-dev] [PATCH 00/12] Support zone-based conntrack timeout policy

> On Jul 31, 2019, at 1:25 AM, Ilya Maximets wrote: > > On 29.07.2019 21:53, Yi-Hung Wei wrote: >> >> As for the database schema, we intend to make CT_Zone table references >> to CT_Timeout_Policy table because some other zone-based feature can >> be configured through ovsdb later on. For exam

Re: [ovs-dev] [PATCH] rhel: Fix upgrade path

> On Jun 25, 2019, at 2:05 PM, Aaron Conole wrote: > > Greg Rose writes: > >> There is a bug in the upgrade path from the old kmod-openvswitch SysV >> based RPM to the new openvswitch-kmod systemd based RPM. Since the >> name of the package is changed it is not possible to use the yum >> or r

Re: [ovs-dev] [PATCH] Remove ESX references.

> On May 31, 2019, at 10:51 AM, Ben Pfaff wrote: > > On Thu, May 30, 2019 at 06:06:32PM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > As long as you build-tested it: > Acked-by: Ben Pfaff Thanks. I pushed t

[ovs-dev] [PATCH] Remove ESX references.

Signed-off-by: Justin Pettit --- configure.ac | 1 - lib/automake.mk | 6 -- lib/dpif.h| 6 +++--- m4/openvswitch.m4 | 10 -- 4 files changed, 3 insertions(+), 20 deletions(-) diff --git a/configure.ac b/configure.ac index 2dbe9a9178e3..a9f0a06dc140 100644 --- a

Re: [ovs-dev] [PATCH] ovsdb-client.1: Fix typo.

> On May 23, 2019, at 2:42 PM, Ben Pfaff wrote: > > On Thu, May 23, 2019 at 02:10:08PM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Acked-by: Ben Pfaff Thanks. I pushed this to master. --Justin _

[ovs-dev] [PATCH] ovsdb-client.1: Fix typo.

Signed-off-by: Justin Pettit --- ovsdb/ovsdb-client.1.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovsdb/ovsdb-client.1.in b/ovsdb/ovsdb-client.1.in index 284433bb36a4..ee329d2d7c2c 100644 --- a/ovsdb/ovsdb-client.1.in +++ b/ovsdb/ovsdb-client.1.in @@ -271,7 +271,7

Re: [ovs-dev] [PATCH 1/3] ovn.at: Clean up northd-backup in "ovn -- ipam" test.

> On May 23, 2019, at 1:31 PM, Ben Pfaff wrote: > > On Thu, May 23, 2019 at 01:07:35PM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > I built this series and ran the tests. They passed. > > For all of these: > Acked-by: Ben Pfaff Tha

[ovs-dev] [PATCH 3/3] ovn-macros: Break the OVN macros into their own file.

Signed-off-by: Justin Pettit --- tests/automake.mk | 3 +- tests/ofproto-macros.at | 177 --- tests/ovn-macros.at | 180 tests/testsuite.at | 1 + 4 files changed, 183 insertions(+), 178 deletions

[ovs-dev] [PATCH 1/3] ovn.at: Clean up northd-backup in "ovn -- ipam" test.

Signed-off-by: Justin Pettit --- tests/ovn.at | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/ovn.at b/tests/ovn.at index 6499df3d3e2a..298f647d37bf 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -6408,6 +6408,9 @@ OVS_APP_EXIT_AND_WAIT([ovsdb-server]) as northd

[ovs-dev] [PATCH 2/3] ovn.at: Use ovn cleanup macros.

Signed-off-by: Justin Pettit --- tests/ovn.at | 92 +++- 1 file changed, 5 insertions(+), 87 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index 298f647d37bf..9c71dc9ffdcf 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -3857,24 +3857,7

Re: [ovs-dev] OVS/OVN Split initial commits are complete

> On Apr 26, 2019, at 2:50 PM, Mark Michelson wrote: > > On 4/26/19 3:42 PM, Ben Pfaff wrote: > >> We need to pick a date (or a trigger) for freezing the OVN parts of OVS. >> I don't know what that date should be. Thoughts? > > I'm of the opinion that it should be ASAP. With the new repo cre

Re: [ovs-dev] [PATCH] MAINTAINERS: Add Ilya Maximets.

Acked-by: Justin Pettit --Justin > On Apr 26, 2019, at 10:52 AM, Ben Pfaff wrote: > > Ilya was elected by the Open vSwitch committers on Thursday. Welcome to > the team, Ilya! > > CC: Ilya Maximets > Signed-off-by: Ben Pfaff > --- > MAINTAINERS.rst | 2 ++ >

Re: [ovs-dev] OVN/OVS Split POC: version 2

> On Apr 23, 2019, at 2:25 PM, Ben Pfaff wrote: > > I got the right permissions to move this, so it is now in ovn-org: > https://github.com/ovn-org/ovn Yes, let's use this as the place for development. I also gave Numan permission to write to the repo as well, since Mark will be taking some

Re: [ovs-dev] [branch-2.5 1/2] Set release date for 2.5.8.

> On Apr 10, 2019, at 5:13 PM, Ben Pfaff wrote: > > On Sat, Mar 30, 2019 at 12:53:25PM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Acked-by: Ben Pfaff > > You can take this for all of the patches in all these release series. > > (I

  1   2   3   4   5   6   7   8   9   >