Re: [ovs-dev] [PATCH] lib: Build action_set in one scan of action_list

2018-06-15 Thread Kyle Simpson
> I like how it actually deletes more lines (161) > than it adds (106). A good result. :) > What do you think of this version? Looks good to me, I'm not a macro person so it was strange at first glance. It makes a lot of sense though, and it's certainly more extensible than my mechanism and what

[ovs-dev] [PATCH] lib: Build action_set in one scan of action_list

2018-06-06 Thread Kyle Simpson
The previous implementation scans the action set of each WRITE_ACTIONS command 13--17 times when moving the actions over. This change builds up the list as a single scan, which should be more efficient. Signed-off-by: Kyle Simpson --- lib/ofp-actions.c | 110