Re: [ovs-dev] [PATCH] netdev-offload-tc: Fix offload of tunnel key tp_src.

Hi Vladislav, On Wed, Nov 15, 2023 at 04:13:13PM +0300, Vladislav Odintsov wrote: ... > Final flow: >

Re: [ovs-dev] [PATCH v13] ofproto-dpif-upcall: Don't set statistics to 0 when they jump back

On Fri, May 26, 2023 at 03:09:02PM +0200, Eelco Chaudron wrote: > > > On 26 May 2023, at 14:03, Balazs Nemeth wrote: > > > The only way that stats->{n_packets,n_bytes} would decrease is due to an > > overflow, or if there are bugs in how statistics are handled. In the > > past, there were multiple

Re: [ovs-dev] [PATCH v5] ofproto-dpif-upcall: Don't set statistics to 0 when they jump back

On Thu, Mar 16, 2023 at 09:51:34AM +0100, Eelco Chaudron wrote: > > > On 22 Dec 2022, at 13:32, Eelco Chaudron wrote: > > > On 22 Dec 2022, at 10:26, Balazs Nemeth wrote: > > > >> The only way that stats->{n_packets,n_bytes} would decrease is due to an > >> overflow, or if there are bugs in how

Re: [ovs-dev] [PATCH 1/1] tc: translate mirror/stolen to mirred

On Wed, Mar 15, 2023 at 09:33:09AM +0100, Simon Horman wrote: > On Tue, Mar 14, 2023 at 06:49:25PM +0100, Ilya Maximets wrote: > > On 3/14/23 12:15, Simon Horman wrote: > > > On Mon, Mar 13, 2023 at 09:34:30PM +0100, Ilya Maximets wrote: > > >> On 3/13/23 11:27, Roi Dayan wrote: > > >>> From: Oz

Re: [ovs-dev] [PATCH] tc: Add TCA_KIND flower to delete and get operation to avoid rtnl_lock().

On Thu, Jan 26, 2023 at 04:23:39AM -0800, Marcelo Ricardo Leitner wrote: > +Cc Chris, Paul and Vlad. > > On Thu, Jan 26, 2023 at 11:08:02AM +0100, Eelco Chaudron wrote: > > A long long time ago, an effort was made to make tc flower > > rtnl_lock() free. However, on the OVS

Re: [ovs-dev] [PATCH] tc: Add TCA_KIND flower to delete and get operation to avoid rtnl_lock().

+Cc Chris, Paul and Vlad. On Thu, Jan 26, 2023 at 11:08:02AM +0100, Eelco Chaudron wrote: > A long long time ago, an effort was made to make tc flower > rtnl_lock() free. However, on the OVS part we forgot to add > the TCA_KIND "flower" attribute, which tell the kernel to skip > the lock. This

Re: [ovs-dev] [PATCHv4 net-next 0/5] net: eliminate the duplicate code in the ct nat functions of ovs and tc

On Thu, Dec 08, 2022 at 11:56:07AM -0500, Xin Long wrote: > The changes in the patchset: > > "net: add helper support in tc act_ct for ovs offloading" > > had moved some common ct code used by both OVS and TC into netfilter. Nice dedup. Acked-by

Re: [ovs-dev] [PATCHv2 net-next 5/5] net: move the nat function to nf_nat_ovs for ovs and tc

On Wed, Nov 23, 2022 at 04:34:45PM -0500, Xin Long wrote: > On Wed, Nov 23, 2022 at 4:21 PM Marcelo Ricardo Leitner > wrote: > > > > On Wed, Nov 23, 2022 at 02:55:05PM -0500, Xin Long wrote: > > > On Wed, Nov 23, 2022 at 2:17 PM Marcelo Ricardo Leitner > > > w

Re: [ovs-dev] [PATCHv2 net-next 5/5] net: move the nat function to nf_nat_ovs for ovs and tc

On Wed, Nov 23, 2022 at 02:55:05PM -0500, Xin Long wrote: > On Wed, Nov 23, 2022 at 2:17 PM Marcelo Ricardo Leitner > wrote: > > > > On Wed, Nov 23, 2022 at 01:54:41PM -0500, Xin Long wrote: > > > On Wed, Nov 23, 2022 at 1:48 PM Marcelo Ricardo Leitner > > > w

Re: [ovs-dev] [PATCHv2 net-next 5/5] net: move the nat function to nf_nat_ovs for ovs and tc

On Wed, Nov 23, 2022 at 01:54:41PM -0500, Xin Long wrote: > On Wed, Nov 23, 2022 at 1:48 PM Marcelo Ricardo Leitner > wrote: > > > > On Wed, Nov 23, 2022 at 12:31:38PM -0500, Xin Long wrote: > > > On Wed, Nov 23, 2022 at 10:13 AM Marcelo Ricardo Leitner > > >

Re: [ovs-dev] [PATCHv2 net-next 5/5] net: move the nat function to nf_nat_ovs for ovs and tc

On Tue, Nov 22, 2022 at 12:32:21PM -0500, Xin Long wrote: > --- a/net/netfilter/Makefile > +++ b/net/netfilter/Makefile > @@ -52,7 +52,7 @@ obj-$(CONFIG_NF_CONNTRACK_SANE) += nf_conntrack_sane.o > obj-$(CONFIG_NF_CONNTRACK_SIP) += nf_conntrack_sip.o > obj-$(CONFIG_NF_CONNTRACK_TFTP) +=

Re: [ovs-dev] [PATCHv2 net-next 5/5] net: move the nat function to nf_nat_ovs for ovs and tc

On Wed, Nov 23, 2022 at 12:31:38PM -0500, Xin Long wrote: > On Wed, Nov 23, 2022 at 10:13 AM Marcelo Ricardo Leitner > wrote: > > > > On Wed, Nov 23, 2022 at 12:09:55PM -0300, Marcelo Ricardo Leitner wrote: > > > On Tue, Nov 22, 2022 at 12:32:21PM -0500, Xin Long wr

Re: [ovs-dev] [PATCHv2 net-next 5/5] net: move the nat function to nf_nat_ovs for ovs and tc

On Wed, Nov 23, 2022 at 12:09:55PM -0300, Marcelo Ricardo Leitner wrote: > On Tue, Nov 22, 2022 at 12:32:21PM -0500, Xin Long wrote: > > +int nf_ct_nat(struct sk_buff *skb, struct nf_conn *ct, > > + enum ip_conntrack_info ctinfo, int *action, > > + const struct

Re: [ovs-dev] [PATCHv2 net-next 5/5] net: move the nat function to nf_nat_ovs for ovs and tc

On Tue, Nov 22, 2022 at 12:32:21PM -0500, Xin Long wrote: > +int nf_ct_nat(struct sk_buff *skb, struct nf_conn *ct, > + enum ip_conntrack_info ctinfo, int *action, > + const struct nf_nat_range2 *range, bool commit) > +{ > + enum nf_nat_manip_type maniptype; > + int

Re: [ovs-dev] [PATCHv2 net-next 2/5] openvswitch: return NF_ACCEPT when OVS_CT_NAT is net set in info nat

There's a typo in the subject here, s/is net/is not/ . ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCHv2 net-next 3/5] net: sched: return NF_ACCEPT when fails to add nat ext in tcf_ct_act_nat

On Tue, Nov 22, 2022 at 12:32:19PM -0500, Xin Long wrote: > This patch changes to return NF_ACCEPT when fails to add nat > ext before doing NAT in tcf_ct_act_nat(), to keep consistent > with OVS' processing in ovs_ct_nat(). > > Reviewed-by: Saeed Mahameed > Signed-off-by: Xin Long > --- >

Re: [ovs-dev] [PATCHv2 net-next 0/5] net: eliminate the duplicate code in the ct nat functions of ovs and tc

On Tue, Nov 22, 2022 at 12:32:16PM -0500, Xin Long wrote: > The changes in the patchset: > > "net: add helper support in tc act_ct for ovs offloading" > > had moved some common ct code used by both OVS and TC into netfilter. Please give me today to review this patchset. Thanks, Marcelo

Re: [ovs-dev] [PATCHv3 net-next 4/4] net: sched: add helper support in act_ct

struct tcf_ct_params *p, bool force) Nit, it could have fetched 'force' from p->ct_action too then, as it is only used in this function. There's a typo in Ilya's name in the cover letter. Other than this, LGTM. Acked-by: Marcelo Ricardo Leitner

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Optimize datapath action set by removing last clone action.

Hi, On Mon, Sep 12, 2022 at 05:11:32PM +0200, Ilya Maximets wrote: > On 8/29/22 12:04, Roi Dayan via dev wrote: ... > > Hi, > > > > we are also running some ovs/ovn tests with this patch. > > we didn't encounter breaking issues with current tests we have. > > > > Thanks, > > Roi > > Thanks, Roi,

Re: [ovs-dev] [PATCH v2] netdev-linux: set correct action for packets that passed policer

8b3d403c62240d3eb5e21c1604 > no_percpu > > Fix the issue by restoring pps policer action type to 'continue'. > > Fixes: c2567e533f8a ("add port-based ingress policing based packet-per-second > rate-limiting") > Signed-off-by: Vlad Buslov Review-by: Marcelo Ricardo Leitner ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] netdev-linux: do not touch LAG slaves if master is not attached to ovs.

On Wed, Jun 22, 2022 at 11:10:17AM +0800, Tao Liu wrote: > On Tue, Jun 21, 2022 at 06:49:42AM -0700, Marcelo Ricardo Leitner wrote: > > Hi, > > > > On Tue, Jun 21, 2022 at 02:10:39PM +0800, Tao Liu wrote: > > > Bond master netdev may be created without a classificat

Re: [ovs-dev] [PATCH v2] netdev-linux: do not touch LAG slaves if master is not attached to ovs.

Hi, On Tue, Jun 21, 2022 at 02:10:39PM +0800, Tao Liu wrote: > Bond master netdev may be created without a classification type, due > to routing or tunneling code. Can you please elaborate on why is this an issue? > > If bond master is not attached to ovs, the ingress block on slaves shoud >

Re: [ovs-dev] [PATCH v3 8/9] netdev-offload-tc: Check for none offloadable ct_state flag combination

On Tue, Mar 29, 2022 at 01:06:36PM +0200, Ilya Maximets wrote: > On 2/25/22 13:29, Marcelo Ricardo Leitner wrote: > > On Thu, Feb 24, 2022 at 03:20:23PM +0100, Eelco Chaudron wrote: > >> > >> > >> On 23 Feb 2022, at 17:23, Marcelo Ricardo Leitner wrote: >

Re: [ovs-dev] [PATCH v3 8/9] netdev-offload-tc: Check for none offloadable ct_state flag combination

On Thu, Feb 24, 2022 at 03:20:23PM +0100, Eelco Chaudron wrote: > > > On 23 Feb 2022, at 17:23, Marcelo Ricardo Leitner wrote: > > > On Tue, Feb 22, 2022 at 04:26:10PM +0100, Eelco Chaudron wrote: > >> This patch checks for none offloadable ct_state match flag combi

Re: [ovs-dev] [PATCH v3 8/9] netdev-offload-tc: Check for none offloadable ct_state flag combination

On Tue, Feb 22, 2022 at 04:26:10PM +0100, Eelco Chaudron wrote: > This patch checks for none offloadable ct_state match flag combinations. > If they exist force the +trk flag down to TC Flower > > Signed-off-by: Eelco Chaudron > --- > v3: > - Instead of warning about an invalid flag combination

Re: [ovs-dev] [PATCH net 1/1] net/sched: act_ct: Fix flow table lookup failure with no originating ifindex

On Thu, Feb 17, 2022 at 02:55:27PM +0100, Pablo Neira Ayuso wrote: > On Thu, Feb 17, 2022 at 11:34:24AM +0200, Paul Blakey wrote: > > After cited commit optimizted hw insertion, flow table entries are > > populated with ifindex information which was intended to only be used > > for HW offload.

Re: [ovs-dev] [PATCH net 1/1] net/sched: act_ct: Fix flow table lookup failure with no originating ifindex

en: Fixes: 9795ded7f924 ("net/sched: act_ct: Fill offloading tuple iifidx") Not sure if it needs a respin or not, but: Reviewed-by: Marcelo Ricardo Leitner > Signed-off-by: Paul Blakey > --- ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH net 1/1] net/sched: act_ct: Fix flow table lookup after ct clear or switching zones

ftware offload of established > flows") > Signed-off-by: Paul Blakey Acked-by: Marcelo Ricardo Leitner ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH net v2 0/3] net/sched: Fix ct zone matching for invalid conntrack state

or: Fix matching on zone id for invalid conns > net: openvswitch: Fix matching zone id for invalid conns arriving from tc I keep getting surprised by how much metadata we have on CT other than skb->_nfct. :-) Reviewed-by: Marcelo Ricardo Leitner _

Re: [ovs-dev] [PATCH v2 0/2] netlink-socket: Improve logging in nl transactions.

On Wed, Aug 11, 2021 at 08:47:33PM +0200, Marcelo Ricardo Leitner wrote: > On Wed, Aug 11, 2021 at 05:43:30PM +0200, Paolo Valerio wrote: > > v1 was a single patch [1]. > > > > The first patch is a small fix pointed out by Marcelo that makes sense > > to keep sepa

Re: [ovs-dev] [PATCH v2 0/2] netlink-socket: Improve logging in nl transactions.

essages in netlink transactions. Reviewed-by: Marcelo Ricardo Leitner ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] tc: Set action flags for tunnel_key release

all to nl_msg_put_act_flags(). > > > > Fixes: 292d5bd9bb34 ("tc: Set 'no_percpu' flag for compatible actions") > > Reported-by: Marcelo Ricardo Leitner > > Signed-off-by: Vlad Buslov > > Reviewed-by: Roi Dayan > > --- > > Hi, Marcelo. > Can you, pl

Re: [ovs-dev] [PATCH] netlink-socket: Log extack error messages in netlink transactions.

Hi, On Thu, Aug 05, 2021 at 11:55:51PM +0200, Paolo Valerio wrote: Now that you put these two together: > As an example, with this patch applied, the following generic message: > > ovs|00239|netlink_socket|DBG|received NAK error=0 (Operation not supported)

Re: [ovs-dev] [PATCH] netdev-offload-tc: verify the flower rule installed

On Mon, Jul 12, 2021 at 10:28:15AM +0200, Eelco Chaudron wrote: > > > On 9 Jul 2021, at 20:23, Ilya Maximets wrote: > > > On 7/9/21 10:35 AM, Eelco Chaudron wrote: > >> > >> > >> On 8 Jul 2021, at 22:18, Ilya Maximets wrote: > >> > >>> On 5/17/21 3:20 PM, Eelco Chaudron wrote: > When OVs

Re: [ovs-dev] [PATCH] netdev-offload-tc: verify the flower rule installed

On Thu, Jul 08, 2021 at 10:18:50PM +0200, Ilya Maximets wrote: > On 5/17/21 3:20 PM, Eelco Chaudron wrote: > > When OVs installs the flower rule, it only checks for the OK from the > > kernel. It does not check if the rule requested matches the one > > actually programmed. This change will add

Re: [ovs-dev] [PATCH v3 0/2] add port-based ingress policing based packet-per-second rate-limiting

On Wed, Jun 23, 2021 at 03:47:45PM +0200, Simon Horman wrote: > On Wed, Jun 09, 2021 at 11:52:07AM +0200, Simon Horman wrote: > > Hi, > > > > this short test adds support for add port-based ingress policing based > > packet-per-second rate-limiting. This builds on existing support for > >

Re: [ovs-dev] [PATCH] netdev-offload-tc: verify the flower rule installed

he > user if this is not the case. > > Signed-off-by: Eelco Chaudron Reviewed-by: Marcelo Ricardo Leitner ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 1/2] add port-based ingress policing based packet-per-second rate-limiting

Hi, On Mon, May 17, 2021 at 01:18:53PM +0200, Simon Horman wrote: ... > @@ -547,6 +549,12 @@ is_tap_netdev(const struct netdev *netdev) > return netdev_get_class(netdev) == _tap_class; > } >  > +enum { > +OVS_TC_QOS_TYPE_BPS, > +OVS_TC_QOS_TYPE_PPS, > +OVS_TC_QOS_TYPE_MAX, >

Re: [ovs-dev] [PATCH 0/2] add port-based ingress policing based packet-per-second rate-limiting

On Mon, May 10, 2021 at 09:36:24AM +0200, Simon Horman wrote: > Hi Marcello, Hi Ilya, Hi all, Hi Simon, > > On Fri, Apr 16, 2021 at 03:58:47PM +0200, Simon Horman wrote: > > Hi, > > > > this short test adds support for add port-based ingress policing based > > packet-per-second rate-limiting.

Re: [ovs-dev] [PATCH v3 2/3] netdev-offload-tc: Probe for support for any of the ct_state flags

On Mon, Mar 15, 2021 at 07:41:11PM +0100, Simon Horman wrote: > On Tue, Mar 09, 2021 at 11:12:51AM -0300, Marcelo Ricardo Leitner wrote: > > On Sun, Mar 07, 2021 at 04:22:02PM +0200, Paul Blakey wrote: > > > Upstream kernel now rejects unsupported ct_state flags. > > &g

Re: [ovs-dev] netdev-offload-tc: Add support for ct_state flag rel

On Tue, Mar 30, 2021 at 01:00:15PM +0300, Ariel Levkovich wrote: TCA_FLOWER_KEY_CT_FLAGS_RELATED is already defined in ovs' copy at include/linux/pkt_cls.h, so no change there is needed. To and from flower parsing is handled below. Mainly due to previous patches, it will not attempt to use it

Re: [ovs-dev] [PATCH] netdev-linux: do not touch LAG slaves if master is not attached to ovs.

+Cc Paul On Fri, Mar 19, 2021 at 05:57:24PM +0800, Tao Liu wrote: > Bond master netdev may be created without a classification type, due > to routing or tunneling code. > > If bond master is not attached to ovs, the slaves shoud not be updated. The change (didn't review the patch) looks okay to

Re: [ovs-dev] [PATCH v2 2/2] testsuite: add test cases for ingress_policing parameters

On Fri, Mar 12, 2021 at 12:59:17PM +0100, Simon Horman wrote: > --- a/tests/system-offloads-traffic.at > +++ b/tests/system-offloads-traffic.at > @@ -70,3 +70,50 @@ AT_CHECK([ovs-appctl upcall/show | grep -E "offloaded > flows : [[1-9]]"], [0], [i > > OVS_TRAFFIC_VSWITCHD_STOP > AT_CLEANUP >

Re: [ovs-dev] [PATCH v2 1/2] netdev-linux: correct unit of burst parameter

On Thu, Mar 25, 2021 at 03:51:11PM -0300, Marcelo Ricardo Leitner wrote: > On Fri, Mar 12, 2021 at 12:59:16PM +0100, Simon Horman wrote: > > From: "Yong.Xu" > > > > Correct calculation of burst parameter used when configuring TC policer > > action for in

Re: [ovs-dev] [PATCH v2 1/2] netdev-linux: correct unit of burst parameter

On Fri, Mar 12, 2021 at 12:59:16PM +0100, Simon Horman wrote: > From: "Yong.Xu" > > Correct calculation of burst parameter used when configuring TC policer > action for ingress port-based policing in the case where TC offload is in > use. This now matches the value calculated for the case where

Re: [ovs-dev] [PATCH v3 2/3] netdev-offload-tc: Probe for support for any of the ct_state flags

off-by: Paul Blakey > Acked-by: Roi Dayan Reviewed-by: Marcelo Ricardo Leitner ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/3] netdev-offload-tc: Probe for support for any of the ct_state flags

Hi, On Wed, Mar 03, 2021 at 02:15:35PM +0200, Paul Blakey wrote: > Upstream kernel now rejects unsupported ct_state flags. > Earlier kernels, ignored it but still echoed back the requested ct_state, > if ct_state was supported. ct_state initial support had trk, new, est, > and rel flags. > > If

[ovs-dev] [PATCH v4] vswitchd: update tc hwol docs regarding vswitchd restarts

lets document that if hw-offload was already enabled changing it requires a restart in order for it to have effect. Signed-off-by: Marcelo Ricardo Leitner --- Notes: v2: include changes regarding the new understanding on hw-offload v3: fixed warnings v4: fix wording vswitchd

Re: [ovs-dev] [PATCH v3] netdev-offload-tc: Reject install rules for tc flower unsupported ct_state flags

> > Fixes: 576126a931cd ("netdev-offload-tc: Add conntrack support") > > > Signed-off-by: wenxu > > --- > > lib/netdev-offload-tc.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > This version loogs good to me. > Marcelo, Pa

[ovs-dev] [PATCH v3] vswitchd: update tc hwol docs regarding vswitchd restarts

lets document that if hw-offload was already enabled changing it requires a restart in order for it to have effect. v2: include changes regarding the new understanding on hw-offload v3: fixed warnings Signed-off-by: Marcelo Ricardo Leitner --- vswitchd/vswitch.xml | 8 +--- 1 file changed, 5

[ovs-dev] [PATCH v2] vswitchd: update tc hwol docs regarding vswitchd restarts

lets document that if hw-offload was already enabled changing it requires a restart in order for it to have effect. v2: include changes regarding the new understanding on hw-offload Signed-off-by: Marcelo Ricardo Leitner --- vswitchd/vswitch.xml | 8 +--- 1 file changed, 5 insertions(+), 3

Re: [ovs-dev] [PATCH v2] netdev-offload-tc: Reject install rules for tc flower unsupported ct_state flags

On Wed, Feb 03, 2021 at 01:30:00PM +0800, we...@ucloud.cn wrote: ... > @@ -1641,6 +1644,10 @@ netdev_tc_flow_put(struct netdev *netdev, struct match > *match, > } > > if (mask->ct_state) { > +if (mask->ct_state & TC_UNSUPP_OVS_CS_FLAGS) { > +return EOPNOTSUPP; > +

Re: [ovs-dev] [PATCH] vswitchd: doc that tc-policy needs a restart

On Fri, Jan 29, 2021 at 11:48:37PM +0100, Ilya Maximets wrote: > On 1/29/21 11:33 PM, Marcelo Ricardo Leitner wrote: > > On Fri, Jan 29, 2021 at 10:31:46PM +0100, Ilya Maximets wrote: > >> On 12/23/20 2:01 PM, Marcelo Ricardo Leitner wrote: > >>> tc-policy, just

Re: [ovs-dev] [PATCH] vswitchd: doc that tc-policy needs a restart

On Fri, Jan 29, 2021 at 10:31:46PM +0100, Ilya Maximets wrote: > On 12/23/20 2:01 PM, Marcelo Ricardo Leitner wrote: > > tc-policy, just like hw-offload, is protected by ovsthread_once_start() > > in netdev_set_flow_api_enabled() so lets document that changing it > > requir

[ovs-dev] [PATCH] vswitchd: doc that tc-policy needs a restart

tc-policy, just like hw-offload, is protected by ovsthread_once_start() in netdev_set_flow_api_enabled() so lets document that changing it requires a restart in order for it to have effect. Signed-off-by: Marcelo Ricardo Leitner --- vswitchd/vswitch.xml | 3 ++- 1 file changed, 2 insertions

Re: [ovs-dev] Conntrack with SCTP: +est is never reached.

On Thu, Mar 19, 2020 at 02:30:14PM -0400, Tim Rozet wrote: > In addition I can see in my setup that conntrack and ovs-dpctl all the > states are established: >

Re: [ovs-dev] [PATCH v5 06/10] tc: Move tunnel_key unset action before output ports

On Tue, Dec 17, 2019 at 08:31:20AM +, Paul Blakey wrote: > I have no problem, maybe remove the changelog part? It was in the patch itself. Enabling pipe_decode in mutt did it. Now everything applies here. Thanks, Marcelo ___ dev mailing list

Re: [ovs-dev] [PATCH v5 06/10] tc: Move tunnel_key unset action before output ports

On Mon, Dec 16, 2019 at 05:53:17PM +0200, Paul Blakey wrote: > diff --git a/lib/tc.c b/lib/tc.c > index b2d8ca7..7a4acce 100644 > --- a/lib/tc.c > +++ b/lib/tc.c > @@ -665,6 +665,12 @@ nl_parse_flower_tunnel(struct nlattr **attrs, struct > tc_flower *flower) Not sure why but my 'git am' can't

Re: [ovs-dev] [PATCH v3 03/10] tc: Introduce tcf_id to specify a tc filter

On Mon, Dec 09, 2019 at 03:09:37PM +, Paul Blakey wrote: > > On 12/3/2019 3:45 PM, Roi Dayan wrote: > > @@ -1428,38 +1419,35 @@ netdev_tc_flow_put(struct netdev *netdev, struct > > match *match, > > } > > } > > > > -block_id = get_block_id_from_netdev(netdev); > >

Re: [ovs-dev] [PATCH v2 03/10] tc: Introduce tc_id to specify a tc filter

On Sun, Dec 01, 2019 at 07:38:35AM +, Paul Blakey wrote: > > On 11/27/2019 4:07 PM, Marcelo Ricardo Leitner wrote: > > On Wed, Nov 27, 2019 at 02:55:09PM +0200, Roi Dayan wrote: >> From: Paul > > Blakey <mailto:pa...@mellanox.com> >> >> Move all t

Re: [ovs-dev] [PATCH v2 10/10] netdev-offloads-tc: Probe recirc tc sharing feature on first recirc_id rule

On Wed, Nov 27, 2019 at 02:55:16PM +0200, Roi Dayan wrote: > @@ -1367,7 +1387,7 @@ netdev_tc_flow_put(struct netdev *netdev, struct match > *match, > uint32_t block_id = 0; > struct nlattr *nla; > struct tc_id id; > -uint32_t chain; > +uint32_t chain = 0; > size_t

Re: [ovs-dev] [PATCH v2 09/10] tc: Move tunnel_key unset action before output ports

On Wed, Nov 27, 2019 at 02:55:15PM +0200, Roi Dayan wrote: > From: Paul Blakey > > Since OvS datapath gets packets already decapsulated from tunnel devices, > it doesn't explicitly decapsulate them. So in a recirculation setup, > the tunnel matching continues in the recirculation as the tunnel >

Re: [ovs-dev] [PATCH v2 08/10] netdev-offload-tc: Add conntrack nat support

On Wed, Nov 27, 2019 at 02:55:14PM +0200, Roi Dayan wrote: > From: Paul Blakey > > Changelog: > V1->V2: > Missing ntohs/htons on nat port range. > > Signed-off-by: Paul Blakey > --- > lib/netdev-offload-tc.c | 104 > > lib/tc.c

Re: [ovs-dev] [PATCH v2 07/10] netdev-offload-tc: Add conntrack label and mark support

On Wed, Nov 27, 2019 at 02:55:13PM +0200, Roi Dayan wrote: > From: Paul Blakey > > Signed-off-by: Paul Blakey > --- > lib/dpif-netlink.c | 2 ++ > lib/netdev-offload-tc.c | 66 > + > lib/tc.c| 52

Re: [ovs-dev] [PATCH v2 03/10] tc: Introduce tc_id to specify a tc filter

On Wed, Nov 27, 2019 at 02:55:09PM +0200, Roi Dayan wrote: > From: Paul Blakey > > Move all that is needed to identify a tc filter to a > new structure, tc_id. This removes a lot of duplication > in accessing/creating tc filters. Ok, gotta say, 'tc_id' is a bit confusing here. Every time I read

Re: [ovs-dev] [PATCH net 2/2] act_ct: support asymmetric conntrack

On Fri, Nov 22, 2019 at 03:39:16PM -0500, Aaron Conole wrote: > Marcelo Ricardo Leitner writes: > > > On Mon, Nov 18, 2019 at 04:21:39PM -0500, Aaron Conole wrote: > >> Marcelo Ricardo Leitner writes: > >> > >> > On Fri, Nov 08, 2019 at 04:07:14PM -05

Re: [ovs-dev] [PATCH 00/10] Add support for offloading CT datapath rules to TC

On Tue, Nov 19, 2019 at 02:56:43PM +, Paul Blakey wrote: > On 10/30/2019 3:37 PM, Roi Dayan wrote: > > The following patchset introduces hardware offload of OVS connection > > tracking datapath rules. > > Hey guys, > > Any comments on the series? :) Ahm.. no. I'm backlogged with current

Re: [ovs-dev] [PATCH net 2/2] act_ct: support asymmetric conntrack

On Mon, Nov 18, 2019 at 04:21:39PM -0500, Aaron Conole wrote: > Marcelo Ricardo Leitner writes: > > > On Fri, Nov 08, 2019 at 04:07:14PM -0500, Aaron Conole wrote: > >> The act_ct TC module shares a common conntrack and NAT infrastructure > >> exposed via netfilter

Re: [ovs-dev] [PATCH net 2/2] act_ct: support asymmetric conntrack

On Fri, Nov 08, 2019 at 04:07:14PM -0500, Aaron Conole wrote: > The act_ct TC module shares a common conntrack and NAT infrastructure > exposed via netfilter. It's possible that a packet needs both SNAT and > DNAT manipulation, due to e.g. tuple collision. Netfilter can support > this because it

Re: [ovs-dev] memory leak in internal_dev_create

On Wed, Aug 07, 2019 at 01:32:40PM -0700, Pravin Shelar wrote: > On Tue, Aug 6, 2019 at 5:00 AM Hillf Danton wrote: > > > > > > On Tue, 06 Aug 2019 01:58:05 -0700 > > > Hello, > > > > > > syzbot found the following crash on: > > > > > ... > > > BUG: memory leak > > > unreferenced object

Re: [ovs-dev] [PATCH RFC v2 0/8] Introduce connection tracking tc offload

On Mon, Jul 29, 2019 at 01:05:50PM +, Paul Blakey wrote: > Hi, > > I reproduced both traces. > > The first rcu trace is because we deference the qdisc block without rtnl > locked (flower allows it unlocked) > > and the second trace is because res->goto_tp can be null if the last > prio of

Re: [ovs-dev] [PATCH RFC v2 0/8] Introduce connection tracking tc offload

On Sat, Jul 20, 2019 at 08:26:59AM +, Paul Blakey wrote: > Hi Marcelo, thanks for reporting this, can you dump the datapath rules via > ovs-appctl dpctl/dump-flows -m --names > Also running "tc filter show dev ns2-veth-ab ingress" while it happened can > show us more details. > > I'll try

Re: [ovs-dev] [PATCH RFC v2 0/8] Introduce connection tracking tc offload

On Thu, Jul 04, 2019 at 05:28:19PM +0300, Paul Blakey wrote: > Hi, > > The following patches add connection tracking offload to tc. > > We plan on offloading the datapath rules to netdev one to one to tc rules. > We'll be using upcoming act_ct tc module which is currently under review in >

Re: [ovs-dev] [PATCH] netdev-dpdk: fix MAC address in port addr example

; > > Billy. > > > > > > > -Original Message- > > > > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > > > > boun...@openvswitch.org] On Behalf Of Marcelo Ricardo Leitner > > > > Sent: Monday, April 9, 2018 6:2

Re: [ovs-dev] [PATCH] netdev-dpdk: fix MAC address in port addr example

address. Seems the doc just wasn't updated when they settled for a way of addressing this issue. Thanks, Marcelo > > Regards, > Billy. > > > -Original Message- > > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > > boun...@openvswitch.org] On Beha

[ovs-dev] [PATCH] netdev-dpdk: fix MAC address in port addr example

.html Fixes: 5e7588186839 ("netdev-dpdk: fix port addition for ports sharing same PCI id") Signed-off-by: Marcelo Ricardo Leitner <marcelo.leit...@gmail.com> --- Documentation/howto/dpdk.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/

Re: [ovs-dev] [PATCH v2 0/4] Check size of packets before sending

On Thu, Jan 25, 2018 at 03:31:05PM +1100, Daniel Axtens wrote: > There are a few ways we can send packets that are too large to a > network driver. > > When non-GSO packets are forwarded, we validate their size, based on > the MTU of the destination device. However, when GSO packets are >

Re: [ovs-dev] [PATCH 2/3] net: is_skb_forwardable: validate length of GSO packet segments

On Tue, Jan 16, 2018 at 01:09:19PM +1100, Daniel Axtens wrote: > is_skb_forwardable attempts to detect if a packet is too large to > be sent to the destination device. However, this test does not > consider GSO packets, and it is possible that a GSO packet, when > resegmented, will be larger than

[ovs-dev] [PATCH ovs] dpif: fix warn msg when failed to open netdev

Currently it is using the datapath name/type but what has actually failed was the netdev. Fix it by using netdev name/type instead and also log why it failed. Signed-off-by: Marcelo Ricardo Leitner <mleit...@redhat.com> --- lib/dpif.c | 3 ++- 1 file changed, 2 insertions(+), 1 de

Re: [ovs-dev] [PATCH ovs V6 00/24] Introducing HW offload support for openvswitch

On Sun, Apr 02, 2017 at 02:36:18PM +0300, Roi Dayan wrote: > > > On 02/04/2017 06:50, Roi Dayan wrote: > > > > > > On 31/03/2017 01:11, Marcelo Ricardo Leitner wrote: > > > On Thu, Mar 30, 2017 at 03:43:36PM -0300, Marcelo Ricardo Leitner wrote: ..

Re: [ovs-dev] [PATCH ovs V6 00/24] Introducing HW offload support for openvswitch

On Thu, Mar 30, 2017 at 03:43:36PM -0300, Marcelo Ricardo Leitner wrote: > On Wed, Mar 29, 2017 at 03:43:10PM +0300, Roi Dayan wrote: > > This patch series introduces rule offload functionality to dpif-netlink > > via netdev ports new flow offloading API. The user can specify whethe

Re: [ovs-dev] [PATCH ovs V6 00/24] Introducing HW offload support for openvswitch

On Wed, Mar 29, 2017 at 03:43:10PM +0300, Roi Dayan wrote: > This patch series introduces rule offload functionality to dpif-netlink > via netdev ports new flow offloading API. The user can specify whether to > enable rule offloading or not via OVS configuration. Netdev providers > are able to

Re: [ovs-dev] [PATCH ovs V3 13/25] netdev-tc-offloads: Add flower mask to priority map

On Wed, Feb 08, 2017 at 05:29:26PM +0200, Roi Dayan wrote: > From: Paul Blakey > > Flower classifer requires a different priority per mask, > so we hash the mask and generate a new priority for > each new mask used. > > Signed-off-by: Paul Blakey >

Re: [ovs-dev] [PATCH ovs V3 12/25] dpif-netlink: Use netdev flow put api to insert a flow

..@mellanox.com>; Mark Bloch <ma...@mellanox.com>; Rony > > > Efraim <ro...@mellanox.com>; Fastabend, John R > > > <john.r.fastab...@intel.com>; Joe Stringer <j...@ovn.org>; Andy > > > Gospodarek <a...@greyhouse.net>; Lance Richardson >