Re: [ovs-dev] [PATCH 3/5] lib/dp-packet: Fix data_len issue with multi-segments

2017-05-31 Thread Michael Qiu
在 2017/5/5 23:44, Ben Pfaff 写道: On Fri, May 05, 2017 at 08:57:27AM +, Kavanagh, Mark B wrote: On Tue, May 02, 2017 at 02:10:43PM +0800, Michael Qiu wrote: From: Michael Qiu When a packet is from DPDK source, and it contains multiple segments, data_len is not equal to the packet size

Re: [ovs-dev] [PATCH 3/5] lib/dp-packet: Fix data_len issue with multi-segments

2017-05-31 Thread Michael Qiu
在 2017/5/31 18:59, Kavanagh, Mark B 写道: From: Michael Qiu [mailto:qdy220091...@gmail.com] Sent: Wednesday, May 31, 2017 9:58 AM To: Ben Pfaff ; Kavanagh, Mark B Cc: d...@openvswitch.org; Lal, PrzemyslawX ; Michael Qiu ; Ksiadz, MarcinX Subject: Re: [ovs-dev] [PATCH 3/5] lib/dp-packet: Fix

[ovs-dev] [PATCH 0/5 v3] DPDK multi-segment mbuf support

2017-06-18 Thread Michael Qiu
From: Michael Qiu Currently, OVS only support DPDK single segment mbuf, it could lead problems, like a large non-DPDK source packet transmit to dpdk port. Also, OVS doesn't copy enough info in mbuf when do packet copy. At the same time, vlan and tunnelling packet's DPDK offloads, f

[ovs-dev] [PATCH 1/5] lib/dp-packet: init the mbuf to zero when build with DPDK

2017-06-18 Thread Michael Qiu
From: Michael Qiu When building with DPDK, and using xmalloc() to get a new packet, field mbuf of the packet will not be initialized, but it's very important for DPDK port when copying the data to DPDK mbuf, because if ol_flags and other info are random values, DPDK driver may hang. Signe

[ovs-dev] [PATCH 2/5] lib/dp-packet: copy additional packet info when do packet copy

2017-06-18 Thread Michael Qiu
From: Michael Qiu Currently, when doing packet copy, lots of DPDK mbuf's info will be missed, like packet type, ol_flags, etc. Those information is very important for DPDK to do packets processing. Signed-off-by: Michael Qiu --- lib/dp-packet.c | 3 +++ lib/netdev-dpdk.c | 4 2

[ovs-dev] [PATCH 3/5] lib/dp-packet: Fix data_len issue with multi-segments

2017-06-18 Thread Michael Qiu
From: Michael Qiu When a packet is from DPDK source, and it contains multiple segments, data_len is not equal to the packet size. This patch fix this issue. Co-authored-by: Mark Kavanagh Co-authored-by: Yuanhan Liu Co-authored-by: Przemyslaw Lal Signed-off-by: Michael Qiu Signed-off-by

[ovs-dev] [PATCH 4/5] lib/dp-packet: copy multi-segments data from DPDK mbuf

2017-06-18 Thread Michael Qiu
From: Michael Qiu When doing packet clone, if packet source is from DPDK driver, multi-segment must be considered, and copy the segment's data one by one. Signed-off-by: Michael Qiu --- lib/dp-packet.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-)

[ovs-dev] [PATCH 5/5] lib/netdev-dpdk: copy large packet to multi-segment mbufs

2017-06-18 Thread Michael Qiu
From: Michael Qiu Currently, one packet is only copied to one segment in function dpdk_do_tx_copy(), this could be an issue when a jumbo frame comes, especially for multiple segments. This patch calculate the segment number needed by the packet and copy the data to different segments. Signed

[ovs-dev] [PATCH 0/5 v2] DPDK multi-segment mbuf support

2017-04-30 Thread Michael Qiu
From: Michael Qiu Currently, OVS only support DPDK single segment mbuf, it could lead problems, like a large non-DPDK source packet transmit to dpdk port. Also, OVS doesn't copy enough info in mbuf when do packet copy. At the same time, vlan and tunnelling packet's DPDK offloads, f

[ovs-dev] [PATCH 2/5] lib/dp-packet: copy additional packet info when do packet copy

2017-04-30 Thread Michael Qiu
From: Michael Qiu Currently, when doing packet copy, lots of DPDK mbuf's info will be missed, like packet type, ol_flags, etc. Those information is very important for DPDK to do packets processing. Signed-off-by: Michael Qiu --- lib/dp-packet.c | 3 +++ lib/netdev-dpdk.c | 4 2

[ovs-dev] [PATCH 1/5] lib/dp-packet: init the mbuf to zero when build with DPDK

2017-04-30 Thread Michael Qiu
From: Michael Qiu When building with DPDK, and using xmalloc() to get a new packet, field mbuf of the packet will not be initialized, but it's very important for DPDK port when copying the data to DPDK mbuf, because if ol_flags and other info are random values, DPDK driver may hang. Signe

[ovs-dev] [PATCH 3/5] lib/dp-packet: Fix data_len issue with multi-segments

2017-04-30 Thread Michael Qiu
From: Michael Qiu When a packet is from DPDK source, and it contains multiple segments, data_len is not equal to the packet size. This patch fix this issue. Signed-off-by: Michael Qiu Signed-off-by: Marcin Ksiadz Signed-off-by: Mark Kavanagh Signed-off-by: Przemyslaw Lal Signed-off-by

[ovs-dev] [PATCH 4/5] lib/dp-packet: copy multi-segments data from DPDK mbuf

2017-04-30 Thread Michael Qiu
From: Michael Qiu When doing packet clone, if packet source is from DPDK driver, multi-segment must be considered, and copy the segment's data one by one. Signed-off-by: Michael Qiu --- lib/dp-packet.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-)

[ovs-dev] [PATCH 5/5] lib/netdev-dpdk: copy large packet to multi-segment mbufs

2017-04-30 Thread Michael Qiu
From: Michael Qiu Currently, one packet is only copied to one segment in function dpdk_do_tx_copy(), this could be an issue when a jumbo frame comes, especially for multiple segments. This patch calculate the segment number needed by the packet and copy the data to different segments. Signed

[ovs-dev] [PATCH 1/5] lib/dp-packet: init the mbuf to zero when build with DPDK

2017-05-01 Thread Michael Qiu
From: Michael Qiu When building with DPDK, and using xmalloc() to get a new packet, field mbuf of the packet will not be initialized, but it's very important for DPDK port when copying the data to DPDK mbuf, because if ol_flags and other info are random values, DPDK driver may hang. Signe

[ovs-dev] [PATCH 0/5 v2] DPDK multi-segment mbuf support

2017-05-01 Thread Michael Qiu
From: Michael Qiu Currently, OVS only support DPDK single segment mbuf, it could lead problems, like a large non-DPDK source packet transmit to dpdk port. Also, OVS doesn't copy enough info in mbuf when do packet copy. At the same time, vlan and tunnelling packet's DPDK offloads, f

[ovs-dev] [PATCH 2/5] lib/dp-packet: copy additional packet info when do packet copy

2017-05-01 Thread Michael Qiu
From: Michael Qiu Currently, when doing packet copy, lots of DPDK mbuf's info will be missed, like packet type, ol_flags, etc. Those information is very important for DPDK to do packets processing. Signed-off-by: Michael Qiu --- lib/dp-packet.c | 3 +++ lib/netdev-dpdk.c | 4 2

[ovs-dev] [PATCH 3/5] lib/dp-packet: Fix data_len issue with multi-segments

2017-05-01 Thread Michael Qiu
From: Michael Qiu When a packet is from DPDK source, and it contains multiple segments, data_len is not equal to the packet size. This patch fix this issue. Signed-off-by: Michael Qiu Signed-off-by: Marcin Ksiadz Signed-off-by: Mark Kavanagh Signed-off-by: Przemyslaw Lal Signed-off-by

[ovs-dev] [PATCH 4/5] lib/dp-packet: copy multi-segments data from DPDK mbuf

2017-05-01 Thread Michael Qiu
From: Michael Qiu When doing packet clone, if packet source is from DPDK driver, multi-segment must be considered, and copy the segment's data one by one. Signed-off-by: Michael Qiu --- lib/dp-packet.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-)

[ovs-dev] [PATCH 5/5] lib/netdev-dpdk: copy large packet to multi-segment mbufs

2017-05-01 Thread Michael Qiu
From: Michael Qiu Currently, one packet is only copied to one segment in function dpdk_do_tx_copy(), this could be an issue when a jumbo frame comes, especially for multiple segments. This patch calculate the segment number needed by the packet and copy the data to different segments. Signed

Re: [ovs-dev] [PATCH 0/5 v2] DPDK multi-segment mbuf support

2017-05-01 Thread Michael Qiu
Please ignor this patch set. 在 2017/5/1 0:15, Michael Qiu 写道: From: Michael Qiu Currently, OVS only support DPDK single segment mbuf, it could lead problems, like a large non-DPDK source packet transmit to dpdk port. Also, OVS doesn't copy enough info in mbuf when do packet copy. A

Re: [ovs-dev] [PATCH 1/5] lib/dp-packet: init the mbuf to zero when build with DPDK

2017-05-04 Thread Michael Qiu
Hi, Ben 在 2017/5/5 7:00, Darrell Ball 写道: On 5/1/17, 11:10 PM, "ovs-dev-boun...@openvswitch.org on behalf of Michael Qiu" wrote: From: Michael Qiu When building with DPDK, and using xmalloc() to get a new packet, field mbuf of the packet will not be initialized

Re: [ovs-dev] [RFC PATCH v3 2/8] lib/dp-packet: init specific mbuf fields to 0

2017-12-07 Thread Michael Qiu
- nb_segs - tx_offload - packet_type Adapted from an idea by Michael Qiu : https://patchwork.ozlabs.org/patch/777570/ Signed-off-by: Mark Kavanagh Acked-by: Michael Qiu --- lib/dp-packet.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/dp-packet.

Re: [ovs-dev] [PATCH 2/5] lib/dp-packet: copy additional packet info when do packet copy

2016-11-23 Thread Michael Qiu
在 2016/11/15 0:05, Kavanagh, Mark B 写道: 2016/10/28 17:47, Kavanagh, Mark B : Currently, when doing packet copy, lots of DPDK mbuf's info will be missed, like packet type, ol_flags, etc. Those information is very important for DPDK to do packets processing. Signed-off-by: Michae