Re: [ovs-dev] [PATCH v6 1/2] handlers: Create additional handler threads when using CPU isolation

2022-07-19 Thread Miguel Angel Ajo
What would be the memory impact of this patch? Context: we have been exploring the use of ovn in SoCs for edge environments where memory is a strong constraint and performance is not our biggest concern in all cases. One of the optimizations we had to make (thanks +Zenghui Shi for this investigati

Re: [ovs-dev] [PATCH v6] ovn: Support configuring the BFD params for the tunnel interfaces

2019-02-01 Thread Miguel Angel Ajo Pelayo
Oops thank you I don’t know how I looked exactly... :) On Fri, 1 Feb 2019 at 18:14, Numan Siddique wrote: > > > On Fri, Feb 1, 2019, 7:55 PM Miguel Angel Ajo Pelayo > wrote: > >> Hmm, numan I see an older version of your patch on patchworks [1], but >> not v6 >&g

Re: [ovs-dev] [PATCH v6] ovn: Support configuring the BFD params for the tunnel interfaces

2019-02-01 Thread Miguel Angel Ajo Pelayo
Hmm, numan I see an older version of your patch on patchworks [1], but not v6 May be there was an issue with mail? [1] https://patchwork.ozlabs.org/patch/973888/ On Fri, Feb 1, 2019 at 3:17 PM Miguel Angel Ajo Pelayo wrote: > Hey, > >Did we get this merged in the end?, > >

Re: [ovs-dev] [PATCH v6] ovn: Support configuring the BFD params for the tunnel interfaces

2019-02-01 Thread Miguel Angel Ajo Pelayo
Hey, Did we get this merged in the end?, We're having customers facing issues related to this and we may need to throttle the BFD settings.y On Tue, Oct 9, 2018 at 10:54 AM Numan Siddique wrote: > On Tue, Oct 9, 2018 at 2:18 PM wrote: > > > From: Numan Siddique > > > > With this commit

Re: [ovs-dev] [PATCH v5] ovn: Support a new Logical_Switch_Port.type - 'external'

2019-01-21 Thread Miguel Angel Ajo Pelayo
On Mon, Jan 21, 2019 at 4:02 PM Numan Siddique wrote: > > Hi Han, > > I have addressed your comments. But before posting the patch I wanted to > get an opinion > on the HA support for these external ports. > > The proposed patch doesn't support HA. If the requested chassis goes down > for some re

Re: [ovs-dev] [PATCH v3] ovn: Support a new Logical_Switch_Port.type - 'external'

2018-12-19 Thread Miguel Angel Ajo Pelayo
Oh, if requested chassis matches the chasis of the SRIOV instance, then we don't need HA. Ignore my comments regarding multiple chassis. And yes it's my understanding that the traffic will bounce to the host interface probably through the internal switch embedded in the SRIOV card, or, if the host

Re: [ovs-dev] [PATCH v3] ovn: Support a new Logical_Switch_Port.type - 'external'

2018-12-18 Thread Miguel Angel Ajo Pelayo
Review (by reading the description, not the code). In openstack we provide HA by having several "chassis" respond to such requests when they are in broadcast mode. Then when the requests are unicast (subsequent lease renewals) the unicast requests are responded by just one chassis. Would it be po

Re: [ovs-dev] VLAN tenant network patches

2018-11-15 Thread Miguel Angel Ajo Pelayo
Thanks for looking at this and keeping it moving forward. I'm also fine with both ways of implementing the feature, and of course, having distributed E/W for VLAN is great, It'd be amazing, based on not duplicating interfaces, that the implementations don't interfere each other, and that numan's p

Re: [ovs-dev] OVN based distributed virtual routing for VLAN backed networks

2018-10-23 Thread Miguel Angel Ajo Pelayo
Hi, Nice document, you are capturing the nuisances of handling VLAN very well, I agree that we need a chassis specific mac for the distributed routers, when handling E/W traffic, otherwise you end up with the situation described in [1] making the router port MAC flip. That is also an iss

Re: [ovs-dev] [PATCH] connmgr: Fix vswitchd abort when a port is added and the controller is down

2018-10-17 Thread Miguel Angel Ajo Pelayo
Wow, proper TDD! Is it possible to get this backported at least down to 2.10 ? Acked-by: Miguel Angel Ajo More context here: https://bugzilla.redhat.com/show_bug.cgi?id=1640045 On Wed, Oct 17, 2018 at 2:59 PM Numan Siddique wrote: > > > On Wed, Oct 17, 2018 at 6:27 PM Miguel

Re: [ovs-dev] [PATCH] connmgr: Fix vswitchd abort when a port is added and the controller is down

2018-10-17 Thread Miguel Angel Ajo Pelayo
Wow, that was quick Numans, Did you try the negative of the test? (removing your patch on the C side and trying the test to make sure it fails?) On Wed, Oct 17, 2018 at 2:08 PM wrote: > From: Numan Siddique > > We see the below trace when a port is added to a bridge and the configured > cont

Re: [ovs-dev] [PATCH v3] ovn: Support configuring the BFD params for the tunnel interfaces

2018-09-27 Thread Miguel Angel Ajo Pelayo
Numan Siddique wrote: > > > On Thu, Sep 27, 2018 at 12:53 PM Miguel Angel Ajo Pelayo < > majop...@redhat.com> wrote: > >> >> >> On Wed, Sep 26, 2018 at 11:08 PM Ben Pfaff wrote: >> >>> On Wed, Sep 26, 2018 at 04:14:18PM +0530, nusid...@redhat.c

Re: [ovs-dev] [PATCH v3] ovn: Support configuring the BFD params for the tunnel interfaces

2018-09-27 Thread Miguel Angel Ajo Pelayo
On Wed, Sep 26, 2018 at 11:08 PM Ben Pfaff wrote: > On Wed, Sep 26, 2018 at 04:14:18PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > With this commit the users can override the default values of > > the BFD params - min_rx, min_tx, decay_min_rx and mult if desired. > > This

Re: [ovs-dev] [PATCH v3] ovn: Support configuring the BFD params for the tunnel interfaces

2018-09-26 Thread Miguel Angel Ajo Pelayo
Thank you, Acked-By: Miguel Angel Ajo Pelayo On Wed, Sep 26, 2018 at 12:46 PM wrote: > From: Numan Siddique > > With this commit the users can override the default values of > the BFD params - min_rx, min_tx, decay_min_rx and mult if desired. > This can be useful to debug any

Re: [ovs-dev] [PATCH] ovn: Support configuring the BFD params for the tunnel interfaces

2018-09-26 Thread Miguel Angel Ajo Pelayo
Looks great! but you forgot the testing for the mult option. Rather simple anyway it's obvious it works, but it's my only nit :) On Wed, Sep 26, 2018 at 10:30 AM Numan Siddique wrote: > > > On Tue, Sep 25, 2018 at 10:18 PM Miguel Angel Ajo Pelayo < > majop...@re

Re: [ovs-dev] [PATCH] ovn: Support configuring the BFD params for the tunnel interfaces

2018-09-25 Thread Miguel Angel Ajo Pelayo
Nak, Great work, this will be useful to adjust parameters based on specific network conditions, or while debugging network issues (to reduce flapping). I miss the "mult" parameter to setup the detection multiplier (rx_interval * mult). Thanks a lot, Miguel Ángel. On Tue, Sep 25, 2018 at 5:46 P

Re: [ovs-dev] [PATCH v7 4/4] Replace router internal MAC with gateway MAC for reply packets

2018-09-24 Thread Miguel Angel Ajo Pelayo
No worries Guru, I understand your feeling, I worked with Anil on developing this feature, and it's indeed rather complex (we are actually replacing keepalived + VRRP with openflow and BFD). I'm happy to work on a more detailed documentation, I guess that Numan, Anil and I could team up to help th

Re: [ovs-dev] [PATCH v7 4/4] Replace router internal MAC with gateway MAC for reply packets

2018-08-14 Thread Miguel Angel Ajo Pelayo
Thank you very much, I wasn't able to perform a proper code review, but you can add the Tested-By: Miguel Angel Ajo The issue I described previously seems to be fixed on the v7 of the series. On Mon, Aug 6, 2018 at 9:19 PM Mark Michelson wrote: > On 08/06/2018 01:58 PM, Anil Venka

Re: [ovs-dev] OVN/OVS split: OVN mailing list?

2018-08-13 Thread Miguel Angel Ajo Pelayo
+1 on my side too :) Thank you for bringing up the topic On Mon, Aug 13, 2018 at 2:03 PM Daniel Alvarez Sanchez wrote: > +1 for the split of the ML > > On Mon, Aug 13, 2018 at 11:17 AM Lucas Alvares Gomes < > lucasago...@gmail.com> > wrote: > > > Hi, > > > > > Before starting in-depth technical

Re: [ovs-dev] [PATCH v2 0/4] ovn : Support native dhcp in ovn controller

2018-07-19 Thread Miguel Angel Ajo Pelayo
2018 at 10:38 AM Miguel Angel Ajo Pelayo < majop...@redhat.com> wrote: > > Nice, I’ve been thinking about this last week. > > One question, are we able to limit which chassis will respond to the DHCP > requests? > > I say this, because, otherwise, if we have a lot of chas

Re: [ovs-dev] [PATCH v2 0/4] ovn : Support native dhcp in ovn controller

2018-07-19 Thread Miguel Angel Ajo Pelayo
Nice, I’ve been thinking about this last week. One question, are we able to limit which chassis will respond to the DHCP requests? I say this, because, otherwise, if we have a lot of chassis, a single request on the network would be responded by all chassis which have connectivity to such network

Re: [ovs-dev] [PATCH v5 0/3] Use VLANs for VLAN packets redirected to a gateway chassis

2018-07-18 Thread Miguel Angel Ajo Pelayo
h to make sure "1" does not happen, and then "2" if we confirm that's problematic. Best, Miguel Ángel. On Tue, Jul 10, 2018 at 8:25 AM, Miguel Angel Ajo Pelayo < majop...@redhat.com> wrote: > Anil, good work!. thank you. > > I'm reviewing the patches a

Re: [ovs-dev] [PATCH v5 0/3] Use VLANs for VLAN packets redirected to a gateway chassis

2018-07-09 Thread Miguel Angel Ajo Pelayo
Anil, good work!. thank you. I'm reviewing the patches and the behaviour of the series to make sure everything is all right. E/W distributed L3 routing over L2 is an interesting problem I'm documenting what I see to share it on this thread. Best, Miguel Ángel On Mon, Jun 25, 2018 at 9:33 AM An

Re: [ovs-dev] [PATCH] OVN python IDL: avoid useless JSON conversion to enhance performance

2018-06-13 Thread Miguel Angel Ajo Pelayo
Thank you very much Ben :) On Wed, Jun 13, 2018 at 5:20 PM Ben Pfaff wrote: > OK, I crossported to branch-2.9. > > On Wed, Jun 13, 2018 at 01:24:44PM +0200, Miguel Angel Ajo Pelayo wrote: > > Ben, Russell, could we get this down to ovs 2.9? > > > > It's very i

Re: [ovs-dev] [PATCH] OVN python IDL: avoid useless JSON conversion to enhance performance

2018-06-13 Thread Miguel Angel Ajo Pelayo
y > noticeable. > Thanks a lot! > Daniel > > On Tue, Mar 6, 2018 at 5:09 PM, Lucas Alvares Gomes > wrote: > >> Hi, >> >> Excellent investigative work here Daniel, thanks for that! >> >> On Wed, Feb 28, 2018 at 9:37 AM, Miguel Angel Ajo Pelayo >

Re: [ovs-dev] [PATCH] ovn: Add a new action 'nd_na_router' to handle NS requests for router IPs

2018-05-08 Thread Miguel Angel Ajo Pelayo
Ack, makes sense to me On Tue, May 8, 2018 at 11:36 AM, Numan Siddique wrote: > > > On Tue, May 8, 2018 at 1:20 PM, Miguel Angel Ajo Pelayo < > majop...@redhat.com> wrote: > >> Thank you Numan! >> >> It took me a bit to find what the "RSO" fl

Re: [ovs-dev] [PATCH] ovn: Add a new action 'nd_na_router' to handle NS requests for router IPs

2018-05-08 Thread Miguel Angel Ajo Pelayo
Thank you Numan! It took me a bit to find what the "RSO" flag was, because they are R, S and O, may be we can change that in the commit, or reference the RFC/section (RFC4861 page 23). R Router flag. When set, the R-bit indicates that the sender is a rout

Re: [ovs-dev] [PATCH v1 1/1] Include bfd_status in ovs-vsctl show for interfaces

2018-03-15 Thread Miguel Angel Ajo Pelayo
Thank you Ben. On Wed, Mar 14, 2018 at 11:34 PM Ben Pfaff wrote: > On Mon, Mar 12, 2018 at 10:31:25AM +0000, Miguel Angel Ajo wrote: > > Since OVS 2.8 OVN provides L3HA capabilities via BFD monitoring, > > but checking the status of BFD is not obvious, and we provide >

[ovs-dev] [PATCH v1 1/1] Include bfd_status in ovs-vsctl show for interfaces

2018-03-12 Thread Miguel Angel Ajo
Since OVS 2.8 OVN provides L3HA capabilities via BFD monitoring, but checking the status of BFD is not obvious, and we provide a simple way to visualize the status with this simple patch. Signed-off-by: Miguel Angel Ajo Tested-by: Miguel Angel Ajo --- lib/db-ctl-base.h | 2 +- utilities

Re: [ovs-dev] [PATCH] OVN python IDL: avoid useless JSON conversion to enhance performance

2018-02-28 Thread Miguel Angel Ajo Pelayo
And if we can get backports down the lane, that'd be great :) On Wed, Feb 28, 2018 at 9:37 AM Miguel Angel Ajo Pelayo wrote: > Acked-by: Miguel Angel Ajo > > On Wed, Feb 28, 2018 at 9:13 AM Daniel Alvarez Sanchez < > dalva...@redhat.com> wrote: > >> Thanks Ter

Re: [ovs-dev] [PATCH] OVN python IDL: avoid useless JSON conversion to enhance performance

2018-02-28 Thread Miguel Angel Ajo Pelayo
Acked-by: Miguel Angel Ajo On Wed, Feb 28, 2018 at 9:13 AM Daniel Alvarez Sanchez wrote: > Thanks Terry and Han for the reviews! > I removed the 'OVN' keyword from the title and submitted a v2: > [PATCH v2] python: avoid useless JSON conversion to enhance performance > &g

Re: [ovs-dev] [branch-2.7 1/2] Set release date for 2.7.4.

2018-02-27 Thread Miguel Angel Ajo Pelayo
Thanks a lot :) On Mon, Feb 26, 2018, 9:07 PM Ben Pfaff wrote: > On Mon, Feb 26, 2018 at 11:57:17AM -0800, Justin Pettit wrote: > > > > > On Feb 26, 2018, at 11:51 AM, Ben Pfaff wrote: > > > > > > On Sat, Feb 24, 2018 at 11:08:38AM -0800, Justin Pettit wrote: > > >> Signed-off-by: Justin Pettit

Re: [ovs-dev] Tagging OVS 2.7.4

2018-02-21 Thread Miguel Angel Ajo Pelayo
oduced and that it's backported on 2.7. Ben/anyone. Can we please get a tag for 2.7.4? That'd get us a rebuild of the package in fedora / Centos CBS / RDO. Best regards, Miguel Angel. On Wed, Jan 31, 2018 at 2:15 PM Miguel Angel Ajo Pelayo wrote: > Does it make sense tagging ovs 2

[ovs-dev] Tagging OVS 2.7.4

2018-01-31 Thread Miguel Angel Ajo Pelayo
Does it make sense tagging ovs 2.7.4 stable?. There are several patches which are important for ovn/ networking-ovn since the release of ovs 2.7.3. And I'd be glad to have them available on the upstream builds, so people can start doing more serious testing over RDO/openstack/networking-ovn . Bes

Re: [ovs-dev] [PATCH 1/3] ovn-controller: Add extend_table instead of group_table to expand meter.

2018-01-30 Thread Miguel Angel Ajo Pelayo
Acked-By: Miguel Angel Ajo The refactor looks good to me. On Wed, Jan 24, 2018 at 2:40 AM Ben Pfaff wrote: > From: Guoshuai Li > > The structure and function of the group table and meter table are similar, > refactoring code is used to extend for add the meter table. > The fol

Re: [ovs-dev] test

2018-01-30 Thread Miguel Angel Ajo Pelayo
ACK. It worked for me. On Mon, Jan 29, 2018 at 9:55 PM Ben Pfaff wrote: > I've heard that there are problems with the mailing list this morning, > so here's a test email. > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/ma

Re: [ovs-dev] [PATCH v2] ovn-controller: add new external_id 'ovn-cms-options' to Chassis table

2018-01-24 Thread Miguel Angel Ajo Pelayo
Thank you Ben, that was very quick. It's very helpful. On Tue, Jan 23, 2018 at 6:58 PM Ben Pfaff wrote: > I agree that this seems harmless and potentially useful, so I applied it > to master and branch-2.9. > > On Tue, Jan 23, 2018 at 03:47:23PM +0000, Miguel Angel Ajo Pelayo w

Re: [ovs-dev] [PATCH v2] ovn-controller: add new external_id 'ovn-cms-options' to Chassis table

2018-01-23 Thread Miguel Angel Ajo Pelayo
Awesome it, this would be very helpful to signal chassis details to the cms in a consistent way. It'd be very helpful if we can get this on 2.9, and although I know it's a feature it's tiny enough and independent enough which may not introduce any regression to OVN. Best, Miguel Ángel On Tue, Ja

Re: [ovs-dev] [PATCH] ovn-northd: Avoid duplicate logical flows in SB db

2018-01-09 Thread Miguel Angel Ajo Pelayo
m my point of view, it might be better just keep northd simple, and > let > > clients handle the correctness, and let ovn-controller to do the final > > check. In this case, could Neutron maintain multiple sg-rule ids in > > external-ids of the same ACL entry? > > > >

Re: [ovs-dev] [PATCH] ovn-northd: Avoid duplicate logical flows in SB db

2018-01-08 Thread Miguel Angel Ajo Pelayo
Right! We didn't hit that issue, but it'd make sense to fix in this patch I guess. We could modify the hashing function to not include the action (not sure if it does now..), and also have a separate search function that ignores the action. On Mon, Jan 8, 2018 at 5:39 PM Ben Pfaff wrote: > I s

Re: [ovs-dev] master now "frozen" for forking

2018-01-08 Thread Miguel Angel Ajo Pelayo
It actually makes a lot of sense. Please ignore my other comment on master about having the IPv6 RA patch on 2.9, doing it this way, we effectively have it already. On Fri, Jan 5, 2018 at 5:51 PM Ben Pfaff wrote: > On Fri, Jan 05, 2018 at 03:58:08PM +, Stokes, Ian wrote: > > > Hello everyo

Re: [ovs-dev] [PATCH] ovn-northd: Avoid duplicate logical flows in SB db

2018-01-08 Thread Miguel Angel Ajo Pelayo
Acked-By: Miguel Angel Ajo On Fri, Jan 5, 2018 at 11:44 AM Daniel Alvarez wrote: > When there are two ACLs in a Logical Switch with same direction, > priority, match and action fields, ovn-northd will generate the > exact same logical flow for them into SB database. This will m

Re: [ovs-dev] [PATCH v6 2/2] OVN: Add support for periodic router advertisements.

2018-01-08 Thread Miguel Angel Ajo Pelayo
Awesome!, do you believe it would be possible to have this on the 2.9 series too? Having the periodic router advertisements on the next openstack release was one of our items towards parity with the reference solution in the land of IPv6. On Fri, Jan 5, 2018 at 6:05 PM Ben Pfaff wrote: > On W

Re: [ovs-dev] [PATCH v1] OVN: Add external_ids to NAT and Logical_Router_Static_Route tables.

2017-12-04 Thread Miguel Angel Ajo Pelayo
Acked-by: Miguel Angel Ajo On Mon, Dec 4, 2017 at 2:16 PM, wrote: > From: Lucas Alvares Gomes > > The external_ids column is missing from the NAT and > Logical_Router_Static_Route tables. > > Signed-off-by: Lucas Alvares Gomes > --- > ovn/ovn-nb.ovsschema | 14 +

Re: [ovs-dev] [PATCH v2] ovn: Add document describing new features in OVN added in version 2.8.

2017-11-13 Thread Miguel Angel Ajo Pelayo
Acked-by: Miguel Angel Ajo Looks good to me too :) On Thu, Nov 9, 2017 at 11:20 PM, Mark Michelson wrote: > Looks good by me! > > On Thu, Nov 9, 2017 at 4:03 PM Ben Pfaff wrote: > > > This is adapted from a talk I gave at OpenStack Summit Sydney on Nov. 6. > > >

Re: [ovs-dev] DNS support feature (was: Re: DNS support options)

2017-10-30 Thread Miguel Angel Ajo Pelayo
I don't believe rounding up TTLs would be a good practice. The administrators are aware of the risks of having a very low TTL, so if they decide to pick a low TTL they may have good reasons (like the possibility of a very close event of the IP being moved, or some sort of failover mechanism, or a w

Re: [ovs-dev] [PATCH 2/2] ovn-northd; Treat logical ports of router type as always being up

2017-10-27 Thread Miguel Angel Ajo Pelayo
Can we move this patch forward and get a backport to 2.8 / 2.7 branches? Otherwise we get a failure on openstack's: neutron.tests.tempest.api.test_routers.RoutersTest.test_router_interface_status Cheers & thanks. On Mon, Oct 2, 2017 at 6:25 PM, Miguel Angel Ajo Pelayo wrote: &

Re: [ovs-dev] [PATCH 1/2] ovn-northd: Refactor logic for logical port 'up' state update

2017-10-27 Thread Miguel Angel Ajo Pelayo
Can we move this patches forward and get a backport to 2.8 / 2.7 branches? Otherwise we get a failure on openstack's: neutron.tests.tempest.api.test_routers.RoutersTest.test_router_interface_status On Mon, Oct 2, 2017 at 1:33 PM, Miguel Angel Ajo Pelayo wrote: > Acked-by: Miguel A

Re: [ovs-dev] race condition in "ovn: l3ha ensure no master bouncing when ovn-controller is restarted" test?

2017-10-27 Thread Miguel Angel Ajo Pelayo
rted, ovn-controller removes the old > Chassis entry from the SBDB and a new one is inserted. > > This cleared the Gateway_Chassis chassis column in the SBDB and then > ovn-northd removed the empty-column Gateway_Chassis entry. > Such event made the other (non-restarted and master ga

Re: [ovs-dev] [PATCH] ovn pacemaker: Provide the option to configure inactivity probe value

2017-10-17 Thread Miguel Angel Ajo Pelayo
Acked-By: Miguel Angel Ajo It makes sense to be able to configure the inactive probe time, also disabling the echo requests on server, as Ben said I agree would also make sense in any future patch. On Mon, Oct 16, 2017 at 9:48 PM, Ben Pfaff wrote: > On Mon, Oct 16, 2017 at 10:58:43AM -0

Re: [ovs-dev] TOS for BFD packets

2017-10-17 Thread Miguel Angel Ajo Pelayo
That's a good point, I don't have experience with that (what's the best DSCP class), but we should make sure BFD packet, as control/monitoring traffic, is prioritised over other types of traffic. On Tue, Oct 17, 2017 at 11:12 AM, Venkatesan Pradeep < venkatesan.prad...@ericsson.com> wrote: > Hi B

Re: [ovs-dev] locks for clustered OVSDB

2017-10-10 Thread Miguel Angel Ajo Pelayo
; > >> On Mon, Sep 25, 2017 at 2:36 AM, Miguel Angel Ajo Pelayo < > > >> majop...@redhat.com> wrote: > > >> > > > >> > I believe Lucas Alvares could give you valuable feedback on this as > > >> > he was planning to use this as

Re: [ovs-dev] [PATCH 2/2] ovn-northd; Treat logical ports of router type as always being up

2017-10-02 Thread Miguel Angel Ajo Pelayo
Acked-by: Miguel Angel Ajo On Mon, Oct 2, 2017 at 3:39 PM, Jakub Sitnicki wrote: > Hi Ajo, > > On Mon, 2 Oct 2017 13:39:03 +0200 > Miguel Angel Ajo Pelayo wrote: > > > On Fri, Sep 29, 2017 at 9:01 PM, Mark Michelson > wrote: > > > > > LGTM > > &

Re: [ovs-dev] [PATCH 2/2] ovn-northd; Treat logical ports of router type as always being up

2017-10-02 Thread Miguel Angel Ajo Pelayo
On Fri, Sep 29, 2017 at 9:01 PM, Mark Michelson wrote: > LGTM > > On Fri, Sep 29, 2017 at 10:07 AM Jakub Sitnicki wrote: > > > Employ the simplest possible approach to determine the state of logical > > ports that connect to logical routers by hardcoding it to always up. > > This is intended to

Re: [ovs-dev] [PATCH 1/2] ovn-northd: Refactor logic for logical port 'up' state update

2017-10-02 Thread Miguel Angel Ajo Pelayo
Acked-by: Miguel Angel Ajo On Fri, Sep 29, 2017 at 8:06 PM, Mark Michelson wrote: > This looks much better. I wrote out the truth table to confirm that the > functionality is the same. > > On Fri, Sep 29, 2017 at 10:06 AM Jakub Sitnicki wrote: > > > No functional change.

Re: [ovs-dev] [PATCH RFC 39/52] ovn-sbctl: Allow retries by default.

2017-09-26 Thread Miguel Angel Ajo Pelayo
it now). > > On Mon, Sep 25, 2017 at 10:53:09AM +0200, Miguel Angel Ajo Pelayo wrote: > > It makes sense. > > > > As an idea for future improvements (also applicable to the python client > > and the ovsdbapp): something that I've found valuable in distributed &

Re: [ovs-dev] [PATCH] ovn-controller: pending_ct_zones should be destroyed

2017-09-25 Thread Miguel Angel Ajo Pelayo
ooh thanks ':D On Mon, Sep 25, 2017 at 3:00 PM, Russell Bryant wrote: > On Mon, Sep 25, 2017 at 5:01 AM, Miguel Angel Ajo Pelayo > wrote: > > Acked-by: Miguel Angel Ajo > > > > (Somehow I thought I had acked this, but apparently I only checked it was > >

Re: [ovs-dev] locks for clustered OVSDB

2017-09-25 Thread Miguel Angel Ajo Pelayo
I believe Lucas Alvares could give you valuable feedback on this as he was planning to use this as a mechanism for synchronization on the networking-ovn side (if I didn't get it wrong). I believe he's back by October. Best regards. Miguel Ángel. On Fri, Sep 22, 2017 at 6:58 PM, Ben Pfaff wrote:

Re: [ovs-dev] [PATCH] ovn-controller: pending_ct_zones should be destroyed

2017-09-25 Thread Miguel Angel Ajo Pelayo
Acked-by: Miguel Angel Ajo (Somehow I thought I had acked this, but apparently I only checked it was ok and never responded) On Mon, Sep 25, 2017 at 7:24 AM, 00037997 wrote: > pending_ct_zones in ovn-controller main should be destroyed when exit. > > Signed-off-by: xu rong >

Re: [ovs-dev] 答复: [PATCH v1 1/3] Add multipath static router in OVN northd and north-db

2017-09-25 Thread Miguel Angel Ajo Pelayo
t will be handled > by the specific chassis. > > Sorry for misleading again. I think we can focus on the implementatioin of > multipath now. :) > > Thanks > Zhenyu Gao > > 2017-09-22 20:22 GMT+08:00 Russell Bryant : > >> On Thu, Sep 21, 2017 at 10:56 AM, Migue

Re: [ovs-dev] [PATCH RFC 39/52] ovn-sbctl: Allow retries by default.

2017-09-25 Thread Miguel Angel Ajo Pelayo
ogram from GNU coreutils). > > On Thu, Sep 21, 2017 at 01:17:09PM +0200, Miguel Angel Ajo Pelayo wrote: > > Makes sense. Is there any way to control the number of retries, and the > > retry time? > > > > Acked-by: Miguel Angel Ajo > > > > On Wed, Sep 20,

Re: [ovs-dev] 答复: [PATCH v1 1/3] Add multipath static router in OVN northd and north-db

2017-09-21 Thread Miguel Angel Ajo Pelayo
d comments are welcome :) > > > Thanks > Zhenyu Gao > > 2017-09-21 19:07 GMT+08:00 Miguel Angel Ajo Pelayo : > >> May be I missed something, but when I tried setting logical routers into >> specific chassis, still the E/W traffic was handled in a distributed way >

Re: [ovs-dev] [PATCH] ovn-northd: add chassis nonull check

2017-09-21 Thread Miguel Angel Ajo Pelayo
Thank you, that was my doing, thanks for finding and fixing!! On Tue, Sep 19, 2017 at 8:07 PM, Russell Bryant wrote: > On Tue, Sep 19, 2017 at 5:49 AM, wrote: > > op->sb->gateway_chassis[0]->chassis may null in some special cases, need > > to add a check to avoid segment fault. > > > > Signed-

Re: [ovs-dev] [PATCH RFC 39/52] ovn-sbctl: Allow retries by default.

2017-09-21 Thread Miguel Angel Ajo Pelayo
Makes sense. Is there any way to control the number of retries, and the retry time? Acked-by: Miguel Angel Ajo On Wed, Sep 20, 2017 at 12:01 AM, Ben Pfaff wrote: > Most of the OVS database-manipulation utilities (ovn-sbctl, ovn-nbctl, > ovs-vsctl, vtep-ctl) don't retry their con

Re: [ovs-dev] [PATCH] ovn-controller: pending_ct_zones should be destroy

2017-09-21 Thread Miguel Angel Ajo Pelayo
Only fix the commit message s/destroy/destroyed/g On Thu, Sep 21, 2017 at 1:14 PM, Miguel Angel Ajo Pelayo < majop...@redhat.com> wrote: > Acked-by: Miguel Angel Ajo > > On Wed, Sep 20, 2017 at 7:57 AM, wrote: > >> pending_ct_zones in ovn-controller main sho

Re: [ovs-dev] [PATCH] ovn-controller: pending_ct_zones should be destroy

2017-09-21 Thread Miguel Angel Ajo Pelayo
Acked-by: Miguel Angel Ajo On Wed, Sep 20, 2017 at 7:57 AM, wrote: > pending_ct_zones in ovn-controller main should be destroy when exit. > > Signed-off-by: xu rong > > --- > ovn/controller/ovn-controller.c | 1 + > 1 file changed, 1 insertion(+) > > diff

Re: [ovs-dev] 答复: [PATCH v1 1/3] Add multipath static router in OVN northd and north-db

2017-09-21 Thread Miguel Angel Ajo Pelayo
rated in two > paths automatically. Otherwise you need to config static rule one by one to > seperate traffics. > To make a long story short, you also can do same thing by config numerous > static rules to seperate traffic but the multipath can do it > automatically. > > 2017-09

Re: [ovs-dev] [PATCH v2] ovn: Fix remote not receive GARP, when localnet Port has vlan tag.

2017-09-21 Thread Miguel Angel Ajo Pelayo
The patch makes sense, could we add some testing to make sure this is happening and ensure that we don't hit regressions later? On Wed, Sep 20, 2017 at 5:12 PM, Guoshuai Li wrote: > When sending a localnet port with vlan, the GARP packet needs push_vlan. > --- > > v2: >Add check vlan vaid.

Re: [ovs-dev] [PATCH v2] ovn: OVN Support QoS meter

2017-09-21 Thread Miguel Angel Ajo Pelayo
I thought we didn't have meters yet in OvS switch implementation (beyond openflow protocol support) as per: http://docs.openvswitch.org/en/latest/faq/qos/ Has this changed in master? On Wed, Sep 20, 2017 at 1:52 PM, Guoshuai Li wrote: > ovn-northd modify: > add bandwidth column in NB's QOS tab

Re: [ovs-dev] 答复: [PATCH v1 1/3] Add multipath static router in OVN northd and north-db

2017-09-20 Thread Miguel Angel Ajo Pelayo
I forgot to say thank you very much for the explanation and diagrams. On Wed, Sep 20, 2017 at 4:07 PM, Miguel Angel Ajo Pelayo < majop...@redhat.com> wrote: > But, if an ovn port in foo (chassis A) wants to talk to alice1 (chassis > B), > wouldn't all that E/W routing will

Re: [ovs-dev] 答复: [PATCH v1 1/3] Add multipath static router in OVN northd and north-db

2017-09-20 Thread Miguel Angel Ajo Pelayo
--+ > | join | | join2 | > +--+ +---+ > | | > | | > +--+ +---+ > | R2 | | R3 | > +--+ +---+ >| | >| | > +-+ > | alice | > +--

Re: [ovs-dev] 答复: [PATCH v1 1/3] Add multipath static router in OVN northd and north-db

2017-09-20 Thread Miguel Angel Ajo Pelayo
o consider > the remote tunnel up/down status. I would like to make it step by step and > implement it in my next series patches. > > Thanks > Zhenyu Gao > > 2017-09-20 17:53 GMT+08:00 Miguel Angel Ajo Pelayo : > >> I'm not very familiar with multipath implementat

Re: [ovs-dev] 答复: [PATCH v1 1/3] Add multipath static router in OVN northd and north-db

2017-09-20 Thread Miguel Angel Ajo Pelayo
I'm not very familiar with multipath implementations, but would it be possible to use bundle( ouput action with hrw algorithm instead of multipath calculation to a register?. I say this, because if you look at lib/multipath.c lib/bundle.c you will find that bundle.c is going to consider the up/do

Re: [ovs-dev] [PATCH] ovn: Discard flows for non-local ports.

2017-09-20 Thread Miguel Angel Ajo Pelayo
Wow, amazing, that makes sense. I also ran manual tests locally and everything seemed fine. On Tue, Sep 19, 2017 at 6:22 PM, Russell Bryant wrote: > On Tue, Sep 19, 2017 at 9:38 AM, Russell Bryant wrote: > > On Mon, Sep 18, 2017 at 7:31 PM, Han Zhou wrote: > >> Thanks Russell for the quick wo

Re: [ovs-dev] 答复: Re: [PATCH] ovn: Discard flows for non-local ports.

2017-09-19 Thread Miguel Angel Ajo Pelayo
> > > Han Zhou > 发件人: ovs-dev-boun...@openvswitch.org > 2017/09/19 07:31 > > 收件人:Russell Bryant , > 抄送: "d...@openvswitch.org" , Miguel Angel > Ajo Pelayo > 主题: Re: [ovs-dev] [PATCH] ovn: Discard flows for non-local > ports

Re: [ovs-dev] [RFC] Question about ovn-controller performance

2017-09-14 Thread Miguel Angel Ajo Pelayo
On Thu, Sep 14, 2017 at 2:58 PM, Ben Pfaff wrote: > On Thu, Sep 14, 2017 at 02:52:48PM -0600, Miguel Angel Ajo Pelayo wrote: > > Although I see we have code for somehow packing stuff into conjunctions: > > > > https://github.com/openvswitch/ovs/blob/1ea2184501d43352ec4076

Re: [ovs-dev] [RFC] Question about ovn-controller performance

2017-09-14 Thread Miguel Angel Ajo Pelayo
I will prepare a summary with what I found and post it on this thread. On Thu, Sep 14, 2017 at 12:28 PM, Ben Pfaff wrote: > On Thu, Sep 14, 2017 at 10:39:28AM +0800, wang.qia...@zte.com.cn wrote: > > I configure 5 networks, every network have about 80 ports, the total > ports > > is 400, all in

Re: [ovs-dev] does ovs bfd support flow based tunnel?

2017-09-14 Thread Miguel Angel Ajo Pelayo
What do you mean by flow-based tunnel? We're using it internally to provide HA connectivity to Gateway_Chassis on OVN, and it's working as a charm to monitor tunnel endpoints on OVS bridges. https://github.com/openvswitch/ovs/blob/master/ovn/controller/bfd.c On Tue, Sep 12, 2017 at 9:19 PM, yche

Re: [ovs-dev] 答复: [RFC] Question about ovn-controller performance

2017-09-14 Thread Miguel Angel Ajo Pelayo
I'm looking at the issue as it was recently detected in our scale lab. Also you may find that ovn-controller is using a lot of memory. Long ago the plan was to use conjunctions [1] to avoid the cartesian product resulting of openstack remote_group_id based rules where you reference all remote IPs

Re: [ovs-dev] [PATCH 2/2] ovn: Support chassis hostname in requested-chassis.

2017-09-07 Thread Miguel Angel Ajo Pelayo
Ack, I'll submit a patch for it :) On Thu, Sep 7, 2017 at 4:28 PM, Russell Bryant wrote: > I'd be supportive of expanding that field to allow either name or > hostname as well. > > On Thu, Sep 7, 2017 at 9:44 AM, Miguel Angel Ajo Pelayo > wrote: > > I was t

Re: [ovs-dev] [PATCH 2/2] ovn: Support chassis hostname in requested-chassis.

2017-09-07 Thread Miguel Angel Ajo Pelayo
I was thinking that it could have been convenient to do it that way in: https://github.com/openvswitch/ovs/blob/master/ovn/ovn-nb.ovsschema#L315 But we picked up chassis_name instead, not sure if it'd make any sense to use the hostname instead, it'd be much nicer for listing, so you can just see

Re: [ovs-dev] Regarding implementing support for SNMP protocol

2017-09-07 Thread Miguel Angel Ajo Pelayo
What kind of information would you like to expose via SNMP? do you already have any examples in mind? You could have an independent SMTP agent querying SBDB & the local OVSDB on every chassis. I believe a separate agent would make a better separation of concerns. On Thu, Sep 7, 2017 at 8:29 AM, S

Re: [ovs-dev] [PATCH v1] ovn: Fix BFD error config on gateway

2017-08-17 Thread Miguel Angel Ajo Pelayo
On Fri, Aug 18, 2017 at 3:24 AM, Gao Zhenyu wrote: > Thanks for the suggestion. A testcase would be add in ovn testings. But I > am not familiar with ovn test and busy on other stuff now. > Since this issue affects many consumers who try to use HA gateways. I > prefer to push this fix in ovs mas

Re: [ovs-dev] [PATCHv2] ovn: Add support for ACL logging.

2017-08-09 Thread Miguel Angel Ajo Pelayo
Nice addition :D On Sat, Jul 29, 2017 at 2:01 AM, Justin Pettit wrote: > > > On Jul 28, 2017, at 4:57 PM, Ben Pfaff wrote: > > > > On Fri, Jul 28, 2017 at 03:48:38PM -0700, Justin Pettit wrote: > >> Signed-off-by: Justin Pettit > >> Acked-by: Han Zhou > >> --- > >> v1->v2: Incorporate Ben and

Re: [ovs-dev] [PATCH] ovn-northd: Add native active-standby HA.

2017-08-09 Thread Miguel Angel Ajo Pelayo
Nice idea, I have btw some comments/thoughts/questions regarding this: 1) Does OVSDB have any heartbeat protocol? (to detect that one northd has died even during inactive periods). Otherwise we can document the need to tweak the tcp_keepalive settings of the system to have some sensible sett

Re: [ovs-dev] [PATCH] ovn: Support for taas(tap-as-a-service) function

2017-08-03 Thread Miguel Angel Ajo Pelayo
I had the same thought about the tables. Regards, Miguel Ángel On Thu, Aug 3, 2017 at 5:11 PM, Russell Bryant wrote: > On Thu, Aug 3, 2017 at 4:44 AM, wrote: > > Taas was designed to provide tenants and service providers a means of > > monitoring the traffic flowing in their Neutron provision

Re: [ovs-dev] [PATCH v5 3/3] ovn-northd: Add logical flows to support native IPv6 RA

2017-07-31 Thread Miguel Angel Ajo Pelayo
Acked-by: Miguel Angel Ajo On Mon, Jul 31, 2017 at 2:41 PM, wrote: > From: Zongkai LI > > This patch adds logical flows which sends IPv6 Router Advertisement > packet in response to the IPv6 Router Solicitation request. It uses > the actions "put_nd_ra_opts" to tran

Re: [ovs-dev] Revisit OVN meeting schedule?

2017-07-27 Thread Miguel Angel Ajo Pelayo
Thank you for bringing this up. #1 works great for me, but #2 also works. On Wed, Jul 26, 2017 at 6:14 PM, Daniel Alvarez Sanchez wrote: > On Wed, Jul 26, 2017 at 5:13 PM, Ben Pfaff wrote: > > > On July 26, 2017 8:07:57 AM PDT, Russell Bryant wrote: > > >It has been difficult for some of our

Re: [ovs-dev] [PATCH] ovn-architecture: Remove outdated comment.

2017-07-25 Thread Miguel Angel Ajo Pelayo
Acked-by: Miguel Angel Ajo On Mon, Jul 24, 2017 at 10:53 PM, Russell Bryant wrote: > This outdated comment said that support for hardware gateways that > support the vtep schema would come later. This was actually > implemented a long time ago. > > Signed-off-by: Russell Bryan

Re: [ovs-dev] [PATCH v3 2/3] ovn-controller: Add a new action - 'put_nd_ra_opts'

2017-07-25 Thread Miguel Angel Ajo Pelayo
Looks good to my unexperienced eye. Acked-by: Miguel Angel Ajo On Fri, Jul 14, 2017 at 2:26 PM, wrote: > From: Numan Siddique > > This patch adds a new OVN action 'put_nd_ra_opts' to support native > IPv6 Router Advertisement in OVN. This action can be used to respon

Re: [ovs-dev] [PATCH v3 3/3] ovn-northd: Add logical flows to support native IPv6 RA

2017-07-25 Thread Miguel Angel Ajo Pelayo
Looks good, just a tiny comment, but not actually very important. On Fri, Jul 14, 2017 at 2:26 PM, wrote: > From: Zongkai LI > > This patch adds logical flows which sends IPv6 Router Advertisement > packet in response to the IPv6 Router Solicitation request. It uses > the actions "put_nd_ra_op

Re: [ovs-dev] [PATCH v3 1/3] ovn util: Refactor dhcp_opts_map to make it generic

2017-07-25 Thread Miguel Angel Ajo Pelayo
Looks good to my unexperienced eyes. Acked-by: Miguel Angel Ajo On Fri, Jul 14, 2017 at 2:25 PM, wrote: > From: Numan Siddique > > Renamed 'struct dhcp_opts_map' to 'struct gen_opts_map' and > renamed ovn-dhcp.h to ovn-l7.h. An upcoming commit to support I

Re: [ovs-dev] [PATCH 2/2] docs: Note currently used L3 gateway HA approach.

2017-07-20 Thread Miguel Angel Ajo Pelayo
Sorry for the delay, I missed this one which makes perfect sense. Acked-by: Miguel Angel Ajo On Sun, Jul 16, 2017 at 9:56 PM, Russell Bryant wrote: > The OVN gateway HA design document is very useful in its current form. > It describes a range of options OVN could take to provide gate

Re: [ovs-dev] [PATCH v7 1/1] ovn: l3ha, CLI for logical router port gateway chassis

2017-07-20 Thread Miguel Angel Ajo Pelayo
date with > another value. > For example, user can add chassis with priority 5, later can update it to > 10 > ovn-nbctl lrp-set-gateway-chassis lrp0 chassis1 5 > ovn-nbctl lrp-set-gateway-chassis lrp0 chassis1 10 > > Thanks > Anil > > On Thu, Jul 20, 2017 at 9:1

Re: [ovs-dev] [PATCH v7 1/1] ovn: l3ha, CLI for logical router port gateway chassis

2017-07-20 Thread Miguel Angel Ajo Pelayo
One last comment, sorry to come late with more comments: if lrp-set-gateway-chassis is additive, shouldn't we rename it to: lrp-add-gateway-chassis ? Thanks, and best regards On Tue, Jul 18, 2017 at 8:05 AM, Venkata Anil Kommaddi wrote: > From: Venkata Anil > > This change adds commands to

Re: [ovs-dev] [PATCH v1 1/1] ovn: l3ha fix unexpected ARP requests on pcap during tests

2017-07-19 Thread Miguel Angel Ajo Pelayo
Please, ignore this patch, it doesn't help. On Wed, Jul 19, 2017 at 12:07 PM, Miguel Angel Ajo wrote: > For testing l3ha datapath we have an external port on a separate sim > instance (ext1), and we send an UDP packet that we expect to see > going through the specific MASTER gatew

[ovs-dev] [PATCH v1 1/1] ovn: l3ha fix unexpected ARP requests on pcap during tests

2017-07-19 Thread Miguel Angel Ajo
the tests, also makes sure that ovn-controller has synchronized and waits one more second to make sure that BFD sessions are fully established between gateways. Signed-off-by: Miguel Angel Ajo --- tests/ofproto-macros.at | 11 ++- tests/ovn.at| 17 - 2 files changed

Re: [ovs-dev] [PATCH] ovn-architecture: Add notes on L3 gateway HA.

2017-07-19 Thread Miguel Angel Ajo Pelayo
Sounds great, thank you! Acked-by: Miguel Angel Ajo On Sun, Jul 16, 2017 at 10:09 PM, Russell Bryant wrote: > Add some comments to the ovn-architecture document that distributed > gateway ports can also be made highly available. Provide a brief > overview of the approach and poi

Re: [ovs-dev] [PATCH v1 4/4] ovn: l3ha truncate log file in tests before action starts

2017-07-18 Thread Miguel Angel Ajo Pelayo
nding gARPs now (uniq filter) 0 packets == the chassis is not sending gARPs for a router. El 19 jul. 2017 4:40 a. m., "Russell Bryant" escribió: > On Tue, Jul 18, 2017 at 10:55 AM, Miguel Angel Ajo > wrote: > > An specific ovn/l3ha test looks for port releases in the MAST

[ovs-dev] [PATCH v1 4/4] ovn: l3ha truncate log file in tests before action starts

2017-07-18 Thread Miguel Angel Ajo
An specific ovn/l3ha test looks for port releases in the MASTER gateway when another gateway on the Gateway_Chassis list is gone. But we didn't clean the log before taking out the chassis, so any previous unrelated occurrence could make the test fail while it was ok. Signed-off-by: Miguel

  1   2   >