Re: [ovs-dev] [PATCH ovn v3 3/3] Add support for overlay provider networks.

On Thu, Jun 6, 2024 at 4:11 PM Mark Michelson wrote: > > Hi Numan, > > I have only one small comment below. > > On 5/21/24 16:17, num...@ovn.org wrote: > > From: Numan Siddique > > > > It is expected that a provider network logical switch has a localnet logica

Re: [ovs-dev] [PATCH ovn 5/5] controller: Handle postponed ports release.

_ports, port_name); > +return !!cp; > +} This is wrong. '_postponed_ports' is an sset and not shash and sset_find returns 'struct sset_node'. You can use sset_contains i.,e static bool is_postponed_port(const char *port_name) { return sset_contains(&_postponed_ports,

Re: [ovs-dev] [PATCH ovn 4/5] controller: Handle postponed ports claims.

poned_port list. > - Changing port type to localport while port claim was postponed. > - Deleting parent of a container port while parent was postponed. > > Signed-off-by: Xavier Simonart Acked-by: Numan Siddique Numan > --- > controller/binding.c | 29 +++

Re: [ovs-dev] [PATCH ovn 3/5] controller: Fix deletion of container parent port.

On Tue, Apr 23, 2024 at 7:54 AM Xavier Simonart wrote: > > Flows were not properly removed when parent port of a container port > was deleted. > > Signed-off-by: Xavier Simonart Acked-by: Numan Siddique Numan > --- > controller/binding.c | 1 + > controller/phys

Re: [ovs-dev] [PATCH ovn 2/5] controller: Nonvif related lports handling.

chassis. > > A test case has been modified to highlight the error, but also to > make the test easier to read (e.g avoid using same name for a port and > for a switch). > > Signed-off-by: Xavier Simonart Acked-by: Numan Siddique Numan > --- > controller

Re: [ovs-dev] [PATCH ovn 1/5] controller: Fix iface-id-ver handling.

On Tue, Apr 23, 2024 at 7:53 AM Xavier Simonart wrote: > > If iface-id-ver was wrong and modified to a correct value, > the port was correctly claimed, but the flows were not installed > by I+P. > > Signed-off-by: Xavier Simonart Acked-by: Numan Siddique Numan > --- &g

Re: [ovs-dev] [PATCH ovn v2] northd: Fix the match not being cleared inside the loop.

On Wed, May 29, 2024 at 5:54 AM Dumitru Ceara wrote: > > On 5/29/24 10:26, Ales Musil wrote: > > The match wasn't cleared which led to matches being appended together > > and the ovn-controller failed to parse them. > > > > Fixes: 3faadc76ad71 ("northd: Fix pmtud for non routed traffic.") > >

Re: [ovs-dev] [PATCH v4 ovn] northd: Fix pmtud for non routed traffic.

On Wed, Apr 24, 2024 at 11:51 AM Lorenzo Bianconi wrote: > > Similar to what is already implemented for routed e/w traffic, > introduce pmtud support for e/w traffic between two logical switch ports > connected to the same logical switch, but running on two different > hypervisors. > > Acked-by:

Re: [ovs-dev] [PATCH ovn] Do not reply on unicast arps for targets.

On Mon, May 20, 2024 at 1:47 AM Vasyl Saienko wrote: > > Thanks for feedback Numan. > > On Wed, May 15, 2024 at 12:04 AM Numan Siddique wrote: > > > On Mon, May 13, 2024 at 9:00 AM Dumitru Ceara wrote: > > > > > > On 5/4/24 11:38, Vasyl Saienko wrote: >

Re: [ovs-dev] [PATCH ovn 0/7] Bump of CI Ubuntu and Fedora versions

On Thu, May 16, 2024 at 12:01 PM Ales Musil wrote: > > On Thu, May 16, 2024 at 5:57 PM Numan Siddique wrote: > > > On Tue, May 14, 2024 at 4:41 AM Ales Musil wrote: > > > > > > The series is pretty small however it is required for the > > > bump to U

Re: [ovs-dev] [PATCH ovn 5/7] ci: Add missing packages to run Fedora image in GH CI.

On Tue, May 14, 2024 at 9:46 AM Ales Musil wrote: > > On Tue, May 14, 2024 at 3:19 PM Ilya Maximets wrote: > > > On 5/14/24 10:38, Ales Musil wrote: > > > There were two things missing for the Fedora builds, 32-bit > > > version of glibc to allows the -m32 compilation on Fedora > > > and

Re: [ovs-dev] [PATCH ovn 0/7] Bump of CI Ubuntu and Fedora versions

On Tue, May 14, 2024 at 4:41 AM Ales Musil wrote: > > The series is pretty small however it is required for the > bump to Ubuntu 24.04 and Fedora 40. Both have newer GCC and > Clang which brought up some issues that needed to be fixed. > > The series also includes fix for weekly runs to use

Re: [ovs-dev] [PATCH ovn] controller: Avoid use after free in LB I-P.

On Mon, May 6, 2024 at 6:37 AM Ales Musil wrote: > > Avoid use after free in scenario when controller received LB deletion > after the DB was reconnected. The reconnect led to idl clearing up > the "old" structs, one of them being the LB. However, during recompute > the struct was referenced when

Re: [ovs-dev] [PATCH ovn] docs: List supported rolling upgrade paths.

On Fri, May 3, 2024 at 1:43 AM Ales Musil wrote: > > On Fri, Apr 26, 2024 at 10:49 PM Ihar Hrachyshka > wrote: > > > The wording above is not completely clear without these scenarios > > listed. A confused reader may incorrectly read it as: > > > > ``` > > Only LTS-to-LTS is supported for

Re: [ovs-dev] [PATCH ovn] docs: Explain nature of ovs dependency.

On Fri, May 3, 2024 at 1:43 AM Ales Musil wrote: > > On Fri, Apr 26, 2024 at 10:35 PM Ihar Hrachyshka > wrote: > > > The dependency is during build time, not runtime. > > > > Signed-off-by: Ihar Hrachyshka > > --- > > Documentation/intro/install/ovn-upgrades.rst | 18 -- > > 1

Re: [ovs-dev] [PATCH ovn] ovn-ctl: Support for --config-file ovsdb-server option.

On Fri, May 3, 2024 at 2:05 AM Ales Musil wrote: > > On Tue, Apr 23, 2024 at 6:43 PM Vladislav Odintsov > wrote: > > > Since OVS 3.3.0 ovsdb-server accepts databases and remotes configuration > > via JSON text file. This patch adds support for such option. > > > > Signed-off-by: Vladislav

Re: [ovs-dev] [PATCH ovn] northd, ic: Fix handling of ovn-appctl resume.

On Fri, May 3, 2024 at 2:07 AM Ales Musil wrote: > > On Tue, Apr 23, 2024 at 2:44 PM Xavier Simonart wrote: > > > After ovn-appctl resume was issued for northd or ovn-ic, there was no > > guarantee that northd or ovn-ic were waking up, potentially handling > > changes received while they were

Re: [ovs-dev] [PATCH ovn] northd: Add lsp option force_fdb_lookup.

On Thu, May 9, 2024 at 2:17 PM Numan Siddique wrote: > > On Thu, May 9, 2024 at 5:54 AM Shibir Basak wrote: > > > > Hi team, > > > > Could someone please review these changes? > > Sorry for the delay. I'll take a look and come back. Thanks for

Re: [ovs-dev] [PATCH ovn] Do not reply on unicast arps for targets.

On Mon, May 13, 2024 at 9:00 AM Dumitru Ceara wrote: > > On 5/4/24 11:38, Vasyl Saienko wrote: > > Hello Numan > > > > Thanks for review and feedback. > > > > On Fri, May 3, 2024 at 7:14 PM Numan Siddique wrote: > > > >> On Mon

Re: [ovs-dev] [PATCH ovn v4] controller: Track individual address set constants.

On Fri, May 10, 2024 at 12:39 PM Han Zhou wrote: > > On Fri, May 10, 2024 at 9:23 AM Numan Siddique wrote: > > > > On Fri, May 10, 2024 at 2:37 AM Han Zhou wrote: > > > > > > On Thu, May 9, 2024 at 10:32 AM Mark Michelson > wrote: > >

Re: [ovs-dev] [PATCH ovn branch-23.06 2/2] Prepare for 23.06.5.

On Thu, May 9, 2024 at 3:12 PM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > &g

Re: [ovs-dev] [PATCH ovn branch-23.06 1/2] Set release date for 23.06.4.

On Thu, May 9, 2024 at 3:20 PM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 ++- > debian/changelog | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS >

Re: [ovs-dev] [PATCH ovn branch-23.09 2/2] Prepare for 23.09.5.

On Thu, May 9, 2024 at 3:11 PM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > &g

Re: [ovs-dev] [PATCH ovn branch-23.09 1/2] Set release date for 23.09.4.

On Thu, May 9, 2024 at 3:12 PM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 ++- > debian/changelog | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS >

Re: [ovs-dev] [PATCH ovn branch-24.03 1/2] Set release date for 24.03.2.

On Thu, May 9, 2024 at 3:11 PM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 ++- > debian/changelog | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS >

Re: [ovs-dev] [PATCH ovn v2] controller: Fix an issue wrt cleanup of stale patch port.

On Fri, May 3, 2024 at 11:00 AM Numan Siddique wrote: > > On Mon, Apr 22, 2024 at 2:49 AM Priyankar Jain > wrote: > > > > Issue: > > Upon updating the network_name option of localnet port from one physical > > bridge to another, ovn-controller fails to cleanup

Re: [ovs-dev] [PATCH ovn v4] controller: Track individual address set constants.

On Fri, May 10, 2024 at 2:37 AM Han Zhou wrote: > > On Thu, May 9, 2024 at 10:32 AM Mark Michelson wrote: > > > > On 5/7/24 02:12, Han Zhou wrote: > > > > > > > > > On Mon, May 6, 2024 at 10:37 PM Ales Musil > > > wrote: > > > > > > > > > > > > > > > > On Mon, May

Re: [ovs-dev] [PATCH ovn 2/2 branch-24.03] northd, controller: Handle tunnel_key change consistently.

n > 'northd' node.") > Fixes: 425f699e2b20 ("controller: fixed potential segfault when changing > tunnel_key and deleting ls.") > Reported-at: https://issues.redhat.com/browse/FDP-393 > Acked-by: Mark Michelson > Signed-off-by: Ales Musil > Signed-off-by: Nu

Re: [ovs-dev] [PATCH ovn] docs: Typo. Remove duplicated "to".

On Wed, May 8, 2024 at 1:38 PM Igor Zhukov wrote: > > I came across a new patch recently: > https://patchwork.ozlabs.org/project/ovn/patch/20240423095006.24429-1-martin.kal...@canonical.com/ > After that, I searched the OVN source code for instances of "to to" and > discovered two more

Re: [ovs-dev] [PATCH ovn] Documentation: change link from ovs to ovn in the "Submitted-at" example.

On Wed, May 8, 2024 at 11:46 AM Igor Zhukov wrote: > > It's a mega nitpick, but I observed that the example URL in the > "Submitted-at" points to the OVS repository instead of OVN. > > Signed-off-by: Igor Zhukov Thanks. Applied to main. Numan > --- >

Re: [ovs-dev] [PATCH ovn] northd: Add lsp option force_fdb_lookup.

On Thu, May 9, 2024 at 5:54 AM Shibir Basak wrote: > > Hi team, > > Could someone please review these changes? Sorry for the delay. I'll take a look and come back. Numan > > Thanks, > Shibir Basak > > > On 24-Apr-2024, at 12:15 PM, Shibir Basak wrote: > > > > This option is applicable only

Re: [ovs-dev] [PATCH ovn] northd: Add documentation for is_cr_port() and is_l3dgw_port().

On Tue, May 7, 2024 at 5:57 PM wrote: > > From: Numan Siddique > > Although these util functions are correct in their implementation, > they are confusing to the reader. Add proper documentation > and make the is_l3dgw_port() more clearer by checking if the > gateway chassi

Re: [ovs-dev] [PATCH ovn v1 2/2] Add support for overlay provider networks.

On Wed, Apr 24, 2024 at 7:46 PM Numan Siddique wrote: > > On Wed, Apr 24, 2024 at 5:14 PM Mark Michelson wrote: > > > > Hi Numan, > > > > I haven't done a full review of this yet, but I figured I'd give some > > initial feedback from what I had looked at. >

Re: [ovs-dev] [PATCH ovn v1 2/2] Add support for overlay provider networks.

patch - https://patchwork.ozlabs.org/project/ovn/patch/20240507215713.902148-1-num...@ovn.org/ which improves documentation for is_cr_port() and is_gw_port() Thanks Numan > > On 4/23/24 12:43, num...@ovn.org wrote: > > From: Numan Siddique > > > > It is expected that a provider networ

Re: [ovs-dev] [PATCH ovn v4] controller: Track individual address set constants.

On Tue, May 7, 2024 at 2:13 AM Han Zhou wrote: > > On Mon, May 6, 2024 at 10:37 PM Ales Musil wrote: > > > > > > > > On Mon, May 6, 2024 at 8:41 PM Han Zhou wrote: > >> > >> > >> > >> On Thu, May 2, 2024 at 10:35 PM Ales Musil wrote: > >> > > >> > On Thu, May 2, 2024 at 6:23 PM Han Zhou

Re: [ovs-dev] [PATCH ovn v2 0/4] Mac cache handling refactor

On Tue, May 7, 2024 at 12:51 PM Ales Musil wrote: > > On Tue, May 7, 2024 at 6:49 PM Numan Siddique wrote: > > > On Tue, May 7, 2024 at 2:25 AM Ales Musil wrote: > > > > > > There were two modules in controller mac_cache and mac-learn, both of > > > t

Re: [ovs-dev] [PATCH ovn v2 0/4] Mac cache handling refactor

On Tue, May 7, 2024 at 2:25 AM Ales Musil wrote: > > There were two modules in controller mac_cache and mac-learn, both of > them did very similar thing with pretty big overlap. The goal of the > series is to consolidate and merge both of those modules into single > one. That will reduce the

Re: [ovs-dev] [PATCH ovn v2] northd: Support routing over other address families.

On Tue, May 7, 2024 at 11:10 AM Felix Huettner via dev wrote: > > On Tue, May 07, 2024 at 10:06:07AM -0400, Numan Siddique wrote: > > On Tue, May 7, 2024 at 5:24 AM Felix Huettner via dev > > wrote: > > > > > > On Mon, May 06, 2024 at 11:03:42PM -0400, Numan

Re: [ovs-dev] [PATCH ovn v2] northd: Support routing over other address families.

On Tue, May 7, 2024 at 5:24 AM Felix Huettner via dev wrote: > > On Mon, May 06, 2024 at 11:03:42PM -0400, Numan Siddique wrote: > > On Mon, Apr 22, 2024 at 9:02 AM Felix Huettner via dev > > wrote: > > > > > > In most cases IPv4 packets are routed only ove

Re: [ovs-dev] [PATCH ovn v2] northd: Support routing over other address families.

On Mon, Apr 22, 2024 at 9:02 AM Felix Huettner via dev wrote: > > In most cases IPv4 packets are routed only over other IPv4 networks and > IPv6 packets are routed only over IPv6 networks. However there is no > inherent reason for this limitation. Routing IPv4 packets over IPv6 > networks just

Re: [ovs-dev] [PATCH ovn 0/4] Mac cache handling refactor

On Tue, Apr 23, 2024 at 3:44 PM Mark Michelson wrote: > > Hi Ales, thanks for this. I always like a change that results in a net > loss of lines of code :) > > For the series, > > Acked-by: Mark Michelson Hi Ales, Can you please rebase the series ? It has some conflicts. Numan > > On

Re: [ovs-dev] [PATCH ovn] Do not reply on unicast arps for targets.

On Mon, Apr 22, 2024 at 2:54 AM Vasyl Saienko wrote: > > Reply only if target ethernet address is broadcast, if > address is specified explicitly do noting to let target > reply by itself. This technique allows to monitor target > aliveness with arping. Thanks for the patch. This patch does

Re: [ovs-dev] [PATCH ovn v2] controller: Fix an issue wrt cleanup of stale patch port.

ort in the > exisiting_ports set as part of #1. > This make sures that the peer port is only removed from existing_ports > only if it is already present on the correct bridge. (#2.1/#2.2) > Otherwise, during the cleanup in #3 it will be considered. > > Fixes: b600316f252a

Re: [ovs-dev] [PATCH ovn] northd: Fix logical router load-balancer nat rules when using DGP.

On Fri, Mar 22, 2024 at 7:51 AM Roberto Bartzen Acosta wrote: > > Hi Mark, > > Thanks for your feedback. > > Em seg., 18 de mar. de 2024 às 11:53, Mark Michelson > escreveu: > > > Hi Roberto, > > > > I have some concerns about this patch. Let's use the test case you added > > as an example

Re: [ovs-dev] [PATCH ovn] northd: Fix the comment about route priorities.

On Mon, Apr 22, 2024 at 2:41 AM Han Zhou wrote: > > The current comments are obviously conflicting. Fixing it according the > current implementation - static route overrides src-ip route. > > Signed-off-by: Han Zhou Acked-by: Numan Siddique Numan > --- > northd/nort

Re: [ovs-dev] [PATCH ovn v7 0/6] Correct tunnel ids exhaustion scenario.

On Fri, Apr 26, 2024 at 3:04 PM Mark Michelson wrote: > > Thanks for the update, Ihar. > > For the series, > Acked-by: Mark Michelson Thanks Ihar, Vladislav and Mark. I applied the series to the main branch. Numan > > On 4/26/24 13:54, Ihar Hrachyshka wrote: > > v2+ of the original test

Re: [ovs-dev] [PATCH ovn] ci: Fix OPTS not being passed to OSX builds.

On Thu, Apr 25, 2024 at 12:24 PM Ales Musil wrote: > > On Thu, Apr 25, 2024 at 4:44 PM wrote: > > > From: Numan Siddique > > > > OSX job is failing with the below error even though the job > > disables SSL. > > > > ld: library 'ssl' not fou

Re: [ovs-dev] [PATCH ovn] Add dh-python to debian/control.

On Fri, Apr 12, 2024 at 7:49 AM Dumitru Ceara wrote: > > On 4/11/24 17:28, Igor Zhukov wrote: > > I tried to build OVN in a fresh Ubuntu 24.04 Docker container. > > > > I only installed the Build-Depends. > > > > I ran: > > > > $ dpkg-buildpackage -us -uc -ui -b > > > > And I received the

Re: [ovs-dev] [PATCH ovn v1 2/2] Add support for overlay provider networks.

quot;overlay_provider_network" option. There should also be a NEWS entry for > the new functionality. > Thanks for the comments. Yes. I missed adding them. I'll address it in v2. > > > See below for a couple more notes. > > On 4/23/24 12:43, num...@ovn.org wrote: > >

Re: [ovs-dev] [PATCH OVN v6 3/3] northd, tests: DHCP Relay Agent support for overlay IPv4 subnets.

On Wed, Apr 24, 2024 at 5:57 AM Naveen Yerramneni < naveen.yerramn...@nutanix.com> wrote: > NB SCHEMA CHANGES > - > 1. New DHCP_Relay table > "DHCP_Relay": { > "columns": { > "name": {"type": "string"}, > "servers": {"type":

Re: [ovs-dev] [PATCH OVN v6 2/3] controller: DHCP Relay Agent support for overlay IPv4 subnets.

On Wed, Apr 24, 2024 at 5:57 AM Naveen Yerramneni < naveen.yerramn...@nutanix.com> wrote: > Added changes in pinctrl to process DHCP Relay opcodes: > - ACTION_OPCODE_DHCP_RELAY_REQ_CHK: For request packets > - ACTION_OPCODE_DHCP_RELAY_RESP_CHK: For response packet > > Signed-off-by: Naveen

Re: [ovs-dev] [PATCH OVN v6 1/3] actions: DHCP Relay Agent support for overlay IPv4 subnets.

On Wed, Apr 24, 2024 at 5:56 AM Naveen Yerramneni < naveen.yerramn...@nutanix.com> wrote: > NEW OVN ACTIONS > --- > 1. dhcp_relay_req_chk(, ) >- This action executes on the source node on which the DHCP request > originated. >- This action relays the DHCP request

Re: [ovs-dev] [PATCH OVN v5 0/4] DHCP Relay Agent support for overlay subnets.

On Wed, Apr 24, 2024 at 9:21 AM Naveen Yerramneni < naveen.yerramn...@nutanix.com> wrote: > > > > On 05-Apr-2024, at 9:08 PM, Numan Siddique wrote: > > > > CAUTION: External Email > > > > > > On Wed, Mar 20, 2024 at 10:40 AM Naveen Yer

Re: [ovs-dev] [PATCH ovn v5] northd, controller: Use paused controller action for packet buffering.

On Mon, Apr 22, 2024 at 11:14 AM Ales Musil wrote: > On Fri, Apr 19, 2024 at 6:38 PM Numan Siddique wrote: > > > > > > > On Fri, Apr 19, 2024 at 7:09 AM Ales Musil wrote: > > > >> The current packet injection loses ct_state in the process. When > >&

Re: [ovs-dev] [PATCH v3 ovn] northd: Fix pmtud for non routed traffic.

On Mon, Apr 22, 2024 at 4:51 PM Dumitru Ceara wrote: > On 4/22/24 22:43, Dumitru Ceara wrote: > > On 4/17/24 14:41, Lorenzo Bianconi wrote: > >> Similar to what is already implemented for routed e/w traffic, > >> introduce pmtud support for e/w traffic between two logical switch ports > >>

Re: [ovs-dev] [PATCH ovn v5] northd, controller: Use paused controller action for packet buffering.

On Fri, Apr 19, 2024 at 7:09 AM Ales Musil wrote: > The current packet injection loses ct_state in the process. When > the ct_state is lost we might commit to DNAT zone and perform > zero SNAT after the packet injection. This causes the first session > to be wrong as the reply packets are not

Re: [ovs-dev] [PATCH ovn] northd: Allow DHCP request from the lport if enabled DHCPv4

On Thu, Apr 18, 2024 at 11:20 PM shy liu wrote: > > > > > > > > On Tue, Apr 16, 2024 at 1:22 AM wrote: > >> > >> From: shylou > >> > >> DHCP for VM fails when removing default security group rules > >> using a CMS like Neutron ML2/OVN [1]. This is because DHCP > >> requests from VMs may be

Re: [ovs-dev] [PATCH ovn] northd: Allow DHCP request from the lport if enabled DHCPv4

On Tue, Apr 16, 2024 at 1:22 AM wrote: > From: shylou > > DHCP for VM fails when removing default security group rules > using a CMS like Neutron ML2/OVN [1]. This is because DHCP > requests from VMs may be dropped by ACLs. To fix this issue, > we add a lflow with a priority of 34000 to allow

Re: [ovs-dev] [PATCH ovn v3 1/2] ci: Make sure that multinode test runs on correct branch.

On Tue, Apr 16, 2024 at 3:28 PM Mark Michelson wrote: > This looks good to me. Thanks Ales. > > Acked-by: Mark Michelson > Thanks. I applied this patch to the main. @Mark - I'm sorry. I missed adding your Ack to this patch. Numan > On 4/10/24 09:29, Ales Musil wrote: > > The

Re: [ovs-dev] [PATCH ovn v2] northd, controller: Use paused controller action for packet buffering.

On Tue, Apr 9, 2024, 7:46 AM Dumitru Ceara wrote: > On 4/8/24 09:19, Ales Musil wrote: > > On Fri, Apr 5, 2024 at 10:35 PM Numan Siddique wrote: > > > >> > >> > >> On Tue, Apr 2, 2024 at 2:28 AM Ales Musil wrote: > >> > >>> T

Re: [ovs-dev] [PATCH ovn v2] northd, controller: Use paused controller action for packet buffering.

On Tue, Apr 2, 2024 at 2:28 AM Ales Musil wrote: > The current packet injection loses ct_state in the process. When > the ct_state is lost we might commit to DNAT zone and perform > zero SNAT after the packet injection. This causes the first session > to be wrong as the reply packets are not

Re: [ovs-dev] [PATCH ovn] ovn-ctl: Use the current user for default file permissions.

On Thu, Apr 4, 2024 at 4:01 PM Mark Michelson wrote: > Thanks Ales, > > Acked-by: Mark Michelson > Thanks. I applied this patch to the main branch. Does this require a backport ? Numan > On 3/25/24 06:40, Ales Musil wrote: > > The ovn-ctl utility was assuming that the user/group is always

Re: [ovs-dev] [PATCH ovn v2] controller: Change dns resolution to async.

On Fri, Apr 5, 2024 at 1:38 AM Naveen Yerramneni < naveen.yerramn...@nutanix.com> wrote: > Currently DNS resolution is a blocking call in OVN controller. > If DNS server is not reachable for any reason then, ovn-controller > thread blocks for longer time and other events are not processed. > >

Re: [ovs-dev] [PATCH OVN v5 0/4] DHCP Relay Agent support for overlay subnets.

On Wed, Mar 20, 2024 at 10:40 AM Naveen Yerramneni < naveen.yerramn...@nutanix.com> wrote: > > This patch contains changes to enable DHCP Relay Agent support for overlay subnets. > > USE CASE: > -- > - Enable IP address assignment for overlay subnets from the centralized

Re: [ovs-dev] [PATCH ovn v3] controller: Release container lport when releasing parent port.

On Wed, Feb 28, 2024 at 5:43 AM Mohammad Heib wrote: > > Currently if the user sets the container parent_port:requested-chassis > option after the VIF/CIF is bonded to the chassis, this will migrate > the VIF/CIF flows to the new chassis but will still have the > container flows installed in the

Re: [ovs-dev] [PATCH OVN v2] DHCP Relay Agent support for overlay subnets.

On Sun, Mar 3, 2024 at 11:20 PM Naveen Yerramneni wrote: > > This patch contains changes to enable DHCP Relay Agent support for > overlay subnets. > > USE CASE: > -- > - Enable IP address assignment for overlay subnets from the centralized > DHCP server present in the

Re: [ovs-dev] [PATCH OVN] ovn-nb: Add documentation for disable_arp_nd_rsp option

On Fri, Feb 16, 2024 at 10:54 PM Naveen Yerramneni wrote: > > Signed-off-by: Naveen Yerramneni Thanks. Applied to main. Numan > --- > ovn-nb.xml | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/ovn-nb.xml b/ovn-nb.xml > index e0b983ed6..b652046a7 100644 > --- a/ovn-nb.xml >

Re: [ovs-dev] [Patch ovn 1/2] actions.c/h: Enable specifying zone for ct_commit.

On Thu, Mar 7, 2024, 5:50 AM Martin Kalcok wrote: > On Thu, Mar 7, 2024 at 1:26 AM Numan Siddique wrote: > > > > > > > On Wed, Mar 6, 2024 at 7:26 AM Martin Kalcok < > martin.kal...@canonical.com> > > wrote: > > > >> Hi Ales, > >>

Re: [ovs-dev] [Patch ovn 1/2] actions.c/h: Enable specifying zone for ct_commit.

On Wed, Mar 6, 2024 at 7:26 AM Martin Kalcok wrote: > Hi Ales, > Thank you for review and helpful comments. I'll update commit subjects for > this series in v2. > > On Wed, Mar 6, 2024 at 7:45 AM Ales Musil wrote: > >> >> >> On Mon, Mar 4, 2024 at 11:56 AM Martin Kalcok < >>

Re: [ovs-dev] [PATCH ovn] northd: Don't skip the unSNAT stage for traffic towards VIPs.

t; Reported-at: https://issues.redhat.com/browse/FDP-291 > Signed-off-by: Dumitru Ceara Thanks for the fix. It also simplified the lr-nat-stateful code. Acked-by: Numan Siddique Numan > --- > northd/en-lflow.c | 3 +- > northd/en-lr-nat.c | 5 --- > nort

Re: [ovs-dev] [PATCH OVN] DHCP Relay Agent support for overlay subnets

On Mon, Feb 26, 2024, 11:41 AM Naveen Yerramneni < naveen.yerramn...@nutanix.com> wrote: > > > > On 24-Jan-2024, at 6:30 PM, Naveen Yerramneni < > naveen.yerramn...@nutanix.com> wrote: > > > > > > > >> On 24-Jan-2024, at 8:59 AM, Numan Sidd

Re: [ovs-dev] [PATCH ovn] physical: Don't reset encap ID across pipelines.

ap IPs > selection.") > Signed-off-by: Han Zhou Acked-by: Numan Siddique Numan > --- > controller/physical.c | 28 --- > tests/ovn.at | 83 ++- > 2 files changed, 98 insertions(+), 13 deletions(-) > > di

Re: [ovs-dev] [PATCH OVN] Add "disable_arp_nd_rsp" option to LSP

On Thu, Feb 15, 2024 at 8:46 PM Naveen Yerramneni wrote: > > > > > On 12-Feb-2024, at 8:36 PM, Ihar Hrachyshka wrote: > > > > On Tue, Jan 30, 2024 at 10:52 PM Naveen Yerramneni > > wrote: > > > > > > > On 29-Jan-2024, at 9:11 PM, Ihar Hrachyshka wrote: > > > > > > On Mon, Jan 22, 2024 at

Re: [ovs-dev] [PATCH OVN] Add "pkt_clone_type" option to LSP.

On Mon, Jan 22, 2024 at 12:13 PM Naveen Yerramneni wrote: > > Currently only valid value for this option is mc_unknown. > If set to mc_unknown, packets destined to the port gets cloned > to all unknown ports connected to the same Logical Switch. > > Usecase: > = > It is required to reduce

Re: [ovs-dev] [PATCH ovn v2] ci: Update crun in Cirrus CI cloud image.

On Fri, Feb 16, 2024 at 9:52 AM Dumitru Ceara wrote: > > On 2/16/24 14:40, Ales Musil wrote: > > There are some issues with older crun and newer kernel > > combination [0]. Unfortunately Ubuntu 23.10 falls into this > > category and the jobs will often time fail. Temoprarily use > > newer crun

Re: [ovs-dev] [PATCH ovn] northd: Initialize hmap size in lflow_mgr.

On Thu, Feb 15, 2024 at 5:10 AM Xavier Simonart wrote: > > Hi Numan > > Thanks for the quick review. > > On Wed, Feb 14, 2024 at 10:57 PM Numan Siddique wrote: > > > On Wed, Feb 14, 2024 at 1:26 PM Xavier Simonart > > wrote: > > > > > > Whe

Re: [ovs-dev] [PATCH ovn] northd: Initialize hmap size in lflow_mgr.

On Wed, Feb 14, 2024 at 1:26 PM Xavier Simonart wrote: > > When (re)starting ovn-northd with an existing big nbdb, > the first iteration of northd was very slow as trying to > push all flows in a single bucket. > > Fixes: a623606052ea ("northd: Refactor lflow management into a separate >

Re: [ovs-dev] [PATCH ovn v1 0/4] northd memory and CPU increase fix due to lflow-mgr.

On Wed, Feb 14, 2024 at 9:51 AM Dumitru Ceara wrote: > > On 2/9/24 00:28, Numan Siddique wrote: > > On Thu, Feb 8, 2024, 4:49 PM wrote: > > > >> From: Numan Siddique > >> > >> This patch series fixes the memory and CPU usage increase seen > &

Re: [ovs-dev] [PATCH ovn] northd: Added lb_vip_mac config option in Logical_Switch.

On Mon, Feb 5, 2024 at 11:45 PM Priyankar Jain wrote: > > Hi, > > On 01/02/24 5:15 am, Numan Siddique wrote: > > On Mon, Jan 8, 2024 at 8:13 AM Priyankar Jain > > wrote: > >> Currently load balancer applied to a logical switch has the > >> following re

Re: [ovs-dev] [PATCH ovn v1 0/4] northd memory and CPU increase fix due to lflow-mgr.

On Thu, Feb 8, 2024, 4:49 PM wrote: > From: Numan Siddique > > This patch series fixes the memory and CPU usage increase seen > in ovn-northd after the lflow I-P patches were merged. > > The first 2 patches in the series addresses duplicate flows > added by northd

Re: [ovs-dev] [PATCH ovn v6 00/13] northd lflow incremental processing

On Tue, Feb 6, 2024 at 3:52 PM Han Zhou wrote: > > On Mon, Feb 5, 2024 at 7:47 PM Numan Siddique wrote: > > > > On Mon, Feb 5, 2024 at 9:41 PM Han Zhou wrote: > > > > > > On Mon, Feb 5, 2024 at 4:12 PM Numan Siddique wrote: > > > > > &

Re: [ovs-dev] [PATCH ovn v6 00/13] northd lflow incremental processing

On Mon, Feb 5, 2024 at 9:41 PM Han Zhou wrote: > > On Mon, Feb 5, 2024 at 4:12 PM Numan Siddique wrote: > > > > On Mon, Feb 5, 2024 at 5:54 PM Han Zhou wrote: > > > > > > On Mon, Feb 5, 2024 at 10:15 AM Ilya Maximets > wrote: > > > > > >

Re: [ovs-dev] [PATCH ovn v6 00/13] northd lflow incremental processing

;> On 2/5/24 08:13, Han Zhou wrote: > > >>>> On Sun, Feb 4, 2024 at 9:26 PM Numan Siddique wrote: > > >>>>> > > >>>>> On Sun, Feb 4, 2024 at 9:53 PM Han Zhou wrote: > > >>>>>> > > >>>&g

Re: [ovs-dev] [PATCH ovn v6 00/13] northd lflow incremental processing

On Sun, Feb 4, 2024 at 9:53 PM Han Zhou wrote: > > On Sun, Feb 4, 2024 at 5:46 AM Ilya Maximets wrote: > > > > >>> > > >>> > 35 files changed, 9681 insertions(+), 4645 deletions(-) > > >>> > > >>> I had another look at this series and acked the remaining patches. I > > >>> just had some minor

Re: [ovs-dev] [PATCH ovn] tests: Fix incorrect 'check_engine_stats' helper function.

On Fri, Feb 2, 2024 at 5:23 PM Mark Michelson wrote: > > Acked-by: Mark Michelson Thanks. Applied to main. Numan > > On 2/2/24 16:57, num...@ovn.org wrote: > > From: Numan Siddique > > > > The patch which added the helper function 'check_engine_stats' >

Re: [ovs-dev] [PATCH ovn 2/2] Prepare for post-24.03.0.

On Fri, Feb 2, 2024 at 11:50 AM Mark Michelson wrote: > > --- > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) With your signed-off-by tag added Acked-by: Numan Siddique Numan >

Re: [ovs-dev] [PATCH ovn 1/2] Prepare for 24.03.0.

On Fri, Feb 2, 2024 at 11:50 AM Mark Michelson wrote: > > --- > NEWS | 4 ++-- > configure.ac | 2 +- > debian/changelog | 4 ++-- > 3 files changed, 5 insertions(+), 5 deletions(-) With your signed-off-by tag added Acked-by: Numan Siddique Numan > >

Re: [ovs-dev] [PATCH ovn v2] tests: Fix flaky test 'SB Port binding incremental processing'.

On Fri, Feb 2, 2024 at 5:37 AM Ales Musil wrote: > > On Thu, Feb 1, 2024 at 1:10 AM wrote: > > > From: Numan Siddique > > > > Fixes: 121661678317 ("northd: Move router ports SB PB options sync to > > sync_to_sb_pb node.") > > > >

Re: [ovs-dev] [PATCH ovn v6 13/13] northd: Add I-P for NB_Global and SB_Global.

On Thu, Feb 1, 2024 at 10:13 AM Numan Siddique wrote: > > On Tue, Jan 30, 2024 at 4:25 PM wrote: > > > > From: Numan Siddique > > > > A new engine node "global_config" is added which handles the changes > > to NB_Global an SB_Global tables.

Re: [ovs-dev] [PATCH ovn v6 13/13] northd: Add I-P for NB_Global and SB_Global.

On Tue, Jan 30, 2024 at 4:25 PM wrote: > > From: Numan Siddique > > A new engine node "global_config" is added which handles the changes > to NB_Global an SB_Global tables. It also creates these rows if > not present. > > Without the I-P, any changes to

Re: [ovs-dev] [PATCH ovn v6 10/13] northd: Add ls_stateful handler for lflow engine node.

On Tue, Jan 30, 2024 at 4:24 PM wrote: > > From: Numan Siddique > > Acked-by: Han Zhou > Signed-off-by: Numan Siddique Recheck-request: github-robot-_Build_and_Test > --- > northd/en-lflow.c| 26 + > northd/en-lflow.h| 1 + > no

Re: [ovs-dev] [PATCH ovn v6 07/13] northd: Move ovn_lb_datapaths from lib to northd module.

On Tue, Jan 30, 2024 at 4:23 PM wrote: > > From: Numan Siddique > > It also moves the ovn-controller specific code from lib/lb.c > and lib/lb.h to controller/lb.c and controller/lb.h. > > Acked-by: Han Zhou > Co-authored-by: Dumitru Ceara > Signed-off-by: Dumitru Ce

Re: [ovs-dev] [PATCH ovn v6 03/13] northd: Generate router's stateful flows using lr_stateful data.

Recheck-request: github-robot-_Build_and_Test On Tue, Jan 30, 2024 at 4:22 PM wrote: > > From: Numan Siddique > > Previous commits added new engine nodes to store logical router's > stateful (LB and NAT data). Make use of the data stored by these > engine nodes to gene

Re: [ovs-dev] [PATCH ovn] northd: Added lb_vip_mac config option in Logical_Switch.

On Mon, Jan 8, 2024 at 8:13 AM Priyankar Jain wrote: > > Currently load balancer applied to a logical switch has the > following restriction: > - VIP of the load balancer cannot reside in the subnet prefix as the > clients as OVN does not install ARP responder flows for the LB VIP. > Hi

Re: [ovs-dev] [PATCH ovn branch-23.09] ovs: Bump submodule to tip of OVS branch-3.2.

On Tue, Jan 30, 2024 at 10:52 AM Numan Siddique wrote: > > On Tue, Jan 30, 2024 at 7:38 AM Dumitru Ceara wrote: > > > > This picks up the following relevant commit: > > cd8ffc956c3c ovs-atomic: Fix inclusion of Clang header by GCC 14. > > > > Witho

Re: [ovs-dev] [PATCH ovn branch-23.09] ovs: Bump submodule to tip of OVS branch-3.2.

le. > > Signed-off-by: Dumitru Ceara Acked-by: Numan Siddique Numan > --- > ovs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ovs b/ovs > index ec1d730163..49e64f13b2 16 > --- a/ovs > +++ b/ovs > @@ -1 +1 @@ > -Subproject commit ec1d730

Re: [ovs-dev] [PATCH ovn] ovs: Bump submodule to latest OVS branch-3.3.

by GCC 14."). > > > > Suggested-by: Ilya Maximets > > Signed-off-by: Dumitru Ceara > > --- > > CC: Eelco, Mohammad, Numan. Acked-by: Numan Siddique Numan > > > .ci/dpdk-build.sh | 28 ++-- > > .ci/linux-build.s

Re: [ovs-dev] [PATCH ovn v5 11/16] northd: Handle lb changes in lflow engine.

On Fri, Jan 19, 2024 at 6:13 AM Dumitru Ceara wrote: > > On 1/11/24 16:32, num...@ovn.org wrote: > > From: Numan Siddique > > > > Since northd tracked data has the changed lb data, northd > > engine handler for lflow engine now handles the lb changes > > incr

Re: [ovs-dev] [PATCH ovn v5 11/16] northd: Handle lb changes in lflow engine.

On Thu, Jan 25, 2024 at 1:25 AM Han Zhou wrote: > > On Thu, Jan 11, 2024 at 7:33 AM wrote: > > > > From: Numan Siddique > > > > Since northd tracked data has the changed lb data, northd > > engine handler for lflow engine now handles the lb changes > >

Re: [ovs-dev] [PATCH ovn v5 03/16] northd: Move router ports SB PB options sync to sync_to_sb_pb node.

On Fri, Jan 26, 2024 at 4:30 AM Dumitru Ceara wrote: > > On 1/25/24 22:01, Numan Siddique wrote: > > On Thu, Jan 25, 2024, 3:29 PM Dumitru Ceara wrote: > > > >> On 1/25/24 17:46, Numan Siddique wrote: > >>> On Tue, Jan 16, 2024 at 6:15 AM Dumitru Ceara wro

  1   2   3   4   5   6   7   8   9   10   >