Hi Vladislav,
On Wed, Nov 15, 2023 at 04:13:13PM +0300, Vladislav Odintsov wrote:
...
> Final flow:
> arp,reg11=0x2,reg12=0x6,reg14=0x4,reg15=0x2,tun_id=0x6,tun_src=10.1.0.103,tun_dst=10.1.0.109,tun_ipv6_src=::,tun_ipv6_dst=::,tun_gbp_id=0,tun_gbp_flags=0,tun_tos=0,tun_ttl=64,tun_erspan_ver=0,gtp
On Fri, May 26, 2023 at 03:09:02PM +0200, Eelco Chaudron wrote:
>
>
> On 26 May 2023, at 14:03, Balazs Nemeth wrote:
>
> > The only way that stats->{n_packets,n_bytes} would decrease is due to an
> > overflow, or if there are bugs in how statistics are handled. In the
> > past, there were multiple
On Thu, Mar 16, 2023 at 09:51:34AM +0100, Eelco Chaudron wrote:
>
>
> On 22 Dec 2022, at 13:32, Eelco Chaudron wrote:
>
> > On 22 Dec 2022, at 10:26, Balazs Nemeth wrote:
> >
> >> The only way that stats->{n_packets,n_bytes} would decrease is due to an
> >> overflow, or if there are bugs in how sta
On Wed, Mar 15, 2023 at 09:33:09AM +0100, Simon Horman wrote:
> On Tue, Mar 14, 2023 at 06:49:25PM +0100, Ilya Maximets wrote:
> > On 3/14/23 12:15, Simon Horman wrote:
> > > On Mon, Mar 13, 2023 at 09:34:30PM +0100, Ilya Maximets wrote:
> > >> On 3/13/23 11:27, Roi Dayan wrote:
> > >>> From: Oz Sh
On Thu, Jan 26, 2023 at 04:23:39AM -0800, Marcelo Ricardo Leitner wrote:
> +Cc Chris, Paul and Vlad.
>
> On Thu, Jan 26, 2023 at 11:08:02AM +0100, Eelco Chaudron wrote:
> > A long long time ago, an effort was made to make tc flower
> > rtnl_lock() free. However, on the OVS
+Cc Chris, Paul and Vlad.
On Thu, Jan 26, 2023 at 11:08:02AM +0100, Eelco Chaudron wrote:
> A long long time ago, an effort was made to make tc flower
> rtnl_lock() free. However, on the OVS part we forgot to add
> the TCA_KIND "flower" attribute, which tell the kernel to skip
> the lock. This pat
On Thu, Dec 08, 2022 at 11:56:07AM -0500, Xin Long wrote:
> The changes in the patchset:
>
> "net: add helper support in tc act_ct for ovs offloading"
>
> had moved some common ct code used by both OVS and TC into netfilter.
Nice dedup.
Acked-by
On Wed, Nov 23, 2022 at 04:34:45PM -0500, Xin Long wrote:
> On Wed, Nov 23, 2022 at 4:21 PM Marcelo Ricardo Leitner
> wrote:
> >
> > On Wed, Nov 23, 2022 at 02:55:05PM -0500, Xin Long wrote:
> > > On Wed, Nov 23, 2022 at 2:17 PM Marcelo Ricardo Leitner
> > > w
On Wed, Nov 23, 2022 at 02:55:05PM -0500, Xin Long wrote:
> On Wed, Nov 23, 2022 at 2:17 PM Marcelo Ricardo Leitner
> wrote:
> >
> > On Wed, Nov 23, 2022 at 01:54:41PM -0500, Xin Long wrote:
> > > On Wed, Nov 23, 2022 at 1:48 PM Marcelo Ricardo Leitner
> > > w
On Wed, Nov 23, 2022 at 01:54:41PM -0500, Xin Long wrote:
> On Wed, Nov 23, 2022 at 1:48 PM Marcelo Ricardo Leitner
> wrote:
> >
> > On Wed, Nov 23, 2022 at 12:31:38PM -0500, Xin Long wrote:
> > > On Wed, Nov 23, 2022 at 10:13 AM Marcelo Ricardo Leitner
> > >
On Tue, Nov 22, 2022 at 12:32:21PM -0500, Xin Long wrote:
> --- a/net/netfilter/Makefile
> +++ b/net/netfilter/Makefile
> @@ -52,7 +52,7 @@ obj-$(CONFIG_NF_CONNTRACK_SANE) += nf_conntrack_sane.o
> obj-$(CONFIG_NF_CONNTRACK_SIP) += nf_conntrack_sip.o
> obj-$(CONFIG_NF_CONNTRACK_TFTP) += nf_conntra
On Wed, Nov 23, 2022 at 12:31:38PM -0500, Xin Long wrote:
> On Wed, Nov 23, 2022 at 10:13 AM Marcelo Ricardo Leitner
> wrote:
> >
> > On Wed, Nov 23, 2022 at 12:09:55PM -0300, Marcelo Ricardo Leitner wrote:
> > > On Tue, Nov 22, 2022 at 12:32:21PM -0500, Xin Long wr
On Wed, Nov 23, 2022 at 12:09:55PM -0300, Marcelo Ricardo Leitner wrote:
> On Tue, Nov 22, 2022 at 12:32:21PM -0500, Xin Long wrote:
> > +int nf_ct_nat(struct sk_buff *skb, struct nf_conn *ct,
> > + enum ip_conntrack_info ctinfo, int *action,
> > + const struct
On Tue, Nov 22, 2022 at 12:32:21PM -0500, Xin Long wrote:
> +int nf_ct_nat(struct sk_buff *skb, struct nf_conn *ct,
> + enum ip_conntrack_info ctinfo, int *action,
> + const struct nf_nat_range2 *range, bool commit)
> +{
> + enum nf_nat_manip_type maniptype;
> + int err,
There's a typo in the subject here, s/is net/is not/ .
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Nov 22, 2022 at 12:32:19PM -0500, Xin Long wrote:
> This patch changes to return NF_ACCEPT when fails to add nat
> ext before doing NAT in tcf_ct_act_nat(), to keep consistent
> with OVS' processing in ovs_ct_nat().
>
> Reviewed-by: Saeed Mahameed
> Signed-off-by: Xin Long
> ---
> net/s
On Tue, Nov 22, 2022 at 12:32:16PM -0500, Xin Long wrote:
> The changes in the patchset:
>
> "net: add helper support in tc act_ct for ovs offloading"
>
> had moved some common ct code used by both OVS and TC into netfilter.
Please give me today to review this patchset.
Thanks,
Marcelo
__
struct tcf_ct_params *p, bool force)
Nit, it could have fetched 'force' from p->ct_action too then, as it
is only used in this function.
There's a typo in Ilya's name in the cover letter.
Other than this, LGTM.
Acked-by: Marcelo Ricardo Leitner
Hi,
On Mon, Sep 12, 2022 at 05:11:32PM +0200, Ilya Maximets wrote:
> On 8/29/22 12:04, Roi Dayan via dev wrote:
...
> > Hi,
> >
> > we are also running some ovs/ovn tests with this patch.
> > we didn't encounter breaking issues with current tests we have.
> >
> > Thanks,
> > Roi
>
> Thanks, Roi, A
cookie 401a9c8b3d403c62240d3eb5e21c1604
> no_percpu
>
> Fix the issue by restoring pps policer action type to 'continue'.
>
> Fixes: c2567e533f8a ("add port-based ingress policing based packet-per-second
> rate-limiting")
> Signed-off-by: Vlad Buslov
Review-by: Marcelo Ricardo Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Jun 22, 2022 at 11:10:17AM +0800, Tao Liu wrote:
> On Tue, Jun 21, 2022 at 06:49:42AM -0700, Marcelo Ricardo Leitner wrote:
> > Hi,
> >
> > On Tue, Jun 21, 2022 at 02:10:39PM +0800, Tao Liu wrote:
> > > Bond master netdev may be created without a classificat
Hi,
On Tue, Jun 21, 2022 at 02:10:39PM +0800, Tao Liu wrote:
> Bond master netdev may be created without a classification type, due
> to routing or tunneling code.
Can you please elaborate on why is this an issue?
>
> If bond master is not attached to ovs, the ingress block on slaves shoud
> not
On Tue, Mar 29, 2022 at 01:06:36PM +0200, Ilya Maximets wrote:
> On 2/25/22 13:29, Marcelo Ricardo Leitner wrote:
> > On Thu, Feb 24, 2022 at 03:20:23PM +0100, Eelco Chaudron wrote:
> >>
> >>
> >> On 23 Feb 2022, at 17:23, Marcelo Ricardo Leitner wrote:
>
On Thu, Feb 24, 2022 at 03:20:23PM +0100, Eelco Chaudron wrote:
>
>
> On 23 Feb 2022, at 17:23, Marcelo Ricardo Leitner wrote:
>
> > On Tue, Feb 22, 2022 at 04:26:10PM +0100, Eelco Chaudron wrote:
> >> This patch checks for none offloadable ct_state match flag combi
On Tue, Feb 22, 2022 at 04:26:10PM +0100, Eelco Chaudron wrote:
> This patch checks for none offloadable ct_state match flag combinations.
> If they exist force the +trk flag down to TC Flower
>
> Signed-off-by: Eelco Chaudron
> ---
> v3:
> - Instead of warning about an invalid flag combination f
On Thu, Feb 17, 2022 at 02:55:27PM +0100, Pablo Neira Ayuso wrote:
> On Thu, Feb 17, 2022 at 11:34:24AM +0200, Paul Blakey wrote:
> > After cited commit optimizted hw insertion, flow table entries are
> > populated with ifindex information which was intended to only be used
> > for HW offload. This
ld have been:
Fixes: 9795ded7f924 ("net/sched: act_ct: Fill offloading tuple iifidx")
Not sure if it needs a respin or not, but:
Reviewed-by: Marcelo Ricardo Leitner
> Signed-off-by: Paul Blakey
> ---
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ftware offload of established
> flows")
> Signed-off-by: Paul Blakey
Acked-by: Marcelo Ricardo Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
or: Fix matching on zone id for invalid conns
> net: openvswitch: Fix matching zone id for invalid conns arriving from tc
I keep getting surprised by how much metadata we have on CT other than
skb->_nfct. :-)
Reviewed-by: Marcelo Ricardo Leitner
_
On Wed, Aug 11, 2021 at 08:47:33PM +0200, Marcelo Ricardo Leitner wrote:
> On Wed, Aug 11, 2021 at 05:43:30PM +0200, Paolo Valerio wrote:
> > v1 was a single patch [1].
> >
> > The first patch is a small fix pointed out by Marcelo that makes sense
> > to keep separate
ages in netlink transactions.
Reviewed-by: Marcelo Ricardo Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
missing call to nl_msg_put_act_flags().
> >
> > Fixes: 292d5bd9bb34 ("tc: Set 'no_percpu' flag for compatible actions")
> > Reported-by: Marcelo Ricardo Leitner
> > Signed-off-by: Vlad Buslov
> > Reviewed-by: Roi Dayan
> > ---
>
> Hi, Marce
Hi,
On Thu, Aug 05, 2021 at 11:55:51PM +0200, Paolo Valerio wrote:
Now that you put these two together:
> As an example, with this patch applied, the following generic message:
>
> ovs|00239|netlink_socket|DBG|received NAK error=0 (Operation not supported)
On Mon, Jul 12, 2021 at 10:28:15AM +0200, Eelco Chaudron wrote:
>
>
> On 9 Jul 2021, at 20:23, Ilya Maximets wrote:
>
> > On 7/9/21 10:35 AM, Eelco Chaudron wrote:
> >>
> >>
> >> On 8 Jul 2021, at 22:18, Ilya Maximets wrote:
> >>
> >>> On 5/17/21 3:20 PM, Eelco Chaudron wrote:
> When OVs insta
On Thu, Jul 08, 2021 at 10:18:50PM +0200, Ilya Maximets wrote:
> On 5/17/21 3:20 PM, Eelco Chaudron wrote:
> > When OVs installs the flower rule, it only checks for the OK from the
> > kernel. It does not check if the rule requested matches the one
> > actually programmed. This change will add this
On Wed, Jun 23, 2021 at 03:47:45PM +0200, Simon Horman wrote:
> On Wed, Jun 09, 2021 at 11:52:07AM +0200, Simon Horman wrote:
> > Hi,
> >
> > this short test adds support for add port-based ingress policing based
> > packet-per-second rate-limiting. This builds on existing support for
> > byte-per-
s is not the case.
>
> Signed-off-by: Eelco Chaudron
Reviewed-by: Marcelo Ricardo Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Hi,
On Mon, May 17, 2021 at 01:18:53PM +0200, Simon Horman wrote:
...
> @@ -547,6 +549,12 @@ is_tap_netdev(const struct netdev *netdev)
> return netdev_get_class(netdev) == &netdev_tap_class;
> }
>
> +enum {
> +OVS_TC_QOS_TYPE_BPS,
> +OVS_TC_QOS_TYPE_PPS,
> +OVS_TC_QOS_TYPE_MA
On Mon, May 10, 2021 at 09:36:24AM +0200, Simon Horman wrote:
> Hi Marcello, Hi Ilya, Hi all,
Hi Simon,
>
> On Fri, Apr 16, 2021 at 03:58:47PM +0200, Simon Horman wrote:
> > Hi,
> >
> > this short test adds support for add port-based ingress policing based
> > packet-per-second rate-limiting. Thi
On Mon, Mar 15, 2021 at 07:41:11PM +0100, Simon Horman wrote:
> On Tue, Mar 09, 2021 at 11:12:51AM -0300, Marcelo Ricardo Leitner wrote:
> > On Sun, Mar 07, 2021 at 04:22:02PM +0200, Paul Blakey wrote:
> > > Upstream kernel now rejects unsupported ct_state flags.
> > >
On Tue, Mar 30, 2021 at 01:00:15PM +0300, Ariel Levkovich wrote:
TCA_FLOWER_KEY_CT_FLAGS_RELATED is already defined in ovs' copy at
include/linux/pkt_cls.h, so no change there is needed.
To and from flower parsing is handled below.
Mainly due to previous patches, it will not attempt to use it with
+Cc Paul
On Fri, Mar 19, 2021 at 05:57:24PM +0800, Tao Liu wrote:
> Bond master netdev may be created without a classification type, due
> to routing or tunneling code.
>
> If bond master is not attached to ovs, the slaves shoud not be updated.
The change (didn't review the patch) looks okay to
On Fri, Mar 12, 2021 at 12:59:17PM +0100, Simon Horman wrote:
> --- a/tests/system-offloads-traffic.at
> +++ b/tests/system-offloads-traffic.at
> @@ -70,3 +70,50 @@ AT_CHECK([ovs-appctl upcall/show | grep -E "offloaded
> flows : [[1-9]]"], [0], [i
>
> OVS_TRAFFIC_VSWITCHD_STOP
> AT_CLEANUP
> +
On Thu, Mar 25, 2021 at 03:51:11PM -0300, Marcelo Ricardo Leitner wrote:
> On Fri, Mar 12, 2021 at 12:59:16PM +0100, Simon Horman wrote:
> > From: "Yong.Xu"
> >
> > Correct calculation of burst parameter used when configuring TC policer
> > action for in
On Fri, Mar 12, 2021 at 12:59:16PM +0100, Simon Horman wrote:
> From: "Yong.Xu"
>
> Correct calculation of burst parameter used when configuring TC policer
> action for ingress port-based policing in the case where TC offload is in
> use. This now matches the value calculated for the case where T
off-by: Paul Blakey
> Acked-by: Roi Dayan
Reviewed-by: Marcelo Ricardo Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Hi,
On Wed, Mar 03, 2021 at 02:15:35PM +0200, Paul Blakey wrote:
> Upstream kernel now rejects unsupported ct_state flags.
> Earlier kernels, ignored it but still echoed back the requested ct_state,
> if ct_state was supported. ct_state initial support had trk, new, est,
> and rel flags.
>
> If k
lets document that if hw-offload was already enabled
changing it requires a restart in order for it to have effect.
Signed-off-by: Marcelo Ricardo Leitner
---
Notes:
v2: include changes regarding the new understanding on hw-offload
v3: fixed warnings
v4: fix wording
vswitchd
gt;
>
> Fixes: 576126a931cd ("netdev-offload-tc: Add conntrack support")
>
> > Signed-off-by: wenxu
> > ---
> > lib/netdev-offload-tc.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
>
> This version loogs good to me.
> Marcel
lets document that if hw-offload was already enabled
changing it requires a restart in order for it to have effect.
v2: include changes regarding the new understanding on hw-offload
v3: fixed warnings
Signed-off-by: Marcelo Ricardo Leitner
---
vswitchd/vswitch.xml | 8 +---
1 file changed, 5
lets document that if hw-offload was already enabled
changing it requires a restart in order for it to have effect.
v2: include changes regarding the new understanding on hw-offload
Signed-off-by: Marcelo Ricardo Leitner
---
vswitchd/vswitch.xml | 8 +---
1 file changed, 5 insertions(+), 3
On Wed, Feb 03, 2021 at 01:30:00PM +0800, we...@ucloud.cn wrote:
...
> @@ -1641,6 +1644,10 @@ netdev_tc_flow_put(struct netdev *netdev, struct match
> *match,
> }
>
> if (mask->ct_state) {
> +if (mask->ct_state & TC_UNSUPP_OVS_CS_FLAGS) {
> +return EOPNOTSUPP;
> +
On Fri, Jan 29, 2021 at 11:48:37PM +0100, Ilya Maximets wrote:
> On 1/29/21 11:33 PM, Marcelo Ricardo Leitner wrote:
> > On Fri, Jan 29, 2021 at 10:31:46PM +0100, Ilya Maximets wrote:
> >> On 12/23/20 2:01 PM, Marcelo Ricardo Leitner wrote:
> >>> tc-policy, just li
On Fri, Jan 29, 2021 at 10:31:46PM +0100, Ilya Maximets wrote:
> On 12/23/20 2:01 PM, Marcelo Ricardo Leitner wrote:
> > tc-policy, just like hw-offload, is protected by ovsthread_once_start()
> > in netdev_set_flow_api_enabled() so lets document that changing it
> > requir
tc-policy, just like hw-offload, is protected by ovsthread_once_start()
in netdev_set_flow_api_enabled() so lets document that changing it
requires a restart in order for it to have effect.
Signed-off-by: Marcelo Ricardo Leitner
---
vswitchd/vswitch.xml | 3 ++-
1 file changed, 2 insertions
On Thu, Mar 19, 2020 at 02:30:14PM -0400, Tim Rozet wrote:
> In addition I can see in my setup that conntrack and ovs-dpctl all the
> states are established:
> sctp,orig=(src=169.254.33.1,dst=169.254.33.2,sport=38982,dport=31769),reply=(src=10.244.0.5,dst=169.254.33.1,sport=62324,dport=38982),zone=
Ich bin Frau Maria Ricardo, ich bin Verwaltungsleiterin in einem Tresor eines
Finanz- und Sicherheitsinstituts hier in Barcelona.
Ich kontaktiere Sie auf der Grundlage einer finanziellen Chance, die ich hier
in unserer Bank entdeckt habe. Es geht um eine aufgegebene Summe von 26,7 Mio.
Euro
On Tue, Dec 17, 2019 at 08:31:20AM +, Paul Blakey wrote:
> I have no problem, maybe remove the changelog part?
It was in the patch itself.
Enabling pipe_decode in mutt did it. Now everything applies here.
Thanks,
Marcelo
___
dev mailing list
d...@o
On Mon, Dec 16, 2019 at 05:53:17PM +0200, Paul Blakey wrote:
> diff --git a/lib/tc.c b/lib/tc.c
> index b2d8ca7..7a4acce 100644
> --- a/lib/tc.c
> +++ b/lib/tc.c
> @@ -665,6 +665,12 @@ nl_parse_flower_tunnel(struct nlattr **attrs, struct
> tc_flower *flower)
Not sure why but my 'git am' can't pro
On Mon, Dec 09, 2019 at 03:09:37PM +, Paul Blakey wrote:
>
> On 12/3/2019 3:45 PM, Roi Dayan wrote:
> > @@ -1428,38 +1419,35 @@ netdev_tc_flow_put(struct netdev *netdev, struct
> > match *match,
> > }
> > }
> >
> > -block_id = get_block_id_from_netdev(netdev);
>
> Acci
On Sun, Dec 01, 2019 at 07:38:35AM +, Paul Blakey wrote:
>
> On 11/27/2019 4:07 PM, Marcelo Ricardo Leitner wrote:
> > On Wed, Nov 27, 2019 at 02:55:09PM +0200, Roi Dayan wrote: >> From: Paul
> > Blakey <mailto:pa...@mellanox.com> >> >> Move all that
On Wed, Nov 27, 2019 at 02:55:16PM +0200, Roi Dayan wrote:
> @@ -1367,7 +1387,7 @@ netdev_tc_flow_put(struct netdev *netdev, struct match
> *match,
> uint32_t block_id = 0;
> struct nlattr *nla;
> struct tc_id id;
> -uint32_t chain;
> +uint32_t chain = 0;
> size_t left;
On Wed, Nov 27, 2019 at 02:55:15PM +0200, Roi Dayan wrote:
> From: Paul Blakey
>
> Since OvS datapath gets packets already decapsulated from tunnel devices,
> it doesn't explicitly decapsulate them. So in a recirculation setup,
> the tunnel matching continues in the recirculation as the tunnel
>
On Wed, Nov 27, 2019 at 02:55:14PM +0200, Roi Dayan wrote:
> From: Paul Blakey
>
> Changelog:
> V1->V2:
> Missing ntohs/htons on nat port range.
>
> Signed-off-by: Paul Blakey
> ---
> lib/netdev-offload-tc.c | 104
>
> lib/tc.c
On Wed, Nov 27, 2019 at 02:55:13PM +0200, Roi Dayan wrote:
> From: Paul Blakey
>
> Signed-off-by: Paul Blakey
> ---
> lib/dpif-netlink.c | 2 ++
> lib/netdev-offload-tc.c | 66
> +
> lib/tc.c| 52
On Wed, Nov 27, 2019 at 02:55:09PM +0200, Roi Dayan wrote:
> From: Paul Blakey
>
> Move all that is needed to identify a tc filter to a
> new structure, tc_id. This removes a lot of duplication
> in accessing/creating tc filters.
Ok, gotta say, 'tc_id' is a bit confusing here. Every time I read
On Fri, Nov 22, 2019 at 03:39:16PM -0500, Aaron Conole wrote:
> Marcelo Ricardo Leitner writes:
>
> > On Mon, Nov 18, 2019 at 04:21:39PM -0500, Aaron Conole wrote:
> >> Marcelo Ricardo Leitner writes:
> >>
> >> > On Fri, Nov 08, 2019 at 04:07:14PM -05
On Tue, Nov 19, 2019 at 02:56:43PM +, Paul Blakey wrote:
> On 10/30/2019 3:37 PM, Roi Dayan wrote:
> > The following patchset introduces hardware offload of OVS connection
> > tracking datapath rules.
>
> Hey guys,
>
> Any comments on the series? :)
Ahm.. no. I'm backlogged with current dead
On Mon, Nov 18, 2019 at 04:21:39PM -0500, Aaron Conole wrote:
> Marcelo Ricardo Leitner writes:
>
> > On Fri, Nov 08, 2019 at 04:07:14PM -0500, Aaron Conole wrote:
> >> The act_ct TC module shares a common conntrack and NAT infrastructure
> >> exposed via netfilter
On Fri, Nov 08, 2019 at 04:07:14PM -0500, Aaron Conole wrote:
> The act_ct TC module shares a common conntrack and NAT infrastructure
> exposed via netfilter. It's possible that a packet needs both SNAT and
> DNAT manipulation, due to e.g. tuple collision. Netfilter can support
> this because it
On Wed, Aug 07, 2019 at 01:32:40PM -0700, Pravin Shelar wrote:
> On Tue, Aug 6, 2019 at 5:00 AM Hillf Danton wrote:
> >
> >
> > On Tue, 06 Aug 2019 01:58:05 -0700
> > > Hello,
> > >
> > > syzbot found the following crash on:
> > >
>
> ...
> > > BUG: memory leak
> > > unreferenced object 0x888
On Mon, Jul 29, 2019 at 01:05:50PM +, Paul Blakey wrote:
> Hi,
>
> I reproduced both traces.
>
> The first rcu trace is because we deference the qdisc block without rtnl
> locked (flower allows it unlocked)
>
> and the second trace is because res->goto_tp can be null if the last
> prio of
On Sat, Jul 20, 2019 at 08:26:59AM +, Paul Blakey wrote:
> Hi Marcelo, thanks for reporting this, can you dump the datapath rules via
> ovs-appctl dpctl/dump-flows -m --names
> Also running "tc filter show dev ns2-veth-ab ingress" while it happened can
> show us more details.
>
> I'll try an
On Thu, Jul 04, 2019 at 05:28:19PM +0300, Paul Blakey wrote:
> Hi,
>
> The following patches add connection tracking offload to tc.
>
> We plan on offloading the datapath rules to netdev one to one to tc rules.
> We'll be using upcoming act_ct tc module which is currently under review in
> netde
t; Regards,
> > > Billy.
> > >
> > > > -Original Message-
> > > > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> > > > boun...@openvswitch.org] On Behalf Of Marcelo Ricardo Leitner
> > > > Sent: Monday, Ap
as they have its
own MAC address.
Seems the doc just wasn't updated when they settled for a way of
addressing this issue.
Thanks,
Marcelo
>
> Regards,
> Billy.
>
> > -Original Message-
> > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> > bo
ril/094976.html
Fixes: 5e7588186839 ("netdev-dpdk: fix port addition for ports sharing same PCI
id")
Signed-off-by: Marcelo Ricardo Leitner
---
Documentation/howto/dpdk.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/howto/dpdk.rst b/Document
On Thu, Jan 25, 2018 at 03:31:05PM +1100, Daniel Axtens wrote:
> There are a few ways we can send packets that are too large to a
> network driver.
>
> When non-GSO packets are forwarded, we validate their size, based on
> the MTU of the destination device. However, when GSO packets are
> forwarde
On Tue, Jan 16, 2018 at 01:09:19PM +1100, Daniel Axtens wrote:
> is_skb_forwardable attempts to detect if a packet is too large to
> be sent to the destination device. However, this test does not
> consider GSO packets, and it is possible that a GSO packet, when
> resegmented, will be larger than t
Currently it is using the datapath name/type but what has actually
failed was the netdev.
Fix it by using netdev name/type instead and also log why it failed.
Signed-off-by: Marcelo Ricardo Leitner
---
lib/dpif.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/dpif.c
Hi,
On Wed, Apr 12, 2017 at 01:13:36PM -0300, Flavio Leitner wrote:
>
> Hi Marcelo,
>
> Could you please confirm if this patch series fixes the aggregation
> issue in your environment?
Yes it did. I can see IPv4 L3 matches in datapath now and their stats
are updated accordingly.
>
> Thanks,
>
On Sun, Apr 02, 2017 at 02:36:18PM +0300, Roi Dayan wrote:
>
>
> On 02/04/2017 06:50, Roi Dayan wrote:
> >
> >
> > On 31/03/2017 01:11, Marcelo Ricardo Leitner wrote:
> > > On Thu, Mar 30, 2017 at 03:43:36PM -0300, Marcelo Ricardo Leitner wrote:
...
>
On Thu, Mar 30, 2017 at 03:43:36PM -0300, Marcelo Ricardo Leitner wrote:
> On Wed, Mar 29, 2017 at 03:43:10PM +0300, Roi Dayan wrote:
> > This patch series introduces rule offload functionality to dpif-netlink
> > via netdev ports new flow offloading API. The user can specify whethe
On Wed, Mar 29, 2017 at 03:43:10PM +0300, Roi Dayan wrote:
> This patch series introduces rule offload functionality to dpif-netlink
> via netdev ports new flow offloading API. The user can specify whether to
> enable rule offloading or not via OVS configuration. Netdev providers
> are able to impl
On Wed, Feb 08, 2017 at 05:29:26PM +0200, Roi Dayan wrote:
> From: Paul Blakey
>
> Flower classifer requires a different priority per mask,
> so we hash the mask and generate a new priority for
> each new mask used.
>
> Signed-off-by: Paul Blakey
> Reviewed-by: Roi Dayan
> ---
> lib/netdev-tc
om]
> > > Sent: Wednesday, February 8, 2017 3:29 PM
> > > To: d...@openvswitch.org
> > > Cc: Paul Blakey ; Or Gerlitz
> > > ; Hadar Hen Zion ; Shahar
> > > Klein ; Mark Bloch ; Rony
> > > Efraim ; Fastabend, John R
> > > ; Joe Stringer
86 matches
Mail list logo
