Re: [ovs-dev] [PATCH V9 07/31] other-config: Add tc-policy switch to control tc flower flag

2017-06-04 Thread Roi Dayan
On 30/05/2017 11:10, Simon Horman wrote: On Sun, May 28, 2017 at 02:59:49PM +0300, Roi Dayan wrote: From: Paul Blakey Add a new configuration tc-policy option that controls tc flower flag. Possible options are none, skip_sw, skip_hw. The default is none which is to insert the rule both to

Re: [ovs-dev] [PATCH V9 08/31] dpif: Save added ports in a port map for netdev flow api use

2017-06-04 Thread Roi Dayan
On 02/06/2017 16:45, Flavio Leitner wrote: On Sun, May 28, 2017 at 02:59:50PM +0300, Roi Dayan wrote: From: Paul Blakey To use netdev flow offloading api, dpifs needs to iterate over added ports. This addition inserts the added dpif ports in a hash map, The map will also be used to

Re: [ovs-dev] [PATCH V9 09/31] dpif-netlink: Flush added ports using netdev flow api

2017-06-04 Thread Roi Dayan
On 02/06/2017 17:46, Flavio Leitner wrote: On Sun, May 28, 2017 at 02:59:51PM +0300, Roi Dayan wrote: From: Paul Blakey If netdev flow offloading is enabled, flush all added ports using netdev flow api. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman Acked-by

Re: [ovs-dev] [PATCH V9 13/31] netdev-tc-offloads: Implement netdev flow dump api using tc interface

2017-06-03 Thread Roi Dayan
On 29/05/2017 10:30, Roi Dayan wrote: On 28/05/2017 14:59, Roi Dayan wrote: From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 184 --- 1 file changed, 175 insertions

Re: [ovs-dev] [PATCH V9 04/31] tc: Add tc flower functions

2017-06-03 Thread Roi Dayan
On 01/06/2017 20:53, Joe Stringer wrote: On 1 June 2017 at 07:39, Roi Dayan wrote: On 31/05/2017 03:50, Joe Stringer wrote: On 28 May 2017 at 04:59, Roi Dayan wrote: Add tc helper functions to query and manipulate the flower classifier. Signed-off-by: Paul Blakey Signed-off-by: Roi

Re: [ovs-dev] [PATCH V9 05/31] netdev: Adding a new netdev API to be used for offloading flows

2017-06-01 Thread Roi Dayan
On 30/05/2017 11:09, Simon Horman wrote: On Sun, May 28, 2017 at 02:59:47PM +0300, Roi Dayan wrote: From: Paul Blakey Add a new API interface for offloading dpif flows to netdev. The API consist on the following: flow_put - offload a new flow flow_get - query an offloaded flow

Re: [ovs-dev] [PATCH V9 02/31] tc: Introduce tc module

2017-06-01 Thread Roi Dayan
On 31/05/2017 03:20, Joe Stringer wrote: On 28 May 2017 at 04:59, Roi Dayan wrote: Add tc module to expose tc operations to be used by other modules. Move some tc related functions from netdev-linux.c to tc.c This patch doesn't change any functionality. Signed-off-by: Paul Blakey S

Re: [ovs-dev] [PATCH V9 02/31] tc: Introduce tc module

2017-06-01 Thread Roi Dayan
On 30/05/2017 11:07, Simon Horman wrote: On Sun, May 28, 2017 at 02:59:44PM +0300, Roi Dayan wrote: Add tc module to expose tc operations to be used by other modules. Move some tc related functions from netdev-linux.c to tc.c This patch doesn't change any functionality. Signed-off-by:

Re: [ovs-dev] [PATCH V9 01/31] netdev-linux: Refactor two tc functions

2017-06-01 Thread Roi Dayan
On 31/05/2017 03:12, Joe Stringer wrote: On 28 May 2017 at 04:59, Roi Dayan wrote: Refactor tc_make_request and tc_add_del_ingress_qdisc to accept ifindex instead of netdev struct. We later want to move those outside netdev-linux module to be used by other modules. This patch doesn't c

Re: [ovs-dev] [PATCH V9 04/31] tc: Add tc flower functions

2017-06-01 Thread Roi Dayan
On 31/05/2017 03:50, Joe Stringer wrote: On 28 May 2017 at 04:59, Roi Dayan wrote: Add tc helper functions to query and manipulate the flower classifier. Signed-off-by: Paul Blakey Signed-off-by: Roi Dayan --- Again is this co-authored? utilities/checkpatch.py checks for stuff like this

Re: [ovs-dev] [PATCH V9 16/31] netdev-tc-offloads: Implement netdev flow put using tc interface

2017-05-31 Thread Roi Dayan
On 28/05/2017 14:59, Roi Dayan wrote: From: Paul Blakey Currently only tunnel offload is supported. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 400 +-- 1 file changed, 390

Re: [ovs-dev] [PATCH V9 13/31] netdev-tc-offloads: Implement netdev flow dump api using tc interface

2017-05-29 Thread Roi Dayan
On 28/05/2017 14:59, Roi Dayan wrote: From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 184 --- 1 file changed, 175 insertions(+), 9 deletions(-) diff --git a/lib

[ovs-dev] [PATCH V9 31/31] NEWS: add a note about hw offloading

2017-05-28 Thread Roi Dayan
Signed-off-by: Roi Dayan --- NEWS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/NEWS b/NEWS index 4d03ca5..4bfcf78 100644 --- a/NEWS +++ b/NEWS @@ -36,6 +36,9 @@ Post-v2.7.0 * The port status bit OFPPS_LIVE now reflects link aliveness. - Fedora Packaging: * OVN services

[ovs-dev] [PATCH V9 30/31] dpif-netlink: Use dpif logging functions

2017-05-28 Thread Roi Dayan
Remove redundant logging functions and reuse the exposed dpif logging functions. Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey --- lib/dpif-netlink.c | 39 ++- 1 file changed, 6 insertions(+), 33 deletions(-) diff --git a/lib/dpif-netlink.c b/lib/dpif

[ovs-dev] [PATCH V9 23/31] netdev-tc-offloads: Add ingress on netdev flow api init

2017-05-28 Thread Roi Dayan
From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc-offloads.c index 4798d86..98c25f6

[ovs-dev] [PATCH V9 22/31] netdev-vport: Use common offloads interface

2017-05-28 Thread Roi Dayan
From: Paul Blakey netdev vports are backed by actualy netdev at the kernel level, so they can use the common netdev-tc offloads interface for flow offloading (if enabled). Signed-off-by: Paul Blakey Signed-off-by: Simon Horman Reviewed-by: Roi Dayan --- lib/netdev-linux.c | 7 +++--- lib

[ovs-dev] [PATCH V9 29/31] dpif: Refactor flow logging functions to be used by other modules

2017-05-28 Thread Roi Dayan
To be reused by other modules. Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey --- lib/dpif.c | 87 +++--- lib/dpif.h | 28 2 files changed, 72 insertions(+), 43 deletions(-) diff --git a/lib/dpif.c b/lib/dpif.c

[ovs-dev] [PATCH V9 24/31] dpctl: Add filter arg to dump-flows command info

2017-05-28 Thread Roi Dayan
This is for it to appear in bash completion. Signed-off-by: Roi Dayan --- lib/dpctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dpctl.c b/lib/dpctl.c index 11be857..d3d97d5 100644 --- a/lib/dpctl.c +++ b/lib/dpctl.c @@ -1554,7 +1554,7 @@ static const struct

[ovs-dev] [PATCH V9 28/31] netdev: Init flow api on already added ports on offload enable

2017-05-28 Thread Roi Dayan
From: Paul Blakey Ports already added to a switch are not being initialized for offloading so when enabling offload we need to go over those ports. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev.c | 14 ++ 1 file changed, 14 insertions

[ovs-dev] [PATCH V9 26/31] dpctl: Indicate if flow is offloaded when dumping flows of all types

2017-05-28 Thread Roi Dayan
From: Paul Blakey When verbosity is requested on dump-flows (-m) indicate which flows are offloaded. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/dpctl.c| 11 --- lib/dpif-netlink.c | 4 lib/dpif.h | 1 + 3 files changed, 13 insertions(+), 3

[ovs-dev] [PATCH V9 14/31] dpif-netlink: Use netdev flow put api to insert a flow

2017-05-28 Thread Roi Dayan
From: Paul Blakey Using the new netdev flow api operate will now try and offload flows to the relevant netdev of the input port. Other operate methods flows will come in later patches. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 218

[ovs-dev] [PATCH V9 20/31] netdev-tc-offloads: Implement flow get using tc interface

2017-05-28 Thread Roi Dayan
From: Paul Blakey Search the requested ufid for a offloaded flow, and if found, dump and parse it back to required format. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 50 ++-- 1 file

[ovs-dev] [PATCH V9 21/31] netdev-linux: Disallow setting policing when configured with hw offload

2017-05-28 Thread Roi Dayan
From: Paul Blakey Notify as not supported. Otherwise the ingress qdisc is being removed and offload rules will be removed. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-linux.c | 8 1 file changed, 8 insertions(+) diff --git a/lib

[ovs-dev] [PATCH V9 17/31] dpif-netlink: Use netdev flow del api to delete a flow

2017-05-28 Thread Roi Dayan
From: Paul Blakey If a flow was offloaded to a netdev we delete it using netdev flow api. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 13 - lib/netdev.c | 15 +++ lib/netdev.h | 2 ++ 3 files

[ovs-dev] [PATCH V9 25/31] dpctl: Add an option to dump only certain kinds of flows

2017-05-28 Thread Roi Dayan
Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpctl.c | 44 -- lib/dpctl.man | 7 - lib/dpif-netdev.c | 3 ++- lib/dpif-netlink.c| 63 ++- lib/dpif

[ovs-dev] [PATCH V9 27/31] tests: Add system-offloads-testsuite

2017-05-28 Thread Roi Dayan
From: Paul Blakey The new system-offloads-testsuite, which can be launched via `make check-offloads`, tests offloading capabilities to makes sure that certian flows are actually offloaded. The tests run on virtual netdevices (VETH). Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed

[ovs-dev] [PATCH V9 18/31] netdev-tc-offloads: Implement netdev flow del using tc interface

2017-05-28 Thread Roi Dayan
From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 33 ++--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc-offloads.c index f141784

[ovs-dev] [PATCH V9 16/31] netdev-tc-offloads: Implement netdev flow put using tc interface

2017-05-28 Thread Roi Dayan
From: Paul Blakey Currently only tunnel offload is supported. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 400 +-- 1 file changed, 390 insertions(+), 10 deletions(-) diff --git a/lib

[ovs-dev] [PATCH V9 15/31] netdev-tc-offloads: Add flower mask to priority map

2017-05-28 Thread Roi Dayan
From: Paul Blakey Flower classifer requires a different priority per mask, so we hash the mask and generate a new priority for each new mask used. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 54

[ovs-dev] [PATCH V9 13/31] netdev-tc-offloads: Implement netdev flow dump api using tc interface

2017-05-28 Thread Roi Dayan
From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 184 --- 1 file changed, 175 insertions(+), 9 deletions(-) diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc

[ovs-dev] [PATCH V9 11/31] dpif-netlink: Dump netdevs flows on flow dump

2017-05-28 Thread Roi Dayan
From: Paul Blakey While dumping flows, dump flows that were offloaded to netdev and parse them back to dpif flow. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 168 + lib/netdev.c

[ovs-dev] [PATCH V9 12/31] netdev-tc-offloads: Add ufid to tc/netdev map

2017-05-28 Thread Roi Dayan
From: Paul Blakey Flows offloaded to tc are identified by priority and handle pair while OVS flows are identified by ufid. Added a hash map to convert between the two for later retrieval and deleting of offloaded flows. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon

[ovs-dev] [PATCH V9 19/31] dpif-netlink: Use netdev flow get api to query a flow

2017-05-28 Thread Roi Dayan
From: Paul Blakey Search all datapath added netdevs for a given flow using netdev flow api and parse it back to dpif flow. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 51 ++- lib

[ovs-dev] [PATCH V9 09/31] dpif-netlink: Flush added ports using netdev flow api

2017-05-28 Thread Roi Dayan
From: Paul Blakey If netdev flow offloading is enabled, flush all added ports using netdev flow api. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman Acked-by: Flavio Leitner --- lib/dpif-netlink.c | 5 + lib/netdev.c | 12 lib/netdev.h

[ovs-dev] [PATCH V9 10/31] netdev-tc-offloads: Implement netdev flow flush using tc interface

2017-05-28 Thread Roi Dayan
From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc-offloads.c index 46017d8..e766972 100644

[ovs-dev] [PATCH V9 08/31] dpif: Save added ports in a port map for netdev flow api use

2017-05-28 Thread Roi Dayan
From: Paul Blakey To use netdev flow offloading api, dpifs needs to iterate over added ports. This addition inserts the added dpif ports in a hash map, The map will also be used to translate dpif ports to netdevs. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman

[ovs-dev] [PATCH V9 07/31] other-config: Add tc-policy switch to control tc flower flag

2017-05-28 Thread Roi Dayan
: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev.c | 6 ++ lib/tc.c | 43 ++- lib/tc.h | 3 +++ vswitchd/vswitch.xml | 17 + 4 files changed, 68 insertions(+), 1 deletion(-) diff --git a/lib

[ovs-dev] [PATCH V9 06/31] other-config: Add hw-offload switch to control netdev flow offloading

2017-05-28 Thread Roi Dayan
-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev.c | 35 +++ lib/netdev.h | 2 ++ vswitchd/bridge.c| 1 + vswitchd/vswitch.xml | 15 +++ 4 files changed, 53 insertions(+) diff --git a/lib/netdev.c b/lib/netdev.c index 9eb37ec

[ovs-dev] [PATCH V9 05/31] netdev: Adding a new netdev API to be used for offloading flows

2017-05-28 Thread Roi Dayan
flows In upcoming commits we will introduce an implementation of this API for netdev-linux. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/automake.mk | 2 + lib/netdev-bsd.c | 2 + lib/netdev-dpdk.c| 1 + lib/netdev-dummy.c

[ovs-dev] [PATCH V9 03/31] compat: Add tc compatibility headers for old kernels

2017-05-28 Thread Roi Dayan
headers. Signed-off-by: Paul Blakey Signed-off-by: Simon Horman Reviewed-by: Roi Dayan Acked-by: Flavio Leitner --- acinclude.m4 | 26 ++ configure.ac | 1 + include/automake.mk | 1 + include/linux/automake.mk

[ovs-dev] [PATCH V9 04/31] tc: Add tc flower functions

2017-05-28 Thread Roi Dayan
Add tc helper functions to query and manipulate the flower classifier. Signed-off-by: Paul Blakey Signed-off-by: Roi Dayan --- lib/tc.c | 992 +++ lib/tc.h | 92 ++ 2 files changed, 1084 insertions(+) diff --git a/lib/tc.c b/lib

[ovs-dev] [PATCH V9 00/31] Introducing HW offload support for openvswitch

2017-05-28 Thread Roi Dayan
s: Add ingress on netdev flow api init dpctl: Add an option to dump only certain kinds of flows dpctl: Indicate if flow is offloaded when dumping flows of all types tests: Add system-offloads-testsuite netdev: Init flow api on already added ports on offload enable Roi Dayan (7): netdev

[ovs-dev] [PATCH V9 02/31] tc: Introduce tc module

2017-05-28 Thread Roi Dayan
Add tc module to expose tc operations to be used by other modules. Move some tc related functions from netdev-linux.c to tc.c This patch doesn't change any functionality. Signed-off-by: Paul Blakey Signed-off-by: Roi Dayan --- lib/automake.mk| 2 + lib/netdev-linux.c

[ovs-dev] [PATCH V9 01/31] netdev-linux: Refactor two tc functions

2017-05-28 Thread Roi Dayan
Refactor tc_make_request and tc_add_del_ingress_qdisc to accept ifindex instead of netdev struct. We later want to move those outside netdev-linux module to be used by other modules. This patch doesn't change any functionality. Signed-off-by: Paul Blakey Signed-off-by: Roi Dayan --- lib/n

Re: [ovs-dev] [PATCH ovs V8 00/26] Introducing HW offload support for openvswitch

2017-05-16 Thread Roi Dayan
On 10/05/2017 17:29, Flavio Leitner wrote: On Wed, May 10, 2017 at 10:44:46AM +0300, Roi Dayan wrote: On 09/05/2017 22:05, Flavio Leitner wrote: On Sun, May 07, 2017 at 10:55:32AM +0300, Roi Dayan wrote: On 03/05/2017 18:58, Federico Iezzi wrote: On Wed, May 3, 2017 at 5:07 PM, Roi

Re: [ovs-dev] [PATCH ovs V8 26/26] dpif-netlink: Use dpif logging functions

2017-05-16 Thread Roi Dayan
On 10/05/2017 18:20, Simon Horman wrote: On Wed, May 03, 2017 at 06:08:17PM +0300, Roi Dayan wrote: Please add some changelog text here. Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey --- lib/dpif-netlink.c | 55 +- 1 file changed

Re: [ovs-dev] [PATCH ovs V8 25/26] dpif: Refactor flow logging functions to be used by other modules

2017-05-16 Thread Roi Dayan
On 10/05/2017 18:21, Simon Horman wrote: On Wed, May 10, 2017 at 05:19:26PM +0200, Simon Horman wrote: On Wed, May 03, 2017 at 06:08:16PM +0300, Roi Dayan wrote: Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey Reviewed-by: Simon Horman Sorry, I didn't notice before but could yo

Re: [ovs-dev] [PATCH ovs V8 21/26] dpctl: Add an option to dump only certain kinds of flows

2017-05-16 Thread Roi Dayan
On 10/05/2017 16:57, Simon Horman wrote: On Wed, May 03, 2017 at 06:08:12PM +0300, Roi Dayan wrote: From: Paul Blakey Usage: # to dump all datapath flows (default): ovs-dpctl dump-flows # to dump only flows that in kernel datapath: ovs-dpctl dump-flows type=ovs # to

Re: [ovs-dev] [PATCH ovs V8 21/26] dpctl: Add an option to dump only certain kinds of flows

2017-05-16 Thread Roi Dayan
On 10/05/2017 16:48, Simon Horman wrote: On Wed, May 03, 2017 at 06:08:12PM +0300, Roi Dayan wrote: From: Paul Blakey Usage: # to dump all datapath flows (default): ovs-dpctl dump-flows # to dump only flows that in kernel datapath: ovs-dpctl dump-flows type=ovs # to

Re: [ovs-dev] [PATCH ovs V8 13/26] netdev-tc-offloads: Implement netdev flow put using tc interface

2017-05-16 Thread Roi Dayan
On 10/05/2017 16:28, Simon Horman wrote: On Wed, May 03, 2017 at 06:08:04PM +0300, Roi Dayan wrote: From: Paul Blakey Currently only tunnel offload is supported. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 4 +- lib

Re: [ovs-dev] [PATCH ovs V8 13/26] netdev-tc-offloads: Implement netdev flow put using tc interface

2017-05-16 Thread Roi Dayan
On 09/05/2017 21:12, Flavio Leitner wrote: On Wed, May 03, 2017 at 06:08:04PM +0300, Roi Dayan wrote: From: Paul Blakey Currently only tunnel offload is supported. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 4 +- lib

Re: [ovs-dev] [PATCH ovs V8 12/26] netdev-tc-offloads: Add flower mask to priority map

2017-05-16 Thread Roi Dayan
On 09/05/2017 22:10, Flavio Leitner wrote: On Tue, May 09, 2017 at 03:23:12PM -0300, Flavio Leitner wrote: On Wed, May 03, 2017 at 06:08:03PM +0300, Roi Dayan wrote: From: Paul Blakey Flower classifer requires a different priority per mask, so we hash the mask and generate a new priority

Re: [ovs-dev] [PATCH ovs V8 07/26] netdev-tc-offloads: Implement netdev flow flush using tc interface

2017-05-16 Thread Roi Dayan
On 08/05/2017 15:56, Simon Horman wrote: On Wed, May 03, 2017 at 06:07:58PM +0300, Roi Dayan wrote: From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman This does not appear to address Flavio Leitner's review of v7 of this patch. email i

Re: [ovs-dev] [PATCH ovs V8 06/26] dpif-netlink: Flush added ports using netdev flow api

2017-05-16 Thread Roi Dayan
On 08/05/2017 15:50, Simon Horman wrote: On Wed, May 03, 2017 at 06:07:57PM +0300, Roi Dayan wrote: From: Paul Blakey If netdev flow offloading is enabled, flush all added ports using netdev flow api. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman Flavio

Re: [ovs-dev] [PATCH ovs V8 05/26] dpif: Save added ports in a port map for netdev flow api use

2017-05-16 Thread Roi Dayan
On 08/05/2017 15:49, Simon Horman wrote: On Wed, May 03, 2017 at 06:07:56PM +0300, Roi Dayan wrote: From: Paul Blakey To use netdev flow offloading api, dpifs needs to iterate over added ports. This addition inserts the added dpif ports in a hash map, The map will also be used to translate

Re: [ovs-dev] [PATCH ovs V8 03/26] other-config: Add hw-offload switch to control netdev flow offloading

2017-05-16 Thread Roi Dayan
On 08/05/2017 15:38, Simon Horman wrote: On Wed, May 03, 2017 at 06:07:54PM +0300, Roi Dayan wrote: From: Paul Blakey Add a new configuration option - hw-offload that enables netdev flow api. Enabling this option will allow offloading flows using netdev implementation instead of the kernel

Re: [ovs-dev] [PATCH ovs V8 02/26] netdev: Adding a new netdev api to be used for offloading flows

2017-05-14 Thread Roi Dayan
On 09/05/2017 21:12, Flavio Leitner wrote: On Wed, May 03, 2017 at 06:07:53PM +0300, Roi Dayan wrote: From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/automake.mk | 2 + lib/netdev-bsd.c | 2 + lib/netdev-dpdk.c

Re: [ovs-dev] [PATCH ovs V8 02/26] netdev: Adding a new netdev api to be used for offloading flows

2017-05-14 Thread Roi Dayan
On 08/05/2017 15:28, Simon Horman wrote: On Wed, May 03, 2017 at 06:07:53PM +0300, Roi Dayan wrote: From: Paul Blakey Please add some text to the changelog. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman ... diff --git a/lib/netdev-tc-offloads.c b/lib

Re: [ovs-dev] [PATCH ovs V8 00/26] Introducing HW offload support for openvswitch

2017-05-10 Thread Roi Dayan
On 09/05/2017 22:05, Flavio Leitner wrote: On Sun, May 07, 2017 at 10:55:32AM +0300, Roi Dayan wrote: On 03/05/2017 18:58, Federico Iezzi wrote: On Wed, May 3, 2017 at 5:07 PM, Roi Dayan wrote: This patch series introduces rule offload functionality to dpif-netlink via netdev ports new

Re: [ovs-dev] [PATCH ovs V8 01/26] tc: Add tc flower interface

2017-05-07 Thread Roi Dayan
On 04/05/2017 19:35, Simon Horman wrote: On Wed, May 03, 2017 at 06:07:52PM +0300, Roi Dayan wrote: From: Paul Blakey Add tc flower interface that will be used to offload flows via tc flower classifier. Depending on the flag used (skip_sw/hw) flower will pass those to HW or handle them

Re: [ovs-dev] [PATCH ovs V8 00/26] Introducing HW offload support for openvswitch

2017-05-07 Thread Roi Dayan
On 03/05/2017 18:58, Federico Iezzi wrote: On Wed, May 3, 2017 at 5:07 PM, Roi Dayan wrote: This patch series introduces rule offload functionality to dpif-netlink via netdev ports new flow offloading API. The user can specify whether to enable rule offloading or not via OVS configuration

[ovs-dev] [PATCH ovs V8 26/26] dpif-netlink: Use dpif logging functions

2017-05-03 Thread Roi Dayan
Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey --- lib/dpif-netlink.c | 55 +- 1 file changed, 17 insertions(+), 38 deletions(-) diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c index 048dae6..3638358 100644 --- a/lib/dpif-netlink.c

[ovs-dev] [PATCH ovs V8 25/26] dpif: Refactor flow logging functions to be used by other modules

2017-05-03 Thread Roi Dayan
Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey --- lib/dpif.c | 87 +++--- lib/dpif.h | 28 2 files changed, 72 insertions(+), 43 deletions(-) diff --git a/lib/dpif.c b/lib/dpif.c index 658830b..bc1f034 100644

[ovs-dev] [PATCH ovs V8 24/26] netdev: Init flow api on already added ports on offload enable

2017-05-03 Thread Roi Dayan
From: Paul Blakey Ports already added to a switch are not being initialized for offloading so when enabling offload we need to go over those ports. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev.c | 14 ++ 1 file changed, 14 insertions

[ovs-dev] [PATCH ovs V8 23/26] compat: Add tc compatibility headers for old kernels

2017-05-03 Thread Roi Dayan
headers. Signed-off-by: Paul Blakey Signed-off-by: Simon Horman Reviewed-by: Roi Dayan --- acinclude.m4 | 26 ++ configure.ac | 1 + include/automake.mk | 1 + include/linux/automake.mk| 4 + include/linux

[ovs-dev] [PATCH ovs V8 19/26] netdev-vport: Use common offloads interface

2017-05-03 Thread Roi Dayan
From: Paul Blakey netdev vports are backed by actualy netdev at the kernel level, so they can use the common netdev-tc offloads interface for flow offloading (if enabled). Signed-off-by: Paul Blakey Signed-off-by: Simon Horman Reviewed-by: Roi Dayan --- lib/netdev-linux.c | 7 +++--- lib

[ovs-dev] [PATCH ovs V8 22/26] tests: Add system-offloads-testsuite

2017-05-03 Thread Roi Dayan
From: Paul Blakey The new system-offloads-testsuite, which can be launched via `make check-offloads`, tests offloading capabilities to makes sure that certian flows are actually offloaded. The tests run on virtual netdevices (VETH). Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed

[ovs-dev] [PATCH ovs V8 21/26] dpctl: Add an option to dump only certain kinds of flows

2017-05-03 Thread Roi Dayan
Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpctl.c | 21 ++- lib/dpctl.man | 7 - lib/dpif-netdev.c | 3 ++- lib/dpif-netlink.c| 63 ++- lib/dpif-provider.h

[ovs-dev] [PATCH ovs V8 16/26] dpif-netlink: Use netdev flow get api to query a flow

2017-05-03 Thread Roi Dayan
From: Paul Blakey Search all datapath added netdevs for a given flow using netdev flow api and parse it back to dpif flow. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 50 +- lib/netdev.c

[ovs-dev] [PATCH ovs V8 20/26] netdev-tc-offloads: Add ingress on netdev flow api init

2017-05-03 Thread Roi Dayan
From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc-offloads.c index c3eddf4..4fc0445

[ovs-dev] [PATCH ovs V8 17/26] netdev-tc-offloads: Implement flow get using tc interface

2017-05-03 Thread Roi Dayan
From: Paul Blakey Search the requested ufid for a offloaded flow, and if found, dump and parse it back to required format. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 50 ++-- 1 file

[ovs-dev] [PATCH ovs V8 18/26] netdev-linux: Disallow setting policing when configured with hw offload

2017-05-03 Thread Roi Dayan
From: Paul Blakey Notify as not supported. Otherwise the ingress qdisc is being removed and offload rules will be removed. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-linux.c | 8 1 file changed, 8 insertions(+) diff --git a/lib

[ovs-dev] [PATCH ovs V8 14/26] dpif-netlink: Use netdev flow del api to delete a flow

2017-05-03 Thread Roi Dayan
From: Paul Blakey If a flow was offloaded to a netdev we delete it using netdev flow api. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 12 +++- lib/netdev.c | 15 +++ lib/netdev.h | 2 ++ 3 files

[ovs-dev] [PATCH ovs V8 15/26] netdev-tc-offloads: Implement netdev flow del using tc interface

2017-05-03 Thread Roi Dayan
From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 33 ++--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc-offloads.c index e3daf62

[ovs-dev] [PATCH ovs V8 13/26] netdev-tc-offloads: Implement netdev flow put using tc interface

2017-05-03 Thread Roi Dayan
From: Paul Blakey Currently only tunnel offload is supported. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 4 +- lib/netdev-tc-offloads.c | 392 ++- 2 files changed, 385 insertions

[ovs-dev] [PATCH ovs V8 12/26] netdev-tc-offloads: Add flower mask to priority map

2017-05-03 Thread Roi Dayan
From: Paul Blakey Flower classifer requires a different priority per mask, so we hash the mask and generate a new priority for each new mask used. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 38

[ovs-dev] [PATCH ovs V8 10/26] netdev-tc-offloads: Implement netdev flow dump api using tc interface

2017-05-03 Thread Roi Dayan
From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 182 --- 1 file changed, 174 insertions(+), 8 deletions(-) diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc

[ovs-dev] [PATCH ovs V8 11/26] dpif-netlink: Use netdev flow put api to insert a flow

2017-05-03 Thread Roi Dayan
From: Paul Blakey Using the new netdev flow api operate will now try and offload flows to the relevant netdev of the input port. Other operate methods flows will come in later patches. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 216

[ovs-dev] [PATCH ovs V8 06/26] dpif-netlink: Flush added ports using netdev flow api

2017-05-03 Thread Roi Dayan
From: Paul Blakey If netdev flow offloading is enabled, flush all added ports using netdev flow api. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 5 + lib/netdev.c | 12 lib/netdev.h | 1 + 3 files

[ovs-dev] [PATCH ovs V8 08/26] dpif-netlink: Dump netdevs flows on flow dump

2017-05-03 Thread Roi Dayan
From: Paul Blakey While dumping flows, dump flows that were offloaded to netdev and parse them back to dpif flow. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 168 + lib/netdev.c

[ovs-dev] [PATCH ovs V8 09/26] netdev-tc-offloads: Add ufid to tc/netdev map

2017-05-03 Thread Roi Dayan
From: Paul Blakey Flows offloaded to tc are identified by priority and handle pair while OVS flows are identified by ufid. Added a hash map to convert between the two for later retrieval and deleting of offloaded flows. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon

[ovs-dev] [PATCH ovs V8 07/26] netdev-tc-offloads: Implement netdev flow flush using tc interface

2017-05-03 Thread Roi Dayan
From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc-offloads.c index eb5e79a..b12a048 100644

[ovs-dev] [PATCH ovs V8 05/26] dpif: Save added ports in a port map for netdev flow api use

2017-05-03 Thread Roi Dayan
From: Paul Blakey To use netdev flow offloading api, dpifs needs to iterate over added ports. This addition inserts the added dpif ports in a hash map, The map will also be used to translate dpif ports to netdevs. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman

[ovs-dev] [PATCH ovs V8 04/26] other-config: Add tc-policy switch to control tc flower flag

2017-05-03 Thread Roi Dayan
: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev.c | 6 ++ lib/tc.c | 43 ++- lib/tc.h | 1 + vswitchd/vswitch.xml | 17 + 4 files changed, 66 insertions(+), 1 deletion(-) diff --git a/lib/netdev.c

[ovs-dev] [PATCH ovs V8 03/26] other-config: Add hw-offload switch to control netdev flow offloading

2017-05-03 Thread Roi Dayan
-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev.c | 30 ++ lib/netdev.h | 2 ++ vswitchd/bridge.c| 1 + vswitchd/vswitch.xml | 11 +++ 4 files changed, 44 insertions(+) diff --git a/lib/netdev.c b/lib/netdev.c index 1677027..90c95cb

[ovs-dev] [PATCH ovs V8 02/26] netdev: Adding a new netdev api to be used for offloading flows

2017-05-03 Thread Roi Dayan
From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/automake.mk | 2 + lib/netdev-bsd.c | 2 + lib/netdev-dpdk.c| 1 + lib/netdev-dummy.c | 2 + lib/netdev-linux.c | 15 +++-- lib/netdev-linux.h

[ovs-dev] [PATCH ovs V8 01/26] tc: Add tc flower interface

2017-05-03 Thread Roi Dayan
-by: Shahar Klein Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/automake.mk|2 + lib/netdev-linux.c | 164 ++-- lib/tc.c | 1109 lib/tc.h | 128 ++ 4 files changed

[ovs-dev] [PATCH ovs V8 00/26] Introducing HW offload support for openvswitch

2017-05-03 Thread Roi Dayan
ption to dump only certain kinds of flows tests: Add system-offloads-testsuite compat: Add tc compatibility headers for old kernels netdev: Init flow api on already added ports on offload enable Roi Dayan (2): dpif: Refactor flow logging functions to be used by other modules dpif-

Re: [ovs-dev] [PATCH ovs V7 02/24] netdev: Adding a new netdev api to be used for offloading flows

2017-05-02 Thread Roi Dayan
On 24/04/2017 14:35, Simon Horman wrote: On Tue, Apr 18, 2017 at 03:18:55PM +0300, Roi Dayan wrote: On 14/04/2017 04:11, Joe Stringer wrote: On 7 April 2017 at 06:12, Roi Dayan wrote: From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman

Re: [ovs-dev] [PATCH ovs V7 21/24] dpctl: Add an option to dump only certain kinds of flows

2017-04-20 Thread Roi Dayan
On 12/04/2017 20:04, Joe Stringer wrote: On 12 April 2017 at 08:22, Flavio Leitner wrote: On Fri, Apr 07, 2017 at 04:13:08PM +0300, Roi Dayan wrote: From: Paul Blakey Usage: # to dump all datapath flows (default): ovs-dpctl dump-flows # to dump only flows that in kernel

Re: [ovs-dev] [PATCH ovs V7 19/24] netdev-vport: Use common offloads interface

2017-04-20 Thread Roi Dayan
On 14/04/2017 04:19, Joe Stringer wrote: On 7 April 2017 at 06:13, Roi Dayan wrote: From: Paul Blakey netdev vports are backed by actualy netdev at the kernel level, so they can use the common netdev-tc offloads interface for flow offloading (if enabled). Signed-off-by: Paul Blakey

Re: [ovs-dev] [PATCH ovs V7 11/24] dpif-netlink: Use netdev flow put api to insert a flow

2017-04-19 Thread Roi Dayan
On 14/04/2017 04:08, Joe Stringer wrote: On 7 April 2017 at 06:12, Roi Dayan wrote: From: Paul Blakey Using the new netdev flow api operate will now try and offload flows to the relevant netdev of the input port. Other operate methods flows will come in later patches. Signed-off-by: Paul

Re: [ovs-dev] [PATCH ovs V7 15/24] netdev-tc-offloads: Implement netdev flow del using tc interface

2017-04-19 Thread Roi Dayan
On 14/04/2017 04:15, Joe Stringer wrote: On 7 April 2017 at 06:13, Roi Dayan wrote: From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 33 ++--- 1 file changed, 30 insertions(+), 3

Re: [ovs-dev] [PATCH ovs V7 09/24] netdev-tc-offloads: Add ufid to tc/netdev map

2017-04-19 Thread Roi Dayan
On 14/04/2017 03:55, Joe Stringer wrote: On 7 April 2017 at 06:12, Roi Dayan wrote: From: Paul Blakey Flows offloaded to tc are identified by priority and handle pair while OVS flows are identified by ufid. Added a hash map to convert between the two for later retrieval and deleting of

Re: [ovs-dev] [PATCH ovs V7 08/24] dpif-netlink: Dump netdevs flows on flow dump

2017-04-19 Thread Roi Dayan
On 14/04/2017 03:51, Joe Stringer wrote: On 7 April 2017 at 06:12, Roi Dayan wrote: From: Paul Blakey While dumping flows, dump flows that were offloaded to netdev and parse them back to dpif flow. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib

Re: [ovs-dev] [PATCH ovs V7 05/24] dpif: Save added ports in a port map for netdev flow api use

2017-04-19 Thread Roi Dayan
On 14/04/2017 03:26, Joe Stringer wrote: On 7 April 2017 at 06:12, Roi Dayan wrote: From: Paul Blakey To use netdev flow offloading api, dpifs needs to iterate over added ports. This addition inserts the added dpif ports in a hash map, The map will also be used to translate dpif ports to

[ovs-dev] [PATCH ovs V2] Documentation: fix broken links in maintainers page

2017-04-19 Thread Roi Dayan
Missing the internals sub folder. Signed-off-by: Roi Dayan --- V2 - fix links but keep GitHub style as it's a top-level document MAINTAINERS.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst index 28831ab..60fa1f5 100644

Re: [ovs-dev] [PATCH ovs] Documentation: fix broken links in maintainers page

2017-04-19 Thread Roi Dayan
On 18/04/2017 19:26, Stephen Finucane wrote: On Tue, 2017-04-18 at 15:08 +0300, Roi Dayan wrote: The links were pointing to static non-existent location instead of internal doc link. Signed-off-by: Roi Dayan --- MAINTAINERS.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [ovs-dev] [PATCH ovs V7 02/24] netdev: Adding a new netdev api to be used for offloading flows

2017-04-18 Thread Roi Dayan
On 14/04/2017 04:11, Joe Stringer wrote: On 7 April 2017 at 06:12, Roi Dayan wrote: From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- diff --git a/lib/netdev.h b/lib/netdev.h index d6c07c1..6d2db7d 100644 --- a/lib/netdev.h +++ b/lib

Re: [ovs-dev] [PATCH ovs V7 02/24] netdev: Adding a new netdev api to be used for offloading flows

2017-04-18 Thread Roi Dayan
On 14/04/2017 04:01, Joe Stringer wrote: On 7 April 2017 at 06:12, Roi Dayan wrote: From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- @@ -769,6 +777,49 @@ struct netdev_class { /* Discards all packets waiting to be received from

<    4   5   6   7   8   9   10   11   >