Re: [ovs-dev] [PATCH] [RFC][windows]: Remap VPORT socket pool

2018-11-13 Thread Shashank Ram
socksp)) { > goto error; > } > +#endif > > error = vport_add_channel(dpif, vport.port_no, socksp); > if (error) { > VLOG_INFO("%s: could not add channels for port %s", >

Re: [ovs-dev] [PATCH RFC] datapath-windows: Remove neighbor entries when Iphelper instance is deleted

2018-10-04 Thread Shashank Ram
On 10/3/18, 4:30 AM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar" wrote: 'OVS_IPHELPER_INSTANCE' is linked to ovsSortedIPNeighList. So when an Iphelper instance is deleted, also delete the ip neighboring entries associated with that instance. Also fix accessi

Re: [ovs-dev] [PATCH v2] datapath-windows: Add support to configure ct zone limits

2018-08-31 Thread Shashank Ram
Hi Anand, one thing looks off to me here. In the signature of OvsCreateNlMsgFromCtLimit(), numAttrs is UINT32, but the loop’s index variable is an UINT16: for (UINT16 i = 0; i < numAttrs; i++) Please address this discrepancy. -- Thanks, Shashank On 8/28/18, 10:37 AM, "ovs-dev-boun...@openvs

Re: [ovs-dev] [PATCH] datapath-windows: Add support to configure ct zone limits

2018-08-27 Thread Shashank Ram
On 08/21/2018 02:57 PM, Anand Kumar wrote: This patch implements limiting conntrack entries per zone using dpctl commands. Example: ovs-appctl dpctl/ct-set-limits default=5 zone=1,limit=2 zone=1,limit=3 ovs-appctl dpct/ct-del-limits zone=4 ovs-appctl dpct/ct-get-limits zone=1,2,3 - Also upda

Re: [ovs-dev] [PATCH 05/14] datapath-windows: Cleanup Gre.c

2018-07-11 Thread Shashank Ram
On 07/09/2018 06:40 AM, Alin Gabriel Serdean wrote: Do not assign an initial value to ` status`, it will be assigned later on. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Gre.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/

Re: [ovs-dev] [PATCH 03/14] datapath-windows: Cleanup Conntrack.c

2018-07-11 Thread Shashank Ram
On 07/09/2018 06:40 AM, Alin Gabriel Serdean wrote: Do not assign an initial value for the variable `entry`, it will be reassigned later on. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Conntrack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data

Re: [ovs-dev] [PATCH 02/14] datapath-windows: Cleanup BufferMgmt.c

2018-07-11 Thread Shashank Ram
; - -mdl = NET_BUFFER_FIRST_MDL(nb); +PMDL mdl = NET_BUFFER_FIRST_MDL(nb); +PUINT8 bufferStart = (PUINT8)OvsGetMdlWithLowPriority(mdl); -bufferStart = (PUINT8)OvsGetMdlWithLowPriority(mdl); if (!bufferStart) { return NDIS_STATUS_RESOURCES; } Acked-by: Shashank

Re: [ovs-dev] [PATCH 01/14] datapath-windows: Cleanup Actions.c

2018-07-11 Thread Shashank Ram
FindVportByPortNo(switchContext, srcPortNo); if (vport == NULL || vport->ovsState != OVS_STATE_CONNECTED) { OvsCompleteNBLForwardingCtx(&ovsFwdCtx, L"OVS-Dropped due to port removal"); Acked-by: Shashank Ram ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCHv5] DNS: Add basic support for asynchronous DNS resolving

2018-06-26 Thread Shashank Ram
On Tue, Jun 26, 2018 at 7:08 PM Yifeng Sun wrote: > This patch is a simple implementation for the proposal discussed in > > https://mail.openvswitch.org/pipermail/ovs-dev/2017-August/337038.html > and > https://mail.openvswitch.org/pipermail/ovs-dev/2017-October/340013.html. > > > It enables ovs-

Re: [ovs-dev] [PATCH v4 4/4] datapath-windows: Compute ct hash based on 5-tuple and zone

2018-06-18 Thread Shashank Ram
On 06/17/2018 10:37 PM, Anand Kumar wrote: Conntrack 5-tuple consists of src address, dst address, src port, dst port and protocol which will be unique to a ct session. Use this information along with zone to compute hash. Also re-factor conntrack code related to parsing netlink attributes.

Re: [ovs-dev] [PATCH v4 3/4] datapath-windows: Implement locking in conntrack NAT.

2018-06-18 Thread Shashank Ram
This patch should be combined with the patch where NAT lock is removed from CT. Keeping this separate will cause the previous patches in this series to break NAT functionality. Thanks, Shashank On 06/17/2018 10:37 PM, Anand Kumar wrote: The 'ovsNatTable' and 'ovsUnNatTable' tables are shared

Re: [ovs-dev] [PATCH v4 2/4] datapath-windows: Remove NAT locks in conntrack.

2018-06-18 Thread Shashank Ram
On 06/17/2018 10:37 PM, Anand Kumar wrote: This patch primarily gets rid of NdisRWLock in conntrack for NAT functionality along with some conntrack optimization. The subsequent patch will have a lock implementation inside NAT module. - Introduce a new function OvsGetTcpHeader() to retrieve TC

Re: [ovs-dev] [PATCH v4 1/4] datapath-windows: Use spinlock instead of RW lock for ct entry

2018-06-18 Thread Shashank Ram
On 06/17/2018 10:37 PM, Anand Kumar wrote: This patch mainly changes a ndis RW lock for conntrack entry to a spinlock along with some minor refactor in conntrack. Using spinlock instead of RW lock as RW locks causes performance hits when acquired/released multiple times. - Use NdisInterlocked

Re: [ovs-dev] [PATCH v2] datapath-windows: Optimize conntrack performance

2018-06-08 Thread Shashank Ram
On Thu, Jun 7, 2018, 11:52 AM Anand Kumar wrote: > - Move conntrack lock out of NAT module > - Use spinlock instead of read/write lock for conntrack entry. > - Update 'ctTotalRelatedEntries' using interlocked functions > - Refactor conntrack code to make it more readable. > > Testing: > Evaluated

Re: [ovs-dev] [PATCH] datapath-windows: Add support for handling DEI bit of VLAN header

2018-05-16 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar Sent: Tuesday, May 15, 2018 4:38 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH] datapath-windows: Add support for handling DEI bit of VLAN header The Drop eligible indicator

Re: [ovs-dev] [PATCH] Windows: Trigger an ARP request before sending IPFIX packet

2018-05-08 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Sairam Venugopal Sent: Tuesday, May 8, 2018 10:09 AM To: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH] Windows: Trigger an ARP request before sending IPFIX packet Will send out a V2 with the cor

Re: [ovs-dev] [PATCH] RFC datapath-windows: Create com device only when extension is enabled

2018-04-05 Thread Shashank Ram
From: aserd...@ovn.org Sent: Thursday, April 5, 2018 2:32 AM To: Shashank Ram; d...@openvswitch.org Subject: RE: [ovs-dev] [PATCH] RFC datapath-windows: Create com device only whenextension is enabled > -Mesaj original- > De l

Re: [ovs-dev] [PATCH] RFC datapath-windows: Create com device only when extension is enabled

2018-04-04 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Alin Gabriel Serdean Sent: Tuesday, April 3, 2018 8:08 AM To: d...@openvswitch.org Cc: Alin Gabriel Serdean Subject: [ovs-dev] [PATCH] RFC datapath-windows: Create com device only when extension i

Re: [ovs-dev] [PATCH] [RFC] build-windows: Add pthread to windows build

2018-03-06 Thread Shashank Ram
ase.tar.gz > > It makes it easier for people which are building on systems that > don't have an internet connections. > > Another idea would be to have `--with-pthread-tar=` and point it > to the tarball. > > Which one do you prefer? > > Thanks, > Alin. > >

Re: [ovs-dev] [PATCH 2/2] datapath-windows: Add Win10Analyze to a make target

2018-03-04 Thread Shashank Ram
> > Signed-off-by: Alin Gabriel Serdean > --- > Acked-by: Shashank Ram ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] AppVeyor: Add Win10 compilation to the build

2018-03-04 Thread Shashank Ram
--with-openssl=C:/OpenSSL-Win32 --with-vstudiotarget=\"Debug\" > - C:\MinGW\msys\1.0\bin\bash -lc "cd /c/openvswitch && make" > - C:\MinGW\msys\1.0\bin\bash -lc "cd /c/openvswitch && make > datapath_windows_analyze" > -- > 2.16.1.windows.1 > > ___ > Acked-by: Shashank Ram ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] datapath-windows: Support to selectively compile targets

2018-03-01 Thread Shashank Ram
Thanks Alin! From: aserd...@ovn.org Sent: Thursday, March 1, 2018 3:09:19 PM To: aserd...@ovn.org; Anand Kumar; Shashank Ram; d...@openvswitch.org Subject: RE: [ovs-dev] [PATCH v2] datapath-windows: Support to selectively compile targets Applied on

[ovs-dev] [PATCH v2] datapath-windows: Support to selectively compile targets

2018-02-27 Thread Shashank Ram
s, we will not pass the "--with-vstudiotargetver" to the configure script. Signed-off-by: Shashank Ram --- Documentation/intro/install/windows.rst | 5 - Makefile.am | 15 +++ appveyor.yml| 4 ++-- m4

Re: [ovs-dev] [PATCH] datapath-windows: Support to selectively compile targets

2018-02-27 Thread Shashank Ram
Sounds good Alin, I will update the documentation, and we can work on a patch with the solution you suggested as an alternative workflow. Thanks, Shashank From: Alin Serdean Sent: Tuesday, February 27, 2018 9:38:22 AM To: Shashank Ram; Alin Balutoiu

Re: [ovs-dev] [PATCH] datapath-windows: Support to selectively compile targets

2018-02-20 Thread Shashank Ram
From: Alin Balutoiu Sent: Tuesday, February 20, 2018 2:58:06 AM To: Anand Kumar; Shashank Ram; Alin Serdean; d...@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: Support to selectively compile targets I agree with having the target specified during make and not during

Re: [ovs-dev] [PATCH] datapath-windows: Support to selectively compile targets

2018-02-08 Thread Shashank Ram
From: aserd...@ovn.org Sent: Thursday, February 8, 2018 10:43 AM To: Shashank Ram; aserd...@ovn.org; d...@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: Support to selectively compile targets Trimming the message a bit. -Mesaj

Re: [ovs-dev] [PATCH] datapath-windows: Support to selectively compile targets

2018-02-08 Thread Shashank Ram
, February 8, 2018 9:32:59 AM To: Shashank Ram; d...@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: Support to selectively compile targets It looks a bit complicated. What do you think about the following approach: git diff datapath-windows/automake.mk diff --git a/datapath

[ovs-dev] [PATCH] datapath-windows: Support to selectively compile targets

2018-02-06 Thread Shashank Ram
s, we will not pass the "--with-vstudiotargetver" to the configure script. Signed-off-by: Shashank Ram --- Makefile.am | 15 +++ appveyor.yml | 4 ++-- m4/openvswitch.m4 | 28 +++- 3 files changed, 44 insertions(+), 3 deletions(-

[ovs-dev] [PATCH v2] Makefile.am: Use correct path separator for Windows

2018-02-02 Thread Shashank Ram
Signed-off-by: Shashank Ram --- Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 5988c02..d397f65 100644 --- a/Makefile.am +++ b/Makefile.am @@ -148,7 +148,7 @@ ro_shell = printf '\043 Generated automatically -- do not m

Re: [ovs-dev] [PATCH] Makefile.am: Use correct path separator for Windows

2018-02-02 Thread Shashank Ram
From: Ben Pfaff Sent: Friday, February 2, 2018 2:07 PM To: Shashank Ram Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH] Makefile.am: Use correct path separator for Windows On Thu, Feb 01, 2018 at 05:03:52PM -0800, Shashank Ram wrote: > Sig

[ovs-dev] [PATCH] Makefile.am: Use correct path separator for Windows

2018-02-01 Thread Shashank Ram
Signed-off-by: Shashank Ram --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 5988c02..1d336b6 100644 --- a/Makefile.am +++ b/Makefile.am @@ -398,7 +398,7 @@ CLEANFILES += flake8-check include $(srcdir)/manpages.mk $(srcdir

[ovs-dev] [PATCH v1 1/2] datapath-windows: Allow compiling all targets using SDK 10.0

2018-01-31 Thread Shashank Ram
SDKs. Signed-off-by: Shashank Ram --- datapath-windows/Package/package.VcxProj | 28 -- datapath-windows/ovsext/ovsext.vcxproj | 50 +++- 2 files changed, 49 insertions(+), 29 deletions(-) diff --git a/datapath-windows/Package/package.VcxProj b

[ovs-dev] [PATCH v1 2/2] datapath-windows: Specify platform arch during compilation

2018-01-31 Thread Shashank Ram
Newer compilers expect the platorm architecture to be passed. Signed-off-by: Shashank Ram --- Makefile.am | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/Makefile.am b/Makefile.am index ed4b7fd..5988c02 100644 --- a/Makefile.am +++ b/Makefile.am @@ -409,14 +409,15

[ovs-dev] [PATCH] openvswitch/types.h: Drop the member name in initializer macro

2018-01-25 Thread Shashank Ram
= {{{ 0xff, 0xff, 0xff, 0xff, 0xff, 0xff }}}; *An extra curly brace is required for GCC in case the struct contains a union. Signed-off-by: Shashank Ram Tested-by: Yi-Hung Wei --- include/openvswitch/types.h | 5 ++--- 1 file changed, 2 insertions(+), 3

Re: [ovs-dev] [PATCH v2] windows/lib: Fix Windows C++ compilation issues on common headers

2017-11-30 Thread Shashank Ram
On Thu, Nov 30, 2017 at 11:45 AM, Ben Pfaff wrote: > On Wed, Nov 29, 2017 at 05:13:14PM -0800, Sairam Venugopal wrote: > > Found when compiling the code with C++ binaries. Most of the issues are > > due to missing explicit cast. > > > > Signed-off-by: Sairam Venugopal > > Signed-off-by: Shireesh

Re: [ovs-dev] [PATCH v2 6/7] datapath-windows: Fix static analysis warnings around ovsInstanceListLock

2017-11-28 Thread Shashank Ram
ggested by: Shashank Ram r...@vmware.com --- Acked-by: Shashank Ram ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 7/7] datapath-windows: Fix possible NULL dereference in IpFragment

2017-11-28 Thread Shashank Ram
On Nov 6, 2017 9:07 PM, "Alin Gabriel Serdean" wrote: From: Alin Serdean If we can't allocate the NBL just go to the cleanup sequence. Found using WDK 10 static code analysis. Signed-off-by: Alin Gabriel Serdean --- Acked-b

Re: [ovs-dev] [PATCH] datapath-windows: Account for VLAN tag in tunnel Decap

2017-11-28 Thread Shashank Ram
, Alin. > -Original Message- > From: Shashank Ram [mailto:r...@vmware.com] > Sent: Tuesday, November 28, 2017 3:33 PM > To: d...@openvswitch.org; Alin Serdean > > Subject: Re: [ovs-dev] [PATCH] datapath-windows: Account for VLAN tag in >

Re: [ovs-dev] [PATCH] datapath-windows: Account for VLAN tag in tunnel Decap

2017-11-28 Thread Shashank Ram
Alin, do you think it makes sense to also apply this on 2.8? -- Thanks, Shashank On 11/28/17, 11:47 AM, "ovs-dev-boun...@openvswitch.org on behalf of Shashank Ram" wrote: Alin, can we apply this patch? It’s been sitting around in the mailing list for a week without any review

Re: [ovs-dev] [PATCH] datapath-windows: Account for VLAN tag in tunnel Decap

2017-11-27 Thread Shashank Ram
ot;ovs-dev-boun...@openvswitch.org on behalf of Shashank Ram" wrote: Decap functions for tunneling protocols do not compute the packet header offsets correctly when there is a VLAN tag in the L2 header. This results in incorrect checksum computation caus

[ovs-dev] [PATCH] datapath-windows: Account for VLAN tag in tunnel Decap

2017-11-20 Thread Shashank Ram
tunneling protocols. Previously, this would result in packet drops due to invalid checksums being computed. - Verified that non-VLAN tagged packets are handled correctly. Signed-off-by: Shashank Ram --- datapath-windows/ovsext/Geneve.c | 14 + datapath-windows/ovsext/Geneve.h | 6

Re: [ovs-dev] [PATCH v2 5/7] datapath-windows: Fix static analysis warnings in OvsGetTcpPayloadLength

2017-11-06 Thread Shashank Ram
On Mon, Nov 6, 2017 at 7:33 AM, Alin Gabriel Serdean wrote: > From: Alin Serdean > > This fixes the static code analysis over the function > 'OvsGetTcpPayloadLength'. > > Signed-off-by: Alin Gabriel Serdean > --- > v2: No chan

Re: [ovs-dev] [PATCH v2 4/7] datapath-windows: Add assert to ethHdr in OvsActionMplsPush

2017-11-06 Thread Shashank Ram
r + MPLS_HLEN, sizeof(*ethHdr)); > ethHdr->Type = mpls->mpls_ethertype; > > -- > 2.10.2.windows.1 > > ___ > Acked-by: Shashank Ram > ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 3/7] datapath-windows: Vport check RtlStringCbLengthW return value

2017-11-06 Thread Shashank Ram
From: Alin Serdean > > The result of `RtlStringCbLengthW` is not currently checked and triggers > a warning using the WDK 8.1 static analysis. > > This patch treats the result of `RtlStringCbLengthW`. > > Signed-off-by: Alin Gabriel Serdean > --- > v2: s/Fail/Failed. S

Re: [ovs-dev] [PATCH v2 2/7] datapath-windows: prettify logging in iphelper

2017-11-06 Thread Shashank Ram
From: Alin Serdean > > Found by inspection. > > Signed-off-by: Alin Gabriel Serdean > --- > v2: s/Fail/Failed. Suggested by: Shashank Ram r...@vmware.com > --- > Acked-by: Shashank Ram ___ dev mailing list d.

Re: [ovs-dev] [PATCH v2 1/7] datapath-windows: Use only non executable memory

2017-11-06 Thread Shashank Ram
lysis. > > Signed-off-by: Alin Gabriel Serdean > --- > v2: Change OvsGetMdlWithLowPrio to OvsGetMdlWithLowPriority. > Suggested by: Shashank Ram > --- > Acked-by: Shashank Ram ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] datapath-windows: Update OvsCompleteNbl argument to match definition

2017-10-25 Thread Shashank Ram
Update the OvsCompleteNbl to take in a PVOID and explicitly cast to POVS_SWITCH_CONTEXT. This is useful when finding declarations in Visual Studio. The mismatch breaks this functionality. Found by inspection. Signed-off-by: Sairam Venugopal --- Acked-by: Shashank Ram

Re: [ovs-dev] [PATCH] datapath-windows: Update OvsIPv4TunnelKey flags in geneve decap.

2017-10-18 Thread Shashank Ram
On 10/17/17, 5:31 PM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar" wrote: Set the geneve flags OVS_TNL_F_GENEVE_OPT and OVS_TNL_F_CRT_OPT in OvsDecapGeneve, so that windows behavior is similiar to linux https://github.com/openvswitch/ovs/blob/master/datapath/linux/c

[ovs-dev] [PATCH] datapath-windows: Fix bugs in cleaner threads

2017-09-22 Thread Shashank Ram
during driver unload. Testint done: Verified that cleaner threads run as expected without crashing during driver unload. Signed-off-by: Shashank Ram --- datapath-windows/ovsext/Conntrack-related.c | 6 +- datapath-windows/ovsext/Conntrack.c | 6 +- datapath-windows/ovsext

Re: [ovs-dev] [PATCH] tests: Fix sparse error on test-ovn.c

2017-09-11 Thread Shashank Ram
;0'. Signed-off-by: Alin Gabriel Serdean --- Acked-by: Shashank Ram ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] datapath-windows: Increment ct packet counters based on ct_state.

2017-09-06 Thread Shashank Ram
does not make sense to style the CT code differently than the rest of the Windows data path code. --- Acked-by: Shashank Ram From: ovs-dev-boun...@openvswitch.org on behalf of Shashank Ram Sent: Tuesday, September 5, 2017 7:47:21 PM To: Anand Kumar

Re: [ovs-dev] [PATCH] datapath-windows: Increment ct packet counters based on ct_state.

2017-09-05 Thread Shashank Ram
Comments inline. Subject: [ovs-dev] [PATCH] datapath-windows: Increment ct packet counters based on ct_state. For a given packet, packet counters in conntrack should be accounted only once, even if the packet is processed multiple times by conntra

Re: [ovs-dev] [PATCH v2] datapath-windows: Add an upper limit to conntrack entries

2017-09-01 Thread Shashank Ram
--- Subject: [ovs-dev] [PATCH v2] datapath-windows: Add an upper limit to conntrack entries The current implementation lacked an upper bound of number of entries in the system. Set the size to ~2M (2^21) for the time being. Signed-off-by: Sairam Venugopal --- Acked-by: Shashank Ram

Re: [ovs-dev] [PATCH] datapath-windows: Remove unnecessary call to OvsInitForwardingCtx

2017-08-30 Thread Shashank Ram
Subject: [ovs-dev] [PATCH] datapath-windows: Remove unnecessary call to OvsInitForwardingCtx Only curNbl in the forwarding context needs to be updated with fragmented NBL. Signed-off-by: Anand Kumar ___ Acked-by: Shashank Ram

Re: [ovs-dev] [PATCH v2] datapath-windows: Add an upper limit to conntrack entries

2017-08-30 Thread Shashank Ram
/Conntrack.c | 10 ++ datapath-windows/ovsext/Conntrack.h | 1 + 2 files changed, 11 insertions(+) ___ Acked-by: Shashank Ram ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman

Re: [ovs-dev] [PATCH] datapath-windows: Add an upper limit to conntrack entries

2017-08-30 Thread Shashank Ram
in the system. Set the size to ~2M (2^21) for the time being. Signed-off-by: Sairam Venugopal ___ Acked-by: Shashank Ram ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman

Re: [ovs-dev] [PATCH] datapath-windows: Add an upper limit to conntrack entries

2017-08-29 Thread Shashank Ram
___ >From: ovs-dev-boun...@openvswitch.org on >behalf of Sairam Venugopal >Sent: Monday, August 28, 2017 4:56 PM >To: d...@openvswitch.org >Subject: [ovs-dev] [PATCH] datapath-windows: Add an upper limit to conntrack > entries > >The current implementati

Re: [ovs-dev] [PATCH] datapath-windows: Add an upper limit to conntrack entries

2017-08-28 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Sairam Venugopal Sent: Monday, August 28, 2017 4:56 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH] datapath-windows: Add an upper limit to conntrack entries The current implementation lack

Re: [ovs-dev] [PATCH 00/40] Fix static code analysis warnings.

2017-08-24 Thread Shashank Ram
> From: ovs-dev-boun...@openvswitch.org on > behalf of Ben Pfaff > Sent: Wednesday, August 2, 2017 11:35 AM > To: Alin Serdean > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 00/40] Fix static code analysis warnings. > > On Fri, Jul 14, 2017

Re: [ovs-dev] [PATCH 00/40] Fix static code analysis warnings.

2017-08-24 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff Sent: Wednesday, August 2, 2017 11:35 AM To: Alin Serdean Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH 00/40] Fix static code analysis warnings. On Fri, Jul 14, 2017 at 04:40:51AM +

Re: [ovs-dev] [PATCH 00/40] Fix static code analysis warnings.

2017-08-24 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff Sent: Wednesday, August 2, 2017 11:35 AM To: Alin Serdean Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH 00/40] Fix static code analysis warnings. On Fri, Jul 14, 2017 at 04:40:51AM +

[ovs-dev] [PATCH] datapath-windows: Move OvsCreateNewNBLsFromMultipleNBs to BuggerMgmt

2017-08-21 Thread Shashank Ram
Moves function OvsCreateNewNBLsFromMultipleNBs() to BufferMgmt.c to facilitate consumption from outside PacketIO.c. Signed-off-by: Shashank Ram --- datapath-windows/ovsext/BufferMgmt.c | 47 datapath-windows/ovsext/BufferMgmt.h | 4 +++ datapath-windows

Re: [ovs-dev] [PATCH v2] datapath-windows: Do not modify port field for ICMP during SNAT/DNAT

2017-08-17 Thread Shashank Ram
icmp_id field during SNAT/DNAT only for ICMP traffic The current NAT module doesn't take the ICMP type/code into account during the lookups. Fix this to make it similar with the other conntrack module. Signed-off-by: Anand Kumar --- ___ Acked-by: Sha

Re: [ovs-dev] [PATCH v3] datapath-windows: Update Orig Tuple to use ICMP Type and Code

2017-08-17 Thread Shashank Ram
for the ct_endpoint's union, so that each member of ct_endpoint's union are of same size. Co-authored-by: Sairam Venugopal Signed-off-by: Anand Kumar --- ___ Acked-by: Shashank Ram ___ dev mail

Re: [ovs-dev] [PATCH v2] datapath-windows: Update Orig Tuple to use ICMP Type and Code

2017-08-16 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar Sent: Tuesday, August 15, 2017 3:23 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH v2] datapath-windows: Update Orig Tuple to use ICMP Type and Code - Also add in some padding

Re: [ovs-dev] [PATCH] datapath-windows: Do not modify port field for ICMP during SNAT/DNAT

2017-08-10 Thread Shashank Ram
icmp_id field during SNAT/DNAT only for ICMP traffic The current NAT module doesn't take the ICMP type/id/code into account during the lookups. Fix this to make it similar with the other conntrack module. Signed-off-by: Anand Kumar ___ Acked-by: Sha

Re: [ovs-dev] DNS support options

2017-08-08 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Lance Richardson Sent: Tuesday, August 8, 2017 11:59 AM To: Ben Pfaff Cc: d...@openvswitch.org Subject: Re: [ovs-dev] DNS support options > From: "Ben Pfaff" > To: d...@openvswitch.org > Sent: Tuesd

Re: [ovs-dev] [PATCH v2] datapath-windows: Refactor OvsCreateNewNBLsFromMultipleNBs

2017-08-01 Thread Shashank Ram
Guru, could you please apply this patch. Thanks, Shashank From: Anand Kumar Sent: Thursday, July 27, 2017 4:48:02 PM To: Shashank Ram; d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH v2] datapath-windows: Refactor OvsCreateNewNBLsFromMultipleNBs

Re: [ovs-dev] [PATCH] datapath-windows: Fix conntrack lookups for reversed keys

2017-08-01 Thread Shashank Ram
y->key)) { +if (OvsCtKeyAreSame(revCtxKey, entry->key)) { found = entry; reply = TRUE; break; -- 2.9.3.windows.1 _______ Acked-by: Shashank Ram __

[ovs-dev] [PATCH v2] datapath-windows: Refactor OvsCreateNewNBLsFromMultipleNBs

2017-07-24 Thread Shashank Ram
, and it returns a linked list of NBLs and sets the HEAD and TAIL of the new list obtained from the curNbl. If the caller wants to chain a new linked list at the HEAD or TAIL, it can make use of the curNbl and lastNbl to do so. Signed-off-by: Shashank Ram --- datapath-windows/ovsext/PacketIO.c | 20

Re: [ovs-dev] [PATCH] datapath-windows: Fix a bug in OvsCreateNewNBLsFromMultipleNBs()

2017-07-24 Thread Shashank Ram
I will hold onto this patch a bit longer. Noticed that there are other bugs that get exposed as a result of this bug fix. Will send out a v2. Thanks, Shashank From: Shashank Ram Sent: Friday, July 21, 2017 11:57:44 AM To: d...@openvswitch.org Cc

[ovs-dev] [PATCH] datapath-windows: Fix a bug in OvsCreateNewNBLsFromMultipleNBs()

2017-07-21 Thread Shashank Ram
While creating a new NBL chain with 1 NB per NBL, from an NBL that contains multiple NBs, the new NBL chain was being broken, as a result leaking packets. Signed-off-by: Shashank Ram --- datapath-windows/ovsext/PacketIO.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [ovs-dev] [PATCH 00/40] Fix static code analysis warnings.

2017-07-14 Thread Shashank Ram
Alin, thanks a lot for this important series! Could you please test out all these changes with Driver verifier and ensure that it does not introduce new regressions such as memory leaks, deadlocks etc. Thanks, Shashank From: ovs-dev-boun...@openvswitch.o

Re: [ovs-dev] [PATCH 37/40] datapath-windows: Add annotation for OvsIpFragmentEntryCleaner

2017-07-14 Thread Shashank Ram
OvsIpFragmentEntryDelete(POVS_IPFRAG_ENTRY entry, BOOLEAN checkExpiry); /* Global and static variables */ -- 2.10.2.windows.1 ___ Acked-by: Shashank Ram ___ dev mailing list d...@openvswitch.org https

Re: [ovs-dev] [PATCH 35/40] datapath-windows: Treat TCP_HDR_LEN static analysis warnings

2017-07-14 Thread Shashank Ram
windows.1 ___ Acked-by: Shashank Ram ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 40/40] datapath-windows: Fix static analysis warnings around ovsInstanceListLock

2017-07-14 Thread Shashank Ram
Comments inline. Thanks, Shashank From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH 40/40] datapath-windows: Fix static analysis warnings around ovsI

Re: [ovs-dev] [PATCH 32/40] datapath-windows: fix excessive stack usage in iphelper

2017-07-14 Thread Shashank Ram
Neigh(internalRow, +status = OvsGetOrResolveIPNeigh(&instance->internalRow, ipAddr, &ipNeigh); OvsUpdateIPNeighEntry(ipAddr, &ipNeigh, status); -- 2.10.2.windows.1 ___ Acked-by: Shashank Ram _

Re: [ovs-dev] [PATCH 38/40] datapath-windows: Fix shared variables which use Interlocked functions

2017-07-14 Thread Shashank Ram
-- 2.10.2.windows.1 ___ Acked-by: Shashank Ram ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 36/40] datapath-windows: Add annotation for OvsCtRelatedEntryCleaner

2017-07-14 Thread Shashank Ram
{ -- 2.10.2.windows.1 ___ Acked-by: Shashank Ram ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 33/40] datapath-windows: Check return status when using APIs

2017-07-14 Thread Shashank Ram
text == NULL || !NT_SUCCESS(status)) { goto error; } NdisAcquireRWLockRead(gOvsSwitchContext->dispatchLock, &lockState, 0); -- 2.10.2.windows.1 ___ Acked-by: Shashank Ram ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 34/40] datapath-windows: Vport check RtlStringCbLengthW return value

2017-07-14 Thread Shashank Ram
gt;> s/Fail/Failed +return status; +} portFriendlyName->Length = (USHORT)len; } else { OVS_LOG_ERROR("Fail to convert interface LUID to alias, status: %x", -- 2.10.2.windows.1 _____

Re: [ovs-dev] [PATCH 31/40] datapath-windows: prettify logging in iphelper

2017-07-14 Thread Shashank Ram
il to register UNICAST IP change, status: %x.", >> s/Fail/Failed + status); } register_cleanup: if (status != STATUS_SUCCESS) { -- 2.10.2.windows.1 _______ Acked-by: Shashank Ram ___

Re: [ovs-dev] [PATCH 30/40] datapath-windows: Add dummy parameter for NotifyRouteChange2

2017-07-14 Thread Shashank Ram
ummy, TRUE, &ipRouteNotificationHandle); if (status != STATUS_SUCCESS) { OVS_LOG_ERROR("Fail to regiter ip route change, status: %x.", -- 2.10.2.windows.1 ___ Acke

Re: [ovs-dev] [PATCH 26/40] datapath-windows: Use annotations instead for macros

2017-07-14 Thread Shashank Ram
gnedMemory(size_t size, UINT16 align); + VOID *OvsAllocateMemoryPerCpu(size_t size, size_t count, ULONG tag); VOID OvsFreeMemory(VOID *ptr); VOID OvsFreeMemoryWithTag(VOID *ptr, ULONG tag); -- 2.10.2.windows.1 _______ Acked-by: Shashank Ram

Re: [ovs-dev] [PATCH 19/40] datapath-windows: Add function annotations for OvsTunnelFilterCancelIrp

2017-07-14 Thread Shashank Ram
); +DRIVER_CANCEL OvsTunnelFilterCancelIrp; /* * Callout driver global variables -- 2.10.2.windows.1 ___ Acked-by: Shashank Ram ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org

Re: [ovs-dev] [PATCH 29/40] datapath-windows: Suppress warning in jhash

2017-07-14 Thread Shashank Ram
]; JhashFinal(&a, &b, &c); } -- 2.10.2.windows.1 ___ Acked-by: Shashank Ram ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 01/40] datapath-windows: Use only non executable memory

2017-07-14 Thread Shashank Ram
Comments inline. Thanks, Shashank From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH 01/40] datapath-windows: Use only non executable memory Use

Re: [ovs-dev] [PATCH 28/40] datapath-windows: Fix possible NULL deference in OvsFullCopyNBL

2017-07-14 Thread Shashank Ram
) == NULL) { return OvsCopySinglePacketNBL(context, nbl, nb, headRoom, copyNblInfo); -- 2.10.2.windows.1 ___ Acked-by: Shashank Ram ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org

Re: [ovs-dev] [PATCH 21/40] datapath-windows: Add function annotations for OvsAcquireEventQueueLock

2017-07-14 Thread Shashank Ram
(eventQueueLockArr[eventId]) static __inline VOID OvsAcquireEventQueueLock(int eventId) { -- 2.10.2.windows.1 ___ Acked-by: Shashank Ram ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman

Re: [ovs-dev] [PATCH 17/40] datapath-windows: Add function annotations for OvsReleaseDatapath

2017-07-14 Thread Shashank Ram
dows.1 ___ Acked-by: Shashank Ram ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 25/40] datapath-windows: Fix spelling for OvsTunnelFilterSetIrpContext

2017-07-14 Thread Shashank Ram
.windows.1 ___ Acked-by: Shashank Ram ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 27/40] datapath-windows: Add assert in OvsPartialCopyNBL

2017-07-14 Thread Shashank Ram
); OvsInitNBLContext(dstCtx, flags, NET_BUFFER_DATA_LENGTH(srcNb) - copySize, OVS_DPPORT_NUMBER_INVALID); -- 2.10.2.windows.1 ___ Acked-by: Shashank Ram ___ dev mailing list d

Re: [ovs-dev] [PATCH 24/40] datapath-windows: Add annotations for OvsAcquirePidHashLock

2017-07-14 Thread Shashank Ram
(DISPATCH_LEVEL) +_IRQL_saves_global_(OldIrql, gOvsSwitchContext->pidHashLock) +_Acquires_lock_(gOvsSwitchContext->pidHashLock) static __inline VOID OvsAcquirePidHashLock() { -- 2.10.2.windows.1 ___ Acked-by: Shasha

Re: [ovs-dev] [PATCH 18/40] datapath-windows: Add function annotations for OvsCancelIrp

2017-07-14 Thread Shashank Ram
; NTSTATUS OvsInitEventQueue() -- 2.10.2.windows.1 ___ Acked-by: Shashank Ram ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 16/40] datapath-windows: Add function annotations for OvsAcquireDatapathWrite

2017-07-14 Thread Shashank Ram
(DISPATCH_LEVEL) +_IRQL_saves_global_(OldIrql, lockState) +_Acquires_lock_(datapath->lock) static __inline VOID OvsAcquireDatapathWrite(OVS_DATAPATH *datapath, LOCK_STATE_EX *lockState, -- 2.10.2.windows.1 ___ Acked-by: Shashank

Re: [ovs-dev] [PATCH 23/40] datapath-windows: Add annotations for OvsReleasePidHashLock

2017-07-14 Thread Shashank Ram
2.10.2.windows.1 ___ Acked-by: Shashank Ram ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 22/40] datapath-windows: Add annotations for OvsReleaseEventQueueLock

2017-07-14 Thread Shashank Ram
ws.1 ___ Acked-by: Shashank Ram ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 14/40] datapath-windows: Remove function declarations from Tunnel.c

2017-07-14 Thread Shashank Ram
); -VOID OvsReleaseDatapath(OVS_DATAPATH *datapath, -LOCK_STATE_EX *lockState); - - NTSTATUS OvsTunnelNotify(FWPS_CALLOUT_NOTIFY_TYPE notifyType, const GUID *filterKey, -- 2.10.2.windows.1 ___ Acked-by: Shashank Ram

Re: [ovs-dev] [PATCH 12/40] datapath-windows: Add annotations for OvsAcquireCtrlLock

2017-07-14 Thread Shashank Ram
: Shashank Ram ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 20/40] datapath-windows: Add function annotations for OvsCancelIrpDatapath

2017-07-14 Thread Shashank Ram
OvsAcquirePidHashLock() -- 2.10.2.windows.1 ___ Acked-by: Shashank Ram ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

  1   2   >