Hi Ben:
>>You added two copies of the following.
>>+ if (!uuid_from_string(uuid_from_cmd, row_uuid)) {
>>+ ctl_error(ctx, "row-uuid '%s' is not a valid UUID", row_uuid);
>>+ return;
>>+ }
This check block has been moved outside for v8. So there is only one uuid check
block now.
Hi Ben:
Thanks!
The answer is as below:
>Command line option names never contain _. Use - instead.
Already fixed in v7
>This introduces duplicate code blocks into cmd_create(). Don't do that.
We can't understand: do you mean that the row-uuid code block under if(id) is
for "update" operatoin. Can you give me some
advice ?
Thanks
Timo
Re: Re: [ovs-dev] [PATCH v5] db-ctl-base: add uuid specified method for create
cmdOn Mon, Mar 16, 2020 at 09:31:48AM +0800, Timo_Liu wrote:
> One point that we should confirm with you: if --id amp;amp;
>
Hi Ben:
Thanks for reviewing!
One point that we should confirm with you: if --id --row-uuid
both specified, we should use UUID from --row-uuid to create table, am I right ?
Also, we should add test in which ovsdb unit test file ?(ovs-vsctl.at or
ovsdb-execution.at)
This commit fixes potential unintended mistake in userspace-tunneling guide:
for the example in userspace-tunneling guide, there is no bridge named
"br-eth1", but only a bridge name "br-phy" which has a port named "eth1"
Signed-off-by: Liu Chang
diff --git
v2->v3: reformat patch from git record
Signed-off-by: Liu Chang
diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
index 01e9004..ab3f82b 100644
--- a/lib/netdev-offload-dpdk.c
+++ b/lib/netdev-offload-dpdk.c
@@ -433,7 +433,10 @@ netdev_offload_dpdk_add_flow(struct
Sorry , I forgot to reformat it in my mail sender.
v1->v2: format patch in raw text
Signed-off-by: Liu Chang
diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
index 01e9004..ab3f82b 100644
--- a/lib/netdev-offload-dpdk.c
+++ b/lib/netdev-offload-dpdk.c
@@ -433,7 +433,10 @@
(match->wc.masks.tp_src ||
Best Regards
Timo_liu
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
