Re: [ovs-dev] [PATCH ovn] northd: Add support for DHCP Option 12 (Hostname)

2021-06-15 Thread Vladislav Odintsov
, which differ only in hostnames. Let me know your thoughts on this, please. Regards, Vladislav Odintsov > On 14 Jun 2021, at 21:29, Numan Siddique wrote: > > On Fri, May 28, 2021 at 7:32 AM Vladislav Odintsov <mailto:odiv...@gmail.com>> wrote: >> >>

Re: [ovs-dev] [PATCH v2 ovn] ovn-controller-vtep: Fix MMR create/update

2021-06-15 Thread Vladislav Odintsov
Hi, I’ve posted a new version of this patch: https://patchwork.ozlabs.org/project/ovn/list/?series=248346 Regards, Vladislav Odintsov > On 11 Jun 2021, at 01:45, Ben Pfaff wrote: > > On Fri, Jun 11, 2021 at 12:13:46AM +0200, Dumitru Ceara wrote: >> On 6/10/21 11:47 PM,

[ovs-dev] [PATCH ovn v2] northd: Add support for DHCP Option 12 (Hostname)

2021-06-15 Thread Vladislav Odintsov
DHCP option Hostname (opcode 12) can be configured in Logical_Switch_Port as well as in DHCP_Options table's options:hostname column. If both methods of configuration were used, Logical_Switch_Port's setting takes precedence. Signed-off-by: Vladislav Odintsov --- v1 -> v2 * Adde

Re: [ovs-dev] [PATCH ovn] northd: Add support for DHCP Option 12 (Hostname)

2021-06-15 Thread Vladislav Odintsov
new to mail list patches submission :) How can I close previous patch versions in patchwork? Regards, Vladislav Odintsov > On 15 Jun 2021, at 15:35, Numan Siddique wrote: > > On Tue, Jun 15, 2021 at 5:00 AM Vladislav Odintsov wrote: >> >> Hi Numan, >> >> Th

[ovs-dev] [PATCH ovn v3] northd: Add support for DHCP Option 12 (Hostname)

2021-06-15 Thread Vladislav Odintsov
DHCP option Hostname (opcode 12) can be configured in Logical_Switch_Port as well as in DHCP_Options table's options:hostname column. If both methods of configuration were used, Logical_Switch_Port's setting takes precedence. Signed-off-by: Vladislav Odintsov --- v2 -> v3 * Fixed

[ovs-dev] [PATCH ovn v4 0/2] controller-vtep: Fix MMR creation and commit only changed data

2021-06-15 Thread Vladislav Odintsov
ssed review comments from Dumitru and Ben. * Split optimization code to separate patch. v1 -> v2 * Fixed formatting. Vladislav Odintsov (2): controller-vtep: fix mmr and physical locators create/update ovn-controller-vtep: update tunnel_key and replication_mode only if needed c

[ovs-dev] [PATCH ovn v3 2/2] controller-vtep: Update tunnel_key and replication_mode if needed

2021-06-15 Thread Vladislav Odintsov
Signed-off-by: Vladislav Odintsov Acked-by: Dumitru Ceara --- controller-vtep/vtep.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/controller-vtep/vtep.c b/controller-vtep/vtep.c index 49723b39d..314cc4eae 100644 --- a/controller-vtep/vtep.c +++ b

[ovs-dev] [PATCH ovn v4 1/2] controller-vtep: fix mmr and physical locators create/update

2021-06-15 Thread Vladislav Odintsov
locators for associated datapath are changed. Next, this newly-created physical locator set is updated in the MMR record. Signed-off-by: Vladislav Odintsov Acked-by: Dumitru Ceara --- controller-vtep/vtep.c | 54 tests/ovn-controller-vtep.at | 70

Re: [ovs-dev] [PATCH ovn v3 1/2] controller-vtep: Fix MMR and physical locators create/update

2021-06-15 Thread Vladislav Odintsov
Hi Dumitru, Thanks for the review, new patch is submitted to the list. Regards, Vladislav Odintsov > On 15 Jun 2021, at 18:50, Dumitru Ceara wrote: > > On 6/11/21 1:44 PM, Vladislav Odintsov wrote: >> Before this patch ovn-controller-vtep created Mcast_Macs_Remote >>

Re: [ovs-dev] [PATCH ovn v4 0/2] controller-vtep: Fix MMR creation and commit only changed data

2021-06-15 Thread Vladislav Odintsov
manual work later for us to make backport in our fork. :) Actually I was going to send backport down to stable branches (21.06->20.03). These patches should cleanly apply on all the branches, let me know if I have to send backports or you can do it by yourself. Regards, Vladislav Odintsov &

[ovs-dev] [ovn] howto? L3 support in HW VTEP

2021-06-18 Thread Vladislav Odintsov
answer such ARP request? Thanks. Regards, Vladislav Odintsov ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [ovn] howto? L3 support in HW VTEP

2021-06-18 Thread Vladislav Odintsov
When physical host sends traffic to its chassis, routing between sw1 and sw2 works. gateway chassis: [9721a9e9-73ef-4a9a-8a50-afa84811c6ef] OVN NB DB is in attachment. Regards, Vladislav Odintsov > On 18 Jun 2021, at 21:27, Numan Siddique wrote: > > On Fri, Jun 18, 20

Re: [ovs-dev] [PATCH ovn v3] northd: Add support for DHCP Option 12 (Hostname)

2021-06-22 Thread Vladislav Odintsov
Thanks Numan for adding ddlog support here and additional tests as well. Okay, I’ll try to do it by myself next time, if any. Regards, Vladislav Odintsov > On 22 Jun 2021, at 13:47, Numan Siddique wrote: > > On Tue, Jun 15, 2021 at 11:34 AM Vladislav Odintsov <mailto:odiv...@gmail

Re: [ovs-dev] [ovn] howto? L3 support in HW VTEP

2021-06-25 Thread Vladislav Odintsov
Hi Numan, did you have a chance to look at db dump? Regards, Vladislav Odintsov > On 18 Jun 2021, at 23:34, Vladislav Odintsov wrote: > > Sorry, there was a typo. > Sure, VM has IP 192.168.1.2/24 and host 192.168.2.2/24. > > [root@ovn-1 ~]# ovn-nbctl show > switch 8e

Re: [ovs-dev] [ovn] howto? L3 support in HW VTEP

2021-07-01 Thread Vladislav Odintsov
I looked at the patch and couldn’t understand how to use it in my case. Can you clarify your idea please? Regards, Vladislav Odintsov > On 28 Jun 2021, at 23:34, Numan Siddique wrote: > > On Fri, Jun 25, 2021 at 4:13 AM Vladislav Odintsov <mailto:odiv...@gmail.com>> wrot

[ovs-dev] [ovn] branch-20.09 tests fail with OVS higher than 2.14.0

2021-07-08 Thread Vladislav Odintsov
, with which branch-20.09 can be built - 2.14.0. 4. It is not clear which OVN versions are suppoted/LTS. Does OVN project have such decisions? 5. It is not also clear to understand the upgrade policy. Should administrator upgrade to each major OVN version or some versions can be skipped especiall

[ovs-dev] [PATCH ovn branch-20.09] ovn-controller: Monitor chassis_private by chassis name.

2021-07-09 Thread Vladislav Odintsov
From: Dumitru Ceara Remove the use of sbrec_chassis_is_new() for uncommitted records. This is not the way IDL *_is_new() functions are supposed to be used. Note: With this change if the system-id changes there will be a transient error in ovn-controller due to ovn-controller trying to insert a

Re: [ovs-dev] [PATCH ovn branch-20.09] ovn-controller: Monitor chassis_private by chassis name.

2021-07-09 Thread Vladislav Odintsov
Acked-by: Vladislav Odintsov Regards, Vladislav Odintsov > On 9 Jul 2021, at 16:10, Vladislav Odintsov wrote: > > From: Dumitru Ceara > > Remove the use of sbrec_chassis_is_new() for uncommitted records. This > is not the way IDL *_is_new() functions are supposed to

Re: [ovs-dev] [PATCH ovn branch-20.09] ovn-controller: Monitor chassis_private by chassis name.

2021-07-09 Thread Vladislav Odintsov
Signed-off-by: Vladislav Odintsov Regards, Vladislav Odintsov > On 9 Jul 2021, at 16:55, Vladislav Odintsov wrote: > > Acked-by: Vladislav Odintsov > > Regards, > Vladislav Odintsov > >> On 9 Jul 2021, at 16:10, Vladislav Odintsov wrote: >> >> Fro

Re: [ovs-dev] [ovn] branch-20.09 tests fail with OVS higher than 2.14.0

2021-07-13 Thread Vladislav Odintsov
Hi Dumitru, Numan, Regards, Vladislav Odintsov > On 12 Jul 2021, at 21:39, Numan Siddique wrote: > > On Fri, Jul 9, 2021 at 9:01 AM Dumitru Ceara <mailto:dce...@redhat.com>> wrote: >> >> On 7/8/21 6:34 PM, Vladislav Odintsov wrote: >>> Hi, >> &

Re: [ovs-dev] [ovn] howto? L3 support in HW VTEP

2021-07-13 Thread Vladislav Odintsov
Hi Numan, could you please look at my case if you have time? Earlier I’ve sent you NB DB dump. Thanks in advance. Regards, Vladislav Odintsov > On 1 Jul 2021, at 11:44, Vladislav Odintsov wrote: > > I looked at the patch and couldn’t understand how to use it in my case. > Can

Re: [ovs-dev] [ovn] Is ovn-interconnection gateway required to be a dedicated node?

2021-07-13 Thread Vladislav Odintsov
Hi, maybe somebody from dev list can take a look and knows an answer? Thanks in advance. Regards, Vladislav Odintsov > On 7 Jul 2021, at 19:32, Vladislav Odintsov wrote: > > Hi all, > > I’ve tried to setup OVN interconnection with only two ovn-controller nodes > (each i

Re: [ovs-dev] [ovn] branch-20.09 tests fail with OVS higher than 2.14.0

2021-07-16 Thread Vladislav Odintsov
to update GH Actions with new inputs when I understand these questions. Regards, Vladislav Odintsov > On 16 Jul 2021, at 17:57, Numan Siddique wrote: > > On Tue, Jul 13, 2021 at 2:00 PM Vladislav Odintsov <mailto:odiv...@gmail.com>> wrote: >> >> Hi Dumitru, Numan,

[ovs-dev] [PATCH ovn] controller-vtep: fix mmr and physical locators create/update

2021-05-27 Thread Vladislav Odintsov
locators for associated datapath are changed. Next, this newly-created physical locator set is updated in the MMR record. Also, update logical switch's tunnel key and replication method only if needed. Signed-off-by: Vladislav Odintsov --- controller-vtep/vtep.c

[ovs-dev] [PATCH v2 ovn] ovn-controller-vtep: Fix MMR create/update

2021-05-28 Thread Vladislav Odintsov
locators for associated datapath are changed. Next, this newly-created physical locator set is updated in the MMR record. Also, update logical switch's tunnel key and replication method only if needed. Signed-off-by: Vladislav Odintsov --- controller-vtep/vtep.c

[ovs-dev] [PATCH ovn] northd: Add support for DHCP Option 12 (Hostname)

2021-05-28 Thread Vladislav Odintsov
DHCP Option Hostname is a per-Logical_Switch_Port property, configured in Logical_Switch_Port's options:hostname field. It is used if DHCPv4 is enabled for this LSP. Signed-off-by: Vladislav Odintsov --- The implementation for ovn-northd-ddlog is absent, it needs help from somebody,

Re: [ovs-dev] [PATCH v2 ovn] ovn-controller-vtep: Fix MMR create/update

2021-06-10 Thread Vladislav Odintsov
Hi Dumitru, First of all, thanks for the review. My comments are inline. Regards, Vladislav Odintsov > On 10 Jun 2021, at 18:50, Dumitru Ceara wrote: > > On 5/28/21 10:21 AM, Vladislav Odintsov wrote: >> Before this patch ovn-controller-vtep created Mcast_Macs_Remote >>

Re: [ovs-dev] [PATCH v2 ovn] ovn-controller-vtep: Fix MMR create/update

2021-06-10 Thread Vladislav Odintsov
master branch I should only use new-style and then rewrite it while backporting? Regards, Vladislav Odintsov > On 10 Jun 2021, at 21:18, Dumitru Ceara wrote: > > On 6/10/21 7:57 PM, Vladislav Odintsov wrote: > > [...] > >>>> >>>> @@ -231,13 +239,19

[ovs-dev] [PATCH ovn v3 0/2] controller-vtep: Fix MMR creation and commit only changed data

2021-06-11 Thread Vladislav Odintsov
mization code to separate patch. v1 -> v2 * Fixed formatting. Vladislav Odintsov (2): controller-vtep: Fix MMR and physical locators create/update controller-vtep: Update tunnel_key and replication_mode if needed controller-vtep/vtep.c | 79 +---

[ovs-dev] [PATCH ovn v3 2/2] controller-vtep: Update tunnel_key and replication_mode if needed

2021-06-11 Thread Vladislav Odintsov
Signed-off-by: Vladislav Odintsov --- controller-vtep/vtep.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/controller-vtep/vtep.c b/controller-vtep/vtep.c index 49723b39d..314cc4eae 100644 --- a/controller-vtep/vtep.c +++ b/controller-vtep/vtep.c

[ovs-dev] [PATCH ovn v3 1/2] controller-vtep: Fix MMR and physical locators create/update

2021-06-11 Thread Vladislav Odintsov
locators for associated datapath are changed. Next, this newly-created physical locator set is updated in the MMR record. Signed-off-by: Vladislav Odintsov --- controller-vtep/vtep.c | 60 ++- tests/ovn-controller-vtep.at | 70 2

[ovs-dev] [ovn] bug: load balancer health check status is not updated if port binding is released from chassis

2022-07-04 Thread Vladislav Odintsov
-id # ensure state remains online sleep 10 ovn-sbctl list service_mon # ensure OVS group and backend is still in bucket ovs-ofctl dump-groups br-int | grep 192.168.0.10 Looking forward to hear any thoughts on this. PS. don’t forget to kill ncat

Re: [ovs-dev] [ovn] bug: load balancer health check status is not updated if port binding is released from chassis

2022-07-04 Thread Vladislav Odintsov
Thanks Numan, would you have time to fix it or maybe give an idea how to do it, so I can try? Regards, Vladislav Odintsov > On 4 Jul 2022, at 19:51, Numan Siddique wrote: > > On Mon, Jul 4, 2022 at 7:48 AM Vladislav Odintsov <mailto:odiv...@gmail.com>> wrote: >> >

[ovs-dev] [PATCH RFC ovn] northd: reset svc_mon status to offline if port_binding is released

2022-07-05 Thread Vladislav Odintsov
Signed-off-by: Vladislav Odintsov --- northd/northd.c | 14 ++ tests/system-ovn.at | 13 - 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/northd/northd.c b/northd/northd.c index 964af992f..4f8f1aaf9 100644 --- a/northd/northd.c +++ b/northd/northd.c

Re: [ovs-dev] [ovn] bug: load balancer health check status is not updated if port binding is released from chassis

2022-07-05 Thread Vladislav Odintsov
c->logical_port: sw1-p1, svc->status: online I guess this is a result of my misunderstanding of principle of incremental engine operation. Can you help to get an idea of why port_binding structure has stale state and how to "pull changes" for it? Regards, Vladislav Odintsov >

[ovs-dev] [PATCH ovn] northd: set svc_mon status to offline if port_binding released

2022-07-05 Thread Vladislav Odintsov
/ovs-dev/2022-July/395504.html Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2103740 Signed-off-by: Vladislav Odintsov --- northd/northd.c | 7 +++ tests/ovn-northd.at | 33 - tests/system-ovn.at | 11 ++- 3 files changed, 37 insertions(

Re: [ovs-dev] [ovn] bug: load balancer health check status is not updated if port binding is released from chassis

2022-07-05 Thread Vladislav Odintsov
Thanks Numan for the hint. I’ve submitted the full patch here: https://patchwork.ozlabs.org/project/ovn/patch/20220705175154.3095150-1-odiv...@gmail.com/ It would be great if you can find some time for review. Thanks. Regards, Vladislav Odintsov > On 5 Jul 2022, at 18:44, Numan Siddique wr

Re: [ovs-dev] [PATCH ovn] northd: set svc_mon status to offline if port_binding released

2022-07-07 Thread Vladislav Odintsov
Thanks Numan. Regards, Vladislav Odintsov > On 7 Jul 2022, at 19:57, Numan Siddique wrote: > > On Tue, Jul 5, 2022 at 1:54 PM Vladislav Odintsov <mailto:odiv...@gmail.com>> wrote: >> >> This patch fixes situation where a Load Balancer >> has correspo

[ovs-dev] openstack/ovsdbapp changes

2022-07-12 Thread Vladislav Odintsov
Hi, I’m interested whether changes to ovsdbapp repository are still accepted? We’ve got some [1], but the review process is on hold for a long time. Thanks. 1: https://review.opendev.org/q/owner:dragen15051%2540gmail.com+status:open Regards, Vladislav Odintsov

[ovs-dev] [PATCH ovn] northd: add support to make l3dgw ports fully distributed

2022-07-19 Thread Vladislav Odintsov
This is used when traffic from HW VTEP goes to routable networks and logical switch to which VTEP logical port is attached also needs to support distributed routing features such as NAT and others. Signed-off-by: Vladislav Odintsov --- northd/northd.c | 8 +++- ovn-nb.xml | 10

[ovs-dev] [PATCH ovn] controller: fix typo in get_lport_type_str()

2022-07-19 Thread Vladislav Odintsov
Signed-off-by: Vladislav Odintsov --- controller/binding.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/controller/binding.c b/controller/binding.c index 9faef02dd..ba803ae3e 100644 --- a/controller/binding.c +++ b/controller/binding.c @@ -881,7 +881,7

[ovs-dev] [ovn] Need advice for multiple routing tables support in LR

2021-08-05 Thread Vladislav Odintsov
that route is global for LR (current behaviour), and when there is a string with route_table name Regards, Vladislav Odintsov - add new stage in logical router ingress pipeline right before lr_in_ip_routing - lr_in_ip_routing_pre. In this stage packets are checked against inport and

[ovs-dev] [PATCH ovn] ic: learn routes to LR only from corresponding transit switch

2021-08-09 Thread Vladislav Odintsov
: Vladislav Odintsov --- This bugfix should have no conflicts to all branches, so it's reasonable to apply it down to supported branches. --- ic/ovn-ic.c | 4 +++- tests/ovn-ic.at | 34 ++ 2 files changed, 37 insertions(+), 1 deletion(-) diff --git a/ic/ovn

Re: [ovs-dev] [ovn] Need advice for multiple routing tables support in LR

2021-08-10 Thread Vladislav Odintsov
nstance, reg7) in one stage prior to lr_in_ip_routing? If yes, I think we should fix router’s registers usage documentation: xxreg0: ">= IP_INPUT" -> ">= DEFRAG" xxreg1: ">= IP_INPUT" -> ">= IP_ROUTING" Right? Regards, Vladislav Odintso

[ovs-dev] [PATCH ovn] northd: fix xxreg{0, 1} registers usage description in router pipeline

2021-08-10 Thread Vladislav Odintsov
wrongly pointed to lr_in_ip_input router stage. Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2021-August/386607.html Signed-off-by: Vladislav Odintsov --- northd/ovn-northd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/northd/ovn-northd.c b/northd/ovn

Re: [ovs-dev] [ovn] Need advice for multiple routing tables support in LR

2021-08-10 Thread Vladislav Odintsov
old branches too. Regards, Vladislav Odintsov > On 10 Aug 2021, at 18:28, Numan Siddique wrote: > > On Tue, Aug 10, 2021 at 8:00 AM Vladislav Odintsov <mailto:odiv...@gmail.com>> wrote: >> >> Hi Numan, >> >> thanks for the answer. >> >>

[ovs-dev] [PATCH ovn 0/3] Add multiple routing tables support to Logical Routers

2021-08-16 Thread Vladislav Odintsov
series get reviewed. Vladislav Odintsov (3): tests: remove strict check for table=N for N > 9 northd: support for RouteTables in LRs utilities: update ovn-nbctl with RouteTables support northd/ovn-northd.8.xml | 63 -- northd/ovn-northd.c | 198 ++--- ovn-nb.ovsschema

[ovs-dev] [PATCH ovn 1/3] tests: remove strict check for table=N for N > 9

2021-08-16 Thread Vladislav Odintsov
=?? and update AT_CHECK command for it. This change is relevant for lrouter ingress pipeline table=N where N > 9, as next patches in this series will modify 10th table. Signed-off-by: Vladislav Odintsov --- tests/ovn-northd.at | 200 ++-- tests/ovn

[ovs-dev] [PATCH ovn 3/3] utilities: update ovn-nbctl with RouteTables support

2021-08-16 Thread Vladislav Odintsov
Signed-off-by: Vladislav Odintsov --- tests/ovn-ic.at | 4 + tests/ovn-nbctl.at| 165 +- utilities/ovn-nbctl.c | 124 +-- 3 files changed, 284 insertions(+), 9 deletions(-) diff --git a/tests/ovn-ic.at b/tests/ovn

[ovs-dev] [PATCH ovn 2/3] northd: support for RouteTables in LRs

2021-08-16 Thread Vladislav Odintsov
iated with appropriate route_table. Signed-off-by: Vladislav Odintsov --- northd/ovn-northd.8.xml | 63 -- northd/ovn-northd.c | 198 +++--- ovn-nb.ovsschema| 5 +- ovn-nb.xml | 30 +++ tests/ovn-northd.at | 72 ++- tests/ovn.at

[ovs-dev] [PATCH ovn v2] ic: learn routes to LR only from corresponding transit switch

2021-08-19 Thread Vladislav Odintsov
: Vladislav Odintsov --- v1 -> v2: - Address Han's review comments: - Make comments and test more clear to understand. - Use ovsdb_idl_index to optimize transit switch lookup. --- ic/ovn-ic.c | 17 ++- tests/ovn-ic.at | 55

[ovs-dev] [PATCH ovn v2] ic: learn routes to LR only from corresponding transit switch

2021-08-19 Thread Vladislav Odintsov
: Vladislav Odintsov --- v1 -> v2: - Address Han's review comments: - Make comments and test more clear to understand. - Use ovsdb_idl_index to optimize transit switch lookup. --- ic/ovn-ic.c | 17 ++- tests/ovn-ic.at | 55

Re: [ovs-dev] [PATCH ovn] ic: learn routes to LR only from corresponding transit switch

2021-08-19 Thread Vladislav Odintsov
Hi Han, thanks for the review! All requested changes I’ve addressed in a new version of this patch: https://patchwork.ozlabs.org/project/ovn/patch/20210819153012.82531-1-odiv...@gmail.com/ Let me know if now patch is okay or needs more improvements. Regards, Vladislav Odintsov > On 19

Re: [ovs-dev] [PATCH ovn v2] ic: learn routes to LR only from corresponding transit switch

2021-08-19 Thread Vladislav Odintsov
Thanks! Regards, Vladislav Odintsov > On 19 Aug 2021, at 20:06, Han Zhou wrote: > > On Thu, Aug 19, 2021 at 8:30 AM Vladislav Odintsov > wrote: >> >> This commit fixes an error where in case of LRs were connected >> between different AZs with ovn-ic, their rout

Re: [ovs-dev] [PATCH ovn] controller: Don't allocate zone ids for non-VIF port bindings.

2021-08-23 Thread Vladislav Odintsov
Tested-by: Vladislav Odintsov Regards, Vladislav Odintsov > On 21 Aug 2021, at 07:58, num...@ovn.org wrote: > > From: Numan Siddique > > The commit 6fb87aad8c3("controller: Improve ct zone handling.") > caused a regression. After this commit ovn-controller is

Re: [ovs-dev] [PATCH ovn] controller: Don't allocate zone ids for non-VIF port bindings.

2021-08-23 Thread Vladislav Odintsov
Hi Numan, thanks for the quick fix. This worked for me. Regards, Vladislav Odintsov > On 23 Aug 2021, at 18:24, Vladislav Odintsov wrote: > > Tested-by: Vladislav Odintsov mailto:odiv...@gmail.com>> > > Regards, > Vladislav Odintsov > >> On 21 Aug 2021, at

Re: [ovs-dev] [PATCH ovn 0/3] Add multiple routing tables support to Logical Routers

2021-08-24 Thread Vladislav Odintsov
Thanks Numan for the information. Regards, Vladislav Odintsov > On 24 Aug 2021, at 18:43, Numan Siddique wrote: > > On Mon, Aug 23, 2021 at 1:38 PM Odintsov Vladislav wrote: >> >> Hi, >> >> I’m wonder if this patch series is interesting for the project. &g

[ovs-dev] [PATCH ovn] ic: remove port_binding on ts deletion

2021-08-24 Thread Vladislav Odintsov
When IC port_binding exists and transit switch is deleted, the orphan port_binding if left in the IC_SB_DB. This patch fixes such situation and adds test for this case. Signed-off-by: Vladislav Odintsov --- ic/ovn-ic.c | 35 +++-- tests/ovn-ic.at | 52

[ovs-dev] [PATCH ovn] ic: use ovsdb_index to iterate over routes

2021-08-30 Thread Vladislav Odintsov
Small optimization in routes advertizement code. Instead of iterating over all routes and checking for needed transit_switch and availability_zone, use ovsdb_index built with appropriate fields. Signed-off-by: Vladislav Odintsov --- ic/ovn-ic.c | 22 ++ 1 file changed, 14

[ovs-dev] [PATCH ovn] ic: call ovn_db_run() only when all DBs are connected

2021-08-30 Thread Vladislav Odintsov
SB DB - ICNB DB - ICSB DB Only when this condition is met, we can safely run ovn-ic sync logic. Signed-off-by: Vladislav Odintsov --- ic/ovn-ic.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ic/ovn-ic.c b/ic/ovn-ic.c index 18066a305..fc608af82 100644 --- a/ic/ovn-ic.c +++

Re: [ovs-dev] [PATCH ovn 2/3] northd: support for RouteTables in LRs

2021-08-30 Thread Vladislav Odintsov
upcoming soft-freeze and as I’m new to project, so I don’t know if it is accepted for now. Regards, Vladislav Odintsov > On 30 Aug 2021, at 23:44, Numan Siddique wrote: > > On Mon, Aug 16, 2021 at 5:15 PM Vladislav Odintsov <mailto:odiv...@gmail.com>> wrote: >> >&

[ovs-dev] [PATCH ovn v2 0/6] Add multiple routing tables support to Logical Routers

2021-09-03 Thread Vladislav Odintsov
- Added NEWS item. - Added myself to authors list. Vladislav Odintsov (6): ic: remove port_binding on ts deletion ic: process only local port_bindings tests: remove strict check for table=N for N > 9 northd,utils: support for RouteTables in LRs ic: add support for routing tables in ad

[ovs-dev] [PATCH ovn v2 1/6] ic: remove port_binding on ts deletion

2021-09-03 Thread Vladislav Odintsov
When IC port_binding exists and transit switch is deleted, the orphan port_binding if left in the IC_SB_DB. This patch fixes such situation and adds test for this case. Signed-off-by: Vladislav Odintsov --- ic/ovn-ic.c | 35 +++-- tests/ovn-ic.at | 52

[ovs-dev] [PATCH ovn v2 2/6] ic: process only local port_bindings

2021-09-03 Thread Vladislav Odintsov
check availability_zone. Signed-off-by: Vladislav Odintsov --- ic/ovn-ic.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/ic/ovn-ic.c b/ic/ovn-ic.c index 418f19147..98d3e 100644 --- a/ic/ovn-ic.c +++ b/ic/ovn-ic.c @@ -68,6 +68,7 @@ struct ic_context { s

[ovs-dev] [PATCH ovn v2 3/6] tests: remove strict check for table=N for N > 9

2021-09-03 Thread Vladislav Odintsov
-org/ovn/commit/e3ae68ed9a1bb231f7b069539693474508f3ed86 [2] https://github.com/ovn-org/ovn/commit/c0085228893e7bf07190fcccf50cf588b028edaa Signed-off-by: Vladislav Odintsov --- tests/ovn-northd.at | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/ovn-northd.at b

[ovs-dev] [PATCH ovn v2 4/6] northd, utils: support for RouteTables in LRs

2021-09-03 Thread Vladislav Odintsov
Signed-off-by: Vladislav Odintsov --- northd/ovn-northd.8.xml | 63 -- northd/ovn-northd.c | 198 +++--- ovn-nb.ovsschema| 5 +- ovn-nb.xml | 30 +++ tests/ovn-ic.at | 4 + tests/ovn-nbctl.at | 196 +- tests/ovn

[ovs-dev] [PATCH ovn v2 5/6] ic: add support for routing tables in adv/learn routes

2021-09-03 Thread Vladislav Odintsov
ach transit switch port and configured as ECMP routes. Note 2: static routes within route tables will be advertised and learned only if interconnecting transit switch's LRPs will have options:route_table same value as route's route_table value. Signed-off-by: Vladislav Odintsov --- NEWS

[ovs-dev] [PATCH ovn v2 6/6] Update Authors list

2021-09-03 Thread Vladislav Odintsov
Signed-off-by: Vladislav Odintsov --- AUTHORS.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS.rst b/AUTHORS.rst index 3f93874a3..e03c6b407 100644 --- a/AUTHORS.rst +++ b/AUTHORS.rst @@ -388,6 +388,7 @@ Venkata Anil Kommaddi vkomm...@redhat.com Venu Iyer

Re: [ovs-dev] [PATCH ovn] ic: remove port_binding on ts deletion

2021-09-07 Thread Vladislav Odintsov
Hi Han, thanks for the review. Regards, Vladislav Odintsov > On 7 Sep 2021, at 08:37, Han Zhou wrote: > > On Tue, Aug 24, 2021 at 11:45 AM Vladislav Odintsov <mailto:odiv...@gmail.com>> > wrote: >> >> When IC port_binding exists and transit switch is delet

[ovs-dev] [PATCH ovn v2] ic: remove orphan port_binding after ts deletion

2021-09-07 Thread Vladislav Odintsov
When IC port_binding exists and transit switch is deleted, the orphan port_binding is left in the IC_SB_DB. This patch fixes such situation and adds test for this case. Signed-off-by: Vladislav Odintsov --- v1 -> v2: - moved port_binding cleanup from ts_run() to port_binding_

Re: [ovs-dev] [PATCH ovn] ic: remove port_binding on ts deletion

2021-09-07 Thread Vladislav Odintsov
I’ve submitted version 2 of this patch: https://patchwork.ozlabs.org/project/ovn/patch/20210907115052.7913-1-odiv...@gmail.com/ Regards, Vladislav Odintsov > On 7 Sep 2021, at 11:42, Vladislav Odintsov wrote: > > Hi Han, > > thanks for the review. > > Regards, > Vladi

Re: [ovs-dev] [PATCH ovn v2] ic: remove orphan port_binding after ts deletion

2021-09-07 Thread Vladislav Odintsov
Hi Han, Yes, somehow I’ve not seen your comments for the test, sorry. I’m okay with those changes, thanks. Regards, Vladislav Odintsov > On 7 Sep 2021, at 21:02, Han Zhou wrote: > > On Tue, Sep 7, 2021 at 4:51 AM Vladislav Odintsov wrote: >> >> When IC port_bindi

[ovs-dev] [ovn] system@ovs-system: failed to query port patch-outside-localnet-to-br-int: Invalid argument

2021-09-09 Thread Vladislav Odintsov
somebody of developers know the reason and the possible impact? Regards, Vladislav Odintsov ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [ovn] system@ovs-system: failed to query port patch-outside-localnet-to-br-int: Invalid argument

2021-09-09 Thread Vladislav Odintsov
I’ve forgot to add: there warnings appear while starting ovn-controller service. Regards, Vladislav Odintsov > On 9 Sep 2021, at 17:41, Vladislav Odintsov wrote: > > Hi, > > with ovn master code and OVS 2.16.0 with OOT kernel module I see error in > ovs-vswitchd: >

Re: [ovs-dev] [ovn] system@ovs-system: failed to query port patch-outside-localnet-to-br-int: Invalid argument

2021-09-09 Thread Vladislav Odintsov
Hi Numan, Regards, Vladislav Odintsov > On 9 Sep 2021, at 20:36, Numan Siddique wrote: > > On Thu, Sep 9, 2021 at 10:43 AM Vladislav Odintsov <mailto:odiv...@gmail.com>> wrote: >> >> I’ve forgot to add: >> there warnings appear while starting ov

[ovs-dev] [ovn] problem: long tcp session instantiation with stateful ACLs

2021-09-13 Thread Vladislav Odintsov
this can be fixed. The problem is actual with OVS 2.13.4 and latest OVN master branch, however we’ve met it on 20.06.3 with same OVS and it’s very important for us. Thanks. Regards, Vladislav Odintsov ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [ovn] problem: long tcp session instantiation with stateful ACLs

2021-09-13 Thread Vladislav Odintsov
There’s a typo in my previous mail. Please, see inline fix. Regards, Vladislav Odintsov > On 13 Sep 2021, at 15:09, Vladislav Odintsov wrote: > > Hi, > > we’ve encountered a next problem with stateful ACLs. > > Suppose, we have one logical switch (ls1) and atta

Re: [ovs-dev] [ovn] problem: long tcp session instantiation with stateful ACLs

2021-09-13 Thread Vladislav Odintsov
Hi Numan, I’ve checked with OVS 2.16.0 and OVN master. The problem persists. Symptoms are the same. # grep ct_zero_snat /var/log/openvswitch/ovs-vswitchd.log 2021-09-13T16:10:01.792Z|00019|ofproto_dpif|INFO|system@ovs-system: Datapath supports ct_zero_snat Regards, Vladislav Odintsov > On

Re: [ovs-dev] [PATCH ovn v2 1/6] ic: remove port_binding on ts deletion

2021-09-14 Thread Vladislav Odintsov
Hi Numan, yes, you’re correct. Regards, Vladislav Odintsov > On 14 Sep 2021, at 21:41, Numan Siddique wrote: > > On Fri, Sep 3, 2021 at 6:35 AM Vladislav Odintsov <mailto:odiv...@gmail.com>> wrote: >> >> When IC port_binding exists and transit switch is delet

[ovs-dev] [PATCH ovn 0/3] controller-vtep: stateful datapath bugfix & add new test

2021-09-15 Thread Vladislav Odintsov
-controller recompute` must be removed from test before merge. It is placed there to show where the bug currently is. [1]: https://mail.openvswitch.org/pipermail/ovs-dev/2021-September/387435.html Vladislav Odintsov (3): tests: use ovn_start in controller-vtep tests tests: check that flow for

[ovs-dev] [PATCH ovn 1/3] tests: use ovn_start in controller-vtep tests

2021-09-15 Thread Vladislav Odintsov
ovn_start function for the purpose of starting OVN. Signed-off-by: Vladislav Odintsov --- tests/ovn-controller-vtep.at | 128 +-- 1 file changed, 62 insertions(+), 66 deletions(-) diff --git a/tests/ovn-controller-vtep.at b/tests/ovn-controller-vtep.at index

[ovs-dev] [PATCH ovn 2/3] tests: check that flow for ramp switch is added when PB is created

2021-09-15 Thread Vladislav Odintsov
Signed-off-by: Vladislav Odintsov --- tests/ovn-controller-vtep.at | 64 1 file changed, 64 insertions(+) diff --git a/tests/ovn-controller-vtep.at b/tests/ovn-controller-vtep.at index 21d79c66b..2d1ebad56 100644 --- a/tests/ovn-controller-vtep.at +++ b

[ovs-dev] [PATCH ovn 3/3] northd: support HW VTEP with stateful datapath

2021-09-15 Thread Vladislav Odintsov
ls_in_pre_acl and ls_in_pre_lb we add new flow with priority 110 to skip such packets. Signed-off-by: Vladislav Odintsov --- Please note: I've got no experience in DDLog and have no ability to extensively test these changes. Just local ./configure --with-ddlog=...; make;

Re: [ovs-dev] [PATCH ovn v2 4/6] northd, utils: support for RouteTables in LRs

2021-09-15 Thread Vladislav Odintsov
Hi Numan, thanks for the suggestion. I’ll update patch with requested change. Have you looked at ovn-ic changes? Should I wait for a review of that patch and submit v3 after that? Regards, Vladislav Odintsov > On 14 Sep 2021, at 19:13, Numan Siddique wrote: > > On Fri, Sep 3, 2021 a

Re: [ovs-dev] [ovn] problem: long tcp session instantiation with stateful ACLs

2021-09-15 Thread Vladislav Odintsov
Hi Dumitru, thanks for your reply. Regards, Vladislav Odintsov > On 15 Sep 2021, at 11:24, Dumitru Ceara wrote: > > Hi Vladislav, > > On 9/13/21 6:14 PM, Vladislav Odintsov wrote: >> Hi Numan, >> >> I’ve checked with OVS 2.16.0 and OVN master. The problem p

Re: [ovs-dev] [ovn] problem: long tcp session instantiation with stateful ACLs

2021-09-16 Thread Vladislav Odintsov
Hi Dumitru, I’ve tried to exclude OOT OVS kernel module. With OVN 20.06.3 + OVS 2.13.4 the problem solved. Could you please try with OOT kmod? For me it looks like a bug in OOT OVS kernel module code. Thanks. Regards, Vladislav Odintsov > On 16 Sep 2021, at 11:02, Dumitru Ceara wr

Re: [ovs-dev] [ovn] problem: long tcp session instantiation with stateful ACLs

2021-09-16 Thread Vladislav Odintsov
Sorry, by OOT I meant non-inbox kmod. I’ve tried to use inbox kernel module (from kernel package) and problem resolved. Regards, Vladislav Odintsov > On 16 Sep 2021, at 17:17, Vladislav Odintsov wrote: > > Hi Dumitru, > > I’ve tried to exclude OOT OVS kernel module. > With

[ovs-dev] [PATCH ovn] controller: configure only matching encaps between chassis

2021-09-16 Thread Vladislav Odintsov
igured STT tunnel (best of VXLAN and STT) and GENEVE on another one ("best" of GENEVE and STT). No traffic could be sent between these chassis. Though the common STT could be used. Now we configure only matching encaps between nodes. Signed-off-by: Vladislav Odintsov --- controller/e

[ovs-dev] [PATCH ovn] rhel, utils: don't affect traffic on controller upgrade

2021-09-17 Thread Vladislav Odintsov
systemctl try-restart. Also, upgrade ovn-ctl script to support --restart argument in it. Ideally this should be done by systemd when restart is called, but it's impossible to pass restart command to systemd. Signed-off-by: Vladislav Odintsov --- rhel/ovn-fedora.spec.in | 8 util

[ovs-dev] [PATCH ovn v2] northd: support HW VTEP with stateful datapath

2021-09-17 Thread Vladislav Odintsov
ls_in_pre_acl and ls_in_pre_lb we add new flow with priority 110 to skip such packets. Signed-off-by: Vladislav Odintsov --- v1 -> v2: - Patch rebased on upstream changes. Please note: I've got no experience in DDLog and have no ability to extensively test these

Re: [ovs-dev] [PATCH ovn 3/3] northd: support HW VTEP with stateful datapath

2021-09-17 Thread Vladislav Odintsov
Hi, done: https://patchwork.ozlabs.org/project/ovn/patch/20210917150104.6143-1-odiv...@gmail.com/ Regards, Vladislav Odintsov > On 17 Sep 2021, at 17:44, Numan Siddique wrote: > > On Wed, Sep 15, 2021 at 8:07 PM Vladislav Odintsov <mailto:odiv...@gmail.com>> wrote: >

[ovs-dev] [PATCH ovn v3 0/3] Add multiple routing tables support to Logical Routers

2021-09-17 Thread Vladislav Odintsov
changes are based on them so they're included. Once those patches are accepts, I can drop them from this series. - Added NEWS item. - Added myself to authors list. Vladislav Odintsov (3): ic: process only local port_bindings northd,utils: support for RouteTables in LRs ic: add

[ovs-dev] [PATCH ovn v3 1/3] ic: process only local port_bindings

2021-09-17 Thread Vladislav Odintsov
check availability_zone. Signed-off-by: Vladislav Odintsov --- ic/ovn-ic.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/ic/ovn-ic.c b/ic/ovn-ic.c index 99356253d..92c83d730 100644 --- a/ic/ovn-ic.c +++ b/ic/ovn-ic.c @@ -68,6 +68,7 @@ struct ic_context { s

[ovs-dev] [PATCH ovn v3 2/3] northd, utils: support for RouteTables in LRs

2021-09-17 Thread Vladislav Odintsov
value associated with appropriate route_table. Signed-off-by: Vladislav Odintsov --- northd/northd.c | 160 --- northd/ovn-northd.8.xml | 63 -- ovn-nb.ovsschema| 5 +- ovn-nb.xml | 30 +++ tests/ovn-ic.at | 4 + tests/ovn-nbctl.at

[ovs-dev] [PATCH ovn v3 3/3] ic: add support for routing tables in adv/learn routes

2021-09-17 Thread Vladislav Odintsov
ach transit switch port and configured as ECMP routes. Note 2: static routes within route tables will be advertised and learned only if interconnecting transit switch's LRPs will have options:route_table same value as route's route_table value. Signed-off-by: Vladislav Odintsov --- NEWS

[ovs-dev] [PATCH ovn] northd: support HW VTEP with stateful datapath

2021-09-17 Thread Vladislav Odintsov
ls_in_pre_acl and ls_in_pre_lb we add new flow with priority 110 to skip such packets. Signed-off-by: Vladislav Odintsov --- northd/northd.c | 14 ++ northd/ovn-northd.8.xml | 29 + northd/ovn_northd.dl| 33 +++-- tests/ovn

Re: [ovs-dev] [PATCH ovn v2] northd: support HW VTEP with stateful datapath

2021-09-17 Thread Vladislav Odintsov
Hi Numan, I’ve posted a new patch version here: https://patchwork.ozlabs.org/project/ovn/patch/20210917215602.10633-1-odiv...@gmail.com/ I’ve tried to answer your question about ACLs in documentation. Please let me know if it is clear. Regards, Vladislav Odintsov > On 17 Sep 2021, at 22

Re: [ovs-dev] [PATCH ovn v2] northd: support HW VTEP with stateful datapath

2021-09-17 Thread Vladislav Odintsov
You’re absolutely right. The difference with normal chassis is only the lack of output port. It is determined in l2_lkp table. This is the only one reason to send packet to ingress pipeline. Regards, Vladislav Odintsov > On 18 Sep 2021, at 01:25, Numan Siddique wrote: > > On Fri, Sep

[ovs-dev] [PATCH ovn branch-21.06] northd: support HW VTEP with stateful datapath

2021-09-18 Thread Vladislav Odintsov
ls_in_pre_acl and ls_in_pre_lb we add new flow with priority 110 to skip such packets. Signed-off-by: Vladislav Odintsov Signed-off-by: Numan Siddique (cherry picked from commit 62ca8b9620cc1168ace6905575b7d36438363aed) --- northd/ovn-northd.8.xml | 28 northd/ovn-northd.c

Re: [ovs-dev] [PATCH ovn] northd: support HW VTEP with stateful datapath

2021-09-18 Thread Vladislav Odintsov
21.06 here: https://patchwork.ozlabs.org/project/ovn/patch/20210918125121.8257-1-odiv...@gmail.com/ 21.03 and older branches have more non-trivial conflicts, and backporting should be done more carefully. If one needs that, he/she can try to do it by its own. Regards, Vladislav Odintsov > On

  1   2   3   4   5   6   >