Re: [ovs-dev] [PATCH ovn v3 0/5] OVN IC multiple same routes fixes

2022-12-16 Thread Vladislav Odintsov
Thanks Dumitru! Regards, Vladislav Odintsov > On 16 Dec 2022, at 15:17, Dumitru Ceara wrote: > > Hi Vladislav, > > I pushed the series to main branch and branch-22.12. I also backported > the first 4 patches all the way down to branch-22.03. > > Thanks a lot for the

Re: [ovs-dev] [PATCH ovn v3 0/5] OVN IC multiple same routes fixes

2022-12-16 Thread Vladislav Odintsov
Hi Dumitru, Regards, Vladislav Odintsov > On 16 Dec 2022, at 02:16, Dumitru Ceara wrote: > > On 12/15/22 22:30, Vladislav Odintsov wrote: >> Thanks Numan for the review. >> >> It seems that for some reason appeared a memory leak, which constantly >> repr

Re: [ovs-dev] [PATCH ovn v3 0/5] OVN IC multiple same routes fixes

2022-12-15 Thread Vladislav Odintsov
Thanks Numan for the review. It seems that for some reason appeared a memory leak, which constantly reproduces. I’ll give it a time tomorrow to find the source of a problem. Regards, Vladislav Odintsov > On 16 Dec 2022, at 00:21, Numan Siddique wrote: > > On Thu, Dec 15, 2022 at

[ovs-dev] [PATCH ovn v3 5/5] ic-sb schema: add index for routes table & document upgrade path

2022-12-15 Thread Vladislav Odintsov
Add new uniq index to OVN IC Southbound Route table to prevent same routes installation. Also document ovn-ic upgrade details & note new schema change to known possible duplicate records, which can fail the schema convert. Signed-off-by: Vladislav Odintsov --- Documentation/intro/install

[ovs-dev] [PATCH ovn v3 4/5] ic: minor code improvements

2022-12-15 Thread Vladislav Odintsov
1. Remove excess nbrec_logical_router variable. 2. Remove excess call to add_static_to_routes_ad(). 3. Remove double nexthop check in ic_route_find(). Signed-off-by: Vladislav Odintsov Acked-by: Dumitru Ceara --- ic/ovn-ic.c | 21 + 1 file changed, 5 insertions(+), 16

[ovs-dev] [PATCH ovn v3 3/5] ic: prevent advertising/learning multiple same routes

2022-12-15 Thread Vladislav Odintsov
Advertize one route (ip_prefix, nexthop, route_table, transit_switch, availability_zone) only once. Signed-off-by: Vladislav Odintsov --- ic/ovn-ic.c | 84 ++--- tests/ovn-ic.at | 60 +++ 2 files changed, 111

[ovs-dev] [PATCH ovn v3 2/5] ic: lookup southbound port_binding only if needed

2022-12-15 Thread Vladislav Odintsov
Signed-off-by: Vladislav Odintsov Acked-by: Dumitru Ceara --- ic/ovn-ic.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ic/ovn-ic.c b/ic/ovn-ic.c index 2bc96d36c..0d5e5f5d9 100644 --- a/ic/ovn-ic.c +++ b/ic/ovn-ic.c @@ -757,6 +757,7 @@ port_binding_run(struct ic_context

[ovs-dev] [PATCH ovn v3 1/5] ic: remove orphan ovn interconnection routes

2022-12-15 Thread Vladislav Odintsov
Before this patch if one deletes transit switch through which there were routes in ICSB:Route table, such routes were left forever in the DB. Now we validate that each ICSB:Route has an appropriate transit switch. Signed-off-by: Vladislav Odintsov Acked-by: Dumitru Ceara --- ic/ovn-ic.c

[ovs-dev] [PATCH ovn v3 0/5] OVN IC multiple same routes fixes

2022-12-15 Thread Vladislav Odintsov
il.com/ Vladislav Odintsov (5): ic: remove orphan ovn interconnection routes ic: lookup southbound port_binding only if needed ic: prevent advertising/learning multiple same routes ic: minor code improvements ic-sb schema: add index for routes table & document upgrade path Documenta

Re: [ovs-dev] [PATCH ovn v2 3/4] ic: prevent advertising/learning multiple same routes

2022-12-15 Thread Vladislav Odintsov
Hi Dumitru, Regards, Vladislav Odintsov > On 12 Dec 2022, at 17:57, Dumitru Ceara wrote: > > On 12/12/22 14:39, Vladislav Odintsov wrote: >> Hi Numan, Dumitru, >> >> I forgot one thing about a possible upgrade recommendation for the users. >> Fix can be applie

Re: [ovs-dev] [PATCH ovn v2 3/4] ic: prevent advertising/learning multiple same routes

2022-12-12 Thread Vladislav Odintsov
ovn-ic-db (at least for RH, there is a separate systemd unit for IC databases) or calling ovsdb-client convert … command directly. Would it be an acceptable compromise for this situation? Regards, Vladislav Odintsov > On 12 Dec 2022, at 16:20, Numan Siddique wrote: > > On Mon, Dec

Re: [ovs-dev] [PATCH ovn v2 3/4] ic: prevent advertising/learning multiple same routes

2022-12-09 Thread Vladislav Odintsov
Hi Dumitru, please see answers inline. Regards, Vladislav Odintsov > On 9 Dec 2022, at 17:37, Dumitru Ceara wrote: > > On 12/6/22 11:20, Vladislav Odintsov wrote: >> Signed-off-by: Vladislav Odintsov > <mailto:odiv...@gmail.com>> >> --- > > Hi Vl

[ovs-dev] [PATCH ovn v2 4/4] ic: minor code improvements

2022-12-06 Thread Vladislav Odintsov
1. Remove excess nbrec_logical_router variable. 2. Remove excess call to add_static_to_routes_ad(). 3. Remove double nexthop check in ic_route_find(). Signed-off-by: Vladislav Odintsov --- ic/ovn-ic.c | 21 + 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/ic

[ovs-dev] [PATCH ovn v2 3/4] ic: prevent advertising/learning multiple same routes

2022-12-06 Thread Vladislav Odintsov
Signed-off-by: Vladislav Odintsov --- ic/ovn-ic.c | 83 +++-- ovn-ic-sb.ovsschema | 6 ++-- tests/ovn-ic.at | 60 3 files changed, 114 insertions(+), 35 deletions(-) diff --git a/ic/ovn-ic.c b/ic/ovn-ic.c

[ovs-dev] [PATCH ovn v2 1/4] ic: remove orphan ovn interconnection routes

2022-12-06 Thread Vladislav Odintsov
Before this patch if one deletes transit switch through which there were routes in ICSB:Route table, such routes were left forever in the DB. Now we validate that each ICSB:Route has an appropriate transit switch. Signed-off-by: Vladislav Odintsov --- ic/ovn-ic.c | 40

[ovs-dev] [PATCH ovn v2 2/4] ic: lookup southbound port_binding only if needed

2022-12-06 Thread Vladislav Odintsov
Signed-off-by: Vladislav Odintsov Acked-by: Dumitru Ceara --- ic/ovn-ic.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ic/ovn-ic.c b/ic/ovn-ic.c index d3bc08761..9e2369fef 100644 --- a/ic/ovn-ic.c +++ b/ic/ovn-ic.c @@ -757,6 +757,7 @@ port_binding_run(struct ic_context

[ovs-dev] [PATCH ovn v2 0/4] OVN IC multiple same routes fixes

2022-12-06 Thread Vladislav Odintsov
2-1-odiv...@gmail.com/ Vladislav Odintsov (4): ic: remove orphan ovn interconnection routes ic: lookup southbound port_binding only if needed ic: prevent advertising/learning multiple same routes ic: minor code improvements ic/ovn-ic.c |

Re: [ovs-dev] [PATCH ovn 6/7] northd: limit ECMP group by 1024 members

2022-12-05 Thread Vladislav Odintsov
space for the routes instead of paths? Regards, Vladislav Odintsov > On 5 Dec 2022, at 21:14, Vladislav Odintsov wrote: > > It’s a good idea. > But one thing is that this is not the only one place where the buckets are > created. > Also they’re created in LBs. Should we ju

Re: [ovs-dev] [PATCH ovn 6/7] northd: limit ECMP group by 1024 members

2022-12-05 Thread Vladislav Odintsov
It’s a good idea. But one thing is that this is not the only one place where the buckets are created. Also they’re created in LBs. Should we just put some common function, which returns the current configured (or default MAX) and use it in every place? Regards, Vladislav Odintsov > On 5

Re: [ovs-dev] [PATCH ovn 5/7] ic: minor code improvements

2022-12-05 Thread Vladislav Odintsov
Regards, Vladislav Odintsov > On 5 Dec 2022, at 19:37, Dumitru Ceara wrote: > > On 12/2/22 18:31, Vladislav Odintsov wrote: >> 1. Remove excess nbrec_logical_router variable. >> 2. Remove excess call to add_static_to_routes_ad(). >> 3. Remove double route_

Re: [ovs-dev] [PATCH ovn 4/7] actions: limit possible OF group bucket count

2022-12-05 Thread Vladislav Odintsov
. This place looks to me like a "last resort" for OF group generation. All buckets are parsed/converted to OF syntax here. Please correct me if I’m wrong. Regards, Vladislav Odintsov > On 5 Dec 2022, at 19:37, Dumitru Ceara wrote: > > On 12/2/22 18:31, Vladislav Odintsov wrote

Re: [ovs-dev] [PATCH ovn 1/7] ic: move routes_ad hmap insert to separate function

2022-12-05 Thread Vladislav Odintsov
Hi, Okay, I’ll split these patches in two series and squash patch #1 with patch #7. Regards, Vladislav Odintsov > On 5 Dec 2022, at 20:00, Numan Siddique wrote: > > On Mon, Dec 5, 2022 at 11:37 AM Dumitru Ceara <mailto:dce...@redhat.com>> wrote: >> >> On 12/

Re: [ovs-dev] [PATCH ovn 2/7] ic: remove orphan ovn interconnection routes

2022-12-05 Thread Vladislav Odintsov
Hi Dumitru, please, see answer inline. Regards, Vladislav Odintsov > On 5 Dec 2022, at 19:37, Dumitru Ceara wrote: > > On 12/2/22 18:31, Vladislav Odintsov wrote: >> Before this patch if one deletes transit switch through which there were >> routes in ICSB:Route table,

Re: [ovs-dev] [OVN RFC 0/7] OVN IC bugfixes & proposals/questions

2022-12-02 Thread Vladislav Odintsov
/ Regards, Vladislav Odintsov > On 2 Dec 2022, at 19:05, Numan Siddique wrote: > > On Fri, Dec 2, 2022 at 8:27 AM Vladislav Odintsov <mailto:odiv...@gmail.com>> wrote: >> >> Hi Numan, >> >> only a part of those patched supposed to be applied. Anothe

[ovs-dev] [PATCH ovn 7/7] ic: prevent advertising/learning multiple same routes

2022-12-02 Thread Vladislav Odintsov
Signed-off-by: Vladislav Odintsov --- ic/ovn-ic.c | 17 ++--- ovn-ic-sb.ovsschema | 6 +++-- tests/ovn-ic.at | 60 + 3 files changed, 78 insertions(+), 5 deletions(-) diff --git a/ic/ovn-ic.c b/ic/ovn-ic.c index 59468545d

[ovs-dev] [PATCH ovn 6/7] northd: limit ECMP group by 1024 members

2022-12-02 Thread Vladislav Odintsov
This patch is intended to show that currently it's possible to build ECMP group of 65k buckets. Signed-off-by: Vladislav Odintsov --- northd/northd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/northd/northd.c b/northd/northd.c index e1f3bace8..f8f7977ae 100644

[ovs-dev] [PATCH ovn 5/7] ic: minor code improvements

2022-12-02 Thread Vladislav Odintsov
1. Remove excess nbrec_logical_router variable. 2. Remove excess call to add_static_to_routes_ad(). 3. Remove double route_table check in ic_route_fin(). 4. Move variable declarations out of loop. Signed-off-by: Vladislav Odintsov --- ic/ovn-ic.c | 31 ++- 1 file

[ovs-dev] [PATCH ovn 2/7] ic: remove orphan ovn interconnection routes

2022-12-02 Thread Vladislav Odintsov
Before this patch if one deletes transit switch through which there were routes in ICSB:Route table, such routes were left forever in the DB. Now we validate that each ICSB:Route has an appropriate transit switch. Signed-off-by: Vladislav Odintsov --- ic/ovn-ic.c | 40

[ovs-dev] [PATCH ovn 4/7] actions: limit possible OF group bucket count

2022-12-02 Thread Vladislav Odintsov
mit(,20),...bucket=bucket_id:1,... This patch introduces a limit of buckets that may be requested to 1024. In case the limit is reached, ovn-controller will write WARN log about this fact. Signed-off-by: Vladislav Odintsov --- lib/actions.c | 40 ++-- 1 f

[ovs-dev] [PATCH ovn 1/7] ic: move routes_ad hmap insert to separate function

2022-12-02 Thread Vladislav Odintsov
This change will be useful in next commit. Signed-off-by: Vladislav Odintsov --- ic/ovn-ic.c | 45 +++-- 1 file changed, 27 insertions(+), 18 deletions(-) diff --git a/ic/ovn-ic.c b/ic/ovn-ic.c index e5c193d9d..50ff65a26 100644 --- a/ic/ovn-ic.c +++ b/ic

[ovs-dev] [PATCH ovn 3/7] ic: lookup southbound port_binding only if needed

2022-12-02 Thread Vladislav Odintsov
Signed-off-by: Vladislav Odintsov --- ic/ovn-ic.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ic/ovn-ic.c b/ic/ovn-ic.c index b3790e965..3e02b4c98 100644 --- a/ic/ovn-ic.c +++ b/ic/ovn-ic.c @@ -757,6 +757,7 @@ port_binding_run(struct ic_context *ctx

[ovs-dev] [PATCH ovn 0/7] OVN IC bugfixes & proposals/questions

2022-12-02 Thread Vladislav Odintsov
static_routes @id done Thanks for reading this, I'm ready to provide any additional information to help investigate this. Vladislav Odintsov (7): ic: move routes_ad hmap insert to separate function ic: remove orphan ovn interconnection routes ic: lookup southbound port_binding only

Re: [ovs-dev] [OVN RFC 0/7] OVN IC bugfixes & proposals/questions

2022-12-02 Thread Vladislav Odintsov
Hi Numan, only a part of those patched supposed to be applied. Another part present in the RFC just to show some PoC/idea, should I repost all of the patches? Regards, Vladislav Odintsov > On 2 Dec 2022, at 00:20, Numan Siddique wrote: > > On Thu, Dec 1, 2022 at 3:58 PM Vladislav

Re: [ovs-dev] [OVN RFC 0/7] OVN IC bugfixes & proposals/questions

2022-12-01 Thread Vladislav Odintsov
Hi, is it possible to consider any of the problems written below and here [0] for the possible fixes to be included in upcoming OVN/OVS releases? Thanks. 0: https://patchwork.ozlabs.org/project/ovn/cover/20221118162050.3019353-1-odiv...@gmail.com/ Regards, Vladislav Odintsov > On 24

[ovs-dev] [OVN RFC 6/7] northd: limit ECMP group by 1024 members

2022-11-18 Thread Vladislav Odintsov
This patch is intended to show that currently it's possible to build ECMP group of 65k buckets. Signed-off-by: Vladislav Odintsov --- northd/northd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/northd/northd.c b/northd/northd.c index e1f3bace8..f8f7977ae 100644

[ovs-dev] [OVN RFC 7/7] ic: prevent advertising/learning multiple same routes

2022-11-18 Thread Vladislav Odintsov
Signed-off-by: Vladislav Odintsov --- ic/ovn-ic.c | 17 ++--- ovn-ic-sb.ovsschema | 6 +++-- tests/ovn-ic.at | 60 + 3 files changed, 78 insertions(+), 5 deletions(-) diff --git a/ic/ovn-ic.c b/ic/ovn-ic.c index 59468545d

[ovs-dev] [OVN RFC 5/7] ic: minor code improvements

2022-11-18 Thread Vladislav Odintsov
1. Remove excess nbrec_logical_router variable. 2. Remove excess call to add_static_to_routes_ad(). 3. Remove double route_table check in ic_route_fin(). 4. Move variable declarations out of loop. Signed-off-by: Vladislav Odintsov --- ic/ovn-ic.c | 31 ++- 1 file

[ovs-dev] [OVN RFC 4/7] actions: limit possible OF group bucket count

2022-11-18 Thread Vladislav Odintsov
mit(,20),...bucket=bucket_id:1,... This patch introduces a limit of buckets that may be requested to 1024. In case the limit is reached, ovn-controller will write WARN log about this fact. Signed-off-by: Vladislav Odintsov --- lib/actions.c | 40 ++-- 1 f

[ovs-dev] [OVN RFC 3/7] ic: lookup southbound port_binding only if needed

2022-11-18 Thread Vladislav Odintsov
Signed-off-by: Vladislav Odintsov --- ic/ovn-ic.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ic/ovn-ic.c b/ic/ovn-ic.c index b3790e965..3e02b4c98 100644 --- a/ic/ovn-ic.c +++ b/ic/ovn-ic.c @@ -757,6 +757,7 @@ port_binding_run(struct ic_context *ctx

[ovs-dev] [OVN RFC 1/7] ic: move routes_ad hmap insert to separate function

2022-11-18 Thread Vladislav Odintsov
This change will be useful in next commit. Signed-off-by: Vladislav Odintsov --- ic/ovn-ic.c | 45 +++-- 1 file changed, 27 insertions(+), 18 deletions(-) diff --git a/ic/ovn-ic.c b/ic/ovn-ic.c index e5c193d9d..50ff65a26 100644 --- a/ic/ovn-ic.c +++ b/ic

[ovs-dev] [OVN RFC 2/7] ic: remove orphan ovn interconnection routes

2022-11-18 Thread Vladislav Odintsov
Before this patch if one deletes transit switch through which there were routes in ICSB:Route table, such routes were left forever in the DB. Now we validate that each ICSB:Route has an appropriate transit switch. Signed-off-by: Vladislav Odintsov --- ic/ovn-ic.c | 40

[ovs-dev] [OVN RFC 0/7] OVN IC bugfixes & proposals/questions

2022-11-18 Thread Vladislav Odintsov
fix=1.2.3.4/32 nexthop=172.31.32.4 policy=dst-ip -- add logical-router vpc-FC7D6A54 static_routes @id done Thanks for reading this, I'm ready to provide any additional information to help investigate this. Vladislav Odintsov (7): ic: move routes_ad hmap insert to separate function ic: remove

Re: [ovs-dev] ovs 2.17.3 release date

2022-10-04 Thread Vladislav Odintsov
Thanks Ilya for clarification. Regards, Vladislav Odintsov > On 4 Oct 2022, at 17:52, Ilya Maximets wrote: > > On 10/4/22 16:19, Vladislav Odintsov wrote: >> Hi, >> >> I’m wonder when OVS 2.17.3 release is expected? > > Hi. We got stuck a little bit

[ovs-dev] ovs 2.17.3 release date

2022-10-04 Thread Vladislav Odintsov
Hi, I’m wonder when OVS 2.17.3 release is expected? Regards, Vladislav Odintsov ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn] spec: require python3-openvswitch for ovn-detrace

2022-09-21 Thread Vladislav Odintsov
Signed-off-by: Vladislav Odintsov --- rhel/ovn-fedora.spec.in | 1 + 1 file changed, 1 insertion(+) diff --git a/rhel/ovn-fedora.spec.in b/rhel/ovn-fedora.spec.in index 821eb03cc..57dc977c1 100644 --- a/rhel/ovn-fedora.spec.in +++ b/rhel/ovn-fedora.spec.in @@ -65,6 +65,7 @@ BuildRequires

Re: [ovs-dev] [PATCH ovn] controller: flush associated conntrack zone on PB release

2022-09-16 Thread Vladislav Odintsov
Thanks Mark. Regards, Vladislav Odintsov > On 16 Sep 2022, at 18:19, Mark Michelson wrote: > > Hi, > > Acked-by: Mark Michelson > > In the interest of getting this merged into 22.09 before its impending > release, I have gone ahead and backported this to branch-2

Re: [ovs-dev] [PATCH ovn] northd: drop traffic to disabled LSPs in ingress pipeline

2022-09-15 Thread Vladislav Odintsov
I’ve submitted v3: https://patchwork.ozlabs.org/project/ovn/patch/20220916011459.2683707-1-odiv...@gmail.com/ Regards, Vladislav Odintsov > On 16 Sep 2022, at 03:04, Numan Siddique wrote: > > On Thu, Sep 15, 2022 at 7:59 PM Vladislav Odintsov <mailto:odiv...@gmail.com>> w

[ovs-dev] [PATCH ovn v3] northd: drop traffic to disabled LSPs in ingress pipeline

2022-09-15 Thread Vladislav Odintsov
tion LSP's zone now as well. Signed-off-by: Vladislav Odintsov --- v3: Addressed Numan's review comments: turned back drop lflow in egress pipeline --- northd/northd.c | 17 ++-- northd/ovn-northd.8.xml | 14 ++- tests/ovn-northd.at | 188 +

Re: [ovs-dev] [PATCH ovn] northd: drop traffic to disabled LSPs in ingress pipeline

2022-09-15 Thread Vladislav Odintsov
Numan, I’ve just to be sure we’re on the same page about moving drop flow. You have reviewed this patch v1 or v2 [1]? 1: https://patchwork.ozlabs.org/project/ovn/patch/20220908140644.2647859-1-odiv...@gmail.com/ Regards, Vladislav Odintsov > On 16 Sep 2022, at 02:25, Vladislav Odintsov wr

Re: [ovs-dev] [PATCH ovn] northd: drop traffic to disabled LSPs in ingress pipeline

2022-09-15 Thread Vladislav Odintsov
Ok, I’ll correct patch and resend v2. Regards, Vladislav Odintsov > On 16 Sep 2022, at 01:06, Numan Siddique wrote: > > On Thu, Sep 15, 2022 at 12:46 PM Vladislav Odintsov <mailto:odiv...@gmail.com>> wrote: >> >> I’ve tried this setup and it seems working co

Re: [ovs-dev] [PATCH ovn] northd: drop traffic to disabled LSPs in ingress pipeline

2022-09-15 Thread Vladislav Odintsov
type: "" up : true [root@dev1 ~]# ovn-nbctl list logical-switch-port ln-public _uuid : e51d2489-e3da-4989-935c-949533b00b35 addresses : [unknown] dhcpv4_options : [] dhcpv6_options : [] dynamic_addresses : [] enabled

Re: [ovs-dev] [PATCH ovn] northd: drop traffic to disabled LSPs in ingress pipeline

2022-09-15 Thread Vladislav Odintsov
Hi Numan, thanks for the provided case. Unfortunately, I’m now sure I correctly understand it. Could you please provide ovn-nbctl commands to create such a topology so I could reproduce and recheck? Regards, Vladislav Odintsov > On 15 Sep 2022, at 15:42, Numan Siddique wrote: > &g

Re: [ovs-dev] [ovn] Fixes before 22.09.0

2022-09-14 Thread Vladislav Odintsov
Hi, Gentle ping. +1 bugfix here: https://patchwork.ozlabs.org/project/ovn/patch/20220912221104.2679484-1-odiv...@gmail.com/ Regards, Vladislav Odintsov > On 9 Sep 2022, at 12:43, Vladislav Odintsov wrote: > > Hi, > > recently I’ve submitted two small fixes [1] and [2]. I’m

[ovs-dev] [PATCH ovn] northd: don't include disabled LSP's IP to Load Balancing

2022-09-12 Thread Vladislav Odintsov
behaviour. This patch resolves this issue for Load Balancers with enabled health check: if LSP is disabled, it wont be added to Service_Monitor and to Load Balancing flow. Signed-off-by: Vladislav Odintsov --- northd/northd.c | 10 ++ tests/ovn-northd.at | 19 +++ 2

[ovs-dev] [ovn] Fixes before 22.09.0

2022-09-09 Thread Vladislav Odintsov
/20220907100457.1817917-1-odiv...@gmail.com/ 2: https://patchwork.ozlabs.org/project/ovn/patch/20220908140644.2647859-1-odiv...@gmail.com/ Regards, Vladislav Odintsov ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo

[ovs-dev] [PATCH ovn v2] northd: drop traffic to disabled LSPs in ingress pipeline

2022-09-08 Thread Vladislav Odintsov
tion LSP's zone now as well. Signed-off-by: Vladislav Odintsov --- northd/northd.c | 18 ++-- northd/ovn-northd.8.xml | 21 ++--- tests/ovn-northd.at | 184 +--- 3 files changed, 135 insertions(+), 88 deletions(-) diff --git a/northd/northd.

Re: [ovs-dev] [PATCH ovn] northd: drop traffic to disabled LSPs in ingress pipeline

2022-09-08 Thread Vladislav Odintsov
Please, ignore this patch. It contains errors, I’ll resend v2. Regards, Vladislav Odintsov > On 8 Sep 2022, at 14:40, Vladislav Odintsov wrote: > > Prior to this patch traffic to LSPs, which are disabled with > `ovn-nbctl lsp-set-enabled disabled` was dropped in the end of >

[ovs-dev] [PATCH ovn] northd: drop traffic to disabled LSPs in ingress pipeline

2022-09-08 Thread Vladislav Odintsov
tion LSP's zone now as well. Port security testcases are updated. Signed-off-by: Vladislav Odintsov --- northd/northd.c | 22 +++--- tests/ovn-northd.at | 184 +++- 2 files changed, 128 insertions(+), 78 deletions(-) diff --git a/northd/northd.c b/north

[ovs-dev] [PATCH ovn] controller: flush associated conntrack zone on PB release

2022-09-07 Thread Vladislav Odintsov
This patch adds conntrack zone flush when port binding is released. system-test is added to test this functionality. Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2022-September/397524.html Signed-off-by: Vladislav Odintsov --- controller/ovn-controller.c | 4 +- tests/system

Re: [ovs-dev] [PATCH ovn] northd: don't add drop lflow if LB VIP matches LRP IP

2022-09-06 Thread Vladislav Odintsov
Thanks Numan. Regards, Vladislav Odintsov > On 6 Sep 2022, at 22:44, Numan Siddique wrote: > > On Wed, Aug 31, 2022 at 9:17 AM Vladislav Odintsov wrote: >> >> Please, add this tag before applying the patch: >> >> Reported-at: >> https://mail.ope

[ovs-dev] [ovn] Conntrack zone is not flushed on PB release

2022-09-06 Thread Vladislav Odintsov
port lsp1 from this chassis (sb_readonly=0) 2022-09-06T18:18:08.037Z|00982|main|DBG|removing ct zone 20 for 'lsp1' Regards, Vladislav Odintsov ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] northd: don't add drop lflow if LB VIP matches LRP IP

2022-08-31 Thread Vladislav Odintsov
Please, add this tag before applying the patch: Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2022-August/052021.html Regards, Vladislav Odintsov > On 31 Aug 2022, at 16:06, Vladislav Odintsov wrote: > > If it is needed to create Load Balancer within LR with V

[ovs-dev] [PATCH ovn] northd: don't add drop lflow if LB VIP matches LRP IP

2022-08-31 Thread Vladislav Odintsov
matches associated with this LR LB VIP. Tests are added as well. Signed-off-by: Vladislav Odintsov --- NEWS| 3 ++ northd/northd.c | 10 -- tests/ovn-northd.at | 86 + 3 files changed, 96 insertions(+), 3 deletions(-) diff --git

Re: [ovs-dev] [PATCH ovn] northd: support vtep LSP-attached LS to use L3 services

2022-08-19 Thread Vladislav Odintsov
Regards, Vladislav Odintsov > On 19 Aug 2022, at 04:05, Han Zhou wrote: > > > > On Thu, Aug 18, 2022 at 12:50 PM Vladislav Odintsov <mailto:odiv...@gmail.com>> wrote: > > > Regards, > Vladislav Odintsov > >> On 18 Aug 2022, at 20:

Re: [ovs-dev] [PATCH ovn] northd: support vtep LSP-attached LS to use L3 services

2022-08-18 Thread Vladislav Odintsov
Regards, Vladislav Odintsov > On 18 Aug 2022, at 20:07, Han Zhou wrote: > > > > On Thu, Aug 18, 2022 at 8:54 AM Vladislav Odintsov <mailto:odiv...@gmail.com>> wrote: > Hi Han, > > As I could understand, admission control flows were introduced for >

Re: [ovs-dev] [PATCH ovn] northd: support vtep LSP-attached LS to use L3 services

2022-08-18 Thread Vladislav Odintsov
LS. All other cases left untouched. Let me know if you have any questions. Regards, Vladislav Odintsov > On 18 Aug 2022, at 18:45, Han Zhou wrote: > > > On Mon, Aug 15, 2022 at 10:01 PM Odintsov Vladislav <mailto:vlodint...@croc.ru>> wrote: > > > >

Re: [ovs-dev] [PATCH ovn] northd: add support to make l3dgw ports fully distributed

2022-08-15 Thread Vladislav Odintsov
version of the patch before the soft freeze, is it still possible for this patch to be considered for 22.09.0? https://patchwork.ozlabs.org/project/ovn/patch/20220815141851.78904-1-odiv...@gmail.com/ Regards, Vladislav Odintsov > On 9 Aug 2022, at 04:54, Numan Siddique wrote: > > On M

[ovs-dev] [PATCH ovn] northd: support vtep LSP-attached LS to use L3 services

2022-08-15 Thread Vladislav Odintsov
If LRP's logical switch has attached LSP of vtep type, the is_chassis_resident() part is not added to lflow to allow traffic originated from logical switch to reach LR services (LBs, NAT). Signed-off-by: Vladislav Odintsov --- This is a continuation from [1] as a v2 edition after Numan's review

Re: [ovs-dev] [PATCH ovn] northd: add support to make l3dgw ports fully distributed

2022-08-08 Thread Vladislav Odintsov
Hi Numan, thanks for the review. My comments below. Regards, Vladislav Odintsov > On 8 Aug 2022, at 03:24, Numan Siddique wrote: > > On Wed, Jul 20, 2022 at 12:15 AM Vladislav Odintsov <mailto:odiv...@gmail.com>> wrote: >> >> This is used when traffic fr

[ovs-dev] [PATCH ovn] controller: fix typo in get_lport_type_str()

2022-07-19 Thread Vladislav Odintsov
Signed-off-by: Vladislav Odintsov --- controller/binding.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/controller/binding.c b/controller/binding.c index 9faef02dd..ba803ae3e 100644 --- a/controller/binding.c +++ b/controller/binding.c @@ -881,7 +881,7

[ovs-dev] [PATCH ovn] northd: add support to make l3dgw ports fully distributed

2022-07-19 Thread Vladislav Odintsov
This is used when traffic from HW VTEP goes to routable networks and logical switch to which VTEP logical port is attached also needs to support distributed routing features such as NAT and others. Signed-off-by: Vladislav Odintsov --- northd/northd.c | 8 +++- ovn-nb.xml | 10

[ovs-dev] openstack/ovsdbapp changes

2022-07-12 Thread Vladislav Odintsov
Hi, I’m interested whether changes to ovsdbapp repository are still accepted? We’ve got some [1], but the review process is on hold for a long time. Thanks. 1: https://review.opendev.org/q/owner:dragen15051%2540gmail.com+status:open Regards, Vladislav Odintsov

Re: [ovs-dev] [PATCH ovn] northd: set svc_mon status to offline if port_binding released

2022-07-07 Thread Vladislav Odintsov
Thanks Numan. Regards, Vladislav Odintsov > On 7 Jul 2022, at 19:57, Numan Siddique wrote: > > On Tue, Jul 5, 2022 at 1:54 PM Vladislav Odintsov <mailto:odiv...@gmail.com>> wrote: >> >> This patch fixes situation where a Load Balancer >> has corr

Re: [ovs-dev] [ovn] bug: load balancer health check status is not updated if port binding is released from chassis

2022-07-05 Thread Vladislav Odintsov
Thanks Numan for the hint. I’ve submitted the full patch here: https://patchwork.ozlabs.org/project/ovn/patch/20220705175154.3095150-1-odiv...@gmail.com/ It would be great if you can find some time for review. Thanks. Regards, Vladislav Odintsov > On 5 Jul 2022, at 18:44, Numan Siddique wr

[ovs-dev] [PATCH ovn] northd: set svc_mon status to offline if port_binding released

2022-07-05 Thread Vladislav Odintsov
dev/2022-July/395504.html Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2103740 Signed-off-by: Vladislav Odintsov --- northd/northd.c | 7 +++ tests/ovn-northd.at | 33 - tests/system-ovn.at | 11 ++- 3 files changed, 37 insertions(+), 1

Re: [ovs-dev] [ovn] bug: load balancer health check status is not updated if port binding is released from chassis

2022-07-05 Thread Vladislav Odintsov
;logical_port: sw1-p1, svc->status: online I guess this is a result of my misunderstanding of principle of incremental engine operation. Can you help to get an idea of why port_binding structure has stale state and how to "pull changes" for it? Regards, Vladislav Odintsov > On

[ovs-dev] [PATCH RFC ovn] northd: reset svc_mon status to offline if port_binding is released

2022-07-05 Thread Vladislav Odintsov
Signed-off-by: Vladislav Odintsov --- northd/northd.c | 14 ++ tests/system-ovn.at | 13 - 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/northd/northd.c b/northd/northd.c index 964af992f..4f8f1aaf9 100644 --- a/northd/northd.c +++ b/northd/northd.c

Re: [ovs-dev] [ovn] bug: load balancer health check status is not updated if port binding is released from chassis

2022-07-04 Thread Vladislav Odintsov
Thanks Numan, would you have time to fix it or maybe give an idea how to do it, so I can try? Regards, Vladislav Odintsov > On 4 Jul 2022, at 19:51, Numan Siddique wrote: > > On Mon, Jul 4, 2022 at 7:48 AM Vladislav Odintsov <mailto:odiv...@gmail.com>> wrote: >> &

[ovs-dev] [ovn] bug: load balancer health check status is not updated if port binding is released from chassis

2022-07-04 Thread Vladislav Odintsov
ure state remains online sleep 10 ovn-sbctl list service_mon # ensure OVS group and backend is still in bucket ovs-ofctl dump-groups br-int | grep 192.168.0.10 Looking forward to hear any thoughts on this. PS. don’t forget to kill ncat ;) Reg

Re: [ovs-dev] [PATCH ovn] controller, northd, vtep: support routed networks with HW VTEP

2022-05-16 Thread Vladislav Odintsov
Hi Numan, I’m fine with the changes and thank you. Regards, Vladislav Odintsov > On 17 May 2022, at 00:45, Numan Siddique wrote: > > > > On Wed, May 4, 2022 at 5:35 AM Vladislav Odintsov <mailto:odiv...@gmail.com>> wrote: > Hi, > > this is a quick

Re: [ovs-dev] GRO for VXLAN and GENEVE doesn't work with OOT kernel module on CentOS 7.x

2022-05-04 Thread Vladislav Odintsov
Hi Gregory, maybe you can take a brief look on this please? Thanks. Regards, Vladislav Odintsov > On 15 Apr 2022, at 11:43, Vladislav Odintsov wrote: > > Hi, > > can anybody give any idea on this please? > > + ovs-discuss > > Regards, > Vladislav Odintsov

Re: [ovs-dev] [PATCH ovn] controller, northd, vtep: support routed networks with HW VTEP

2022-05-04 Thread Vladislav Odintsov
Hi, this is a quick reminder. Thanks. Regards, Vladislav Odintsov > On 15 Apr 2022, at 11:46, Vladislav Odintsov wrote: > > Hi Numan, Ihar, Han, Mark, > > would somebody find some time to take a look on this please? > > Thanks. > > Regards, > Vladislav Odint

Re: [ovs-dev] [PATCH ovn] controller, northd, vtep: support routed networks with HW VTEP

2022-04-15 Thread Vladislav Odintsov
Hi Numan, Ihar, Han, Mark, would somebody find some time to take a look on this please? Thanks. Regards, Vladislav Odintsov > On 1 Apr 2022, at 11:32, Vladislav Odintsov wrote: > > When HW VTEP is used with OVN logical networks routed by > Logical Routers, only directly-attached

Re: [ovs-dev] GRO for VXLAN and GENEVE doesn't work with OOT kernel module on CentOS 7.x

2022-04-15 Thread Vladislav Odintsov
Hi, can anybody give any idea on this please? + ovs-discuss Regards, Vladislav Odintsov > On 7 Apr 2022, at 19:54, Vladislav Odintsov wrote: > > Hi, > > I’ve faced an issue where GENEVE and VXLAN offload on RX path doesn’t work > with openvswitch OOT kernel module. > T

[ovs-dev] GRO for VXLAN and GENEVE doesn't work with OOT kernel module on CentOS 7.x

2022-04-07 Thread Vladislav Odintsov
way to fix the initial (GRO for udp_tnl) issue and not to break things around this? :) Thanks. 1: https://github.com/openvswitch/ovs/commit/e1ededf45f072c41295f1b441a6f106159ff191b Regards, Vladislav Odintsov ___ dev mailing list d...

Re: [ovs-dev] [PATCH ovn 1/2] vtep: correctly bring vtep lport up in SBDB

2022-04-06 Thread Vladislav Odintsov
Regarding the code style, should I resend patch or this can be fixed when the patch gets applied? regards, Vladislav Odintsov > On 5 Apr 2022, at 23:03, Mark Michelson wrote: > > Hi, > > The subject claims this is patch 1/2, but I don't see patch 2/2 on patchwork > or o

Re: [ovs-dev] [PATCH ovn 1/2] vtep: correctly bring vtep lport up in SBDB

2022-04-06 Thread Vladislav Odintsov
Hi Mark, Initially there should be a second patch, but after sending the first I’ve decided to send second one separately: http://patchwork.ozlabs.org/project/ovn/patch/20220401083229.1583750-1-odiv...@gmail.com/ regards, Vladislav Odintsov > On 5 Apr 2022, at 23:03, Mark Michelson wr

[ovs-dev] [PATCH ovn] controller, northd, vtep: support routed networks with HW VTEP

2022-04-01 Thread Vladislav Odintsov
-by: Vladislav Odintsov --- controller-vtep/vtep.c | 31 --- controller/physical.c | 18 ++ northd/northd.c | 50 + northd/ovn-northd.8.xml | 55 + tests/ovn-northd.at | 9

[ovs-dev] [PATCH ovn 1/2] vtep: correctly bring vtep lport up in SBDB

2022-04-01 Thread Vladislav Odintsov
Signed-off-by: Vladislav Odintsov --- controller-vtep/binding.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/controller-vtep/binding.c b/controller-vtep/binding.c index 01d5a16d2..7c7bea90a 100644 --- a/controller-vtep/binding.c +++ b/controller-vtep/binding.c

Re: [ovs-dev] OVS 2.17.0 multiple test errors

2022-03-25 Thread Vladislav Odintsov
Thanks again Ilya, With branch-2.17 there are no problems for me. Regards, Vladislav Odintsov > On 25 Mar 2022, at 14:42, Vladislav Odintsov wrote: > > Hi Ilya, > > thaks for pointing to the patch - I didn’t notice it. > I’ll try it. > > Regards, > Vladislav Od

Re: [ovs-dev] OVS 2.17.0 multiple test errors

2022-03-25 Thread Vladislav Odintsov
Hi Ilya, thaks for pointing to the patch - I didn’t notice it. I’ll try it. Regards, Vladislav Odintsov > On 25 Mar 2022, at 14:28, Ilya Maximets wrote: > > On 3/25/22 12:11, Vladislav Odintsov wrote: >> Hi, >> >> I’m trying to build OVS v2.17.0 against CentOS 7.5

[ovs-dev] OVS 2.17.0 multiple test errors

2022-03-25 Thread Vladislav Odintsov
ith CentOS 7, or could be some configuration error on my build machine? Thanks. Regards, Vladislav Odintsov ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] rhel: fix logrotate user config option

2022-03-24 Thread Vladislav Odintsov
Thanks Numan. Regards, Vladislav Odintsov > On 24 Mar 2022, at 17:54, Numan Siddique wrote: > > On Tue, Mar 22, 2022 at 2:33 PM Mark Michelson wrote: >> >> Acked-by: Mark Michelson >> > > Thanks. > > I applied this patch to the main branch and b

[ovs-dev] [PATCH ovn] rhel: fix logrotate user config option

2022-03-22 Thread Vladislav Odintsov
/ovn/*.log , skipping ``` Replace 'ovn' user with 'openvswitch' to fix the issue. Signed-off-by: Vladislav Odintsov --- rhel/ovn-fedora.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rhel/ovn-fedora.spec.in b/rhel/ovn-fedora.spec.in index 3fb854a37..821eb03cc 100644

Re: [ovs-dev] [PATCH ovn v3] controller: add ovn-set-local-ip option

2022-02-22 Thread Vladislav Odintsov
Thanks Numan. Regards, Vladislav Odintsov > On 22 Feb 2022, at 18:41, Numan Siddique wrote: > > On Sat, Feb 19, 2022 at 1:38 AM Han Zhou wrote: >> >> On Fri, Feb 18, 2022 at 10:38 AM Vladislav Odintsov >> wrote: >>> >>> When transport node has

Re: [ovs-dev] [PATCH ovn v2] controller: add ovn-set-local-ip option

2022-02-18 Thread Vladislav Odintsov
Hi Numan, Han, please check this out (v3): https://patchwork.ozlabs.org/project/ovn/patch/20220218183814.2976667-1-odiv...@gmail.com/ Regards, Vladislav Odintsov > On 18 Feb 2022, at 20:16, Han Zhou wrote: > > On Thu, Feb 17, 2022 at 3:57 PM Numan Siddique wrote: >> >>

[ovs-dev] [PATCH ovn v3] controller: add ovn-set-local-ip option

2022-02-18 Thread Vladislav Odintsov
-by: Vladislav Odintsov --- controller/encaps.c | 43 + controller/ovn-controller.8.xml | 7 ++ tests/ovn-controller.at | 9 +++ 3 files changed, 44 insertions(+), 15 deletions(-) diff --git a/controller/encaps.c b/controller/encaps.c index

Re: [ovs-dev] [PATCH ovn v2] controller: add ovn-set-local-ip option

2022-02-17 Thread Vladislav Odintsov
Hi Han, thanks for the note about log message, I’ll fix this in v3 right after the question with other_config is resolved. Frankly speaking I also don’t understand why to sync ovn-set-local-ip option to other_config — I did this only because Numan asked to do :) Regards, Vladislav Odintsov

[ovs-dev] ovsdb with ovn-controller-vtep question

2022-02-15 Thread Vladislav Odintsov
.12.0/controller-vtep/vtep.c#L241 2: https://github.com/ovn-org/ovn/blob/v21.12.0/controller-vtep/vtep.c#L261 Regards, Vladislav Odintsov ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn v2] controller: add ovn-set-local-ip option

2022-02-15 Thread Vladislav Odintsov
Hi Numan, I’ve submitted the v2, please check this out: https://patchwork.ozlabs.org/project/ovn/patch/20220215145442.2868060-1-odiv...@gmail.com/ Regards, Vladislav Odintsov > On 11 Feb 2022, at 22:12, Numan Siddique wrote: > > On Wed, Feb 9, 2022 at 6:33 PM Vladislav Odintsov <

<    1   2   3   4   5   >