Re: [ovs-dev] [OVN PATCH] northd: add unsnat/undnat lflow for established connections

2022-10-10 Thread Wentao Jia
t.est snat lflow, the lflow priority is higher than ct.new snat lflow Does my fix make sense? B R Wentao Jia diff --git a/northd/northd.c b/northd/northd.c index 6771ccce5..77f160770 100644 --- a/northd/northd.c +++ b/northd/northd.c @@ -13298,7 +13298,7 @@ build_lrouter_out_snat_flow(struct hm

Re: [ovs-dev] [OVN PATCH] northd: add unsnat/undnat lflow for established connections

2022-10-09 Thread Wentao Jia
ackets:2, bytes:148, used:3.230s, offloaded:yes, dp:tc, actions:set(eth(src=fa:16:3e:ae:b5:e5,dst=8c:1f:64:30:61:43)),set(ipv4(ttl=63)),enp1s0np1 there maybe some wrong with ct_snat_in_czone, but I can not find it out do you have any idea about this ? B R Wentao Jia -Original Message-

Re: [ovs-dev] [OVN PATCH] northd: add unsnat/undnat lflow for established connections

2022-08-17 Thread Wentao Jia
Hi, Numan It is not difficult to reproduce,this is about snat/dnat rules create router and create different type of nat rules of this router no other issues to be considered。 BR Wentao Jia -Original Message- From: Numan Siddique Sent: Thursday, August 18, 2022 10:30 AM To: Wentao Jia

Re: [ovs-dev] [OVN PATCH] northd: add unsnat/undnat lflow for established connections

2022-08-17 Thread Wentao Jia
;1.1.1.45" logical ip: "192.168.210.102" type: "dnat_and_snat" nat 88b9371b-a058-46b5-91f9-6741edf3391a external ip: "1.1.1.124" logical ip: "192.168.210.0/24" type: "snat" nat f9843d73-341a-4557-b996-ce

Re: [ovs-dev] [OVN PATCH] northd: add unsnat/undnat lflow for established connections

2022-08-10 Thread Wentao Jia
014-77a8607a9406" && is_chassis_resident("cr-lrp-0e701852-85a0-4c57-8014-77a8607a9406")), action=(ct_dnat_in_czone;) table=1 (lr_out_undnat ), priority=100 , match=(ip && ip4.src == 192.168.210.0/24 && outport == "lrp-0e701852-85a0-4c57-8014-

[ovs-dev] 回复: [OVN PATCH] northd: add unsnat/undnat lflow for established connections

2022-08-10 Thread Wentao Jia
reason is tc offload only support established connection, ct commit action is considered to be un established connection and cannot be offloaded B R Wentao 发件人: Ales Musil 发送时间: 2022年8月9日 19:45 收件人: Wentao Jia 抄送: d...@openvswitch.org 主题: Re: [ovs-dev] [OVN PATCH] northd: add unsnat/undnat lflow

[ovs-dev] [OVN PATCH] northd: add unsnat/undnat lflow for established connections

2022-08-02 Thread Wentao Jia
:1f:64:30:61:43),eth_type(0x0800),ipv4(src=0.0.0.0/0.0.0.0,dst=1.1.1.240/255.255.255.240,proto=0/0,tos=0/0,ttl=0/0,frag=no), packets:1, bytes:60, used:6.531s, offloaded:yes, dp:tc, actions:ct_clear,enp1s0np1 Signed-off-by: Wentao Jia --- northd/northd.c | 10 +++--- 1 file changed, 3

Re: [ovs-dev] [PATCH] python: idl: set cond_changed to true if condition change requested

2022-04-01 Thread Wentao Jia
ss poll loop, >> because cond_changed is true will trigger immediate_wake() >> >> >> Fixes: 46d44cf ("python: idl: Add monitor_cond_since support.") >> --- > >Hi Wentao Jia, > >I'm not sure why this patch failed to apply. Applying it with pa

[ovs-dev] [PATCH] python: idl: set cond_changed to true if condition change requested

2022-04-01 Thread Wentao Jia
cond_changed set to true if _req_cond (requested condition change) is not none. This can avoid falling into an endless poll loop, because cond_changed is true will trigger immediate_wake() Fixes: 46d44cf ("python: idl: Add monitor_cond_since support.") Signed-off-by: Wentao Jia

[ovs-dev] [PATCH] python: idl: set cond_changed to true if condition change requested

2022-03-25 Thread Wentao Jia
cond_changed set to true if _req_cond (requested condition change) is not none. This can avoid falling into an endless poll loop, because cond_changed is true will trigger immediate_wake() Fixes: 46d44cf ("python: idl: Add monitor_cond_since support.") --- python/ovs/db/idl.py | 2 +- 1 file

Re: [ovs-dev] [PATCH] datapath: use after free flow mask on destroy flow table

2022-03-24 Thread Wentao Jia
Hi,TongHao and Ilya this patch was reported at https://mail.openvswitch.org/pipermail/ovs-discuss/2020-August/050489.html and it was fixed by patch 1f3a090("net: openvswitch: introduce common code for flushing flows") Best regards, Wentao Jia Hi,TongHao and Ilya I guess this bug

Re: [ovs-dev] [PATCH] datapath: use after free flow mask on destroy flow table

2022-03-24 Thread Wentao Jia
Hi,TongHao and Ilya I guess this bug was fixed by patch 1f3a090("net: openvswitch: introduce common code for flushing flows"),but this patch is not for fix bug use-after-free flow mask Best regards, Wentao Jia >> On 3/24/22 05:17, Wentao Jia wrote: >> > >>

[ovs-dev] [PATCH] datapath: use after free flow mask on destroy flow table

2022-03-23 Thread Wentao Jia
sible memleak on destroy flow-table") Signed-off-by: Wentao Jia Signed-off-by: Chuanjie Zeng --- datapath/flow_table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath/flow_table.c b/datapath/flow_table.c index 650338fb0..b2f4b1108 100644 --- a/datapath/flow_tab

[ovs-dev] [PATCH] datapath: use after free flow mask on destroy flow table

2022-03-23 Thread Wentao Jia
sible memleak on destroy flow-table") Signed-off-by: Wentao Jia Signed-off-by: Chuanjie Zeng --- datapath/flow_table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath/flow_table.c b/datapath/flow_table.c index 650338fb0..b2f4b1108 100644 --- a/datapath/flow_tab

[ovs-dev] [PATCH] python: idl: set cond_changed to false if last id is zero

2022-03-20 Thread Wentao Jia
after reconnection, cond_changed will be set to true, poll will be called and never block, cpu high load forever Signed-off-by: Wentao Jia --- python/ovs/db/idl.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/python/ovs/db/idl.py b/python/ovs/db/idl.py index 4ecdcaa19

Re: [ovs-dev] [PATCH OVN] ovndb-ctl:probe interval of ovndb-ctl daemon

2022-01-20 Thread Wentao Jia
line option" is a good way Thanks for your reply Best regards, Wentao Jia >> >> Hi, Ilya >> >> Initially, ovndb-ctl command is a program executed only once,probe interval >> is not be set。 >> ovndb-ctl daemon mode is a longrun program,so we need to s

Re: [ovs-dev] [PATCH OVN] ovndb-ctl:probe interval of ovndb-ctl daemon

2022-01-20 Thread Wentao Jia
Hi, Ilya Initially, ovndb-ctl command is a program executed only once,probe interval is not be set。 ovndb-ctl daemon mode is a longrun program,so we need to set probe interval。 Best regards, Wentao Jia >>> >>> ovndb-ctl deamon mode, the connection cannot be reconnected w

[ovs-dev] [PATCH] relay:probe interval of relay server

2022-01-09 Thread Wentao Jia
probe interval of relay server can be configured from "sb_global/nb_global options:relay_probe_interval" minimum and default value is 5s Signed-off-by: Wentao Jia --- ovsdb/relay.c | 74 +++ 1 file changed, 74 insertions(+) di

[ovs-dev] [PATCH] relay:probe interval of relay server

2022-01-07 Thread Wentao Jia
probe interval of relay server can be configured from "sb_global/nb_global options:relay_probe_interval" minimum and default value is 5s Signed-off-by: Wentao Jia --- ovsdb/relay.c | 73 +++ 1 file changed, 73 insertions(+) di

[ovs-dev] [PATCH] relay:add transaction history for relay server

2022-01-06 Thread Wentao Jia
relay server inherit transaction historys from cluster source server Signed-off-by: Wentao Jia --- lib/ovsdb-cs.c | 1 + lib/ovsdb-cs.h | 1 + ovsdb/ovsdb-server.c | 4 +++- ovsdb/relay.c| 22 -- ovsdb/transaction.c | 17 - ovsdb

[ovs-dev] [PATCH OVN] ovndb-ctl:probe interval of ovndb-ctl daemon

2022-01-06 Thread Wentao Jia
ovndb-ctl deamon mode, the connection cannot be reconnected when connection is broken, set inactivity probe interval to make it reconnected Signed-off-by: Wentao Jia --- utilities/ovn-dbctl.c | 4 1 file changed, 4 insertions(+) diff --git a/utilities/ovn-dbctl.c b/utilities/ovn

[ovs-dev] [PATCH] relay:add transaction history for relay server

2022-01-06 Thread Wentao Jia
relay server inherit transaction historys from cluster source server Signed-off-by: Wentao Jia --- lib/ovsdb-cs.c | 1 + lib/ovsdb-cs.h | 1 + ovsdb/ovsdb-server.c | 4 +++- ovsdb/relay.c| 22 -- ovsdb/transaction.c | 17 +++-- ovsdb

[ovs-dev] [PATCH] ovsdb-server:Add parameter "relay-leader-only-mode"

2022-01-06 Thread Wentao Jia
a lot of transactions maybe fail in cluster ovsdb because of prerequisite check mechanism, relay server connect to leader can avoid this issue Signed-off-by: Wentao Jia --- ovsdb/ovsdb-server.c | 21 + ovsdb/relay.c| 4 ++-- ovsdb/relay.h| 2 +- 3