[ovs-dev] [PATCH] netdev-linux: Fix wrong ceil rate when max-rate less than 8bit.

2017-11-01 Thread fukaige
From: Kaige Fu When max-rate is less than 8bit, the hc->max_rate will be set as htb->max_rate mistakenly instead of mtu of netdev. Fixes: 13c1637 ("smap: New function smap_get_ullong().") Signed-off-by: Kaige Fu --- lib/netdev-linux.c | 9 + 1

[ovs-dev] [PATCH] datapath: Remove redundant check for IFF_NO_QUEUE

2017-10-30 Thread fukaige
From: Kaige Fu IFF_NO_QUEUE is checked twice. This cause a situation that HAVE_IFF_NO_QUEUE is defined no matter whether the flag IFF_NO_QUEUE is defined in kernel or not. Signed-off-by: Kaige Fu --- datapath/linux/compat/include/linux/netdevice.h | 3

[ovs-dev] [PATCH] dpif: Remove duplicated word in comment for dpif_recv()

2017-08-25 Thread fukaige
From: Kaige Fu Signed-off-by: Kaige Fu --- lib/dpif.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/dpif.c b/lib/dpif.c index 79b2e6c..a4471d5 100644 --- a/lib/dpif.c +++ b/lib/dpif.c @@ -1547,11 +1547,11 @@

[ovs-dev] [PATCH v4] route-table: Remove netdevs in netdev_hash when deleted

2017-08-14 Thread fukaige
From: Kaige Fu Start a virtual machine with its backend tap device attached to a brought up linux bridge. If we delete the linux bridge when vm is still running, we'll get the following error when trying to create a ovs bridge with the same name. The reason is that

Re: [ovs-dev] [PATCH v3] route-table: Remove netdevs in netdev_hash when deleted

2017-08-14 Thread fukaige
> -Original Message- > From: Tonghao Zhang [mailto:xiangxia.m@gmail.com] > Sent: Thursday, August 10, 2017 9:23 AM > To: fukaige > Cc: ovs dev > Subject: Re: [ovs-dev] [PATCH v3] route-table: Remove netdevs in netdev_hash > when deleted > >

[ovs-dev] [PATCH v3] route-table: Remove netdevs in netdev_hash when deleted

2017-08-09 Thread fukaige
From: Kaige Fu Start a virtual machine with its backend tap device attached to a brought up linux bridge. If we delete the linux bridge when vm is still running, we'll get the following error when trying to create a ovs bridge with the same name. The reason is that

Re: [ovs-dev] [PATCH v3] tnl-ports: Remove netdevs in netdev_hash when deleted

2017-08-08 Thread fukaige
> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, August 09, 2017 4:06 AM > To: fukaige > Cc: d...@openvswitch.org; Zhaoshenglong > Subject: Re: [PATCH v3] tnl-ports: Remove netdevs in netdev_hash when > deleted > > On Thu, Jul 1

Re: [ovs-dev] [PATCH v3] tnl-ports: Remove netdevs in netdev_hash when deleted

2017-07-12 Thread fukaige
> -Original Message- > From: fukaige > Sent: Tuesday, July 11, 2017 3:34 PM > To: 'Ben Pfaff' > Cc: d...@openvswitch.org; Zhaoshenglong > Subject: RE: [PATCH v3] tnl-ports: Remove netdevs in netdev_hash when > deleted > > > > -Original Message--

Re: [ovs-dev] [PATCH v3] tnl-ports: Remove netdevs in netdev_hash when deleted

2017-07-11 Thread fukaige
> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Saturday, July 08, 2017 5:54 AM > To: fukaige > Cc: d...@openvswitch.org; Zhaoshenglong > Subject: Re: [PATCH v3] tnl-ports: Remove netdevs in netdev_hash when > deleted > > On Thu, Jun 1

[ovs-dev] [resend PATCH v3] tnl-ports: Remove netdevs in netdev_hash when deleted

2017-06-27 Thread fukaige
-eth: added service controller "punix:/var/run/openvswitch/br-eth.mgmt" Signed-off-by: fukaige <fuka...@huawei.com> --- lib/tnl-ports.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/tnl-ports.c b/lib/tnl-ports.c index 4a07dcb..5f5791c 100644 --- a/lib/tnl-ports

[ovs-dev] [PATCH v3] tnl-ports: Remove netdevs in netdev_hash when deleted

2017-06-14 Thread fukaige
-eth: added service controller "punix:/var/run/openvswitch/br-eth.mgmt" Signed-off-by: fukaige <fuka...@huawei.com> --- lib/tnl-ports.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/tnl-ports.c b/lib/tnl-ports.c index 4a07dcb..5f5791c 100644 --- a/lib/tnl-ports

Re: [ovs-dev] [PATCH v2] tnl-ports: Remove netdevs in netdev_hash when deleted

2017-06-14 Thread fukaige
> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Thursday, June 15, 2017 5:25 AM > To: fukaige > Cc: d...@openvswitch.org; Zhaoshenglong > Subject: Re: [PATCH v2] tnl-ports: Remove netdevs in netdev_hash when > deleted > > On Wed, Jun 1

[ovs-dev] [PATCH v2] tnl-ports: Remove netdevs in netdev_hash when deleted

2017-06-13 Thread fukaige
-eth: added service controller "punix:/var/run/openvswitch/br-eth.mgmt" Signed-off-by: fukaige <fuka...@huawei.com> --- lib/tnl-ports.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/tnl-ports.c b/lib/tnl-ports.c index bcf4b94..75b5909 100644 --- a/lib/tnl-p

Re: [ovs-dev] [PATCH v1] netdev-linux: Remove device in netdev_shash when deleted

2017-06-11 Thread fukaige
Thanks for review, I will consider your suggestion and push v2 patch as soon as possible. Thanks fukaige > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Friday, June 09, 2017 4:35 AM > To: fukaige > Cc: d...@openvswitch.org > Subject: Re: [PATC

[ovs-dev] [PATCH v1] netdev-linux: Remove device in netdev_shash when deleted

2017-05-30 Thread fukaige
-eth: added service controller "punix:/var/run/openvswitch/br-eth.mgmt" Change-Id: Ib5ead59bc91453f83549da89937c0d3607e0385e Signed-off-by: fukaige <fuka...@huawei.com> --- lib/netdev-linux.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/netdev-linux.c b/lib/netd

[ovs-dev] [PATCH v1] netdev-linux: Remove device in netdev_shash when deleted

2017-05-30 Thread fukaige
-eth: added service controller "punix:/var/run/openvswitch/br-eth.mgmt" Change-Id: Ib5ead59bc91453f83549da89937c0d3607e0385e Signed-off-by: fukaige <fuka...@huawei.com> --- lib/netdev-linux.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/netdev-linux.c b/lib/netd

Re: [ovs-dev] [bug] failed to add ovs bridge

2017-05-18 Thread fukaige
Ok, thank you. I'll pursue this. > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Thursday, May 18, 2017 10:41 AM > To: fukaige > Cc: d...@openvswitch.org > Subject: Re: [bug] failed to add ovs bridge > > I don't plan to pursue this because i

Re: [ovs-dev] [bug] failed to add ovs bridge

2017-05-17 Thread fukaige
No. I just hit this in the situation. Do you think this is a bug? What's your next plan? > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, May 17, 2017 11:55 PM > To: fukaige > Cc: d...@openvswitch.org > Subject: Re: [bug] failed to add

Re: [ovs-dev] [bug] failed to add ovs bridge

2017-05-16 Thread fukaige
be created. What do you think? Thanks fukaige > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, May 17, 2017 11:37 AM > To: fukaige > Cc: d...@openvswitch.org > Subject: Re: [bug] failed to add ovs bridge > > On Wed, May 17, 2017 at 01:1

Re: [ovs-dev] [bug] failed to add ovs bridge

2017-05-16 Thread fukaige
I test ovs 2.5.0/2.5.2/2.5.3 on ARM64 All got the same error. From: fukaige Sent: Wednesday, May 17, 2017 9:16 AM To: 'd...@openvswitch.org' Cc: 'Ben Pfaff' Subject: [bug] failed to add ovs bridge Hi, all I am using ovs-2.5.2 and get error when creating a bridge using “ovs-vsctl add-br br-eth

[ovs-dev] [bug] failed to add ovs bridge

2017-05-16 Thread fukaige
Hi, all I am using ovs-2.5.2 and get error when creating a bridge using “ovs-vsctl add-br br-eth” ovs-vsctl: Error detected while setting up 'br-eth'. See ovs-vswitchd log for details. ovs-vswitchd log is as below: 2017-05-11T03:45:25.293Z|00026|ofproto_dpif|INFO|system@ovs-system: