> -Original Message-
> From: Ilya Maximets
> Sent: Thursday, April 6, 2023 8:21 PM
> To: lin huang ; d...@openvswitch.org
> Cc: i.maxim...@ovn.org; Lin Huang ; Simon
> Horman
> Subject: Re: [PATCH v1 2/2] netdev-dpdk: add netdev-dpdk ingress pkts
> policer.
&g
> -Original Message-
> From: Simon Horman
> Sent: Thursday, April 6, 2023 8:48 PM
> To: Ilya Maximets
> Cc: lin huang ; d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v1 0/2] Add netdev-dpdk support for ingress
> and egress pkts policer.
>
> On Thu,
Hi Simon,
: )
Thanks for your reply.
There are some explanations about your comments.
Best regards, Huang Lin.
> -Original Message-
> From: Simon Horman
> Sent: Wednesday, April 5, 2023 8:28 PM
> To: lin huang
> Cc: d...@openvswitch.org; i.maxim...@ovn.org
> Sub
Hi Ilya,
Thanks for looking at this patch and for your feedback.
There are some explanations about your comments.
> -Original Message-
> From: Ilya Maximets
> Sent: Tuesday, April 4, 2023 11:08 PM
> To: mit...@outlook.com; d...@openvswitch.org
> Cc: i.maxim...@ovn
Hi Ilya,
Thanks for looking at this patch and for your feedback.
There are some explanations about your comments.
> -Original Message-
> From: Ilya Maximets
> Sent: Tuesday, April 4, 2023 10:58 PM
> To: mit...@outlook.com; d...@openvswitch.org
> Cc: i.maxim...@ovn
pkts_burst=2048`
Thanks a lot.
> -----Original Message-
> From: lin huang
> Sent: Sunday, April 2, 2023 5:30 PM
> To: d...@openvswitch.org; i.maxim...@ovn.org
> Cc: Lin Huang
> Subject: [PATCH v1 0/2] Add netdev-dpdk support for ingress and egress pkts
> policer.
>
>
Signed-off-by: Lin Huang
> -Original Message-
> From: Ilya Maximets
> Sent: Tuesday, April 4, 2023 3:48 AM
> To: mit...@outlook.com; d...@openvswitch.org
> Cc: i.maxim...@ovn.org; Lin Huang
> Subject: Re: [ovs-dev] [PATCH v2] conntrack-tp: Fix clang warning.
>
&g
Hi Eelco,
Thanks for reviewing.
The latest patch will be update soon.
> -Original Message-
> From: Eelco Chaudron
> Sent: Wednesday, October 19, 2022 8:06 PM
> To: mit...@outlook.com
> Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org; vdas...@gmail.com; Lin
> Hua
Hi Aaron,
Pls review my patch.
Thanks a lot.
> -Original Message-
> From: dev On Behalf Of
> mit...@outlook.com
> Sent: Wednesday, October 5, 2022 8:12 PM
> To: ovs-dev@openvswitch.org; i.maxim...@ovn.org; ktray...@redhat.com
> Cc: Lin Huang
> Subject: [ovs-dev
1500, then return the maximum mtu.
So, I will change "mtu > intf.mtu[0]" to "mtu < intf.mtu[0]."
Thanks a lot.
> -Original Message-
> From: Aaron Conole
> Sent: Wednesday, October 5, 2022 9:10 PM
> To: mit...@outlook.com
> Cc: ovs-dev@openvswitch.org; i.m
Hi Vasu,
Pls review my patch.
Thanks a lot.
> -Original Message-
> From: lin huang
> Sent: Friday, July 29, 2022 7:17 PM
> To: ovs-dev@openvswitch.org; echau...@redhat.com; i.maxim...@ovn.org;
> vdas...@gmail.com
> Cc: Lin Huang ; Zhang Yuhuang
>
> Subject: [
Hi Vasu & Eelco,
Pls review my patch.
Thanks a lot.
> -Original Message-
> From: lin huang
> Sent: Friday, July 29, 2022 7:17 PM
> To: ovs-dev@openvswitch.org; echau...@redhat.com; i.maxim...@ovn.org;
> vdas...@gmail.com
> Cc: Lin Huang ; Zhang Yuhuang
>
Hi Kevin,
Thanks for the review.
It's very helpful to me.
> -Original Message-
> From: Kevin Traynor
> Sent: Tuesday, May 17, 2022 11:34 PM
> To: mit...@outlook.com; ovs-dev@openvswitch.org
> Cc: Lin Huang
> Subject: Re: [PATCH v3 0/2] Fix ALB parameters
Hi Kevin,
Thanks for the review.
One comment below.
> -Original Message-
> From: Kevin Traynor
> Sent: Wednesday, May 11, 2022 5:44 PM
> To: Mike Pattrick ; lin huang
> Cc: d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH 1/2] dpif-netdev : Fix ALB parameter
Hi Kevin,
Thanks for the review, much appreciated.
I will send a new patch later.
> -Original Message-
> From: Kevin Traynor
> Sent: Wednesday, May 11, 2022 12:16 AM
> To: lin huang ; ovs-dev@openvswitch.org
> Subject: Re: [PATCH 2/2] dpif-netdev : Fix ALB 'rebal
.
Fixes: 5bf84282482a ("Adding support for PMD auto load balancing")
Signed-off-by: Lin Huang linhu...@ruijie.com.cn
---
lib/dpif-netdev.c | 6 +-
tests/alb.at | 20 +++-
2 files changed, 24 insertions(+), 2 deletions(-)
diff --git a/lib/dpif-netdev.c b/lib/d
The ALB parameters should never be negative.
So it's to use smap_get_ulonglong() or smap_get_uint() to get it properly.
Fixes: 5bf84282482a ("Adding support for PMD auto load balancing")
Signed-off-by: Lin Huang linhu...@ruijie.com.cn
---
lib/dpif-netdev.c | 14 +++---
1
and set a hard limit
to rebalance_intvl.
It also includes some self-tests.
Lin Huang (2):
dpif-netdev : Fix ALB parameters type mismatch.
dpif-netdev : Fix ALB 'rebalance_intvl' max hard limit.
lib/dpif-netdev.c | 20
tests/alb.at | 20 +++-
.
Fixes: 5bf84282482a ("Adding support for PMD auto load balancing")
Signed-off-by: Lin Huang linhu...@ruijie.com.cn<mailto:linhu...@ruijie.com.cn>
---
tests/alb.at | 20 +++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/tests/alb.at b/tests/alb.at
index 2be
The ALB parameters should never be negative.
So it's to use smap_get_ulonglong() or smap_get_uint() to get it properly.
Fixes: 5bf84282482a ("Adding support for PMD auto load balancing")
Signed-off-by: Lin Huang linhu...@ruijie.com.cn<mailto:linhu...@ruijie.com.cn>
---
l
This series fix ALB parameters type mismatch and set a hard limit
to rebalance_intvl.
It also includes some self-tests.
Lin Huang (2):
dpif-netdev : Fix ALB parameters type mismatch.
dpif-netdev : Fix ALB 'rebalance_intvl' max hard limit.
lib/dpif-netdev.c | 14 +++---
te
root/ovs/utilities/ovs-vsctl --no-wait set open_vSwitch .
> other_config:pmd-auto-lb-rebal-interval="-0"
>
> # 2022-04-28T14:01:07Z|00359|dpif_netdev|INFO|PMD auto load balance
> interval set to 1 mins
>
> However, we can add a guard for other negative numbers for the
Fix typo in comments.
Signed-off-by: Lin Huang
---
lib/dpif-netdev-private-flow.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/dpif-netdev-private-flow.h b/lib/dpif-netdev-private-flow.h
index 66016eb09..3b7a47d63 100644
--- a/lib/dpif-netdev-private-flow.h
+++ b/lib
ix pmd-auto-lb-rebal-interval's value to 1.
Fixes: 5bf84282482a ("Adding support for PMD auto load balancing")
Signed-off-by: Lin Huang linhu...@ruijie.com.cn<mailto:linhu...@ruijie.com.cn>
---
lib/dpif-netdev.c | 6 --
tests/alb.at | 10 ++
2 files changed, 14 insert
-lb-rebal-interval's value to 1.
Fixes: 5bf84282482a ("Adding support for PMD auto load balancing")
Signed-off-by: Lin Huang
---
lib/dpif-netdev.c | 6 --
tests/alb.at | 10 ++
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/lib/dpif-netdev.c
So, fix pmd-auto-lb-rebal-interval's value to 1.
Fixes: 5bf84282482a ("Adding support for PMD auto load balancing")
Signed-off-by: Lin Huang mailto:linhu...@ruijie.com.cn>>
---
lib/dpif-netdev.c | 8
tests/alb.at | 10 ++
2 files changed, 14 insertions(
Hi wenxu,
I send a relevant patch before:
https://patchwork.ozlabs.org/project/openvswitch/patch/meyp282mb33022fd47b7f116701d9e6fccd...@meyp282mb3302.ausp282.prod.outlook.com/
>
> If VXLAN tunnel's source ip and the output_bridge netdev's ip are not on
> the same subnet, tnl_send_arp_request() wi
Hi Ilya,
I am sorry for what I have done.
This patch looks good to me.
发件人: dev 代表 Ilya Maximets
发送时间: 2021年12月17日 8:05
收件人: ovs-dev@openvswitch.org
抄送: Lin Huang; Ilya Maximets
主题: [ovs-dev] [PATCH] bridge: Fix incorrect configuration of netdev&#
n_sys_4789 device failed: No such device"
If there are a lot of userspace tunnel ports on a bridge, the
iface_refresh_netdev_status() function will spend a lot of time.
So ignore userspace tunnel port ioctl(SIOCGIFINDEX) operation, just
return -ENODEV.
Signed-off-by: Lin Huang
Test-by
hi all,
pls review my code.
Regards,
Lin Huang
发件人: lin huang
发送时间: 2021年11月24日 21:32
收件人: d...@openvswitch.org
抄送: m...@redhat.com; aconole; i.maximets
主题: [PATCH v3] netdev-vport : Fix userspace tunnel ioctl(SIOCGIFINDEX) info
logs.
From: linhuang
n_sys_4789 device failed: No such device"
If there are a lot of userspace tunnel ports on a bridge, the
iface_refresh_netdev_status() function will spend a lot of time.
So ignore userspace tunnel port ioctl(SIOCGIFINDEX) operation, just
return -ENODEV.
Signed-off-by: Lin Huang
Test-by
uf, sizeof(buf));
+const char *dpif_type = netdev_get_dpif_type(netdev_);
-return linux_get_ifindex(name);
+return !strcmp(type, "system") ? linux_get_ifindex(name) : -ENODEV;
}
#define NETDEV_VPORT_GET_IFINDEX netdev_vport_get_ifindex
--
2.12.2
______
hi all,
pls review my code.
Regards,
Lin Huang
From: lin huang<mailto:mit...@outlook.com>
Date: 2021-10-25 13:16
To: d...@openvswitch.org<mailto:d...@openvswitch.org>
CC: Aaron Conole<mailto:acon...@redhat.com>;
i.maxim...@ovn.org<mailto:i.maxim...@ovn.org>
Subject:
Signed-off-by: Lin Huang
---
tests/system-traffic.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index 092de308b..528d22cfc 100644
--- a/tests/system-traffic.at
+++ b/tests/system-traffic.at
@@ -3915,7 +3915,7 @@ zone=4
From: linhuang
Userspace tunnel doesn't have a valid device in the kernel. So
get_ifindex() function (ioctl) always get error during
adding a port, deleting a port or updating a port status.
The info log is
"2021-08-29T09:17:39.830Z|00059|netdev_linux|INFO|ioctl(SIOCGIFINDEX)
on vxlan_sys_4789 d
> From: Aaron Conole [mailto:acon...@redhat.com]
> Sent: Wednesday, October 20, 2021 11:15 PM
> To: lin huang
> Cc: d...@openvswitch.org; david.march...@redhat.com;
> i.maxim...@ovn.org
> Subject: Re: [ovs-dev] [PATCH v1] netdev-vport : Fix userspace tunnel
> ioctl(SIOCGIFIND
From: linhuang
Userspace tunnel doesn't have a valid device in the kernel. So
get_ifindex() function (ioctl) always get error during
adding a port, deleting a port or updating a port status.
The info log is
"2021-08-29T09:17:39.830Z|00059|netdev_linux|INFO|ioctl(SIOCGIFINDEX)
on vxlan_sys_4789 d
From: linhuang
Userspace tunnel doesn't have a valid device in the kernel. So
get_ifindex() function (ioctl) always get error during
adding a port, deleting a port or updating a port status.
The info log is
"2021-08-29T09:17:39.830Z|00059|netdev_linux|INFO|ioctl(SIOCGIFINDEX)
on vxlan_sys_4789 d
From: linhuang
The dpif is used, so remove the OVS_UNUSED flag.
Signed-off-by: linhuang
---
lib/dpif-netdev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 4cd0e9ebd..75f381ec1 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif
The dpif parameter of zone limits function is used.
We need to remove OVS_UNUSED flag.
Signed-off-by: linhuang
---
lib/dpif-netdev.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index b3e57bb95..1708a5f9e 100644
---
From: linhuang
Dpif parameter is used.So we need to remove OVS_UNUSED flag.
Signed-off-by: linhuang
---
lib/dpif-netdev.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index b3e57bb95..1708a5f9e 100644
--- a/lib/dpi
Call json_destroy() after json_object_create.
Signed-off-by: linhuang
---
ovsdb/ovsdb-tool.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/ovsdb/ovsdb-tool.c b/ovsdb/ovsdb-tool.c
index 7a8997bba..05a0223e7 100644
--- a/ovsdb/ovsdb-tool.c
+++ b/ovsdb/ovsdb-tool.c
@@
Fix indentation and whitespace.
Signed-off-by: linhuang
---
lib/netdev-native-tnl.c | 40
lib/netdev-native-tnl.h | 5 +++--
2 files changed, 27 insertions(+), 18 deletions(-)
diff --git a/lib/netdev-native-tnl.c b/lib/netdev-native-tnl.c
index b89dfdd5
"ovs-ofctl dump-tlv-map ${bridge}" command need right ofp_version.
Signed-off-by: linhuang
---
utilities/ovs-save | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/ovs-save b/utilities/ovs-save
index 7d810cb40..069c5932e 100755
--- a/utilities/ovs-save
+++ b/utilities
1. That is arp/nd gateway learning
failed, no packets will be encapped in vxlan tunnel.
This patch fix it using the output_bridge netdev's ip as arp/nd request ip.
Signed-off-by: Lin Huang
---
lib/ovs-router.c | 2 +-
ofproto/ofproto-dpif-xlate.c | 31 ++
The quotes for strings like "br0" had been removed.In ovs-save file
get_highest_ofp_version function still using quotes as field separator.
That is, get_highest_ofp_version() always return OpenFlow14 version string,
not the highest ofp version.
This patch adds support for new string style to retur
netdev-linux.c : nl_sock_listen_all_nsid triggers NULL deref.
Signed-off-by: miter
---
lib/netdev-linux.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index 15b25084b..0994044ec 100644
--- a/lib/netdev-linux.c
+++ b/lib/netdev-lin
dpif-netdev.c : Fix indentation.
Add extra space to fix indentation.
Signed-off-by: miter
---
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 816945375..dc77fa2fa 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -7404,7 +7404,7 @@ dp_netdev_input__(struct dp_netdev_pmd_thread *p
dpif-netdev.c : Fix indentation.
Add extra space to fix indentation.
Signed-off-by: miter
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 816945375..dc77fa2fa 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -7404,7 +7404,7 @@ dp_netdev_input__(struct dp_netdev_pmd
>From 32113ea0fb65a99271359440316abf7d8a14f551 Mon Sep 17 00:00:00 2001
From: miter
Date: Wed, 19 May 2021 12:55:24 +0800
Subject: [PATCH] netdev-linux.c : nl_sock_listen_all_nsid triggers NULL deref.
Signed-off-by: miter
---
lib/netdev-linux.c | 4 +++-
1 file changed, 3 insertions(+), 1 delet
>Sent: Saturday, December 23, 2017 5:17 AM
>>To: lin huang
>>Cc: d...@openvswitch.org
>>Subject: Re: [ovs-dev] how to use ofctl/packet-out command???
>>
>>On Fri, Dec 22, 2017 at 09:04:41AM +, lin huang wrote:
>>> I want to redirect packet-out
Hi guys,
I want to redirect packet-out message to a specific port. Is there an
example for me??
Or someone who could teach me to use this feature??
Thank you!!!
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/lis
52 matches
Mail list logo
