Hi Eelco,
On 12/4/2023 5:01 PM, Eelco Chaudron wrote:
On 3 Dec 2023, at 15:19, miter wrote:
Hi Eelco,
Some comments below.
On 9/19/2023 10:58 PM, Eelco Chaudron wrote:
On 26 Aug 2023, at 8:01, mit...@outlook.com wrote:
From: Lin Huang
OvS has supported packet-per-second policer
Hi Eelco,
Some comments below.
On 9/19/2023 10:58 PM, Eelco Chaudron wrote:
On 26 Aug 2023, at 8:01, mit...@outlook.com wrote:
From: Lin Huang
OvS has supported packet-per-second policer which can be set at ingress
and egress side in kernel datapath. But the userspace datapath doesn't
sup
Hi Eelco,
Sorry for the late reply.
A comments below.
On 9/19/2023 10:57 PM, Eelco Chaudron wrote:
On 26 Aug 2023, at 8:01, mit...@outlook.com wrote:
From: Lin Huang
Now, token-bucket 'last_fill' is updated by token_bucket_withdraw()
itself.
Add a new function parameter 'now' to update
Hi Simon，
Sorry for the late reply and thank you for your reviewing.
Some comments inline.
On 8/16/2023 8:38 PM, Simon Horman wrote:
On Wed, Aug 09, 2023 at 12:19:21AM +0800, mit...@outlook.com wrote:
From: Lin Huang
OvS has supported packet-per-second policer which can be set at ingress
an
Hi Aaron,
Thanks for reviewing my code.
I will update a new patch later.
On 8/1/2023 4:10 AM, Aaron Conole wrote:
mit...@outlook.com writes:
From: Lin Huang
OvS has supported packet-per-second policer which can be set at ingress
and egress side in kernel datapath. But the userspace datapat
Hi Aaron,
Thanks for reviewing my code.
I will update a new patch later.
On 8/1/2023 4:11 AM, Aaron Conole wrote:
mit...@outlook.com writes:
From: Lin Huang
OvS has supported packet-per-second policer which can be set at ingress
and egress side in kernel datapath. But the userspace datapat
On 7/15/2023 4:51 PM, Eelco Chaudron wrote:
Send from my phone
Op 15 jul. 2023 om 06:01 heeft miter het volgende
geschreven:
Hi Eelco,
On 7/14/2023 9:18 PM, Eelco Chaudron wrote:
On 14 Jul 2023, at 13:34, Ilya Maximets wrote:
On 7/14/23 12:42, Eelco Chaudron wrote:
On 1 Jul 2023
Hi Eelco,
On 7/14/2023 9:18 PM, Eelco Chaudron wrote:
On 14 Jul 2023, at 13:34, Ilya Maximets wrote:
On 7/14/23 12:42, Eelco Chaudron wrote:
On 1 Jul 2023, at 16:40, mit...@outlook.com wrote:
From: Lin Huang
Now, token-bucket 'last_fill' is updated by token_bucket_withdraw() itself.
Add
Thank you for your reply.
On 7/14/2023 11:01 PM, Ilya Maximets wrote:
On 7/14/23 14:20, Eelco Chaudron wrote:
On 14 Jul 2023, at 13:52, Eelco Chaudron wrote:
On 1 Jul 2023, at 16:40, mit...@outlook.com wrote:
From: Lin Huang
OvS has supported packet-per-second policer which can be set at
Hi Ilya,
Thank you for your advice. 😁
Can I take 2 minutes off of your time? 😉
Does this command work correctly? I usually use this command to send
patches.
"git send-email --to d...@openvswitch.org --cover-letter --annotate -v6 -4"
Best regards, Lin Huang.
On 6/29/2023 10:51 PM, Ilya Maxim
Tested-by: Lin Huang
Tested-by: Zhang YuHuang
On 6/22/2023 6:32 AM, Ilya Maximets wrote:
Current implementation of meters in the userspace datapath takes
the meter lock for every packet batch. If more than one thread
hits the flow with the same meter, they will lock each other.
Replace the c
Hi Ilya,
Thanks for reviewing our code.
We have 20+ threads indeed, so taking the same meter lock makes 'now'
not updated timely.
Using lockless meter to police traffic will be a perfect solution. :)
Thanks a lot.
On 6/22/2023 6:35 AM, Ilya Maximets wrote:
On 6/21/23 18:07, Ilya Maximets
Hi/ilya,/
Could you please review my code?
On 5/31/2023 11:41 PM, mit...@outlook.com wrote:
From: Lin Huang
Currently, a meter's timestamp 'now' is set by 'pmd->ctx.now' which updated
by pmd_thread_ctx_time_update().
Before processing of the new packet batch:
- dpif_netdev_execute()
- dp_ne
Hi simon,
Thanks for your reviewing.
On 5/10/2023 10:34 PM, Simon Horman wrote:
On Mon, May 01, 2023 at 07:33:38PM +0800, mit...@outlook.com wrote:
From: Lin Huang
OvS has supported packet-per-second policer which can be set at ingress
and egress side in kernel datapath. But the userspace
Hi Simon,
Thanks for your reviewing.
Sorry for the late reply.
I will update a new patch after some modification.
On 4/20/2023 4:52 PM, Simon Horman wrote:
Hi Lin Huang,
thanks for your patch.
On Sun, Apr 09, 2023 at 07:15:08PM +0800,mit...@outlook.com wrote:
From: Lin Huang
OvS has supp
This patch fix the style of bridge_configure_rstp() function.
Signed-off-by: linhuang
---
vswitchd/bridge.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index 5ed7e8234..4ada54475 100644
--- a/vswitchd/bridge.c
+++ b/vswitchd/br
From dbd4f52abf0429604d558b3d31112a5144a73349 Mon Sep 17 00:00:00 2001
From: miter
Date: Wed, 26 May 2021 19:51:29 +0800
Subject: [PATCH] odp-execute.c : Fix odp_execute_clone if-else coding
style.
Signed-off-by: linhuang
---
lib/odp-execute.c | 3 +--
1 file changed, 1 insertion(+), 2
From 2061ef85f1e76e75e8752db6f6ee8c35dffbb728 Mon Sep 17 00:00:00 2001
From: miter
Date: Wed, 26 May 2021 19:46:59 +0800
Subject: [PATCH] Fix bridge_configure_rstp if-else coding style.
Signed-off-by: linhuang
---
vswitchd/bridge.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions
Author: miter
Date: Wed May 26 19:51:29 2021 +0800
odp-execute.c : Fix odp_execute_clone if-else coding style.
Signed-off-by: Miter Lin
---
diff --git a/lib/odp-execute.c b/lib/odp-execute.c
index 6eeda2a61..95c8d71d2 100644
--- a/lib/odp-execute.c
+++ b/lib/odp-execute.c
@@ -735,8 +735,7
Author: miter
Date: Wed May 26 19:46:59 2021 +0800
bridge.c : Fix bridge_configure_rstp if-else coding style.
Signed-off-by: Miter Lin
---
diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index 5ed7e8234..4ada54475 100644
--- a/vswitchd/bridge.c
+++ b/vswitchd/bridge.c
@@ -1883,14
Author: miter
Date: Wed May 26 19:46:59 2021 +0800
bridge.c : Fix bridge_configure_rstp if-else coding style.
Signed-off-by: Miter Lin
---
diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index 5ed7e8234..4ada54475 100644
--- a/vswitchd/bridge.c
+++ b/vswitchd/bridge.c
@@ -1883,14
Author: miter
Date: Wed May 26 19:51:29 2021 +0800
odp-execute.c : Fix odp_execute_clone if-else coding style.
Signed-off-by: Miter Lin
diff --git a/lib/odp-execute.c b/lib/odp-execute.c
index 6eeda2a61..95c8d71d2 100644
--- a/lib/odp-execute.c
+++ b/lib/odp-execute.c
@@ -735,8
Author: miter
Date: Wed May 26 19:46:59 2021 +0800
bridge.c : Fix bridge_configure_rstp if-else coding style.
Signed-off-by: Miter Lin
diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index 5ed7e8234..4ada54475 100644
--- a/vswitchd/bridge.c
+++ b/vswitchd/bridge.c
@@ -1883,14
23 matches
Mail list logo
