If setting the port range in SNAT, we expect that the selected port is in the
range we set.
At the same time, this behavior is consistent with the kernel-datapath.
The port has no meaning for the icmp/icmpv6 protocol.
If no key is available, it will exit early.
Signed-off-by: LiWei
---
lib/c
ive series here:
> https://mail.openvswitch.org/pipermail/ovs-dev/2019-February/356654.html
>
Thanks for your quick ack.
I have seen the accepted patch-set in the upstream.
--
Thanks
Solomon
> Darrell
>
>
> On Mon, Feb 25, 2019 at 7:03 AM solomon wrote:
>
>>
>> If setting
ovs-appctl: ovs-vswitchd: transaction error (End of file)
--
Thanks
Solomon
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
if (!zone || *zone == conn->key.zone) {
> ovs_assert(conn->conn_type == CT_CONN_TYPE_DEFAULT);
> conn_clean(ct, conn, ctb);
> }
> }
> }
> ct_lock_unlock(&ctb->lock);
> }
>
>
ot;
> 3. ovs-ofctl dump-group-stats br-int
>
> gdb) bt
> at ../sysdeps/posix/libc_fatal.c:175
> ar_ptr=) at malloc.c:5049
> group_id=, cb=cb@entry=0x55cab8fd6cd0 ) at
> ofproto/ofproto.c:6790
>
> Signed-off-by: solomon
> Signed-off-by: Ben Pfaff
> ---
> ofpr
stats command.
Signed-off-by: solomon
---
include/openflow/openflow-1.1.h | 4 +++-
include/openvswitch/ofp-group.h | 8 +++-
lib/ofp-group.c | 11 ---
ofproto/ofproto-dpif.c | 3 ++-
tests/ofproto.at| 17 +
5 files change
The bucket id field is added to the ofp11_bucket_counter structure.
So, adjust the corresponding testcases.
Signed-off-by: solomon
---
tests/ofp-print.at | 48
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/tests/ofp-print.at b
Ben Pfaff wrote:
> On Thu, Mar 21, 2019 at 10:41:05AM +0800, solomon wrote:
>> Ben Pfaff wrote:
>>> On Wed, Mar 20, 2019 at 08:16:18PM +0800, Li Wei wrote:
>>>>
>>>> After inserting/removing a bucket, we don't update the bucket counter.
>>>&
Roi Dayan wrote>
>
> Hi,
>
> the title of the patch has non utf8 chars after the word 'tests'.
> can you check please.
>
> I see it as
>
> ovs: tests???Adjust the test cases about group stats
yes, there is a Chinese colon in original title.
>
> Thanks,
> Roi
> __
Ilya Maximets wrote:
>> On Thu, Mar 21, 2019 at 10:41:05AM +0800, solomon wrote:
>>> Ben Pfaff wrote:
>>>> On Wed, Mar 20, 2019 at 08:16:18PM +0800, Li Wei wrote:
>>>>>
>>>>> After inserting/removing a bucket, we don't update the bucket
Simon Horman wrote:
Also need to backport commit 0b4caa2eba to branch2.6~2.10.
>>>
>>> Thanks, I have made preliminary backports to the relevant branches
>>> and am running travisci to see if the tests pass.
>>>
>>> https://travis-ci.org/horms2/ovs/builds/511479533
>>
>> The check above, o
: Mon Feb 25 15:36:31 2019 -0800
conntrack: Fix wasted work for ICMP NAT.
Signed-off-by: solomon
---
lib/conntrack.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/lib/conntrack.c b/lib/conntrack.c
index d7d48a43a..9d6b8a358 100644
--- a/lib/conntrack.c
+++ b/lib
ICMP/ICMPv6 fails, if the src/dst port is set in a common NAT rule.
like this:
actions=ct(nat(dst=172.16.1.100:5000),commit,table=40)
Fixes: 4cd0481c9e8b ("conntrack: Fix wasted work for ICMP NAT.")
CC: Darrell Ball
Signed-off-by: solomon
Signed-off-by: Darrell Ball
---
lib/c
Thank you very much for your suggestions and testcases.
I sent a v2 patch，ref to
https://mail.openvswitch.org/pipermail/ovs-dev/2019-May/359385.html
Darrell Ball wrote:
> Thanks Solomon; fix looks good.
>
> Can you:
>
> 1/ Change subject to:
>
> "conntrack: ignor
ICMP/ICMPv6 fails, if the src/dst port is set in a common NAT rule.
like this:
actions=ct(nat(dst=172.16.1.100:5000),commit,table=40)
Fixes: 4cd0481c9e8b ("conntrack: Fix wasted work for ICMP NAT.")
CC: Darrell Ball
Signed-off-by: solomon
Signed-off-by: Darrell Ball
Co-authored-b
It looks good to me，thank you.
Darrell Ball wrote:
> From: solomon
>
> ICMP/ICMPv6 fails, if the src/dst port is set in a common NAT rule.
> For example:
> actions=ct(nat(dst=172.16.1.100:5000),commit,table=40)
>
> Fixes: 4cd0481c9e8b ("conntrack: Fix wasted
kets) {
-if (bucket->weight && gm->type != OFPGT11_SELECT) {
+if (bucket->weight && gm->type != OFPGT11_SELECT &&
+gm->command != OFPGC15_INSERT_BUCKET) {
return OFPERR_OFPGMFC_INVALID_GROUP;
}
--
2.11.0
--
Thanks
Solomon
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
e other types do
not use this weight parameter.
v1-->v2:
1. fix warning from 0-day robot.
Signed-off-by: solomon
---
lib/ofp-group.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/lib/ofp-group.c b/lib/ofp-group.c
index c9e95ad4c..6ba15fd82 100644
--
e other types do
not use this weight parameter.
v2-->v3:
1. add testcase.
v1-->v2:
1. fix warning from 0-day robot.
Signed-off-by: solomon
---
lib/ofp-group.c | 17 +++--
tests/ofproto.at | 14 ++
2 files changed, 25 insertions(+), 6 deletions(-)
diff --git a/lib
Aaron Conole wrote:
> solomon writes:
>
>> After creating a group with hash select type，then we need to insert a new
>> bucket with weight，
>> But，it fails. Commands are as following:
>>
>> # ovs-ofctl -O OpenFlow15 add-group br0 "group_id=10, type
e other types do
not use this weight parameter.
v3--v4:
1. remove the redundant space in testcase。
ref：https://api.travis-ci.org/v3/job/467942792/log.txt
v2-->v3:
1. add testcase.
v1-->v2:
1. fix warning from 0-day robot.
Signed-off-by: solomon
---
lib/ofp-group.c | 17
' is not defined"
GDB parses python scripts with python3, so need to replace "long" to "int" also.
--
Thanks
Solomon
>
> Signed-off-by: Eelco Chaudron
> ---
> utilities/gdb/ovs_gdb.py | 41 ++--
> 1 file changed,
still works on Python
> 2.7.
>
> Signed-off-by: Eelco Chaudron
Hi Eeclo:
Test your new patch with all commands, and another two error messages
are reported as following:
(gdb) ovs_dump_netdev
Traceback (most recent call last):
File "/root/solomon/ovs/utilities/gdb/ovs
;v2:
1. fix warning from 0-day robot.
Signed-off-by: solomon
---
lib/ofp-group.c | 8 +---
tests/ofproto.at | 14 ++
2 files changed, 19 insertions(+), 3 deletions(-)
diff --git a/lib/ofp-group.c b/lib/ofp-group.c
index c9e95ad4c..6857164f0 100644
--- a/lib/ofp-group.c
+++
Ben Pfaff wrote:
> On Mon, Dec 17, 2018 at 12:24:04PM +0800, solomon wrote:
>> After creating a group with hash select type，then we need to insert a new
>> bucket with weight，
>> But，it fails. Commands are as following:
>>
>> # ovs-ofctl -O OpenFlow15 add-gr
s on Python 2.7.
>
> The uKey walker is rather slow on python3, so added a spinner to
> indicate we are still busy processing entries.
>
> Fix functions using the iterkeys() function on dictionaries.
>
> Signed-off-by: Eelco Chaudron
It's good to me.
Tested-by: solomon
>
Bonjour,
Nous recherchons pour nos clients Promoteurs, Marchands de Biens et
Investisseurs, des terrains constructibles, des immeubles vides ou
loués, des locaux commerciaux ou industriels.
Toute France mais uniquement dans les grandes villes et leurs
agglomérations. Tous budgets.
Décrive
This patch addresses the checkpatch.pl warning that long long is
preferred over long long int.
Signed-off-by: Solomon Tan
---
net/openvswitch/meter.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/openvswitch/meter.c b/net/openvswitch/meter.c
index 04a060ac7fdf
28 matches
Mail list logo
