Re: [ovs-dev] [PATCH v6 1/2 ovn] External IP based NAT: Add Columns and CLI

2020-09-08 Thread svc . mail . git
Hi Numan, Thanks a lot for review and applying the patch. Sure, just sent out the patch for 'NEWS '. Regards, Ankur From: Numan Siddique Sent: Tuesday, September 8, 2020 2:14 AM To: svc.mail.git Cc: ovs-dev Subject: Re: [ovs-dev] [PATCH v6 1/2 ovn] External IP

Re: [ovs-dev] [PATCH v4 2/2 ovn] External IP based NAT: NORTHD changes to use applied/exempted external ip

2020-08-12 Thread svc . mail . git
Hi Numan, Sure, yes thats a valid concern. I will try to address this in V5. Regards, Ankur From: Numan Siddique Sent: Friday, August 7, 2020 2:37 AM To: svc.mail.git Cc: ovs-dev Subject: Re: [ovs-dev] [PATCH v4 2/2 ovn] External IP based NAT: NORTHD changes

Re: [ovs-dev] [PATCH v3 0/2 ovn] External IP based NAT

2020-08-04 Thread svc . mail . git
Hi Numan, Just submitted V4. Appreciate your feedback. Regards, Ankur From: Numan Siddique Sent: Monday, August 3, 2020 2:45 AM To: svc.mail.git Cc: ovs-dev Subject: Re: [ovs-dev] [PATCH v3 0/2 ovn] External IP based NAT On Thu, Jul 9, 2020 at 5:55 AM

Re: [ovs-dev] [PATCH v2 1/2 ovn] External IP based NAT: Add Columns and CLI

2020-07-08 Thread svc . mail . git
Hi Mark, Submitted V3. a. As of now, i have kept the usage of Address Set (based on the use case called out). However, please feel free to let me know, if you prefer moving to an ip address list. b. Renamed the columns to "applied_ext_ips" and "exempted_ext_ips". c. Improved the documentation

Re: [ovs-dev] [PATCH v2 1/2 ovn] External IP based NAT: Add Columns and CLI

2020-06-29 Thread svc . mail . git
Hi Mark, Thanks a lot for the feedback. a. Address Set is used to make sure that we don't have to configure common set of endpoint ips again and again. In a deployment, peered physical subnets will be common across all the logical routers, hence using address set looked better. As more IPs

Re: [ovs-dev] [PATCH v3 1/2 ovn] Fix the data type for DHCP option tftp_server (66)

2020-06-01 Thread svc . mail . git
Hi Numan, Thanks for reply. Sure, added Signed-off-by tag. Regards, Ankur From: Numan Siddique Sent: Monday, June 1, 2020 10:10 AM To: svc.mail.git Cc: ovs-dev ; Dhathri Purohith Subject: Re: [ovs-dev] [PATCH v3 1/2 ovn] Fix the data type for DHCP option

Re: [ovs-dev] [PATCH v2 ovn] Add support for DHCP options - Domain Search List (119) and TFTP server (66).

2020-05-07 Thread svc . mail . git
Hi Numan, Sure, no problem at all. We can wait till master is open for review. Regards, Ankur From: Numan Siddique Sent: Thursday, May 7, 2020 11:42 AM To: svc.mail.git Cc: ovs-dev ; Dhathri Purohith Subject: Re: [ovs-dev] [PATCH v2 ovn] Add support for DHCP

Re: [ovs-dev] [PATCH v4 1/2 ovn] NAT: Provide port range in input

2020-04-07 Thread svc . mail . git
Hi Numan, Thanks a lot for the feedback. Addressed the schema versioning in V5. Regarding the error seen. I tried with sparse and wError on my machine. I tried ./.travis/linux-build.sh as well, but compilation went through. Looking at the error, looks like it is complaining about string length

Re: [ovs-dev] [PATCH v3 0/2 ovn] NAT port range support

2020-04-02 Thread svc . mail . git
Hi Mark, Thanks a lot for review and Ack. Just submitted V4, with Author name in the beginning. Regards, Ankur From: Mark Michelson Sent: Thursday, April 2, 2020 6:55 AM To: svc.mail.git ; ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v3 0/2 ovn] NAT