[ovs-dev] [OVN v13] OVN - Add Support for Remote Port Mirroring

2022-11-04 Thread Abhiram R N
Mirror creation just creates the mirror. The lsp-attach-mirror triggers the sequence to create Mirror in OVS DB on compute node. OVS already supports Port Mirroring. Note: This is targeted to mirror to destinations anywhere outside the cluster where the analyser resides and it need not be an OVN n

Re: [ovs-dev] [OVN v13] OVN - Add Support for Remote Port Mirroring

2022-11-04 Thread 0-day Robot
Bleep bloop. Greetings Abhiram R N, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #2593 FILE: utilities/ovn-nbctl.c:275: mirror-a

Re: [ovs-dev] [OVN v13] OVN - Add Support for Remote Port Mirroring

2022-11-16 Thread Abhiram R N
Hi Ihar, Thanks for your inputs. I think I have found the issue in the test. In the test case I had missed one thing. Below are the details The log which you shared as the last message in ovs-vswitchd log led me to it. > 2022-11-15T16:31:05.280Z|00541|ofproto_dpif_xlate|WARN|over max > translati

Re: [ovs-dev] [OVN v13] OVN - Add Support for Remote Port Mirroring

2022-11-16 Thread Ihar Hrachyshka
The code is now closer to final, so I've drilled down and listed a number of nits and style changes recommended. These are not complete and you should apply similar changes to the whole body of the patch. I reviewed all the code except test suite changes since you were going to reshuffle the t

Re: [ovs-dev] [OVN v13] OVN - Add Support for Remote Port Mirroring

2022-11-17 Thread Ihar Hrachyshka
Dear Abhiram, today during the OVN IRC meeting we discussed this issue with vswitchd frozen on incorrect (?) mirror setup. We believe it is a legit issue in OVS. We have to understand what triggers it and whether it's safe to land OVN support before the OVS issue is resolved. (We'll also need to u