On Thu, Aug 25, 2022 at 1:57 PM Abhiram R N wrote:
>
> Hi Ihar,
>
> Thanks for the review of v4 patch.
> I will take care of the changes you have suggested in the xml(ovn-nb.xml),
> the tests (ovn-nbctl.at, ovn.at, ovn-northd.at) and ovn-nbctl.c in the next
> patch.
>
> Other than those regardin
Hi Ihar,
Thanks for the review of v4 patch.
I will take care of the changes you have suggested in the xml(ovn-nb.xml),
the tests (ovn-nbctl.at, ovn.at, ovn-northd.at) and ovn-nbctl.c in the next
patch.
Other than those regarding the ovn-controller.c and ovn-nb.ovsschema I have
replied inline belo
Hi,
I've reviewed everything except mirror.[ch] files. See below.
On Mon, Aug 22, 2022 at 4:41 PM Abhiram R N wrote:
>
> Added changes in ovn-nbctl, ovn-sbctl, northd and in ovn-controller.
> While Mirror creation just creates the mirror, the lsp-attach-mirror
> triggers the sequence to create M
Bleep bloop. Greetings Abhiram R N, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
#1758 FILE: utilities/ovn-nbctl.c:275:
mirror-a
Added changes in ovn-nbctl, ovn-sbctl, northd and in ovn-controller.
While Mirror creation just creates the mirror, the lsp-attach-mirror
triggers the sequence to create Mirror in OVS DB on compute node.
OVS already supports Port Mirroring.
Note: This is targeted to mirror to destinations anywhere
