Re: [ovs-dev] [PATCH] [ovs-dev v3] dpctl: Add support to count upcall packets

2023-01-04 Thread Michael Santana
On 12/27/22 22:41, wangchuanlei wrote: Add support to count upall packets, when kmod of openvswitch upcall to count the number of packets for upcall succeed and failed, which is a better way to see how many packets upcalled on every interfaces. Signed-off-by: wangchuanlei Hi wangchuanlei,

Re: [ovs-dev] [PATCH] [ovs-dev v3] dpctl: Add support to count upcall packets

2023-01-03 Thread Eelco Chaudron
On 3 Jan 2023, at 3:12, wangchuanlei wrote: > Hi eelco, > > thanks for review again , i will give a new version > base on your comments, here, i don't undestand what "Alignment is off" > mean, can you give a explanation? thank you! > >> true }, >> +[OVS_VPORT_ATTR_UPCALL_STATS] = {

Re: [ovs-dev] [PATCH] [ovs-dev v3] dpctl: Add support to count upcall packets

2023-01-02 Thread wangchuanlei
Hi eelco, thanks for review again , i will give a new version base on your comments, here, i don't undestand what "Alignment is off" mean, can you give a explanation? thank you! > true }, > +[OVS_VPORT_ATTR_UPCALL_STATS] = { .type = NL_A_NESTED, > +

Re: [ovs-dev] [PATCH] [ovs-dev v3] dpctl: Add support to count upcall packets

2023-01-02 Thread Eelco Chaudron
On 28 Dec 2022, at 3:41, wangchuanlei wrote: > Add support to count upall packets, when kmod of openvswitch upcall to > count the number of packets for upcall succeed and failed, which is a > better way to see how many packets upcalled on every interfaces. See my comments below. Also, let’s dis

[ovs-dev] [PATCH] [ovs-dev v3] dpctl: Add support to count upcall packets

2022-12-27 Thread wangchuanlei
Add support to count upall packets, when kmod of openvswitch upcall to count the number of packets for upcall succeed and failed, which is a better way to see how many packets upcalled on every interfaces. Signed-off-by: wangchuanlei --- Since v1: - Patch of add support Since v2: - Modify form

Re: [ovs-dev] [PATCH] [ovs-dev v3] dpctl: Add support to count upcall packets

2022-12-27 Thread 0-day Robot
Bleep bloop. Greetings wangchuanlei, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Inappropriate bracing around statement #107 FILE: lib/dpif-netlink.c:4733: else Lin

[ovs-dev] [PATCH] [ovs-dev v3] dpctl: Add support to count upcall packets

2022-12-27 Thread wangchuanlei
Add support to count upall packets, when kmod of openvswitch upcall to count the number of packets for upcall succeed and failed, which is a better way to see how many packets upcalled on every interfaces. Signed-off-by: wangchuanlei --- Since v1: - Patch of add support Since v2: - Modify forma