Hi Gaetan,
On 5/24/21 1:26 AM, Gaëtan Rivet wrote:
> On Wed, May 19, 2021, at 09:55, Maxime Coquelin wrote:
>> Hi Liang-min,
>>
>> When replying inline, please do not prefix with ">>" as it is handled as
>> quoted text. There is no need to prefix.
>>
>> On 5/18/21 8:00 PM, Wang, Liang-min wrote:
On Wed, May 19, 2021, at 09:55, Maxime Coquelin wrote:
> Hi Liang-min,
>
> When replying inline, please do not prefix with ">>" as it is handled as
> quoted text. There is no need to prefix.
>
> On 5/18/21 8:00 PM, Wang, Liang-min wrote:
> >> -Original Message-
> >> From: Maxime Coquelin
> -Original Message-
> From: Maxime Coquelin
> Sent: Wednesday, May 19, 2021 4:47 PM
> To: Wang, Liang-min ; Miskell, Timothy
> ; d...@openvswitch.org
> Subject: Re: [PATCH] Extends the existing mirror configuration parameters
>
>
>
> On 5/19/21 4:17 PM, Wang, Liang-min wrote:
> >>
On 5/19/21 4:17 PM, Wang, Liang-min wrote:
>> -Original Message-
>> From: Maxime Coquelin
>> Sent: Wednesday, May 19, 2021 8:50 AM
>> To: Wang, Liang-min ; Miskell, Timothy
>> ; d...@openvswitch.org
>> Subject: Re: [PATCH] Extends the existing mirror configuration parameters
>>
>>
>>
> -Original Message-
> From: Maxime Coquelin
> Sent: Wednesday, May 19, 2021 8:50 AM
> To: Wang, Liang-min ; Miskell, Timothy
> ; d...@openvswitch.org
> Subject: Re: [PATCH] Extends the existing mirror configuration parameters
>
>
>
> On 5/19/21 1:53 PM, Wang, Liang-min wrote:
> >>
On 5/19/21 1:53 PM, Wang, Liang-min wrote:
>> -Original Message-
>> From: Maxime Coquelin
>> Sent: Wednesday, May 19, 2021 3:56 AM
>> To: Wang, Liang-min ; Miskell, Timothy
>> ; d...@openvswitch.org
>> Subject: Re: [PATCH] Extends the existing mirror configuration parameters
>>
>> Hi
> -Original Message-
> From: Maxime Coquelin
> Sent: Wednesday, May 19, 2021 3:56 AM
> To: Wang, Liang-min ; Miskell, Timothy
> ; d...@openvswitch.org
> Subject: Re: [PATCH] Extends the existing mirror configuration parameters
>
> Hi Liang-min,
>
> When replying inline, please do not
Hi Liang-min,
When replying inline, please do not prefix with ">>" as it is handled as
quoted text. There is no need to prefix.
On 5/18/21 8:00 PM, Wang, Liang-min wrote:
>> -Original Message-
>> From: Maxime Coquelin
>> Sent: Tuesday, May 18, 2021 12:15 PM
>> To: Miskell, Timothy ;
> -Original Message-
> From: Maxime Coquelin
> Sent: Tuesday, May 18, 2021 12:15 PM
> To: Miskell, Timothy ; d...@openvswitch.org
> Cc: Wang, Liang-min
> Subject: Re: [PATCH] Extends the existing mirror configuration parameters
>
> Hi Timothy, Liang-min,
>
> Thanks for rebasing the
Hi Timothy, Liang-min,
Thanks for rebasing the patch.
A list of delta against the first RFC could help the reviewers.
I notice one change in the right direction is the conversion to Vhost
API datapath instead of Vhost PMD.
Also, I would suggest to have the patch split in several incremental
Bleep bloop. Greetings Timothy Miskell, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
#1224 FILE: lib/netdev.c:2331:
From: Liang-min Wang
The following parameters are added:
- mirror-offload: to turn on/off mirror offloading.
- output-port-name: specify a port, using name string, that is on a different
bridge
- output-src-vlan: output port vlan for each select-src-port.
- output-dst-vlan: output port
12 matches
Mail list logo
