> >>> +if (id != NULL) {
> >>
> >>It's safe to call free(NULL), so , please, don't check.
> > [Rick] Does it mean that we override the original free() method, so that it
> > won't crash when we call free(NULL)? If so, that is good and I don't need
> > to check here.
>
> It's part of a C
"Rick Zhong" writes:
> Hi Ilya,
>
> I took your advice and will submit a new merge request.
Please send an email with a link to the pull request. It's best if you
can use 'git send-email' to send the series to the list instead.
> As to the existing "autoattach" commands, it requires DCBX enabl
Hi Ilya,
I took your advice and will submit a new merge request.
As to the existing "autoattach" commands, it requires DCBX enabled on peer
device. Otherwise, nothing is shown by the command.
That's why I didn't merge into it.
Best regards,
Rick Zhong
At 2021-04-08 01:55:20, "Ilya Maximets"
On 4/7/21 7:08 PM, Rick Zhong wrote:
> Hi Ilya,
>
> Many thanks for your attention on this and reply. Please see my comments
> inline.
>
>
> And I will try the 'git' commands as you mentioned.
>
> Best regards,
>
> Rick Zhong
>
>
> At 2021-04-07 20:21:19, "Ilya Maximets" wrote:
>>On 3/24/2
Hi Ilya,
Many thanks for your attention on this and reply. Please see my comments inline.
And I will try the 'git' commands as you mentioned.
Best regards,
Rick Zhong
At 2021-04-07 20:21:19, "Ilya Maximets" wrote:
>On 3/24/21 4:56 AM, Rick Zhong wrote:
>> Dear OVS reviewers/supervisors:
Hi Ilya and Ben,
Actually I was thinking how to make documentation for such kind of user
commands change. Sure, I will provide it as you mentioned.
Best regards,
Rick Zhong
At 2021-04-07 23:11:00, "Ilya Maximets" wrote:
>On 4/7/21 4:40 PM, Ben Pfaff wrote:
>> On Wed, Apr 07, 2021 at 02:21:19
On 4/7/21 4:40 PM, Ben Pfaff wrote:
> On Wed, Apr 07, 2021 at 02:21:19PM +0200, Ilya Maximets wrote:
>> Also, it seems like none of these commands documented anywhere.
>> We will need to fix that someday.
>
> I'd recommend requiring documentation for anything being added, so the
> situation doesn'
On Wed, Apr 07, 2021 at 02:21:19PM +0200, Ilya Maximets wrote:
> Also, it seems like none of these commands documented anywhere.
> We will need to fix that someday.
I'd recommend requiring documentation for anything being added, so the
situation doesn't get worse.
We usually document this kind of
On 3/24/21 4:56 AM, Rick Zhong wrote:
> Dear OVS reviewers/supervisors:
>
>
> This patch is related to LLDP which provides a new command "ovs-appctl
> lldp/neighbor" to show LLDP neighbor info when LLDP is enabled on OVS
> interfaces.
>
>
> With this new command, user is enable to get LLDP ne
Dear OVS reviewers/supervisors:
This patch is related to LLDP which provides a new command "ovs-appctl
lldp/neighbor" to show LLDP neighbor info when LLDP is enabled on OVS
interfaces.
With this new command, user is enable to get LLDP neighbor info even if not in
SPB network.
One limitatio
10 matches
Mail list logo
