[ovs-dev] [PATCH] Makefiles: Fail build for flake8 only when configured with --enable-Werror.

2017-07-06 Thread Ben Pfaff
flake8 checking is useful. Until now, it always failed the build for any flake8 errors. This is too aggressive, for the same reason that always failing the build for any compiler warnings is too aggressive: compilers change over time and asynchronously from OVS itself. Thus, if we release some v

Re: [ovs-dev] [PATCH] Makefiles: Fail build for flake8 only when configured with --enable-Werror.

2017-07-06 Thread Russell Bryant
On Thu, Jul 6, 2017 at 6:12 PM, Ben Pfaff wrote: > flake8 checking is useful. Until now, it always failed the build for any > flake8 errors. This is too aggressive, for the same reason that always > failing the build for any compiler warnings is too aggressive: compilers > change over time and a

Re: [ovs-dev] [PATCH] Makefiles: Fail build for flake8 only when configured with --enable-Werror.

2017-07-07 Thread Ben Pfaff
On Thu, Jul 06, 2017 at 09:00:50PM -0400, Russell Bryant wrote: > On Thu, Jul 6, 2017 at 6:12 PM, Ben Pfaff wrote: > > flake8 checking is useful. Until now, it always failed the build for any > > flake8 errors. This is too aggressive, for the same reason that always > > failing the build for any