Re: [ovs-dev] [PATCH] OVN python IDL: avoid useless JSON conversion to enhance performance

2018-06-13 Thread Miguel Angel Ajo Pelayo
Thank you very much Ben :) On Wed, Jun 13, 2018 at 5:20 PM Ben Pfaff wrote: > OK, I crossported to branch-2.9. > > On Wed, Jun 13, 2018 at 01:24:44PM +0200, Miguel Angel Ajo Pelayo wrote: > > Ben, Russell, could we get this down to ovs 2.9? > > > > It's very important for scale. > > > > Best reg

Re: [ovs-dev] [PATCH] OVN python IDL: avoid useless JSON conversion to enhance performance

2018-06-13 Thread Ben Pfaff
OK, I crossported to branch-2.9. On Wed, Jun 13, 2018 at 01:24:44PM +0200, Miguel Angel Ajo Pelayo wrote: > Ben, Russell, could we get this down to ovs 2.9? > > It's very important for scale. > > Best regards, > Miguel Ángel. > > On Wed, Jun 13, 2018 at 1:13 PM Daniel Alvarez Sanchez > wrote:

Re: [ovs-dev] [PATCH] OVN python IDL: avoid useless JSON conversion to enhance performance

2018-06-13 Thread Miguel Angel Ajo Pelayo
Ben, Russell, could we get this down to ovs 2.9? It's very important for scale. Best regards, Miguel Ángel. On Wed, Jun 13, 2018 at 1:13 PM Daniel Alvarez Sanchez wrote: > Hi, > Bringing this up again. > Can we please get this backported into 2.9 branch? The enhancement is very > noticeable. >

Re: [ovs-dev] [PATCH] OVN python IDL: avoid useless JSON conversion to enhance performance

2018-06-13 Thread Daniel Alvarez Sanchez
Hi, Bringing this up again. Can we please get this backported into 2.9 branch? The enhancement is very noticeable. Thanks a lot! Daniel On Tue, Mar 6, 2018 at 5:09 PM, Lucas Alvares Gomes wrote: > Hi, > > Excellent investigative work here Daniel, thanks for that! > > On Wed, Feb 28, 2018 at 9:37

Re: [ovs-dev] [PATCH] OVN python IDL: avoid useless JSON conversion to enhance performance

2018-03-06 Thread Lucas Alvares Gomes
Hi, Excellent investigative work here Daniel, thanks for that! On Wed, Feb 28, 2018 at 9:37 AM, Miguel Angel Ajo Pelayo wrote: > And if we can get backports down the lane, that'd be great :) > +1 for backporting it. The changes seems straight forward to do so. > On Wed, Feb 28, 2018 at 9:37 AM

Re: [ovs-dev] [PATCH] OVN python IDL: avoid useless JSON conversion to enhance performance

2018-02-28 Thread Miguel Angel Ajo Pelayo
And if we can get backports down the lane, that'd be great :) On Wed, Feb 28, 2018 at 9:37 AM Miguel Angel Ajo Pelayo wrote: > Acked-by: Miguel Angel Ajo > > On Wed, Feb 28, 2018 at 9:13 AM Daniel Alvarez Sanchez < > dalva...@redhat.com> wrote: > >> Thanks Terry and Han for the reviews! >> I re

Re: [ovs-dev] [PATCH] OVN python IDL: avoid useless JSON conversion to enhance performance

2018-02-28 Thread Miguel Angel Ajo Pelayo
Acked-by: Miguel Angel Ajo On Wed, Feb 28, 2018 at 9:13 AM Daniel Alvarez Sanchez wrote: > Thanks Terry and Han for the reviews! > I removed the 'OVN' keyword from the title and submitted a v2: > [PATCH v2] python: avoid useless JSON conversion to enhance performance > > Thanks again. > Daniel

Re: [ovs-dev] [PATCH] OVN python IDL: avoid useless JSON conversion to enhance performance

2018-02-28 Thread Daniel Alvarez Sanchez
Thanks Terry and Han for the reviews! I removed the 'OVN' keyword from the title and submitted a v2: [PATCH v2] python: avoid useless JSON conversion to enhance performance Thanks again. Daniel On Wed, Feb 28, 2018 at 12:41 AM, Han Zhou wrote: > Great catch! > This patch is generic and not only

Re: [ovs-dev] [PATCH] OVN python IDL: avoid useless JSON conversion to enhance performance

2018-02-27 Thread Han Zhou
Great catch! This patch is generic and not only for OVN, so I suggest to remove the "OVN" keyword in commit title. Acked-by: Han Zhou On Tue, Feb 27, 2018 at 12:44 PM, Terry Wilson wrote: > On Tue, Feb 27, 2018 at 9:25 AM, Daniel Alvarez > wrote: > > This patch removes a useless conversion to

Re: [ovs-dev] [PATCH] OVN python IDL: avoid useless JSON conversion to enhance performance

2018-02-27 Thread Terry Wilson
On Tue, Feb 27, 2018 at 9:25 AM, Daniel Alvarez wrote: > This patch removes a useless conversion to/from JSON in the > processing of any 'modify' operations inside the process_update2 > method in Python IDL implementation. > > Previous code will make resources creation take longer as the number >

[ovs-dev] [PATCH] OVN python IDL: avoid useless JSON conversion to enhance performance

2018-02-27 Thread Daniel Alvarez
This patch removes a useless conversion to/from JSON in the processing of any 'modify' operations inside the process_update2 method in Python IDL implementation. Previous code will make resources creation take longer as the number of elements in the row grows because of that JSON conversion. This