The MPLS portions of this were inadvertently broken in v2.4 due to
433637881ca5 ("datapath: define compat __skb_gso_segment()") which
inverts the supports_mpls_gso() logic, then when rpl_dev_queue_xmit()
backport dropped its VLAN portion in v2.6, the whole function became a
no-op - since b63bf24882
Hi Joe,
On Wed, Feb 08, 2017 at 04:50:36PM -0800, Joe Stringer wrote:
> The MPLS portions of this were inadvertently broken in v2.4 due to
> 433637881ca5 ("datapath: define compat __skb_gso_segment()") which
> inverts the supports_mpls_gso() logic, then when rpl_dev_queue_xmit()
> backport dropped
On 9 February 2017 at 02:20, Simon Horman wrote:
> Hi Joe,
>
> On Wed, Feb 08, 2017 at 04:50:36PM -0800, Joe Stringer wrote:
>> The MPLS portions of this were inadvertently broken in v2.4 due to
>> 433637881ca5 ("datapath: define compat __skb_gso_segment()") which
>> inverts the supports_mpls_gso(
On Thu, Feb 09, 2017 at 04:32:08PM -0800, Joe Stringer wrote:
> On 9 February 2017 at 02:20, Simon Horman wrote:
> > Hi Joe,
> >
> > On Wed, Feb 08, 2017 at 04:50:36PM -0800, Joe Stringer wrote:
> >> The MPLS portions of this were inadvertently broken in v2.4 due to
> >> 433637881ca5 ("datapath: d
On 8 February 2017 at 16:50, Joe Stringer wrote:
> The MPLS portions of this were inadvertently broken in v2.4 due to
> 433637881ca5 ("datapath: define compat __skb_gso_segment()") which
> inverts the supports_mpls_gso() logic, then when rpl_dev_queue_xmit()
> backport dropped its VLAN portion in
On Thu, Mar 02, 2017 at 03:00:37PM -0800, Joe Stringer wrote:
> On 8 February 2017 at 16:50, Joe Stringer wrote:
> > The MPLS portions of this were inadvertently broken in v2.4 due to
> > 433637881ca5 ("datapath: define compat __skb_gso_segment()") which
> > inverts the supports_mpls_gso() logic,
On 20 March 2017 at 06:36, Simon Horman wrote:
> On Thu, Mar 02, 2017 at 03:00:37PM -0800, Joe Stringer wrote:
>> On 8 February 2017 at 16:50, Joe Stringer wrote:
>> > The MPLS portions of this were inadvertently broken in v2.4 due to
>> > 433637881ca5 ("datapath: define compat __skb_gso_segment(
Hi Simon,
I posted a patch series[1,2,3] to backport the MPLS GSO upstream
commits. It would be great if you could provide some feedback on that.
I have tested the backport series on kernel 4.4, and 4.9 with
the similar setup as in [3]. To trigger MPLS GSO, I use iperf instead of
the ping test in
