Re: [ovs-dev] [PATCH] compiler: Fix compilation when using VStudio 2015/2017

2019-04-16 Thread Alin Gabriel Serdean
Thanks both! I applied this patch as far back as branch-2.9. > On 16 Apr 2019, at 02:16, Anand Kumar via dev wrote: > > Acked-by: Anand Kumar > > Thanks, > Anand Kumar > > ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mail

Re: [ovs-dev] [PATCH] compiler: Fix compilation when using VStudio 2015/2017

2019-04-15 Thread Anand Kumar via dev
Acked-by: Anand Kumar Thanks, Anand Kumar On 4/3/19, 5:02 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Gabriel Serdean" wrote: This is somewhat a regression of: https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenvswitch%2Fovs%2Fcommit%2F27f1

Re: [ovs-dev] [PATCH] compiler: Fix compilation when using VStudio 2015/2017

2019-04-13 Thread Ben Pfaff
On Wed, Apr 03, 2019 at 03:01:55PM +0300, Alin Gabriel Serdean wrote: > This is somewhat a regression of: > https://github.com/openvswitch/ovs/commit/27f141d44d95b4cabfd7eac47ace8d1201668b2c > > The main issue using `offsetof` from via the C compiler from > MSVC 2015/2017 has issues and is buggy:

[ovs-dev] [PATCH] compiler: Fix compilation when using VStudio 2015/2017

2019-04-03 Thread Alin Gabriel Serdean
This is somewhat a regression of: https://github.com/openvswitch/ovs/commit/27f141d44d95b4cabfd7eac47ace8d1201668b2c The main issue using `offsetof` from via the C compiler from MSVC 2015/2017 has issues and is buggy: https://bit.ly/2UvWwti Until it is fixed, we define our own definition of `off