Re: [ovs-dev] [PATCH] connmgr: Fix vswitchd abort when a port is added and the controller is down

2018-10-17 Thread Numan Siddique
On Wed, Oct 17, 2018 at 10:01 PM Ben Pfaff wrote: > On Wed, Oct 17, 2018 at 05:33:05PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > We see the below trace when a port is added to a bridge and the > configured > > controller is down > > > > 0x7fb002f8b207 in raise () fro

Re: [ovs-dev] [PATCH] connmgr: Fix vswitchd abort when a port is added and the controller is down

2018-10-17 Thread Ben Pfaff
On Wed, Oct 17, 2018 at 05:33:05PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > We see the below trace when a port is added to a bridge and the configured > controller is down > > 0x7fb002f8b207 in raise () from /lib64/libc.so.6 > 0x7fb002f8c8f8 in abort () from /lib64/li

Re: [ovs-dev] [PATCH] connmgr: Fix vswitchd abort when a port is added and the controller is down

2018-10-17 Thread Numan Siddique
On Wed, Oct 17, 2018 at 7:45 PM Eelco Chaudron wrote: > > > On 17 Oct 2018, at 14:03, nusid...@redhat.com wrote: > > > From: Numan Siddique > > > > We see the below trace when a port is added to a bridge and the > > configured > > controller is down > > > > 0x7fb002f8b207 in raise () from /l

Re: [ovs-dev] [PATCH] connmgr: Fix vswitchd abort when a port is added and the controller is down

2018-10-17 Thread Eelco Chaudron
On 17 Oct 2018, at 14:03, nusid...@redhat.com wrote: From: Numan Siddique We see the below trace when a port is added to a bridge and the configured controller is down 0x7fb002f8b207 in raise () from /lib64/libc.so.6 0x7fb002f8c8f8 in abort () from /lib64/libc.so.6 0x7fb00495

Re: [ovs-dev] [PATCH] connmgr: Fix vswitchd abort when a port is added and the controller is down

2018-10-17 Thread Miguel Angel Ajo Pelayo
Wow, proper TDD! Is it possible to get this backported at least down to 2.10 ? Acked-by: Miguel Angel Ajo More context here: https://bugzilla.redhat.com/show_bug.cgi?id=1640045 On Wed, Oct 17, 2018 at 2:59 PM Numan Siddique wrote: > > > On Wed, Oct 17, 2018 at 6:27 PM Miguel Angel Ajo Pelay

Re: [ovs-dev] [PATCH] connmgr: Fix vswitchd abort when a port is added and the controller is down

2018-10-17 Thread Numan Siddique
On Wed, Oct 17, 2018 at 6:27 PM Miguel Angel Ajo Pelayo wrote: > Wow, that was quick Numans, > > Did you try the negative of the test? (removing your patch on the C side > and trying the test > to make sure it fails?) > Yes. I actually started with the test to make sure it fails before working o

Re: [ovs-dev] [PATCH] connmgr: Fix vswitchd abort when a port is added and the controller is down

2018-10-17 Thread Miguel Angel Ajo Pelayo
Wow, that was quick Numans, Did you try the negative of the test? (removing your patch on the C side and trying the test to make sure it fails?) On Wed, Oct 17, 2018 at 2:08 PM wrote: > From: Numan Siddique > > We see the below trace when a port is added to a bridge and the configured > cont

[ovs-dev] [PATCH] connmgr: Fix vswitchd abort when a port is added and the controller is down

2018-10-17 Thread nusiddiq
From: Numan Siddique We see the below trace when a port is added to a bridge and the configured controller is down 0x7fb002f8b207 in raise () from /lib64/libc.so.6 0x7fb002f8c8f8 in abort () from /lib64/libc.so.6 0x7fb004953026 in ofputil_protocol_to_ofp_version () from /lib64/libop