lieu of 'liberal' mode; this will do as you
>> require.
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> Hardware offload implementations can be done well or poorly; catering to
>> poor implementations at the cost to every other use
On Tue, Jun 4, 2019 at 11:41 PM 姜立东 wrote:
> *comments* *inline*.
>
>
>
> *发件人:* Darrell Ball
> *发送时间:* 2019年6月5日 13:31
> *收件人:* 姜立东
> *抄送:* d...@openvswitch.org; 王志克
> *主题:* Re: [ovs-dev] [PATCH] conntrack: add tcp_in_liberal option in
> userspace conntrack
On Tue, Jun 4, 2019 at 7:13 PM 姜立东 wrote:
> Please check *comments* *inline*.
>
>
>
> BR, Lidong
>
>
>
> *发件人:* Darrell Ball
> *发送时间:* 2019年6月4日 23:33
> *收件人:* 姜立东
> *抄送:* d...@openvswitch.org; 王志克
> *主题:* Re: [ovs-dev] [PATCH] conntrack: add tcp_in_
d.
>
>
> I think tighter check is good for normal situation, but may be conflict
> with the purpose of TCP liberal mode by putting more limitations.
>
>
> BR, Lidong
>
>
>
> *发件人:* Darrell Ball
> *发送时间:* 2019年6月3日 23:53
> *收件人:* 姜立东
> *抄送:* d...
sws))
>
> + /* Acking not more than one window forward */
>
> && ((tcp_flags & TCP_RST) == 0 || orig_seq == src->seqlo
>
> -|| (orig_seq == src->seqlo + 1) || (orig_seq + 1 ==
> src->seqlo))) {
>
> + || (orig_seq == src
eqlo + 1) || (orig_seq + 1 ==
src->seqlo))) {+ || (orig_seq == src->seqlo + 1)+
|| (orig_seq + 1 == src->seqlo))) {
/* Require an exact/+1 sequence match on resets when possible */
/* update max window */
>
>>
>
> Thanks Lidong
anks Lidong
The algorithm I used adheres to the liberal mode definition.
For future reference, another important aspect is test support.
Darrell
>
>
> BR,
>
> Lidong
>
>
>
> *发件人:* Darrell Ball
> *发送时间:* 2019年5月30日 14:51
> *收件人:* 姜立东
> *抄送:* d...@openvs
Hi Lidong/Zhike
I sent an alternative implementation:
https://mail.openvswitch.org/pipermail/ovs-dev/2019-May/359364.html
Pls take a look and check if it meets your requirements.
Thanks Darrell
On Fri, May 24, 2019 at 10:11 AM Darrell Ball wrote:
> Thanks for the patch Lidong/Zhike
>
> I took
Thanks for the patch Lidong/Zhike
I took an initial look and will send a response next week.
Darrell
On Tue, May 21, 2019 at 8:53 PM 姜立东 wrote:
> From 3ce112684921bca74839e109fda91848aa024a54 Mon Sep 17 00:00:00 2001
> From: Jiang Lidong
> Date: Wed, 22 May 2019 11:21:34 +0800
> Subject: [PAT
From 3ce112684921bca74839e109fda91848aa024a54 Mon Sep 17 00:00:00 2001
From: Jiang Lidong
Date: Wed, 22 May 2019 11:21:34 +0800
Subject: [PATCH] conntrack: add tcp_in_liberal option in userspace conntrack
Adding similar cp_in_liberal option in userspace conntrack as
kernel conntrack does to skip
10 matches
Mail list logo
