Re: [ovs-dev] [PATCH] datapath: use after free flow mask on destroy flow table

2022-03-24 Thread Wentao Jia
Hi,TongHao and Ilya this patch was reported at https://mail.openvswitch.org/pipermail/ovs-discuss/2020-August/050489.html and it was fixed by patch 1f3a090("net: openvswitch: introduce common code for flushing flows") Best regards, Wentao Jia Hi,TongHao and Ilya I guess this bug was fixed

Re: [ovs-dev] [PATCH] datapath: use after free flow mask on destroy flow table

2022-03-24 Thread Wentao Jia
Hi,TongHao and Ilya I guess this bug was fixed by patch 1f3a090("net: openvswitch: introduce common code for flushing flows"),but this patch is not for fix bug use-after-free flow mask Best regards, Wentao Jia >> On 3/24/22 05:17, Wentao Jia wrote: >> > >> > >> > on destroy flow table instan

Re: [ovs-dev] [PATCH] datapath: use after free flow mask on destroy flow table

2022-03-24 Thread Tonghao Zhang
On Thu, Mar 24, 2022 at 6:32 PM Ilya Maximets wrote: > > On 3/24/22 05:17, Wentao Jia wrote: > > > > > > on destroy flow table instance, referenced flow mask may be released > > too. fuction ovs_flow_tbl_destroy(), release flow mask first and then > > destroy flow table instance. this will trigger

Re: [ovs-dev] [PATCH] datapath: use after free flow mask on destroy flow table

2022-03-24 Thread Ilya Maximets
On 3/24/22 05:17, Wentao Jia wrote: > > > on destroy flow table instance, referenced flow mask may be released > too. fuction ovs_flow_tbl_destroy(), release flow mask first and then > destroy flow table instance. this will trigger kernel panic on detroy > datapath > > > [ 377.647756] kernel B

Re: [ovs-dev] [PATCH] datapath: use after free flow mask on destroy flow table

2022-03-23 Thread 0-day Robot
Bleep bloop. Greetings Wentao Jia, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: corrupt patch at line 19 error: could not build fake ancestor hint: Use 'git am --show-current

[ovs-dev] [PATCH] datapath: use after free flow mask on destroy flow table

2022-03-23 Thread Wentao Jia
on destroy flow table instance, referenced flow mask may be released too. fuction ovs_flow_tbl_destroy(), release flow mask first and then destroy flow table instance. this will trigger kernel panic on detroy datapath [ 377.647756] kernel BUG at .../datapath/linux/flow_table.c:272! [ 377.653

Re: [ovs-dev] [PATCH] datapath: use after free flow mask on destroy flow table

2022-03-23 Thread 0-day Robot
Bleep bloop. Greetings Wentao Jia, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: patch failed: datapath/flow_table.c:415 error: datapath/flow_table.c: patch does not apply err

[ovs-dev] [PATCH] datapath: use after free flow mask on destroy flow table

2022-03-23 Thread Wentao Jia
on destroy flow table instance, referenced flow mask may be released too. fuction ovs_flow_tbl_destroy(), release flow mask first and then destroy flow table instance. this will trigger kernel panic on detroy datapath [ 377.647756] kernel BUG at .../datapath/linux/flow_table.c:272! [ 377.653