Re: [ovs-dev] [PATCH] datapath-windows: Fix parsing of split buffers in OvsGetTcpHeader.

2024-06-28 Thread Wenying Dong via dev
Hi Alin, llya, I have tried the patch, unfortunately, we hit BSOD after patching the change. So I think it doesn't work. Best regards, Wenying On Fri, Jun 7, 2024 at 8:58 AM Wenying Dong wrote: > Sure, happy to help if we have a patch. > > Best, > Wenying > > On Thu, Jun 6, 2024 at 7:19 PM Al

Re: [ovs-dev] [PATCH] datapath-windows: Fix parsing of split buffers in OvsGetTcpHeader.

2024-06-07 Thread Wenying Dong via dev
Sure, happy to help if we have a patch. Best, Wenying On Thu, Jun 6, 2024 at 7:19 PM Alin Serdean wrote: > Hi Ilya, > > Thanks for the patch. Will try to get a setup and test it. > > In theory if we have a new analyze target of a newer visual studio it > should flag those types of issues. > > W

Re: [ovs-dev] [PATCH] datapath-windows: Fix parsing of split buffers in OvsGetTcpHeader.

2024-06-06 Thread Alin Serdean
Hi Ilya, Thanks for the patch. Will try to get a setup and test it. In theory if we have a new analyze target of a newer visual studio it should flag those types of issues. Will try to send a patch for the aforementioned target. Wenying can you help in testing the patch? Thank you, Alin.

[ovs-dev] [PATCH] datapath-windows: Fix parsing of split buffers in OvsGetTcpHeader.

2024-06-06 Thread Ilya Maximets
NdisGetDataBuffer() is called without providing a buffer to copy packet data in case it is not contiguous. So, it fails in some scenarios where the packet is handled by the general network stack before OVS and headers become split in multiple buffers. Use existing helpers to retrieve the headers