Re: [ovs-dev] [PATCH] datapath-windows: Set Version correctly for OVSExt

2017-05-15 Thread Alin Serdean
Sorry I cut a bit to much. Like the following (also attached): --- datapath-windows/ovsext/ovsext.rc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/datapath-windows/ovsext/ovsext.rc b/datapath-windows/ovsext/ovsext.rc index a7cf0a7..20e54bf 100644 --- a/datapath-windows/ov

Re: [ovs-dev] [PATCH] datapath-windows: Set Version correctly for OVSExt

2017-05-15 Thread Shashank Ram
ank Ram; d...@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: Set Version correctly for OVSExt I think the same effect can be achieved using this incremental: --- datapath-windows/ovsext/ovsext.rc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/datapath-windows/ovsext/ov

Re: [ovs-dev] [PATCH] datapath-windows: Set Version correctly for OVSExt

2017-05-15 Thread Alin Serdean
BLOCK "VarFileInfo" -- 2.10.2.windows.1 Without the need to change the vcxproj. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Alin Serdean > Sent: Monday, May 15, 2017 11:50 PM > To: Shashank

Re: [ovs-dev] [PATCH] datapath-windows: Set Version correctly for OVSExt

2017-05-15 Thread Shashank Ram
17 1:50:09 PM To: Shashank Ram; d...@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: Set Version correctly for OVSExt Thanks a lot for the patch. I had to double look the changes. It may be worth adding to the commit message that this impacts the way the "ovsext.sys"

Re: [ovs-dev] [PATCH] datapath-windows: Set Version correctly for OVSExt

2017-05-15 Thread Alin Serdean
s-dev- > boun...@openvswitch.org] On Behalf Of Shashank Ram > Sent: Saturday, May 6, 2017 1:58 AM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH] datapath-windows: Set Version correctly for > OVSExt > > - Previously, the 'Version' property passed to MSBuild

[ovs-dev] [PATCH] datapath-windows: Set Version correctly for OVSExt

2017-05-05 Thread Shashank Ram
- Previously, the 'Version' property passed to MSBuild was not being passed to the RcComplile section. To use the value of 'Version' property in the rc file, it needs to be passed. - Adds a macro to convert the Version to a string literal. Previously, the Version was simply being converted