Re: [ovs-dev] [PATCH] datapath-windows: Specify external include paths

2021-06-30 Thread alinserdean
Hi Guru, Thank you for letting me know. I backported the change until 2.13. Thank you, Alin. From: Guru Shetty Sent: Saturday, June 26, 2021 1:14 AM To: Alin-Gabriel Serdean Cc: Ilya Maximets ; ovs dev ; Frank Wagner Subject: Re: [ovs-dev] [PATCH] datapath-windows: Specify

Re: [ovs-dev] [PATCH] datapath-windows: Specify external include paths

2021-06-25 Thread Guru Shetty
Alin, Does it make sense to apply this patch to stable branches too. I see that 2.15 fails with a similar error. Thanks, Guru On Thu, 17 Jun 2021 at 02:31, Alin-Gabriel Serdean wrote: > On Wed, 2021-06-16 at 18:06 +0300, Alin-Gabriel Serdean wrote: > > On Tue, 2021-06-15 at 18:06 +0200, Ilya M

Re: [ovs-dev] [PATCH] datapath-windows: Specify external include paths

2021-06-17 Thread Ilya Maximets
On 6/17/21 11:31 AM, Alin-Gabriel Serdean wrote: > On Wed, 2021-06-16 at 18:06 +0300, Alin-Gabriel Serdean wrote: >> On Tue, 2021-06-15 at 18:06 +0200, Ilya Maximets wrote: >>> On 6/15/21 3:43 PM, Alin Gabriel Serdean wrote: VStudio 16.10 adds usermode includes before including the driver

Re: [ovs-dev] [PATCH] datapath-windows: Specify external include paths

2021-06-17 Thread Alin-Gabriel Serdean
On Wed, 2021-06-16 at 18:06 +0300, Alin-Gabriel Serdean wrote: > On Tue, 2021-06-15 at 18:06 +0200, Ilya Maximets wrote: > > On 6/15/21 3:43 PM, Alin Gabriel Serdean wrote: > > > VStudio 16.10 adds usermode includes before including the driver > > > kit ones. > > > > > > Bug tracked at: > > > http

Re: [ovs-dev] [PATCH] datapath-windows: Specify external include paths

2021-06-16 Thread Alin-Gabriel Serdean
On Tue, 2021-06-15 at 18:06 +0200, Ilya Maximets wrote: > On 6/15/21 3:43 PM, Alin Gabriel Serdean wrote: > > VStudio 16.10 adds usermode includes before including the driver > > kit ones. > > > > Bug tracked at: > > https://developercommunity.visualstudio.com/t/error-lnk2019-unresolved-external-s

Re: [ovs-dev] [PATCH] datapath-windows: Specify external include paths

2021-06-15 Thread Ilya Maximets
On 6/15/21 3:43 PM, Alin Gabriel Serdean wrote: > VStudio 16.10 adds usermode includes before including the driver kit ones. > > Bug tracked at: > https://developercommunity.visualstudio.com/t/error-lnk2019-unresolved-external-symbol-stdio-com/1434674 > > Fixes appveyor build reported by forcing

[ovs-dev] [PATCH] datapath-windows: Specify external include paths

2021-06-15 Thread Alin Gabriel Serdean
VStudio 16.10 adds usermode includes before including the driver kit ones. Bug tracked at: https://developercommunity.visualstudio.com/t/error-lnk2019-unresolved-external-symbol-stdio-com/1434674 Fixes appveyor build reported by forcing external includes. Reported-by: Ilya Maximets Reported-by: