Re: [ovs-dev] [PATCH] datapath-windows: Update flow key in SET action

2020-07-28 Thread Jinjun Gao
Thanks for review, Alin. I have updated the patch and uploaded v2 patch. Please help review again. Also, the PR (https://github.com/openvswitch/ovs/pull/326) has pasted in issue (https://github.com/openvswitch/ovs-issues/issues/190). Please help link them. - Jinjun From: Alin Serdean Date: Tu

Re: [ovs-dev] [PATCH] datapath-windows: Update flow key in SET action

2020-07-28 Thread Alin Serdean
Thanks a lot for testing and fixing this as discussed offline. Can you please split the assignment via the form: “key->ipKey.nwDst = ipHdr->daddr = ipAttr->ipv4_dst” It confuses the SDV tool from msft for some reason: https://docs.microsoft.com/en-us/windows-hardware/drivers/develop/static-driver

[ovs-dev] [PATCH] datapath-windows: Update flow key in SET action

2020-07-27 Thread Jinjun Gao
The flow key is not updated when process OVS_ACTION_ATTR_SET action. It will impact follow-up actions, such as, conntrack module cannot find created conntrack entry if passing older flow key to it. Reported-by: Rui Cao Signed-off-by: Jinjun Gao --- datapath-windows/ovsext/Actions.c | 41 +++