Re: [ovs-dev] [PATCH] db-ctl-base: Fix memory leak of db commands.

2023-10-18 Thread Ilya Maximets
On 10/18/23 12:09, Simon Horman wrote: > On Tue, Oct 17, 2023 at 07:11:19PM +0800, Zengyuan Wang via dev wrote: >> Variable "want_key" in function check_condition and variable "key" in >> function set_column were not destroyed in exception branch. >> >> This patch calls ovsdb_atom_destroy to relea

Re: [ovs-dev] [PATCH] db-ctl-base: Fix memory leak of db commands.

2023-10-18 Thread Simon Horman
On Tue, Oct 17, 2023 at 07:11:19PM +0800, Zengyuan Wang via dev wrote: > Variable "want_key" in function check_condition and variable "key" in > function set_column were not destroyed in exception branch. > > This patch calls ovsdb_atom_destroy to release resources to avoid memory leak. > > Fixe

[ovs-dev] [PATCH] db-ctl-base: Fix memory leak of db commands.

2023-10-17 Thread Zengyuan Wang via dev
Variable "want_key" in function check_condition and variable "key" in function set_column were not destroyed in exception branch. This patch calls ovsdb_atom_destroy to release resources to avoid memory leak. Fixes: 79c1a00fb5a5 ("db-ctl-base: Don't die in set_column() on error.") Fixes: e09b3af

Re: [ovs-dev] [PATCH] db-ctl-base: fix memory leak of db commands

2023-10-17 Thread 0-day Robot
Bleep bloop. Greetings Zengyuan Wang, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: The subject summary should start with a capital. WARNING: The subject summary should

[ovs-dev] [PATCH] db-ctl-base: fix memory leak of db commands

2023-10-17 Thread Zengyuan Wang via dev
Variable "want_key" in function check_condition and variable "key" in function set_column were not destroyed in exception branch. This patch calls ovsdb_atom_destroy to release resources to avoid memory leak. Fixes: 79c1a00fb5a5 ("db-ctl-base: Don't die in set_column() on error.") Fixes: e09b3af