Re: [ovs-dev] [PATCH] dp-packet.h: move funcs to be within cond block

2018-10-10 Thread Stokes, Ian
> There is already an ifdef DPDK_NETDEV block, so instead of checking on > each and every function, move them to the right block. > > No functional change. Thanks for this Flavio, LGTM, will be part of this weeks pull request. Thanks Ian ___ dev mailin

Re: [ovs-dev] [PATCH] dp-packet.h: move funcs to be within cond block

2018-10-08 Thread Ben Pfaff
On Mon, Oct 08, 2018 at 05:39:04PM +, Stokes, Ian wrote: > > For what it's worth, Ian, I'm hoping that you'll take a look at this and > > decide whether to merge it. > > Sure, thanks for flagging Ben, apologies for the delay, I've been on > vacation the past 2 weeks but will have time to look

Re: [ovs-dev] [PATCH] dp-packet.h: move funcs to be within cond block

2018-10-08 Thread Stokes, Ian
> For what it's worth, Ian, I'm hoping that you'll take a look at this and > decide whether to merge it. Sure, thanks for flagging Ben, apologies for the delay, I've been on vacation the past 2 weeks but will have time to look at this now. Thanks Ian > > On Tue, Oct 02, 2018 at 10:32:40AM +0100

Re: [ovs-dev] [PATCH] dp-packet.h: move funcs to be within cond block

2018-10-02 Thread Ben Pfaff
For what it's worth, Ian, I'm hoping that you'll take a look at this and decide whether to merge it. On Tue, Oct 02, 2018 at 10:32:40AM +0100, Lam, Tiago wrote: > (Sending this again as yesterday's email seems to have been dropped.) > > Hi Flavio, > > Thanks for the patch. Looks good to me, it c

Re: [ovs-dev] [PATCH] dp-packet.h: move funcs to be within cond block

2018-10-02 Thread Lam, Tiago
(Sending this again as yesterday's email seems to have been dropped.) Hi Flavio, Thanks for the patch. Looks good to me, it compiles with both DPDK and without DPDK linked, and the check-system-userspace tests pass. Acked-by: Tiago Lam On 25/09/2018 22:08, Flavio Leitner wrote: > There is alre

[ovs-dev] [PATCH] dp-packet.h: move funcs to be within cond block

2018-09-25 Thread Flavio Leitner
There is already an ifdef DPDK_NETDEV block, so instead of checking on each and every function, move them to the right block. No functional change. Signed-off-by: Flavio Leitner --- lib/dp-packet.h | 260 +++- 1 file changed, 146 insertions(+)