Re: [ovs-dev] [PATCH] dpif: Ensure ERSPAN GRE support

2018-06-07 Thread Jiri Benc
On Fri, 1 Jun 2018 11:23:12 -0700, William Tu wrote: > Looking at the dpif_netlink_rtnl_probe_oot_tunnels(), since now we > added ERSPAN feature, instead of probing geneve module, > we should probe ip_gre module with a nlattr of ERSPAN (ex: HWID). > If it does not return -ENOSUPPORT, then use the

Re: [ovs-dev] [PATCH] dpif: Ensure ERSPAN GRE support

2018-06-05 Thread Ben Pfaff
On Fri, Jun 01, 2018 at 06:38:53PM +0200, Jiri Benc wrote: > On Fri, 1 Jun 2018 09:15:33 -0700, Gregory Rose wrote: > > Since ERSPAN over gre/ip_gre was added to the Linux 4.16 kernel the > > compat interface is needed > > for kernels up to 4.15 so that we can support ERSPAN.  If the built-in >

Re: [ovs-dev] [PATCH] dpif: Ensure ERSPAN GRE support

2018-06-04 Thread Eric Garver
On Fri, Jun 01, 2018 at 11:23:12AM -0700, William Tu wrote: > On Fri, Jun 1, 2018 at 9:38 AM, Jiri Benc wrote: > > On Fri, 1 Jun 2018 09:15:33 -0700, Gregory Rose wrote: > >> Since ERSPAN over gre/ip_gre was added to the Linux 4.16 kernel the > >> compat interface is needed > >> for kernels up to

Re: [ovs-dev] [PATCH] dpif: Ensure ERSPAN GRE support

2018-06-01 Thread William Tu
On Fri, Jun 1, 2018 at 9:38 AM, Jiri Benc wrote: > On Fri, 1 Jun 2018 09:15:33 -0700, Gregory Rose wrote: >> Since ERSPAN over gre/ip_gre was added to the Linux 4.16 kernel the >> compat interface is needed >> for kernels up to 4.15 so that we can support ERSPAN. If the built-in >> gre/ip_gre

Re: [ovs-dev] [PATCH] dpif: Ensure ERSPAN GRE support

2018-06-01 Thread William Tu
On Fri, Jun 1, 2018 at 9:56 AM, Gregory Rose wrote: > On 6/1/2018 9:38 AM, Jiri Benc wrote: >> >> On Fri, 1 Jun 2018 09:15:33 -0700, Gregory Rose wrote: >>> >>> Since ERSPAN over gre/ip_gre was added to the Linux 4.16 kernel the >>> compat interface is needed >>> for kernels up to 4.15 so that we

Re: [ovs-dev] [PATCH] dpif: Ensure ERSPAN GRE support

2018-06-01 Thread Gregory Rose
On 6/1/2018 9:38 AM, Jiri Benc wrote: On Fri, 1 Jun 2018 09:15:33 -0700, Gregory Rose wrote: Since ERSPAN over gre/ip_gre was added to the Linux 4.16 kernel the compat interface is needed for kernels up to 4.15 so that we can support ERSPAN.  If the built-in gre/ip_gre kernel modules don't have

Re: [ovs-dev] [PATCH] dpif: Ensure ERSPAN GRE support

2018-06-01 Thread Gregory Rose
On 6/1/2018 9:38 AM, Jiri Benc wrote: On Fri, 1 Jun 2018 09:15:33 -0700, Gregory Rose wrote: Since ERSPAN over gre/ip_gre was added to the Linux 4.16 kernel the compat interface is needed for kernels up to 4.15 so that we can support ERSPAN.  If the built-in gre/ip_gre kernel modules don't have

Re: [ovs-dev] [PATCH] dpif: Ensure ERSPAN GRE support

2018-06-01 Thread Jiri Benc
On Fri, 1 Jun 2018 09:15:33 -0700, Gregory Rose wrote: > Since ERSPAN over gre/ip_gre was added to the Linux 4.16 kernel the > compat interface is needed > for kernels up to 4.15 so that we can support ERSPAN.  If the built-in > gre/ip_gre kernel modules > don't have the ERSPAN support in them

Re: [ovs-dev] [PATCH] dpif: Ensure ERSPAN GRE support

2018-06-01 Thread Gregory Rose
On 6/1/2018 8:30 AM, Eric Garver wrote: On Fri, Jun 01, 2018 at 07:40:49AM -0700, Gregory Rose wrote: On 6/1/2018 6:15 AM, Eric Garver wrote: I'm a bit late, but I have comments below. I'm also a bit out of touch, so I may be missing some context - if so, I apologize. On Thu, May 31, 2018 at

Re: [ovs-dev] [PATCH] dpif: Ensure ERSPAN GRE support

2018-06-01 Thread Eric Garver
On Fri, Jun 01, 2018 at 07:40:49AM -0700, Gregory Rose wrote: > On 6/1/2018 6:15 AM, Eric Garver wrote: > > I'm a bit late, but I have comments below. > > > > I'm also a bit out of touch, so I may be missing some context - if so, I > > apologize. > > > > On Thu, May 31, 2018 at 03:50:31PM -0700,

Re: [ovs-dev] [PATCH] dpif: Ensure ERSPAN GRE support

2018-06-01 Thread Gregory Rose
On 6/1/2018 6:15 AM, Eric Garver wrote: I'm a bit late, but I have comments below. I'm also a bit out of touch, so I may be missing some context - if so, I apologize. On Thu, May 31, 2018 at 03:50:31PM -0700, Greg Rose wrote: When verifying the built-in gre kernel module check for ERSPAN

Re: [ovs-dev] [PATCH] dpif: Ensure ERSPAN GRE support

2018-06-01 Thread Eric Garver
I'm a bit late, but I have comments below. I'm also a bit out of touch, so I may be missing some context - if so, I apologize. On Thu, May 31, 2018 at 03:50:31PM -0700, Greg Rose wrote: > When verifying the built-in gre kernel module check for ERSPAN support. > > Reported-by: Guru Shetty >

Re: [ovs-dev] [PATCH] dpif: Ensure ERSPAN GRE support

2018-05-31 Thread Ben Pfaff
On Thu, May 31, 2018 at 03:50:31PM -0700, Greg Rose wrote: > When verifying the built-in gre kernel module check for ERSPAN support. > > Reported-by: Guru Shetty > Signed-off-by: Greg Rose Thanks, I applied this to master. ___ dev mailing list

[ovs-dev] [PATCH] dpif: Ensure ERSPAN GRE support

2018-05-31 Thread Greg Rose
When verifying the built-in gre kernel module check for ERSPAN support. Reported-by: Guru Shetty Signed-off-by: Greg Rose --- lib/dpif-netlink-rtnl.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/dpif-netlink-rtnl.c b/lib/dpif-netlink-rtnl.c index