On 15/07/2020 11:02, Ilya Maximets wrote:
> On 7/15/20 11:44 AM, Kevin Traynor wrote:
>> On 14/07/2020 19:24, Ilya Maximets wrote:
>>> On 7/14/20 7:52 PM, Ilya Maximets wrote:
On 7/14/20 5:33 PM, Kevin Traynor wrote:
> On 09/07/2020 16:19, Ilya Maximets wrote:
>> @@ -3175,11 +3219,31 @
On 7/15/20 11:44 AM, Kevin Traynor wrote:
> On 14/07/2020 19:24, Ilya Maximets wrote:
>> On 7/14/20 7:52 PM, Ilya Maximets wrote:
>>> On 7/14/20 5:33 PM, Kevin Traynor wrote:
On 09/07/2020 16:19, Ilya Maximets wrote:
> @@ -3175,11 +3219,31 @@ dpif_netdev_get_flow_offload_status(const struc
On 14/07/2020 19:24, Ilya Maximets wrote:
> On 7/14/20 7:52 PM, Ilya Maximets wrote:
>> On 7/14/20 5:33 PM, Kevin Traynor wrote:
>>> On 09/07/2020 16:19, Ilya Maximets wrote:
Main thread will try to pause/stop all revalidators during datapath
reconfiguration via datapath purge callback (d
On 7/14/20 7:52 PM, Ilya Maximets wrote:
> On 7/14/20 5:33 PM, Kevin Traynor wrote:
>> On 09/07/2020 16:19, Ilya Maximets wrote:
>>> Main thread will try to pause/stop all revalidators during datapath
>>> reconfiguration via datapath purge callback (dp_purge_cb) while
>>> holding 'dp->port_mutex'.
On 7/14/20 5:33 PM, Kevin Traynor wrote:
> On 09/07/2020 16:19, Ilya Maximets wrote:
>> Main thread will try to pause/stop all revalidators during datapath
>> reconfiguration via datapath purge callback (dp_purge_cb) while
>> holding 'dp->port_mutex'. And deadlock happens in case any of
>> revalid
On 09/07/2020 16:19, Ilya Maximets wrote:
> Main thread will try to pause/stop all revalidators during datapath
> reconfiguration via datapath purge callback (dp_purge_cb) while
> holding 'dp->port_mutex'. And deadlock happens in case any of
> revalidator threads is already waiting on 'dp->port_mu
Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Comment with 'xxx' marker
#157 FILE: lib/dpif-netdev.c:3217:
* XXX: Main thread
Main thread will try to pause/stop all revalidators during datapath
reconfiguration via datapath purge callback (dp_purge_cb) while
holding 'dp->port_mutex'. And deadlock happens in case any of
revalidator threads is already waiting on 'dp->port_mutex' while
dumping offloaded flows:
ma
