>
> Hi Vishal, thanks for the patch, I've some minor comments below. I'm
> still testing but so far it seems good.
>
> Unless there are objections (or any new issues come to light) I will put
> this as part of the pull request this week and back port to the
> appropriate branches.
>
> Thanks
> I
On 6/17/2018 3:21 AM, Vishal Deep Ajmera wrote:
OVS reads packets in batches from a given port and packets in the
batch are subjected to potentially 3 levels of lookups to identify
the datapath megaflow entry (or flow) associated with the packet.
Each megaflow entry has a dedicated buffer in whic
day, June 21, 2018 11:42 AM
> To: Han Zhou
> Cc: ovs dev
> Subject: Re: [ovs-dev] [PATCH] dpif-netdev: Avoid reordering of packets in a
> batch with same megaflow
>
>
> Thanks for the patch! I didn't review the patch, but just have a question:
> does
> this issu
Thanks for the patch! I didn't review the patch, but just have a question: does
this issue exist only for dpif-netdev, or does kernel datapath has same issue?
I am not familiar with kernel data-path and don’t know if it also uses
flow-based batching as in dpif-netdev.
__
On Sat, Jun 16, 2018 at 7:21 PM, Vishal Deep Ajmera <
vishal.deep.ajm...@ericsson.com> wrote:
>
> OVS reads packets in batches from a given port and packets in the
> batch are subjected to potentially 3 levels of lookups to identify
> the datapath megaflow entry (or flow) associated with the packet
> I looked into the code and the logic seems good to me.
> But reordering in dataplane also has performance implications especially
> considering non-TCP traffic. Also, the packets came to OvS may already been
> out-of-ordered. Could you provide some performance data points showing when
> all
era
>Sent: Monday, June 18, 2018 8:49 AM
>To: d...@openvswitch.org
>Subject: Re: [ovs-dev] [PATCH] dpif-netdev: Avoid reordering of packets in a
>batch with same megaflow
>
>Hi,
>
>Does anyone see any issue with the patch ? The intent of the patch is to fix
>*reordering* o
Hi,
Does anyone see any issue with the patch ? The intent of the patch is to fix
*reordering* of packets belonging to same megaflow. The issue can be frequently
reproduced by running iperf test (as an example) between two VM's connected by
an OVS netdev bridge with NORMAL flow. Analyzing packet
OVS reads packets in batches from a given port and packets in the
batch are subjected to potentially 3 levels of lookups to identify
the datapath megaflow entry (or flow) associated with the packet.
Each megaflow entry has a dedicated buffer in which packets that match
the flow classification crite
