On 8/16/21 6:21 AM, Tony van der Peet wrote:
> When a PACKET_OUT has output port of OFPP_TABLE, and the rule
> table includes a meter and this causes the packet to be deleted,
> execute with a clone of the packet, restoring the original packet
> if it is changed by the execution.
>
> Add tests to
When a PACKET_OUT has output port of OFPP_TABLE, and the rule
table includes a meter and this causes the packet to be deleted,
execute with a clone of the packet, restoring the original packet
if it is changed by the execution.
Add tests to verify the original issue is fixed, and that the fix
Bleep bloop. Greetings Tony van der Peet, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or
When a PACKET_OUT has output port of OFPP_TABLE, and the rule
table includes a meter and this causes the packet to be deleted,
execute with a clone of the packet, restoring the original packet
if it is changed by the execution.
Add tests to verify the original issue is fixed, and that the fix
is kind of behavior in OVS.
> >
> > For the reference, the packet-out generated by OVN controller had a few
> > set() actions and the resubmit() to a different table. And this
> > table had rules leading to packet output to a tunnel port, resulting
>
gt; table had rules leading to packet output to a tunnel port, resulting
> > in a tunnel push + output datapath actions.
> >
> >> Cheers
> >> Tony
> >>
> >> From: Aaron Conole
> >> Sent: Saturday,
rules leading to packet output to a tunnel port, resulting
> in a tunnel push + output datapath actions.
>
>> Cheers
>> Tony
>>
>> From: Aaron Conole
>> Sent: Saturday, 19 June 2021 2:50 a.m.
>> To: Ilya Maximets
>> Cc: Ben Pfaff; Tony van der Peet; d...@openv
apath actions.
> Cheers
> Tony
>
> From: Aaron Conole
> Sent: Saturday, 19 June 2021 2:50 a.m.
> To: Ilya Maximets
> Cc: Ben Pfaff; Tony van der Peet; d...@openvswitch.org; Tony van der Peet
> Subject: Re: [ovs-dev] [PATCH] dpif-netdev: Fix crash w
From: Aaron Conole
Sent: Saturday, 19 June 2021 2:50 a.m.
To: Ilya Maximets
Cc: Ben Pfaff; Tony van der Peet; d...@openvswitch.org; Tony van der Peet
Subject: Re: [ovs-dev] [PATCH] dpif-netdev: Fix crash when PACKET_OUT is metered
Ilya Maximets writes:
> On 6/17/21 11
Ilya Maximets writes:
> On 6/17/21 11:59 PM, Ben Pfaff wrote:
>> All these flags for stealing, allowing stealing, blah blah, are just
>> ways to do some kind of dumb reference counting without actually have a
>> reference count. When it gets super complex like this, maybe
>> introducing a
On 6/17/21 11:59 PM, Ben Pfaff wrote:
> All these flags for stealing, allowing stealing, blah blah, are just
> ways to do some kind of dumb reference counting without actually have a
> reference count. When it gets super complex like this, maybe
> introducing a reference count is the way to go.
All these flags for stealing, allowing stealing, blah blah, are just
ways to do some kind of dumb reference counting without actually have a
reference count. When it gets super complex like this, maybe
introducing a reference count is the way to go. It would be a bigger
change, but perhaps more
On 6/17/21 7:47 PM, Ilya Maximets wrote:
> On 6/16/21 11:54 PM, Tony van der Peet wrote:
>> Thanks Ilya. For what it's worth, besides running the OVS unit tests, I put
>> this new code through our (enhanced) version of oftest (500 test cases)
>> including a couple I wrote just for this
On 6/16/21 11:54 PM, Tony van der Peet wrote:
> Thanks Ilya. For what it's worth, besides running the OVS unit tests, I put
> this new code through our (enhanced) version of oftest (500 test cases)
> including a couple I wrote just for this situation.
>
> Tony
>
> On Thu, Jun 17, 2021 at 8:05
Thanks Ilya. For what it's worth, besides running the OVS unit tests, I put
this new code through our (enhanced) version of oftest (500 test cases)
including a couple I wrote just for this situation.
Tony
On Thu, Jun 17, 2021 at 8:05 AM Ilya Maximets wrote:
> On 6/16/21 2:04 AM, Tony van der
On 6/16/21 2:04 AM, Tony van der Peet wrote:
> From: Tony van der Peet
>
> When a PACKET_OUT has output port of OFPP_TABLE, and the rule
> table includes a meter and this causes the packet to be deleted,
> stop the packet from being deleted twice by cloning it and setting
> it up to be stolen in
From: Tony van der Peet
When a PACKET_OUT has output port of OFPP_TABLE, and the rule
table includes a meter and this causes the packet to be deleted,
stop the packet from being deleted twice by cloning it and setting
it up to be stolen in execution.
Add a test to verify this condition.
17 matches
Mail list logo
