Re: [ovs-dev] [PATCH] dpif-netdev: Remove useless port checking.

2017-07-11 Thread Ben Pfaff
On Fri, Jun 23, 2017 at 09:43:45AM -0700, Greg Rose wrote: > On 06/20/2017 12:53 AM, Ilya Maximets wrote: > >Since commit ff073a71f9bb ("dpif-netdev: Use hmap instead of > >list+array for tracking ports."), 'is_valid_port_number()' is > >equal to 'port_no != ODPP_NONE', and the expression below wil

Re: [ovs-dev] [PATCH] dpif-netdev: Remove useless port checking.

2017-06-23 Thread Greg Rose
On 06/20/2017 12:53 AM, Ilya Maximets wrote: Since commit ff073a71f9bb ("dpif-netdev: Use hmap instead of list+array for tracking ports."), 'is_valid_port_number()' is equal to 'port_no != ODPP_NONE', and the expression below will never be true. Signed-off-by: Ilya Maximets --- lib/dpif-netde

[ovs-dev] [PATCH] dpif-netdev: Remove useless port checking.

2017-06-20 Thread Ilya Maximets
Since commit ff073a71f9bb ("dpif-netdev: Use hmap instead of list+array for tracking ports."), 'is_valid_port_number()' is equal to 'port_no != ODPP_NONE', and the expression below will never be true. Signed-off-by: Ilya Maximets --- lib/dpif-netdev.c | 7 --- 1 file changed, 7 deletions(-)