Re: [ovs-dev] [PATCH] dpif-netdev: Replace loop iterating over packet batch with macro.

2022-05-04 Thread Ilya Maximets
On 4/26/22 21:24, Rosemarie O'Riorden wrote: > The function dp_netdev_pmd_flush_output_on_port() iterates over the > p->output_pkts batch directly, when it should be using the special > iterator macro, DP_PACKET_BATCH_FOR_EACH. > > However, this wasn't possible because the macro could not accept >

Re: [ovs-dev] [PATCH] dpif-netdev: Replace loop iterating over packet batch with macro.

2022-04-26 Thread 0-day Robot
Bleep bloop. Greetings Rosemarie O'Riorden, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Inappropriate bracing around statement #32 FILE: lib/dp-packet.h:827: if

[ovs-dev] [PATCH] dpif-netdev: Replace loop iterating over packet batch with macro.

2022-04-26 Thread Rosemarie O'Riorden
The function dp_netdev_pmd_flush_output_on_port() iterates over the p->output_pkts batch directly, when it should be using the special iterator macro, DP_PACKET_BATCH_FOR_EACH. However, this wasn't possible because the macro could not accept &p->output_pkts. The addition of parentheses when BATCH