Re: [ovs-dev] [PATCH] dpif-netlink: Fix memory leak dpif_netlink_open().

2023-04-19 Thread wangyunjian via dev
> -Original Message- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Wednesday, April 19, 2023 2:44 PM > To: wangyunjian > Cc: d...@openvswitch.org; i.maxim...@ovn.org; luyicai > Subject: Re: [ovs-dev] [PATCH] dpif-netlink: Fix memory leak &

Re: [ovs-dev] [PATCH] dpif-netlink: Fix memory leak dpif_netlink_open().

2023-04-18 Thread David Marchand
On Tue, Apr 18, 2023 at 3:16 PM wangyunjian wrote: > > I wonder though if we should pass any ofpbuf at all, as we don't care about > > the > > reply from the kernel for this case. > > Something like: > > > > $ git diff > > diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c index > > de07112778

Re: [ovs-dev] [PATCH] dpif-netlink: Fix memory leak dpif_netlink_open().

2023-04-18 Thread wangyunjian via dev
> -Original Message- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Tuesday, April 18, 2023 8:57 PM > To: wangyunjian > Cc: d...@openvswitch.org; i.maxim...@ovn.org; luyicai > Subject: Re: [ovs-dev] [PATCH] dpif-netlink: Fix memory leak &

Re: [ovs-dev] [PATCH] dpif-netlink: Fix memory leak dpif_netlink_open().

2023-04-18 Thread David Marchand
On Tue, Apr 18, 2023 at 2:14 PM Yunjian Wang via dev wrote: > > Reported by Address Sanitizer. > > Indirect leak of 1024 byte(s) in 1 object(s) allocated from: > #0 0x7fe09d3bfe70 in __interceptor_malloc > (/usr/lib64/libasan.so.4+0xe0e70) > #1 0x8759be in xmalloc__ lib/util.c:140 > #

[ovs-dev] [PATCH] dpif-netlink: Fix memory leak dpif_netlink_open().

2023-04-18 Thread Yunjian Wang via dev
Reported by Address Sanitizer. Indirect leak of 1024 byte(s) in 1 object(s) allocated from: #0 0x7fe09d3bfe70 in __interceptor_malloc (/usr/lib64/libasan.so.4+0xe0e70) #1 0x8759be in xmalloc__ lib/util.c:140 #2 0x875a9a in xmalloc lib/util.c:175 #3 0x7ba0d2 in ofpbuf_init lib/ofpbu