Re: [ovs-dev] [PATCH] dpif-netlink-rtnl: Retry a smaller MTU for netdev when MAX_MTU is too large.

2018-07-06 Thread Gregory Rose
On 7/5/2018 11:55 AM, Yifeng Sun wrote: When MAX_MTU is larger than hw supported max MTU, dpif_netlink_rtnl_create will fail. This leads to testing failure '11: datapath - ping over gre tunnel' in 'make check-kmod'. This patch fixes this issue by retrying a smaller MTU when MAX_MTU is too large.

Re: [ovs-dev] [PATCH] dpif-netlink-rtnl: Retry a smaller MTU for netdev when MAX_MTU is too large.

2018-07-06 Thread Yifeng Sun
Oh yes, I missed that when I tried to make code look compact. Thanks for pointing it out. Yifeng On Fri, Jul 6, 2018 at 1:17 PM, Ben Pfaff wrote: > On Thu, Jul 05, 2018 at 11:55:46AM -0700, Yifeng Sun wrote: > > When MAX_MTU is larger than hw supported max MTU, > > dpif_netlink_rtnl_create will

Re: [ovs-dev] [PATCH] dpif-netlink-rtnl: Retry a smaller MTU for netdev when MAX_MTU is too large.

2018-07-06 Thread Ben Pfaff
On Thu, Jul 05, 2018 at 11:55:46AM -0700, Yifeng Sun wrote: > When MAX_MTU is larger than hw supported max MTU, > dpif_netlink_rtnl_create will fail. This leads to > testing failure '11: datapath - ping over gre tunnel' > in 'make check-kmod'. > > This patch fixes this issue by retrying a smaller

Re: [ovs-dev] [PATCH] dpif-netlink-rtnl: Retry a smaller MTU for netdev when MAX_MTU is too large.

2018-07-06 Thread Yifeng Sun
Hi Ben, Yes, this is GRE-specific, somehow gre_sys doesn't support current MTU which is 65000. `make check-kmod` no. 11 and 21 fail due to this issue. On the kernel side, the error shows up as: [ 6135.11] gre_sys: Invalid MTU 65000 requested, hw max 1500 It reflects to userspace as error be

Re: [ovs-dev] [PATCH] dpif-netlink-rtnl: Retry a smaller MTU for netdev when MAX_MTU is too large.

2018-07-06 Thread Ben Pfaff
On Thu, Jul 05, 2018 at 11:55:46AM -0700, Yifeng Sun wrote: > When MAX_MTU is larger than hw supported max MTU, > dpif_netlink_rtnl_create will fail. This leads to > testing failure '11: datapath - ping over gre tunnel' > in 'make check-kmod'. > > This patch fixes this issue by retrying a smaller

[ovs-dev] [PATCH] dpif-netlink-rtnl: Retry a smaller MTU for netdev when MAX_MTU is too large.

2018-07-05 Thread Yifeng Sun
When MAX_MTU is larger than hw supported max MTU, dpif_netlink_rtnl_create will fail. This leads to testing failure '11: datapath - ping over gre tunnel' in 'make check-kmod'. This patch fixes this issue by retrying a smaller MTU when MAX_MTU is too large. Signed-off-by: Yifeng Sun --- lib/dpif