Re: [ovs-dev] [PATCH] flow: Fix crash on vlan packets with partial offloading.

2019-10-25 Thread Ilya Maximets
On 24.10.2019 22:00, Ben Pfaff wrote: On Thu, Oct 24, 2019 at 12:09:16PM +0200, Ilya Maximets wrote: parse_tcp_flags() does not care about vlan tags in a packet thus not able to parse them. As a result, if partial offloading is enabled in userspace datapath vlan packets are not parsed, i.e. has

Re: [ovs-dev] [PATCH] flow: Fix crash on vlan packets with partial offloading.

2019-10-24 Thread Ben Pfaff
On Thu, Oct 24, 2019 at 12:09:16PM +0200, Ilya Maximets wrote: > parse_tcp_flags() does not care about vlan tags in a packet thus > not able to parse them. As a result, if partial offloading is > enabled in userspace datapath vlan packets are not parsed, i.e. > has no initialized offsets. This ca

[ovs-dev] [PATCH] flow: Fix crash on vlan packets with partial offloading.

2019-10-24 Thread Ilya Maximets
parse_tcp_flags() does not care about vlan tags in a packet thus not able to parse them. As a result, if partial offloading is enabled in userspace datapath vlan packets are not parsed, i.e. has no initialized offsets. This causes OVS crash on any attempt to access/modify packet header fields. F