On 3/22/22 21:17, Rosemarie O'Riorden wrote:
> Hi Dumitru,
>
> Thank you for the review! I'm going to send a v2 shortly with some changes.
>
>> I'm not sure what the benefit is to have 'start' as 'const unsigned char
>> *'; it could easily be 'const char *' and we wouldn't have to cast later
>>
Hi Dumitru,
Thank you for the review! I'm going to send a v2 shortly with some changes.
> I'm not sure what the benefit is to have 'start' as 'const unsigned char
> *'; it could easily be 'const char *' and we wouldn't have to cast later
> on. Also, a comment might be useful, describing that
Hi Rosemarie,
On 2/28/22 16:39, Rosemarie O'Riorden wrote:
> To parse a json string prior to this change, json_lex_input is called
> with each character of the string. If the character needs to be copied
> to the buffer, it is copied individually. This is an expensive
> operation, as often there
To parse a json string prior to this change, json_lex_input is called
with each character of the string. If the character needs to be copied
to the buffer, it is copied individually. This is an expensive
operation, as often there are multiple characters in a row
that need to be copied, and copying
