Re: [ovs-dev] [PATCH] latch-unix: Make the latch read buffer shared

2021-07-14 Thread Ben Pfaff
On Wed, Jul 14, 2021 at 09:12:10PM +0100, Anton Ivanov wrote: > On 14/07/2021 19:33, Ben Pfaff wrote: > > On Wed, Jul 14, 2021 at 05:36:36PM +0100, anton.iva...@cambridgegreys.com > > wrote: > > > From: Anton Ivanov > > > > > > There is no point to add 512 bytes on the stack > > > every time lat

Re: [ovs-dev] [PATCH] latch-unix: Make the latch read buffer shared

2021-07-14 Thread Anton Ivanov
On 14/07/2021 19:33, Ben Pfaff wrote: On Wed, Jul 14, 2021 at 05:36:36PM +0100, anton.iva...@cambridgegreys.com wrote: From: Anton Ivanov There is no point to add 512 bytes on the stack every time latch is polled. Alignment, cache line thrashing, etc - you name it. Do you have evidence this i

Re: [ovs-dev] [PATCH] latch-unix: Make the latch read buffer shared

2021-07-14 Thread Ben Pfaff
On Wed, Jul 14, 2021 at 05:36:36PM +0100, anton.iva...@cambridgegreys.com wrote: > From: Anton Ivanov > > There is no point to add 512 bytes on the stack > every time latch is polled. Alignment, cache line thrashing, > etc - you name it. Do you have evidence this is a real problem? > The result

[ovs-dev] [PATCH] latch-unix: Make the latch read buffer shared

2021-07-14 Thread anton . ivanov
From: Anton Ivanov There is no point to add 512 bytes on the stack every time latch is polled. Alignment, cache line thrashing, etc - you name it. The result of the read is discarded anyway so the buffer can be shared by all latches. Signed-off-by: Anton Ivanov --- lib/latch-unix.c | 7 --